Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Wednesday, January 10, 2018 10:18 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup >

Re: [FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

On Tue, Apr 11, 2017 at 08:05:02PM +0200, Stephan Holljes wrote: > --- > > This version is rebased on Simon's tcp return fix. > > libavformat/tcp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tcp.c b/libavformat/tcp.c > index 07b4ed9..f1a597d 100644

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

2018-01-11 3:01 GMT+01:00 Li, Zhong : >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Carl Eugen Hoyos >> Sent: Wednesday, January 10, 2018 10:18 PM >> To: FFmpeg development discussions and patches >> >> Subject: Re:

Re: [FFmpeg-devel] GSoC 2018

On Wed, Jan 10, 2018, at 7:31 PM, Carl Eugen Hoyos wrote: > > Were the GSoC rules concerning documentation projects changed? I don't know. I haven't memorized the rules and haven't looked at them for several years. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

On Thu, 11 Jan 2018 02:01:38 + "Li, Zhong" wrote: > IIUC, This commit was merged from Libav, checking the commit log of > cf7d3846fc865df47bd64f7d4d10bbedf9e3a17b: Yeah, but... > Merge commit '9de9b828ef005dec37052548c195a6b4f18fc701' > > * commit

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

> > IIUC, This commit was merged from Libav, checking the commit log of > cf7d3846fc865df47bd64f7d4d10bbedf9e3a17b: > > Yeah, but... > > > Merge commit '9de9b828ef005dec37052548c195a6b4f18fc701' > > > > * commit '9de9b828ef005dec37052548c195a6b4f18fc701': > > lavc: don't overwrite

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

On Thu, 11 Jan 2018 05:34:07 + "Li, Zhong" wrote: > > > IIUC, This commit was merged from Libav, checking the commit log of > > cf7d3846fc865df47bd64f7d4d10bbedf9e3a17b: > > > > Yeah, but... > > > > > Merge commit '9de9b828ef005dec37052548c195a6b4f18fc701' > > >

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

On 2018/1/11 8:45, wm4 wrote: > On Tue, 2 Jan 2018 13:59:12 +0800 > Jun Zhao wrote: > >> From e030510864c28d4b17c8d1eb09ab00f274bf5dcc Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 2 Jan 2018 13:55:29 +0800 >> Subject: [PATCH] doc/codecs: Add

[FFmpeg-devel] [PATCH] http: cosmetics: reformat reconnect check for better readability

The condition was a bit too long, and most editors will break the line and turn it into an unreadable mess. Move out some of the conditions. This should not change the behavior. --- libavformat/http.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] example/vaapi_transcode: Add a VA-API transcode example.

From b76a2f790814df326d7d93c54b14b3c8e74ab759 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 11 Jan 2018 15:00:30 +0800 Subject: [PATCH 2/2] example/vaapi_transcode: Add a VA-API transcode example. Add VA-API transcoding example, useage like: ./vaapi_transcode

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

On Thu, 11 Jan 2018 09:11:08 +0800 Jun Zhao wrote: > On 2018/1/11 8:45, wm4 wrote: > > On Tue, 2 Jan 2018 13:59:12 +0800 > > Jun Zhao wrote: > > > >> From e030510864c28d4b17c8d1eb09ab00f274bf5dcc Mon Sep 17 00:00:00 2001 > >> From: Jun Zhao

[FFmpeg-devel] [PATCH 1/2] examples/vaapi_encode: Remove redundancy check when free context.

From ef424745ce8d425859e9ca16dd9aca72297ed90a Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 11 Jan 2018 13:21:58 +0800 Subject: [PATCH 1/2] examples/vaapi_encode: Remove redundancy check when free context. avcodec_free_context have handle NULL pointer case, so caller

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

On Wed, Jan 10, 2018 at 9:10 AM, Zhong Li wrote: > Currently a hacky way is used for some specific codecs such as > H264/VP6F/DXV. > Replace with a more generic way(an evolution based on a history commit > 9de9b828ef005dec37052548c195a6b4f18fc701 but reverted somehow) to

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

On Wed, Jan 10, 2018 at 08:58:05 +0100, dmitry.gumen...@gmail.com wrote: > +@table @option > +@item d > +Dimensions @code{WxH}. > +@code{W} - number of data values in json, values will be scaled according to > @code{H}. > +The default value is @var{640x480} > + > +@item s > +Samples count per

Re: [FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

2018-01-10 9:10 GMT+01:00 Zhong Li : > Currently a hacky way is used for some specific codecs such as > H264/VP6F/DXV. > Replace with a more generic way(an evolution based on a history commit > 9de9b828ef005dec37052548c195a6b4f18fc701 but reverted somehow) This commit was

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

On Wed, Jan 10, 2018 at 09:11:35 -0500, Devin Heitmueller wrote: > For loop declaration has been part of the C standard since C99. I'm just quoting other similar discussions on this list. This has been a topic several (hundred? ;-)) times the last few months. It peaked in this discussion which

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

On 2018/1/11 9:26, wm4 wrote: > On Thu, 11 Jan 2018 09:11:08 +0800 > Jun Zhao wrote: > >> On 2018/1/11 8:45, wm4 wrote: >>> On Tue, 2 Jan 2018 13:59:12 +0800 >>> Jun Zhao wrote: >>> From e030510864c28d4b17c8d1eb09ab00f274bf5dcc Mon Sep 17

Re: [FFmpeg-devel] GSoC 2018

2018-01-11 2:10 GMT+01:00 Lou Logan : > On Wed, Jan 10, 2018, at 3:30 PM, Michael Niedermayer wrote: >> >> Would there be interrest in a project to write a QR code / barcode >> search & decode filter ? > > I've personally never scanned a QR code, but maybe I'm an outlier. > Seems

Re: [FFmpeg-devel] [PATCH] added reitnerlace filter

2018-01-10 11:57 GMT+01:00 Vasile Toncu : > From the messages regarding the new reinterlace filter, based on your > arguments and guidance, I came out with the following solution. > > Modify tinterlace filter so that it would behave like that: > >/if GONGIG_GPL is

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/libopenmpt: Probe file format from file data if possible

On 01/10/2018 12:55 PM, Carl Eugen Hoyos wrote: 2018-01-10 12:18 GMT+01:00 Jörn Heusipp : When building with libopenmpt 0.3, use the libopenmpt file header probing functions for probing. libopenmpt probing functions are allocation-free and designed to be as

Re: [FFmpeg-devel] [PATCH] examples/qsvdec: remove the deprecated field refcounted_frames

On Wed, 10 Jan 2018 16:39:16 +0800 Zhong Li wrote: > It was just useful for deprecated API (avcodec_decode_video2), > but useless for new decode APIs (avcodec_send_packet/avcodec_receive_frame). > > Signed-off-by: Zhong Li > --- > doc/examples/qsvdec.c

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

> wavesurer.js - Web Audio API I mean its would be hard to do the same for large files https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/decodeAudioData > On 10 Jan 2018, at 09:04, Дмитрий Гуменюк wrote: > > Hi, > While Waveform.js converts old

[FFmpeg-devel] [PATCH v2 0/4] libopenmpt 0.3 updates

Compared to the previous patch versions, only part 4 has been changed (based on the comments received so far). I also ran more performance tests. FFmpeg is configured via './configure --enable-libopenmpt --enable-libmodplug' in all tests. probetest failures with current libopenmpt

[FFmpeg-devel] [PATCH v2 1/4] avformat/libopenmpt: Fix mixed code and declarations

Signed-off-by: Jörn Heusipp --- libavformat/libopenmpt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index af6eb1a..2e22290 100644 --- a/libavformat/libopenmpt.c +++

Re: [FFmpeg-devel] [PATCH] added reitnerlace filter

On 1/10/18, Vasile Toncu wrote: > Hello, > > From the messages regarding the new reinterlace filter, based on your > arguments and guidance, I came out with the following solution. > > Modify tinterlace filter so that it would behave like that: > > /if GONGIG_GPL is

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/libopenmpt: Probe file format from file data if possible

2018-01-10 12:18 GMT+01:00 Jörn Heusipp : > When building with libopenmpt 0.3, use the libopenmpt file header > probing functions for probing. libopenmpt probing functions are > allocation-free and designed to be as fast as possible. > > For libopenmpt 0.2, or

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

Same JSON schema used by SoundCloud > On 10 Jan 2018, at 10:16, Дмитрий Гуменюк wrote: > >> wavesurer.js - Web Audio API > I mean its would be hard to do the same for large files > https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/decodeAudioData >

Re: [FFmpeg-devel] [PATCH] added reitnerlace filter

Hello, From the messages regarding the new reinterlace filter, based on your arguments and guidance, I came out with the following solution. Modify tinterlace filter so that it would behave like that: /if GONGIG_GPL is defined:/ /    use curent titnerlace code with asm opts/

[FFmpeg-devel] [PATCH v2 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

Signed-off-by: Jörn Heusipp --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 30c3d6e..5efbdc4 100644 --- a/libavformat/libopenmpt.c +++

[FFmpeg-devel] [PATCH v2 4/4] avformat/libopenmpt: Probe file format from file data if possible

When building with libopenmpt 0.3, use the libopenmpt file header probing functions for probing. libopenmpt probing functions are allocation-free and designed to be as fast as possible. For libopenmpt 0.2, or when libopenmpt 0.3 file header probing cannot probe successfully due to too small probe

[FFmpeg-devel] [PATCH v2 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

libopenmpt 0.3 deprecates openmpt_module_create_from_memory() and provides a replacement function openmpt_module_create_from_memory2(). Detecting libopenmpt 0.3 can be done at build time via the API version macros provided by libopenmpt. libopenmpt 0.2 did not provide all required macros, however

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

On 10.01.2018 09:34, Дмитрий Гуменюк wrote: There is no existing dumping format for RMS. How to make it generic? Some of my applications use the following pattern to dump audio envelope data during transcoding: ffmpeg -i input-file -f [...] output-file \ -f wav -write_peak only peak-file

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

On Mon, Jan 08, 2018 at 20:16:48 -0500, Devin Heitmueller wrote: > +if (ctx->supports_vanc == 0 || > ctx->dlo->DoesSupportVideoMode(ctx->bmd_mode, ctx->raw_format, In other places you (or the DeckLink code) use if (!ctx->supports_vanc || [...] which I believe is preferred. > +

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote: > > +for (size_t i = 0; i < cc_count; i++) { > Declare i outside the clause. > > +for (int i = 0; i < vanc_lines.num_lines; i++) { > Same here. Sorry, this rule may not apply to C++ files, as it's part of all C++ standards

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

Hello Moritz, > On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote: >>> +for (size_t i = 0; i < cc_count; i++) { >> Declare i outside the clause. >>> +for (int i = 0; i < vanc_lines.num_lines; i++) { >> Same here. > > Sorry, this rule may not apply to C++ files, as it's

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

Hi, For this to be a part of libavfilter the output needs to be more generic than the just the Soundcloud format. If we want this to be generally useful it should probably just output an array of floats between 0.0 and 1.0. The consumer of this data (JS library, or whatever) can use this in

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Tue, Jan 09, 2018 at 10:25:12AM -0800, Jacob Trimble wrote: > On Mon, Jan 8, 2018 at 5:19 PM, Carl Eugen Hoyos wrote: > > 2018-01-08 23:16 GMT+01:00 Jacob Trimble > > : > >>> You can't remove API just like that without a deprecation

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: AIFF fix in case of ANNO

On Wed, Jan 10, 2018 at 09:03:00AM +0200, Eduard Sinelnikov wrote: > Yes, the problem found from playing the file AIFF file you can download it > from: https://www.datafilehost.com/d/60337fcd thanks, i will apply the patch [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] GSoC 2018

On Tue, Jan 09, 2018 at 07:27:28PM +0100, Thilo Borgmann wrote: > Hi folks, > > yet again, the registration for Google Summer of Code 2018 has opened. > > Like in the previous years, we've setup an ideas page in our wiki: > https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2018 Would there

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

Ping? any comments? On 2018/1/2 13:59, Jun Zhao wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

On Tue, 2 Jan 2018 13:59:12 +0800 Jun Zhao wrote: > From e030510864c28d4b17c8d1eb09ab00f274bf5dcc Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 2 Jan 2018 13:55:29 +0800 > Subject: [PATCH] doc/codecs: Add missing documentation for hwaccel_flags.

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: set bytesPerPixel only for packed formats.

On Wed, Jan 10, 2018 at 10:26:58AM +0530, Gyan Doshi wrote: > > > On 1/4/2018 5:25 PM, Gyan Doshi wrote: > > > >On 12/29/2017 8:38 AM, Michael Niedermayer wrote: > >>On Thu, Dec 28, 2017 at 12:50:00PM -0900, Lou Logan wrote: > >>>On Thu, Dec 28, 2017, at 11:51 AM, Michael Niedermayer wrote: >

Re: [FFmpeg-devel] [PATCH] avfilter/vidstab: set bytesPerPixel only for packed formats.

On Thu, 11 Jan 2018 01:46:56 +0100 Michael Niedermayer wrote: > On Wed, Jan 10, 2018 at 10:26:58AM +0530, Gyan Doshi wrote: > > > > > > On 1/4/2018 5:25 PM, Gyan Doshi wrote: > > > > > >On 12/29/2017 8:38 AM, Michael Niedermayer wrote: > > >>On Thu, Dec 28, 2017 at

Re: [FFmpeg-devel] GSoC 2018

On Wed, Jan 10, 2018, at 3:30 PM, Michael Niedermayer wrote: > > Would there be interrest in a project to write a QR code / barcode > search & decode filter ? I've personally never scanned a QR code, but maybe I'm an outlier. Seems more like an OpenCV project to me. While we are throwing ideas

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer wrote: > [...] > > This causes a crash: > > = > ==4012==ERROR: AddressSanitizer: heap-buffer-overflow on address > 0x6020eb78 at pc 0x00a944aa bp

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

Hi, While Waveform.js converts old SoundCloud PNGs, wavesurer.js is using Web Audio API which is limited/not supported by all browsers > On 10 Jan 2018, at 08:51, Дмитрий Гуменюк wrote: > > There is no rush on this. Could you please do a code review so I can see how

[FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

Currently a hacky way is used for some specific codecs such as H264/VP6F/DXV. Replace with a more generic way(an evolution based on a history commit 9de9b828ef005dec37052548c195a6b4f18fc701 but reverted somehow) to handle these cases. Signed-off-by: Zhong Li ---

[FFmpeg-devel] [PATCH] examples/qsvdec: remove the deprecated field refcounted_frames

It was just useful for deprecated API (avcodec_decode_video2), but useless for new decode APIs (avcodec_send_packet/avcodec_receive_frame). Signed-off-by: Zhong Li --- doc/examples/qsvdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/examples/qsvdec.c

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

On 10.01.2018 09:11, Дмитрий Гуменюк wrote: Hi, In my opinion JSON is more flexible, so envelope can be rendered in web app or mobile app This filter is useful when you’d like to generate visual representation of audio while doing transcode I see, but my point is: If you do the image

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

On 08.01.2018 01:36, dmitry.gumen...@gmail.com wrote: From: Dmytro Humeniuk Signed-off-by: Dmytro Humeniuk --- Changelog | 1 + libavfilter/Makefile | 1 + libavfilter/af_dumpwave.c | 273