Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-01 Thread Gyan Doshi
On 1/29/2018 6:53 PM, Gyan Doshi wrote: On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote: How did you test this patch? By remuxing with patched ffmpeg and then checking with ffprobe, but not ffplay! ... Sorry, I'll rework and submit. Revised and tested patch attached. From

[FFmpeg-devel] [PATCH] avcodec/ffv1: Support for RGBA64 and GBRAP16

2018-02-01 Thread Jerome Martinez
Add support for 16-bit/component RGB with Alpha encoding and decoding in FFV1, both RGBA64 and GBRAP16 for encoding, GBRAP16 for decoding. Resulting bitstream was tested about lossless encoding/decoding by the compression from DPX to FFV1 then decompression from FFV1 to DPX, see commands

Re: [FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

2018-02-01 Thread Jerome Martinez
On 05/01/2018 11:18, Jerome Martinez wrote: 1 year without RGB48 related patches, tested by a couple of users, tested with a FFV1 conformance checker, I suggest that FFV1 RGB48 support in FFmpeg does not mandate anymore the user to add " -strict experimental" on the command line during

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Brian Matherly
On 2/1/2018 4:03 AM, Nicolas George wrote: Regarding the efficiency of avfilter_next(), I think we should not care. Almost nobody uses that function outside lavfi anyway. If it proves a concern for some application, we can deal with it when it is found. For what it's worth, I use

[FFmpeg-devel] [PATCH] configure: fix clang-cl detection

2018-02-01 Thread Alexander Bilyak
When using clang-cl it expects parameters passed in MSVC-style, so appropriate toolchain should be selected. As soon as both clang and clang-cl report themselfs as "clang" with -v option the only chance to detect clang-cl is passing -? option to both which is valid for clang-cl.exe and not for

Re: [FFmpeg-devel] [PATCH] vc2enc: prevent bitrate overshoots

2018-02-01 Thread James Darnley
On 2018-01-31 15:56, James Darnley wrote: > From: Rostislav Pehlivanov > > The rounding caused by the size scaler wasn't compensated for and the > slice sizes grew beyond what is allowed per frame. > > Signed-off-by: Rostislav Pehlivanov > --- I forgot

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Michael Niedermayer
On Thu, Feb 01, 2018 at 02:43:56AM +0100, wm4 wrote: > On Thu, 1 Feb 2018 02:06:52 +0100 > Michael Niedermayer wrote: > > > On Wed, Jan 31, 2018 at 12:24:43PM +0100, wm4 wrote: > > > On Wed, 31 Jan 2018 12:11:25 +0100 > > > Michael Niedermayer

Re: [FFmpeg-devel] hls BANDWIDTH field in master playlist

2018-02-01 Thread Amit Kale
Thanks for this info. Will soon get back with a patch. -Amit On 01-Feb-2018 3:58 PM, "Jeyapal, Karthick" wrote: > On 2/1/18 3:12 PM, Amit Kale wrote: > > Hi All, > > > > When emitting a master playlist, BANDWIDTH field is computed in > > libavformat/hlsenc.c by adding video

[FFmpeg-devel] [PATCH] avfilter: sort filter list

2018-02-01 Thread Muhammad Faiz
Move REGISTER_FILTER to FILTER_TABLE in configure. Replace linked list with static table, and sort it. Use bsearch() on avfilter_get_by_name(). Deprecate avfilter_register_all(), avfilter_register(), and avfilter_next(). Add avfilter_iterate() as a replacement for avfilter_next(). Signed-off-by:

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Muhammad Faiz
On Thu, Feb 1, 2018 at 5:03 PM, Nicolas George wrote: > Hi. > > Muhammad Faiz (2018-01-30): >> Move REGISTER_FILTER to FILTER_TABLE in configure. >> Auto generate filter extern and filter table. >> Sort filter table, use bsearch on avfilter_get_by_name. >> Define next pointer at

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Muhammad Faiz
On Wed, Jan 31, 2018 at 7:03 PM, wm4 wrote: > On Wed, 31 Jan 2018 11:52:14 + > Mark Thompson wrote: > >> >> On the other side, you get rid of a field in AVFilter and avoid having to >> >> put some pointless boilerplate in a lot of places. >> > >> > The

Re: [FFmpeg-devel] [PATCH v3] avcodec/libopus: support disabling phase inversion.

2018-02-01 Thread Michael Niedermayer
On Fri, Jan 26, 2018 at 11:30:57AM +0100, Menno de Gier wrote: > From: Menno > > This supports disabling phase inversion in both the libopus encoder and the > decoder. > > Signed-off-by: Menno > --- > doc/encoders.texi | 5 + >

[FFmpeg-devel] [PATCH v2] librsvgdec: Fix frame clearing code

2018-02-01 Thread Calvin Walton
The existing code attempts to clear the frame by painting in OVER mode with transparent black - which is a no-op. As a result if you have many input frames (e.g. you're using a sequence of svg files), you'll start to see new frames drawn over old frames as memory gets re-used. Switch the code to

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Nicolas George
Muhammad Faiz (2018-02-02): > Actually I have a plan to sort codecs based on name and codec_id. And > it is difficult to sort based on codec_id with only extern declaration > in allcodecs. It seems like a good idea, although I have not given it much list. But as it is, Josh and you are proposing

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-01 Thread Muhammad Faiz
On Thu, Feb 1, 2018 at 3:25 AM, Josh de Kock wrote: > Also replace linked list with an array. > --- > configure | 12 +- > doc/APIchanges |4 + > libavcodec/.gitignore |2 + > libavcodec/allcodecs.c | 1473 >

Re: [FFmpeg-devel] [PATCH] librsvgdec: Fix frame clearing code

2018-02-01 Thread Rostislav Pehlivanov
On 31 January 2018 at 22:17, Calvin Walton wrote: > The existing code attempts to clear the frame by painting in OVER mode > with transparent black - which is, of course, a no-op. As a result if > you have many input frames (e.g. you're using a sequence of svg files), >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Fix memleaks in decode_header()

2018-02-01 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 09:04:54PM +0100, Moritz Barsnick wrote: > On Wed, Jan 31, 2018 at 19:20:08 +0100, Michael Niedermayer wrote: > > > @@ -1458,8 +1465,10 @@ static int decode_header(EXRContext *s, AVFrame > > *frame) > > > > s->channels = av_realloc(s->channels, > >

[FFmpeg-devel] Hardware encoder ARM input as device input

2018-02-01 Thread Marcin Woźniak
Hello, I try to implement an HiSilicon H264 encoder direct input as ffmpeg libavdevice source (someking like V4L linux for cameras with H264 source driver). I successfully recieve H264 packets with NAL units and set correct PTS according to source packet. I am stuck at the moment where timing

[FFmpeg-devel] First Post

2018-02-01 Thread param mangal
Hello I am a student pursuing a Bachelor's degree in Computer Science and Engineering. I am comfortable programming in C, C++, and Java. I want to contribute to the ffmpeg project. I am familiar with the git workflow but I have never worked on an actual open source project. Please tell me how to

Re: [FFmpeg-devel] Remove carriage return ('\r') in Windows CC_IDENT

2018-02-01 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 02:35:29PM -0800, Xiaohan Wang (王消寒) wrote: > > configure |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > f8dfee52e94f632ac5803332e2fe050c9a880254 > 0001-Remove-carriage-return-r-in-Windows-CC_IDENT.patch > From 07e33b2aa09b8b224ac35a5b56b29490a6486bdf Mon

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr_fixed: Fix overflows in rounding in sbr_hf_assemble()

2018-02-01 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 07:20:09PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 2052929346 + 204817098 cannot > be represented in type 'int' > Fixes: 5275/clusterfuzz-testcase-minimized-5367635958038528 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v4] avcodec/libopus: support disabling phase inversion.

2018-02-01 Thread Menno de Gier
From: Menno Fix crash on decoder options. Signed-off-by: Menno --- doc/encoders.texi | 5 + libavcodec/libopusdec.c | 33 + libavcodec/libopusenc.c | 14 ++ 3 files changed, 52 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] delogo will fail if interp is zero.

2018-02-01 Thread Michael Niedermayer
On Wed, Jan 31, 2018 at 11:25:00AM +0800, wuxiaoyong wrote: > With ROUNDED_DIV operation, if the first parameter is 0, it will > overflow and return a very large number, delogo will fail. > So, if it's zero, just set it to 1, it will not affect the result so > much. > > Signed-off-by: wuxiaoyong

[FFmpeg-devel] [V2 PATCH 4/4] Add docs and Changelog

2018-02-01 Thread Thilo Borgmann
... -Thilo From f464bb688dd966fb12a1b678f71109601d1e235a Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Fri, 2 Feb 2018 02:52:08 +0100 Subject: [PATCH 4/4] Add docs and Changelog --- Changelog | 2 ++ doc/encoders.texi | 92

[FFmpeg-devel] [PATCH] libavformat/aac: Parse ID3 tags between ADTS frames.

2018-02-01 Thread rshaffer
From: Richard Shaffer While rare, ID3 tags may be inserted between ADTS frames. This change enables parsing them and setting the appropriate metadata updated event flag. --- I have encountered a streaming provider that I must support which does this. There are indications

[FFmpeg-devel] [V2 PATCH 3/4] Add codec wrapper for librv11

2018-02-01 Thread Thilo Borgmann
Moved to non-free. Symbols handled at compile time, no more dlsym fun. Merged into one ENCDEC. -Thilo From f27957382ffb729a2454914bcd3a99554d6dff0d Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Fri, 2 Feb 2018 02:51:14 +0100 Subject: [PATCH 3/4] Add codec wrapper

[FFmpeg-devel] [V2 PATCH 2/4] Add muxing/demuxing of RMHD

2018-02-01 Thread Thilo Borgmann
Does not add a new demuxer anymore. For the muxer I'm not sure it should be done - would require more logic to check for valid codec ids for both cases I think (like for AAC audio). -Thilo From 1e4331416f6d3fb93215530759fe99745c4d91de Mon Sep 17 00:00:00 2001 From: Thilo Borgmann

[FFmpeg-devel] [V2 PATCH 1/4] lavformat/rm: Add decoding of MLTI chunks, prefer audio, dts for multiple streams, several muxer fixes depending on codec id

2018-02-01 Thread Thilo Borgmann
All of these should be valid for RMVB (file format version 1). I have no .rm files to test these changes, only .rmhd ones. AAC muxing yet not included, requires file format version 2. However, if all muxer changes are applied, all existing FATE tests involving .rm muxing/demuxing pass for me.

Re: [FFmpeg-devel] First Post

2018-02-01 Thread grady player
Probably a good place to start would be: https://ffmpeg.org/developer.html especially: https://ffmpeg.org/developer.html#Submitting-patches as for looking for things to fix, most people add features they

[FFmpeg-devel] [PATCH] libavformat/hls: Support metadata updates from subdemuxers

2018-02-01 Thread rshaffer
From: Richard Shaffer If a subdemuxer has the updated metadata event flag set, the metadata is copied to the corresponding stream. The flag is cleared on the subdemuxer and the appropriate event flag is set on the stream. --- This is semi-related to a patch I recently sent

Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to AVCodecParameters

2018-02-01 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Tuesday, January 30, 2018 10:06 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to > AVCodecParameters > > >

Re: [FFmpeg-devel] [PATCH] avfilter: sort filter list

2018-02-01 Thread Michael Niedermayer
On Fri, Feb 02, 2018 at 01:29:54AM +0700, Muhammad Faiz wrote: > Move REGISTER_FILTER to FILTER_TABLE in configure. > Replace linked list with static table, and sort it. > Use bsearch() on avfilter_get_by_name(). > Deprecate avfilter_register_all(), avfilter_register(), and > avfilter_next(). >

[FFmpeg-devel] [V2 PATCH 0/4] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-02-01 Thread Thilo Borgmann
Hi, V2 adapts to newest SDK beta 0.5 which exports all symbols and changed some behavior. Patchset now requires the beta_0_5 version download from: http://rmhd.io Split into four patches now, should still be unusable if applied separately. PTS issue and linker warning fixed. Patch 1/4:

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-01 Thread Michael Niedermayer
On Thu, Feb 01, 2018 at 08:57:40AM +, Josh de Kock wrote: > > > On 1 Feb 2018, at 03:03, Michael Niedermayer wrote: > > > >> On Wed, Jan 31, 2018 at 08:25:50PM +, Josh de Kock wrote: > >> Also replace linked list with an array. > >> --- > >> configure

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse ID3 tags between ADTS frames.

2018-02-01 Thread wm4
On Thu, 1 Feb 2018 18:37:45 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > While rare, ID3 tags may be inserted between ADTS frames. This change enables > parsing them and setting the appropriate metadata updated event flag. > --- > I have encountered a

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Support metadata updates from subdemuxers

2018-02-01 Thread wm4
On Thu, 1 Feb 2018 18:44:34 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > If a subdemuxer has the updated metadata event flag set, the metadata is > copied > to the corresponding stream. The flag is cleared on the subdemuxer and the > appropriate event flag

Re: [FFmpeg-devel] Hardware encoder ARM input as device input

2018-02-01 Thread wm4
On Thu, 1 Feb 2018 07:48:27 +0100 Marcin Woźniak wrote: > Hello, > I try to implement an HiSilicon H264 encoder direct input as ffmpeg > libavdevice source (someking like V4L linux for cameras with H264 source > driver). > I successfully recieve H264 packets with

[FFmpeg-devel] [PATCH] qsvenc: AVBR is not supported on non-windows OS

2018-02-01 Thread Zhong Li
Encoding failed when disable look_ahead on Linux See: ./ffmpeg -i in.h264 -vcodec h264_qsv -look_ahead 0 out.h264 (reported:"Selected ratecontrol mode is not supported by the QSV runtime".) It is due to AVBR is supported from API 1.3 but only available for Windows Signed-off-by: Zhong Li

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Support metadata updates from subdemuxers

2018-02-01 Thread Richard Shaffer
On Thu, Feb 1, 2018 at 10:18 PM, wm4 wrote: > On Thu, 1 Feb 2018 18:44:34 -0800 > rshaf...@tunein.com wrote: > >> From: Richard Shaffer >> >> If a subdemuxer has the updated metadata event flag set, the metadata is >> copied >> to the corresponding

Re: [FFmpeg-devel] [PATCH v3 1/6] lavc: add new API for iterating codecs and codec parsers

2018-02-01 Thread Josh de Kock
> On 1 Feb 2018, at 03:03, Michael Niedermayer wrote: > >> On Wed, Jan 31, 2018 at 08:25:50PM +, Josh de Kock wrote: >> Also replace linked list with an array. >> --- >> configure | 12 +- >> doc/APIchanges |4 + >> libavcodec/.gitignore |

[FFmpeg-devel] hls BANDWIDTH field in master playlist

2018-02-01 Thread Amit Kale
Hi All, When emitting a master playlist, BANDWIDTH field is computed in libavformat/hlsenc.c by adding video and audio stream bitrates and then adding 10% to account for container overhead. However HLS specification (RFC8216) says that BANDWIDTH represents the peak segment bit rate.

Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-02-01 Thread Nicolas George
Hi. Muhammad Faiz (2018-01-30): > Move REGISTER_FILTER to FILTER_TABLE in configure. > Auto generate filter extern and filter table. > Sort filter table, use bsearch on avfilter_get_by_name. > Define next pointer at filter extern, no need to initialize > next pointer at run time, so AVFilter can

Re: [FFmpeg-devel] hls BANDWIDTH field in master playlist

2018-02-01 Thread Jeyapal, Karthick
On 2/1/18 3:12 PM, Amit Kale wrote: > Hi All, > > When emitting a master playlist, BANDWIDTH field is computed in > libavformat/hlsenc.c by adding video and audio stream bitrates and then > adding 10% to account for container overhead. However HLS specification > (RFC8216) says that BANDWIDTH