Re: [FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-15 Thread Philipp M. Scholl
On Thu, Feb 15, 2018 at 01:54:17AM +0100, Michael Niedermayer wrote: [..snip..] > breaks fate > I was unsure about the ramifications of a changed blocksize. Maybe you can comment on that? > > [...] > > --- a/tests/ref/seek/lavf-alaw > > +++ b/tests/ref/seek/lavf-alaw > > @@ -1,53 +1,53 @@ > >

Re: [FFmpeg-devel] [PATCH 2/2] fate: add tests for pan audio filter

2018-02-15 Thread Nicolas George
Tobias Rapp (2018-02-15): > Signed-off-by: Tobias Rapp > --- > tests/fate/filter-audio.mak | 30 ++ > tests/ref/fate/filter-pan-mono1 | 26 ++ > tests/ref/fate/filter-pan-mono2 | 26 ++ >

Re: [FFmpeg-devel] [PATCH 2/2] fate: add tests for pan audio filter

2018-02-15 Thread Tobias Rapp
On 15.02.2018 09:39, Nicolas George wrote: Tobias Rapp (2018-02-15): Signed-off-by: Tobias Rapp --- tests/fate/filter-audio.mak | 30 ++ tests/ref/fate/filter-pan-mono1 | 26 ++

Re: [FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-15 Thread Philipp M. Scholl
On Wed, Feb 14, 2018 at 03:41:18PM +0100, Tomas Härdin wrote: [..snip..] > FFMAX(codec->sample_rate/25, 1) would be nicer > agree. > > +size = FFMIN(size, RAW_SAMPLES * codec->block_align); > > +size = 1 << ff_log2(size); > > -size= RAW_SAMPLES*s->streams[0]->codecpar->block_align; >

[FFmpeg-devel] [PATCH 2/2] fate: add tests for pan audio filter

2018-02-15 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- tests/fate/filter-audio.mak | 30 ++ tests/ref/fate/filter-pan-mono1 | 26 ++ tests/ref/fate/filter-pan-mono2 | 26 ++ tests/ref/fate/filter-pan-stereo1 |

[FFmpeg-devel] [PATCH 1/2] swresample/rematrix: fix update of channel matrix if input or output layout is undefined

2018-02-15 Thread Tobias Rapp
Prefer direct in/out channel count values over channel layout, when available. Fixes a pan filter bug (ticket #6790). Signed-off-by: Tobias Rapp --- libswresample/rematrix.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] fate: add tests for pan audio filter

2018-02-15 Thread Nicolas George
Tobias Rapp (2018-02-15): > I have run the Fate tests on Linux 32/64bit and Mips/Qemu, but possibly the > float channel coefficients could be fragile (especially of the stereo3 > test). Do you have some idea on how to make them more reliable? Or shall we > give it a try and remove problematic

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

2018-02-15 Thread Aman Gupta
From: Aman Gupta This refactor splits up the main mediacodec decode loop into two send/receive helpers, which are then used to rewrite the receive_frame callback and take full advantage of the new decoding api. Since we can now request packets on demand with

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-15 Thread Aman Gupta
On Thu, Feb 15, 2018 at 12:33 PM, Stefan Pöschel wrote: > Am 15.02.2018 um 20:52 schrieb Aman Gupta: > > Patch looks reasonable to me. > > Great! > > > It might also be worth surfacing when the audio descriptor flags contain > > mix_type=0, as this indicates a dependent

[FFmpeg-devel] [PATCH] libavformat/network: Fixed wait timeout functionality to exit immediately when timeout is 0.

2018-02-15 Thread rpatagar
From: Ravindra Signed-off-by: Ravindra --- libavformat/network.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/network.c b/libavformat/network.c index d5c82e9..542bd3e 100644 --- a/libavformat/network.c +++

[FFmpeg-devel] [PATCH] avutil/common: Fix integer overflow in av_clip_uint8_c() and av_clip_uint16_c()

2018-02-15 Thread Michael Niedermayer
Fixes: 5567/clusterfuzz-testcase-minimized-5769966247739392 Fixes: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-15 Thread Gyan Doshi
On 2/15/2018 8:58 AM, Michael Niedermayer wrote: On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote: FATE patch and sample file attached. Sample file should go into (new) mpegps directory in suite. have you checked that none of the existing fate samples can be used ? Yes. There's

Re: [FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-15 Thread Tomas Härdin
On 2018-02-15 10:17, Philipp M. Scholl wrote: On Wed, Feb 14, 2018 at 03:41:18PM +0100, Tomas Härdin wrote: [..snip..] FFMAX(codec->sample_rate/25, 1) would be nicer agree. +size = FFMIN(size, RAW_SAMPLES * codec->block_align); +size = 1 << ff_log2(size); -size=

Re: [FFmpeg-devel] [PATCH] avcodec/h264_cabac: Tighten allowed coeff_abs range

2018-02-15 Thread Michael Niedermayer
On Wed, Feb 14, 2018 at 12:32:30AM +0100, Michael Niedermayer wrote: > Fixes: integer overflows > Reported-by: "Xiaohan Wang (王消寒)" > > Based on limits in "8.5 Transform coefficient decoding process and picture > construction process prior to deblocking filter process" >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-15 Thread Gyan Doshi
On 2/15/2018 8:57 AM, Michael Niedermayer wrote: On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote: +if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) { +if (size < 3) { +av_log(ctx, AV_LOG_ERROR, "Invalid packet size %d\n", size); +return -1;

[FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-15 Thread Stefan Pöschel
The supplementary audio descriptor is defined in ETSI EN 300 468 and provides more details regarding accessibility audio tracks, especially the normative annex J contains a detailed description of its use. Its language code (if present) overrides the language code of an also present ISO 639

Re: [FFmpeg-devel] GSOC mentored project : Super Resolution filter

2018-02-15 Thread Pedro Arthur
Hi Shivam, 2018-02-14 15:56 GMT-02:00 Shivam Saboo : > Hi Dev-Community, > > I am Shivam Saboo from India. I am pursuing B.Tech in Computer Science and > Engineering at Indian Institute of Information Technology, Vadodara. I am > new to FFmpeg and wish to contribute as

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-15 Thread Aman Gupta
On Thu, Feb 15, 2018 at 4:12 AM Stefan Pöschel wrote: > The supplementary audio descriptor is defined in ETSI EN 300 468 and > provides more details regarding accessibility audio tracks, especially > the normative annex J contains a detailed description of its use. > > Its

[FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-15 Thread 王消寒
From 7c1e6b50ebe35b2a38c4f1d0a988e31eccbd0ead Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Thu, 15 Feb 2018 12:05:53 -0800 Subject: [PATCH] ffmpeg: Fix memset size on ctts_data in mov_read_trun() The allocated size of sc->ctts_data is (st->nb_index_entries + entries) *

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

2018-02-15 Thread Stefan Pöschel
Am 15.02.2018 um 20:52 schrieb Aman Gupta: > Patch looks reasonable to me. Great! > It might also be worth surfacing when the audio descriptor flags contain > mix_type=0, as this indicates a dependent stream which cannot be played > standalone. Yes, this seems to be useful, as both mixing types

Re: [FFmpeg-devel] GSOC mentored project : Super Resolution filter

2018-02-15 Thread Rostislav Pehlivanov
On 15 February 2018 at 13:30, Pedro Arthur wrote: > Hi Shivam, > > 2018-02-14 15:56 GMT-02:00 Shivam Saboo : > > > Hi Dev-Community, > > > > I am Shivam Saboo from India. I am pursuing B.Tech in Computer Science > and > > Engineering at Indian

Re: [FFmpeg-devel] [FFmpeg-cvslog] rtsp: rename certain options after a deprecation period

2018-02-15 Thread Alexander Strasser
Hi! On 2018-02-04 14:22 +, wm4 wrote: > ffmpeg | branch: master | wm4 | Thu Jan 25 18:57:26 > 2018 +0100| [ff46124b0df17a1d35249e09ae8eae9a61f16e04] | committer: wm4 > > rtsp: rename certain options after a deprecation period > > The "timeout" option name inherently

Re: [FFmpeg-devel] [FFmpeg-cvslog] rtsp: rename certain options after a deprecation period

2018-02-15 Thread wm4
On Fri, 16 Feb 2018 00:52:19 +0100 Alexander Strasser wrote: > Hi! > > On 2018-02-04 14:22 +, wm4 wrote: > > ffmpeg | branch: master | wm4 | Thu Jan 25 18:57:26 > > 2018 +0100| [ff46124b0df17a1d35249e09ae8eae9a61f16e04] | committer: wm4 > > > >