Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Timo Teras
On Tue, 17 Apr 2018 11:06:58 +0200 Michael Niedermayer wrote: > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > > See my earlier patch that changes it to report as "N/A". This is > > what > > i meant the function. Which cannot output N/A as it outputs a >

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: clean up duplicate option fields

2018-04-17 Thread Steven Liu
> On 17 Apr 2018, at 03:02, Richard Shaffer wrote: > > On Fri, Apr 13, 2018 at 5:14 PM, wrote: > >> From: Richard Shaffer >> >> The HLSContext struct contains fields which duplicate the data stored in >> the >> avio_opts field.

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cinepak: Skip empty frames

2018-04-17 Thread Tomas Härdin
tis 2018-04-17 klockan 02:13 +0200 skrev Michael Niedermayer: > Speeds up decoding from 3 to 0.1 seconds for > 6302/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5626371985375232 > Fixes: Timeout > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_mc : add hevc_mc for checkasm

2018-04-17 Thread Shengbin Meng
> On Apr 9, 2018, at 10:12, Yingming Fan wrote: > > From: Yingming Fan > > --- > Hi, there. > I plane to submit our arm32 neon codes for qpel and epel. > While before this i will submit hevc_mc checkasm codes. > This hevc_mc checkasm codes check

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > On Tue, 17 Apr 2018 01:02:43 +0200 > Michael Niedermayer wrote: > > > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton Balint wrote: > > > > > > On Mon, 16 Apr 2018, Timo Teras wrote: > > > > > > >On Sun,

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cinepak: move some checks prior to frame allocation

2018-04-17 Thread Tomas Härdin
tis 2018-04-17 klockan 02:13 +0200 skrev Michael Niedermayer: > Speeds up decoding from 8 to 3 seconds for > 6302/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5626371985375232 > Fixes: Timeout > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2] libavformat/dashdec: Avoid multiple HTTP requests for initialization segment that is common among all representations

2018-04-17 Thread Steven Liu
> On 10 Apr 2018, at 15:02, sanilraut wrote: > > Hi, > > The following patch avoid multiple HTTP requests for initialization segment > that is common among all representations. > > --- > libavformat/dashdec.c | 82 --- > 1

Re: [FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-17 Thread Steven Liu
> On 11 Apr 2018, at 07:13, Richard Shaffer wrote: > > > > On Tue, Apr 10, 2018 at 4:00 PM, Liu Steven wrote: > > > 在 2018年4月11日,上午3:14,Richard Shaffer 写道: > > > > On Tue, Apr 3, 2018 at 5:11 PM, Steven Liu

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Nicolas George
Hendrik Leppkes (2018-04-17): > Internally we have been using 0/1 for undefined aspect ratios since > like forever, I'm not sure why that was chosen, but maybe to avoid an > accidental division by zero? There is the need for two special values: unknown/undefined and invalid/broken. Possible

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Tobias Rapp
On 17.04.2018 07:32, Timo Teras wrote: [...] Do note that calculating the reduced DAR requires some mathematics which may not be simple to do from e.g. shell or simple scripting languages. This is the primary reason why I was hoping ffprobe to do this for me. Would it be acceptable to print

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Hendrik Leppkes
On Tue, Apr 17, 2018 at 11:06 AM, Michael Niedermayer wrote: > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: >> On Tue, 17 Apr 2018 01:02:43 +0200 >> Michael Niedermayer wrote: >> >> > On Mon, Apr 16, 2018 at 07:56:34PM +0200, Marton

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-17 Thread Vasile Toncu
On 12.04.2018 19:45, Thomas Mundt wrote: You need to write separate AVOption interlace_options and AVFilter avfilter_vf_interlace in vf_tinterlace.c Have a look at this patch: https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/88e0e2054d911b38662f681bdc267e08312d313a Regards, Thomas

[FFmpeg-devel] [PATCH] avformat/mpegts: also ignore new stream in PMT while seeking

2018-04-17 Thread Yuusei KUWANA
avformat/mpegts: also ignore new stream in PMT while seeking Signed-off-by: Yuusei KUWANA --- libavformat/mpegts.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 37a6aa8..bd75494 100644 --- a/libavformat/mpegts.c +++

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cinepak: Skip empty frames

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 10:36:40AM +0200, Tomas Härdin wrote: > tis 2018-04-17 klockan 02:13 +0200 skrev Michael Niedermayer: > > Speeds up decoding from 3 to 0.1 seconds for > > 6302/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5626371985375232 > > Fixes: Timeout > > > >

Re: [FFmpeg-devel] [PATCH 1/1] [RFC] ffprobe: report DAR even if SAR is undefined

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 11:16:36AM +0200, Hendrik Leppkes wrote: > On Tue, Apr 17, 2018 at 11:06 AM, Michael Niedermayer > wrote: > > On Tue, Apr 17, 2018 at 08:32:57AM +0300, Timo Teras wrote: > >> On Tue, 17 Apr 2018 01:02:43 +0200 > >> Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cinepak: move some checks prior to frame allocation

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 10:32:16AM +0200, Tomas Härdin wrote: > tis 2018-04-17 klockan 02:13 +0200 skrev Michael Niedermayer: > > Speeds up decoding from 8 to 3 seconds for > > 6302/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5626371985375232 > > Fixes: Timeout > > > >

Re: [FFmpeg-devel] Respect AR and NM overrides for Windows builds.

2018-04-17 Thread Derek Buitenhuis
On 4/17/2018 12:28 AM, Dale Curtis wrote: > Necessary for clang-cl cross compiling builds to work on Linux. Looks fairly reasonable, I think. Are you manually overriding these? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-17 Thread Paul B Mahol
On 4/17/18, Vasile Toncu wrote: > > > On 12.04.2018 19:45, Thomas Mundt wrote: >> >> You need to write separate AVOption interlace_options and AVFilter >> avfilter_vf_interlace in vf_tinterlace.c >> Have a look at this patch: >>

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffplay: only use hardware accelerated SDL texture formats

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 17, 2018 at 01:27:48AM +0200, Marton Balint wrote: > > > On Mon, 16 Apr 2018, Michael Niedermayer wrote: > > >Hi > > > >On Sat, Nov 04, 2017 at 06:28:58PM +, Marton Balint wrote: > >>ffmpeg | branch: master | Marton Balint | Sat Oct 28 > >>22:46:08 2017 +0200|

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-17 Thread Thomas Mundt
Hi, 2018-04-17 13:33 GMT+02:00 Vasile Toncu : > > > On 12.04.2018 19:45, Thomas Mundt wrote: > >> >> You need to write separate AVOption interlace_options and AVFilter >> avfilter_vf_interlace in vf_tinterlace.c >> Have a look at this patch: >>

[FFmpeg-devel] [PATCH] aac: Rework extradata parsing code

2018-04-17 Thread Vittorio Giovara
- enable the parsing code - use the new buffer instead of replacing the context one - do not push/pop configuration, just discard the exiting one - propagate errors correctly --- ping libavcodec/aacdec_template.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-)

Re: [FFmpeg-devel] [PATCH] avfilter: add deblock filter

2018-04-17 Thread Gyan Doshi
On 4/18/2018 2:25 AM, Paul B Mahol wrote: +@item block +Set size of block, allowed range is from 4 to 512. Is this along each dimension? What happens if value is greater than width or height? Please indicate default value. +@item alpha +@item beta +@item gamma +@item delta +Set blocking

Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-17 Thread Michael Niedermayer
On Mon, Apr 16, 2018 at 01:13:21PM -0700, Rahul Chaudhry wrote: > Hi Michael, > > While it is true that some linkers support the conditional branch to PLT in > Thumb mode, it is of very limited use, since it uses an R_ARM_THM_JUMP19 > relocation and does not have a good range. If I switch my

Re: [FFmpeg-devel] [FFmpeg-cvslog] ffplay: only use hardware accelerated SDL texture formats

2018-04-17 Thread Marton Balint
On Tue, 17 Apr 2018, Michael Niedermayer wrote: On Tue, Apr 17, 2018 at 01:27:48AM +0200, Marton Balint wrote: On Mon, 16 Apr 2018, Michael Niedermayer wrote: Hi On Sat, Nov 04, 2017 at 06:28:58PM +, Marton Balint wrote: ffmpeg | branch: master | Marton Balint |

Re: [FFmpeg-devel] [PATCH] libavformat/http: Fix memory leak in get_cookies.

2018-04-17 Thread wm4
On Tue, 17 Apr 2018 10:48:16 -0700 Richard Shaffer wrote: > On Fri, Apr 13, 2018 at 4:42 PM, wrote: > > > From: Richard Shaffer > > > > --- > > libavformat/http.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] ffprobe: report unavailable SAR correctly in stream info

2018-04-17 Thread Rostislav Pehlivanov
On 14 April 2018 at 21:20, Rostislav Pehlivanov wrote: > > > On 12 April 2018 at 09:07, Timo Teräs wrote: > >> av_guess_sample_aspect_ratio() will return undefined or missing >> value as {0,1}. This fixes show_stream() to check numerator to >> display

Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

2018-04-17 Thread Rahul Chaudhry
On Tue, Apr 17, 2018 at 6:17 AM, Michael Niedermayer wrote: > why does it go through the PLT at all ? You're right. The branches don't have to go through the PLT at all. Here's an alternate patch that modifies the branches to skip the PLT and jump directly to the

Re: [FFmpeg-devel] [PATCH] aac: Rework extradata parsing code

2018-04-17 Thread wm4
On Tue, 17 Apr 2018 11:47:00 -0400 Vittorio Giovara wrote: > - enable the parsing code > - use the new buffer instead of replacing the context one > - do not push/pop configuration, just discard the exiting one > - propagate errors correctly > --- > > ping > > >

[FFmpeg-devel] [PATCH] mov: Properly abide by the track's media duration

2018-04-17 Thread Derek Buitenhuis
The track's media duration from the mdhd atom takes precedence over both the stts and elst atom for calculating and setting the track's total duraion. Technically, we shouldn't be using the stts atom at all for calculating stream durations. This fixes incorrect stream and final packet durations

Re: [FFmpeg-devel] [PATCH] libavformat/http: Fix memory leak in get_cookies.

2018-04-17 Thread Richard Shaffer
On Fri, Apr 13, 2018 at 4:42 PM, wrote: > From: Richard Shaffer > > --- > libavformat/http.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index 983034f083..b4a1919f24 100644 > ---

Re: [FFmpeg-devel] Respect AR and NM overrides for Windows builds.

2018-04-17 Thread Dale Curtis
Yes, to cross-compile on Linux you need to use llvm-ar and llvm-nm. This is pretty chromium specific, but you can get the gist of what's necessary from this Chromium change: https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/1013323/4/chromium/scripts/build_ffmpeg.py - dale

[FFmpeg-devel] [PATCH] avfilter: add deblock filter

2018-04-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 23 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_deblock.c | 366 +++ 4 files changed, 391 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

2018-04-17 Thread Stephan Holljes
On Fri, Mar 30, 2018 at 3:13 PM, Stephan Holljes wrote: > On Fri, Jan 12, 2018 at 8:47 PM, Michael Niedermayer > wrote: >> On Fri, Jan 12, 2018 at 07:16:30PM +0100, Stephan Holljes wrote: >>> Signed-off-by: Stephan Holljes

Re: [FFmpeg-devel] [PATCH] libavformat/http: Fix memory leak in get_cookies.

2018-04-17 Thread Richard Shaffer
On Tue, Apr 17, 2018 at 1:04 PM, wm4 wrote: > On Tue, 17 Apr 2018 10:48:16 -0700 > Richard Shaffer wrote: > > > On Fri, Apr 13, 2018 at 4:42 PM, wrote: > > > > > From: Richard Shaffer > > > > > > --- > > >

Re: [FFmpeg-devel] [PATCH] lavf/http.c: Don't write chunked-transfer-trailer to listening server context.

2018-04-17 Thread Stephan Holljes
On Thu, Apr 12, 2018 at 2:07 AM, Stephan Holljes wrote: > --- > I found this bug while working on my qualification task. When closing > a listening HTTP AVIOContext http_shutdown() tries to write the > chunked-transfer-encoding trailer to the listening Context. > >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-04-17 Thread Michael Niedermayer
On Tue, Apr 03, 2018 at 04:08:51PM -0700, Jacob Trimble wrote: > >> > >> Ping again. I know this is low priority, but I would like to get > >> these merged soon. > > > > Ping. Despite being almost 2 months old, these patches still apply > > cleanly. Please take a look. These have been in

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove redundant code

2018-04-17 Thread Steven Liu
> On 18 Apr 2018, at 09:01, Richard Shaffer wrote: > > On Mon, Apr 16, 2018 at 10:24 PM, Steven Liu wrote: > >> >> >>> On 16 Apr 2018, at 08:37, Jun Zhao wrote: >>> >>> >>> >>> On 2018/4/13 20:29, Steven Liu wrote:

[FFmpeg-devel] [PATCH] libavformat/http: Refactor and fix additional leaks in get_cookies.

2018-04-17 Thread rshaffer
From: Richard Shaffer This refactors get_cookies to simplify some code paths, specifically for skipping logic in the while loop or exiting it. It also simplifies the logic for appending additional values to *cookies by replacing strlen/malloc/snprintf with one call

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove redundant code

2018-04-17 Thread Richard Shaffer
On Mon, Apr 16, 2018 at 10:24 PM, Steven Liu wrote: > > > > On 16 Apr 2018, at 08:37, Jun Zhao wrote: > > > > > > > > On 2018/4/13 20:29, Steven Liu wrote: > >> 2018-04-13 16:19 GMT+08:00 Jun Zhao : > >>> > >>> On 2018/4/12 16:48,