Re: [FFmpeg-devel] [PATCH] lavf/bluray: translate a read of 0 to EOF

On Sun, May 6, 2018 at 5:32 PM, wm4 wrote: > > Hilarious, another of those EOf issues. Too bad we didn't just revert > that crap. I wonder how many years it'll take until we got all of them. > > LGTM. Thanks, pushed. This should be back-ported to release/4.0 I guess? Jan

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config check for zlib

On 5/5/2018 4:12 PM, Jan Ekström wrote: > It exists, so why not use it? Helps one get rid of additional > search path related flags in addition to PKG_CONFIG_{PATH,LIBDIR} > when utilizing a cross-prefix separate from the sysroot. > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1

[FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg: fix for all forced key frames when 'copyts' is enabled

From: Vishwanath Dixit Forced key frames generation functionality was assuming the first PTS value as zero, but, when 'copyts' is enabled, the first PTS can be any big number. This was eventually forcing all the frames as key frames. To resolve this issue, update has been made

Re: [FFmpeg-devel] [PATCH] lavf/bluray: translate a read of 0 to EOF

On Sun, May 06, 2018 at 06:55:01PM +0300, Jan Ekström wrote: > On Sun, May 6, 2018 at 5:32 PM, wm4 wrote: > > > > Hilarious, another of those EOf issues. Too bad we didn't just revert > > that crap. I wonder how many years it'll take until we got all of them. > > > > LGTM.

[FFmpeg-devel] [PATCH 2/2] avcodec/libzvbi-teletextdec: formatted ass output

Inspired by the VideoLAN text decoder and its port to FFmpeg made by Aman Gupta. Signed-off-by: Marton Balint --- doc/decoders.texi| 18 ++- libavcodec/libzvbi-teletextdec.c | 265 +-- 2 files changed, 270 insertions(+), 13

[FFmpeg-devel] [PATCH 1/2] avcodec/libzvbi-teletextdec: add support for selecting subtitle pages only

Signed-off-by: Marton Balint --- doc/decoders.texi| 5 +++-- libavcodec/libzvbi-teletextdec.c | 31 ++- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index a551d5d0fd..8f07bc1afb

Re: [FFmpeg-devel] [PATCH 2/9] lavfi/nlmeans: add SIMD-friendly assumptions for compute_safe_ssd_integral_image

On Sun, May 06, 2018 at 01:40:53PM +0200, Clément Bœsch wrote: > SIMD code will not have to deal with padding itself. Overwriting in that > function may have been possible but involve large overreading of the > sources. Instead, we simply make sure the width to process is always a > multiple of

Re: [FFmpeg-devel] [PATCH 1/3] avformat/utils: function to get the formatted ntp time

On Sun, May 06, 2018 at 06:04:35PM +, Dixit, Vishwanath wrote: > > > On 4/28/18 6:38 AM, Michael Niedermayer wrote: > > On Fri, Apr 27, 2018 at 08:00:23AM +, Dixit, Vishwanath wrote: > >> > >> > >> On 4/27/18 5:15 AM, Michael Niedermayer wrote: > >>> On Thu, Apr 26, 2018 at 11:05:59AM

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-06 13:32 GMT+02:00 Tomas Härdin : > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt: > > Hi, > > > > this is a better version of the patch. > > 10 bit and TFF are mandatory for AVC Intra only. Other profiles > > differ. > > > > > diff --git a/libavformat/mxfenc.c

[FFmpeg-devel] [PATCH] mdct15: simplify the fft15 x86 SIMD

Saves 1 gpr and 2 instructions and simplifies the macros a bit. Signed-off-by: Rostislav Pehlivanov --- libavcodec/x86/mdct15.asm | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/libavcodec/x86/mdct15.asm

[FFmpeg-devel] [PATCH 2/3] lavf/tcp: add option to setting Maximum Segment Size

This can change the the MSS value announced to the other end in the initial TCP packet, it's can be used when failed Path MTU discovery. Signed-off-by: Jun Zhao --- libavformat/tcp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/tcp.c

[FFmpeg-devel] [PATCH 1/3] lavf/network: fix doxygen comments.

Signed-off-by: Jun Zhao --- libavformat/network.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/network.h b/libavformat/network.h index e3fda4d..efaa789 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -87,9 +87,9 @@

[FFmpeg-devel] [PATCH 3/3] doc/protocols: documents tcp_mss

Signed-off-by: Jun Zhao --- doc/protocols.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index e19504d..4a0bbc8 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1397,6 +1397,9 @@ Set send buffer size, expressed

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libzvbi-teletextdec: allow -1 subtitle duration and make it the default

On Wed, 2 May 2018, Marton Balint wrote: Most decoders (pgssubdec, ccaption_dec) are using -1 or UINT32_MAX for a subtitle event which should be cleared at the next event. Applied this and the next patch, I will re-send the third. Regards, Marton

[FFmpeg-devel] [PATCH] lavf/bluray: translate a read of 0 to EOF

Yet another case of forgotten 0 =! EOF translation. The libbluray documentation specifically mentions that a read of 0 is EOF. Reported by Fyr on IRC. --- libavformat/bluray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/bluray.c b/libavformat/bluray.c index

Re: [FFmpeg-devel] [PATCH 7/9] lavfi/nlmeans: switch from double to float

On Sun, May 06, 2018 at 13:40:58 +0200, Clément Bœsch wrote: > Overall speed appears to be 1.1x faster with no noticeable quality impact. Probably platform dependant? > struct weighted_avg { > -double total_weight; > -double sum; > +float total_weight; > +float sum; > }; I

Re: [FFmpeg-devel] [PATCH 3/3] doc/protocols: documents tcp_mss

On 5/6/2018 8:42 PM, Jun Zhao wrote: +@item tcp_mss=@var{bytes} +Set maximum segment size for outgoing TCP packets, expressed bytes. 'expressed bytes' --> 'expressed in bytes' or just 'in bytes' (preferred). Thanks, Gyan ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avformat/utils: function to get the formatted ntp time

On 4/28/18 6:38 AM, Michael Niedermayer wrote: > On Fri, Apr 27, 2018 at 08:00:23AM +, Dixit, Vishwanath wrote: >> >> >> On 4/27/18 5:15 AM, Michael Niedermayer wrote: >>> On Thu, Apr 26, 2018 at 11:05:59AM +, Dixit, Vishwanath wrote: On 4/26/18 1:04 AM, Michael

Re: [FFmpeg-devel] [PATCH] lavf/bluray: translate a read of 0 to EOF

On Sun, 6 May 2018 17:19:44 +0300 Jan Ekström wrote: > Yet another case of forgotten 0 =! EOF translation. The libbluray > documentation specifically mentions that a read of 0 is EOF. > > Reported by Fyr on IRC. > --- > libavformat/bluray.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config check for zlib

On Sun, May 6, 2018 at 7:41 PM, James Almer wrote: > > LGTM. Thanks, pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/g2meet: Change order of operations to avoid undefined behavior

On Fri, May 04, 2018 at 07:43:45PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65280 * 196032 cannot be represented in type > 'int' > Fixes: > 7279/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5977332473921536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

On 5/5/2018 5:38 PM, James Almer wrote: > On 4/10/2018 2:16 PM, Sergey Lavrushkin wrote: >> diff --git a/libavfilter/vf_srcnn.c b/libavfilter/vf_srcnn.c >> new file mode 100644 >> index 00..d9b4891f7f >> --- /dev/null >> +++ b/libavfilter/vf_srcnn.c >> @@ -0,0 +1,420 @@ >> +/* >> + *

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: handling copyts use case in forced key frames functionality

On 4/27/18 6:24 AM, Michael Niedermayer wrote: > On Thu, Apr 26, 2018 at 10:33:59AM +0530, vdi...@akamai.com wrote: >> From: Vishwanath Dixit >> >> Forced key frames creation functionality was assuming the first PTS >> value to be zero, but, when 'copyts' is enalbed, the

Re: [FFmpeg-devel] [PATCH 2/3] lavf/tcp: add option to setting Maximum Segment Size

On Sun, May 06, 2018 at 11:12:13PM +0800, Jun Zhao wrote: > This can change the the MSS value announced to the other end in > the initial TCP packet, it's can be used when failed Path MTU > discovery. > > Signed-off-by: Jun Zhao > --- > libavformat/tcp.c | 5 + > 1 file

[FFmpeg-devel] [PATCH] avformat/dashenc: Add documentation for http method option

From: Karthick Jeyapal --- doc/muxers.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 2429f8e..ea80296 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -252,6 +252,8 @@ DASH-templated name to used for the

Re: [FFmpeg-devel] [PATCH 2/3] lavf/tcp: add option to setting Maximum Segment Size

2018-05-07 5:17 GMT+08:00 Michael Niedermayer : > On Sun, May 06, 2018 at 11:12:13PM +0800, Jun Zhao wrote: >> This can change the the MSS value announced to the other end in >> the initial TCP packet, it's can be used when failed Path MTU >> discovery. >> >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] doc/protocols: documents tcp_mss

2018-05-06 23:16 GMT+08:00 Gyan Doshi : > > > On 5/6/2018 8:42 PM, Jun Zhao wrote: > >> +@item tcp_mss=@var{bytes} >> +Set maximum segment size for outgoing TCP packets, expressed bytes. > > > 'expressed bytes' --> 'expressed in bytes' > > or just 'in bytes' (preferred). > >

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

2018-05-06 17:27 GMT-03:00 James Almer : > On 5/5/2018 5:38 PM, James Almer wrote: >> On 4/10/2018 2:16 PM, Sergey Lavrushkin wrote: >>> diff --git a/libavfilter/vf_srcnn.c b/libavfilter/vf_srcnn.c >>> new file mode 100644 >>> index 00..d9b4891f7f >>> --- /dev/null >>>

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

Hi Sergey, How should i test this filter? I tested it some days ago, the picture get worse from 2nd frame. input resolution 640x480 to 1280x720; ffmpeg -i input -vf srcnn output > On May 7, 2018, at 09:33, Pedro Arthur wrote: > > 2018-05-06

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check that there will be sufficient input for the coded fragments in unpack_superblocks()

On 5/6/18, Michael Niedermayer wrote: > On Sat, May 05, 2018 at 09:14:52PM +0200, wm4 wrote: >> On Sat, 5 May 2018 21:10:06 +0200 >> Michael Niedermayer wrote: >> >> > Fixes: Timeout >> > Fixes: >> >

[FFmpeg-devel] [PATCH 4/9] lavfi/nlmeans: add AArch64 SIMD for compute_safe_ssd_integral_image

ssd_integral_image_c: 49204.6 ssd_integral_image_neon: 28346.8 --- libavfilter/aarch64/Makefile | 3 ++ libavfilter/aarch64/vf_nlmeans_init.c | 33 libavfilter/aarch64/vf_nlmeans_neon.S | 78 +++ libavfilter/vf_nlmeans.c | 18 +--

[FFmpeg-devel] [PATCH 5/9] checkasm: add vf_nlmeans test for ssd_integral_image

--- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_nlmeans.c | 113 4 files changed, 118 insertions(+) create mode 100644 tests/checkasm/vf_nlmeans.c diff --git

[FFmpeg-devel] [PATCH 8/9] lavfi/nlmeans: move final weighted averaging out of nlmeans_plane

This helps figuring out where the filter is slow: 70.53% ffmpeg_g ffmpeg_g [.] nlmeans_slice 25.73% ffmpeg_g ffmpeg_g [.] compute_safe_ssd_integral_image_c 1.74% ffmpeg_g ffmpeg_g [.] compute_unsafe_ssd_integral_image 0.82% ffmpeg_g ffmpeg_g

[FFmpeg-devel] [PATCH 6/9] lavfi/nlmeans: make compute_safe_ssd_integral_image_c faster

before: ssd_integral_image_c: 49204.6 after: ssd_integral_image_c: 44272.8 Unrolling by 4 for made the biggest different on odroid-c2 (aarch64); unrolling by 2 or 8 both raised 46k cycles vs 44k for 4. Additionally, this is a much better reference when writing SIMD (SIMD vectorization will

[FFmpeg-devel] [PATCH 9/9] lavfi/nlmeans: reorder memory accesses in get_integral_patch_value

This doesn't seem to make much of a difference but it can't hurt. --- libavfilter/vf_nlmeans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index abe708a2fc..38c50bc94a 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] [PATCH 2/9] lavfi/nlmeans: add SIMD-friendly assumptions for compute_safe_ssd_integral_image

SIMD code will not have to deal with padding itself. Overwriting in that function may have been possible but involve large overreading of the sources. Instead, we simply make sure the width to process is always a multiple of 16. Additionally, there must be some actual area to process so the SIMD

[FFmpeg-devel] [PATCH 3/9] lavfi/nlmeans: use ptrdiff_t for linesizes

Similarly to previous commit, this will help writing SIMD code by not having manual zero-extension in SIMD code --- libavfilter/vf_nlmeans.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index

[FFmpeg-devel] [PATCH 1/9] lavfi/nlmeans: random code shuffling to help compiler

This makes nlmeans_slice() slightly faster at least on GCC 7.3. --- libavfilter/vf_nlmeans.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index e4952e187e..d222d3913e 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] Misc improvements in nlmeans filter

The biggest change is the introduction of the dsp infrastructure such that more SIMD can be added, in particular x86 version(s) of the integral computation function. Only aarch64 was added so far (because the ASM is easy), and I don't plan to work on other arch for now. The filter is still pretty

[FFmpeg-devel] [PATCH 7/9] lavfi/nlmeans: switch from double to float

Overall speed appears to be 1.1x faster with no noticeable quality impact. --- libavfilter/vf_nlmeans.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index f37f1183f7..201e4feb41 100644 ---

Re: [FFmpeg-devel] [PATCH] opt: print a deprecation indicator when listing options

On Sat, May 05, 2018 at 09:45:26PM +0100, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavutil/opt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 99282605f5..73295356a1 100644 > ---

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfenc: add h264 profiles

fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt: > Hi, > > this is a better version of the patch. > 10 bit and TFF are mandatory for AVC Intra only. Other profiles > differ. > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 3bb7032..81513dc 100644 > ---