Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Derek Buitenhuis
On 17/01/2019 23:33, Michael Niedermayer wrote: > Would you be ok with rejecting RSCC files without a keyframe ? > or more precissely all frames before a keyframe and thus if there is > no keyframe the whole file > (that would be a superset of what this patch rejects) This, to me, soundsp

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Vittorio Giovara
On Thu, Jan 17, 2019 at 10:57 PM Neil Birkbeck wrote: > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > wrote: > > > This allows preservation of color values set from the container, > > while still letting the bitstream take precedent when its values > > are specified to some actual value

Re: [FFmpeg-devel] [PATCH 5/5] lavf/tls: enable server verification by default when not on mbedtls

2019-01-18 Thread Carl Eugen Hoyos
2019-01-18 9:46 GMT+01:00, Rodger Combs : > All other TLS wrappers now have a mechanism to load a system trust store > by default, without setting the cafile option. For Secure Transport and > Secure Channel, it's the OS. For OpenSSL and libtls, it's a path set at > compile-time. For GNUTLS, it's

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fate.sh: print some statistics

2019-01-18 Thread Carl Eugen Hoyos
2019-01-17 22:21 GMT+01:00, Michael Niedermayer : > On Tue, Jan 15, 2019 at 11:41:22PM +0100, Carl Eugen Hoyos wrote: >> 2019-01-15 23:36 GMT+01:00, Michael Niedermayer : >> > On Fri, Jan 04, 2019 at 08:29:36PM +0100, Michael Niedermayer wrote: >> >> On Sat, Dec 29, 2018 at 10:47:16AM +0100,

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for ROI-based encoding

2019-01-18 Thread Derek Buitenhuis
On 18/01/2019 15:53, Guo, Yejun wrote: [...] > +static av_cold int libx265_encode_set_roi(libx265Context *ctx, const AVFrame > *frame, x265_picture* pic) > +{ > +// From x265.h: > +/* An array of quantizer offsets to be applied to this image during > encoding. > +* These are added

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Vittorio Giovara
On Fri, Jan 18, 2019 at 6:43 AM Carl Eugen Hoyos wrote: > 2019-01-18 4:48 GMT+01:00, Neil Birkbeck : > > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > > wrote: > > > >> This allows preservation of color values set from the container, > >> while still letting the bitstream take precedent when

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Vittorio Giovara
On Thu, Jan 17, 2019 at 6:34 PM Michael Niedermayer wrote: > On Wed, Jan 16, 2019 at 09:05:18PM -0500, Vittorio Giovara wrote: > > On Wed, Jan 16, 2019 at 7:44 PM Michael Niedermayer > > > wrote: > > > > > Fixes: Timeout > > > Fixes: > > > >

[FFmpeg-devel] [PATCH]lavu/frame: Try to improve the documentation wording

2019-01-18 Thread Carl Eugen Hoyos
Hi! Attached patch tries to improve the ROI documentation wording, C structs cannot return errors. Please comment, Carl Eugen From 4abd545e7ab463c97bf816b270544eee25c4755b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 18 Jan 2019 12:35:44 +0100 Subject: [PATCH] lavu/frame: Try to

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Derek Buitenhuis
On 18/01/2019 11:46, Carl Eugen Hoyos wrote: > No, you are completely missing the point. I am not. I fully understand the argument in favour of these, I just don't agree. > Possible security issues in this decoder will only be > searched (and therefore found) if the decoder doesn't > timeout

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Carl Eugen Hoyos
2019-01-17 22:58 GMT+01:00, Derek Buitenhuis : > On 17/01/2019 03:06, Carl Eugen Hoyos wrote: >> You mean searching for security issues makes no sense? > > This isn't a security and it isn't a fix. It's a completely > arbitrary statistic to make an arbitrary program happy. No, you are completely

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Carl Eugen Hoyos
2019-01-18 4:48 GMT+01:00, Neil Birkbeck : > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > wrote: > >> This allows preservation of color values set from the container, >> while still letting the bitstream take precedent when its values >> are specified to some actual value (e.g., not

Re: [FFmpeg-devel] [PATCHv2 2/6] avcodec/vp3dsp: add 12 pixel loop filter functions

2019-01-18 Thread Peter Ross
On Tue, Jan 15, 2019 at 12:18:44AM +0100, Hendrik Leppkes wrote: > On Mon, Jan 14, 2019 at 9:48 PM Peter Ross wrote: > > diff --git a/libavcodec/vp3dsp.h b/libavcodec/vp3dsp.h > > index f55a7f834f..30a76100d9 100644 > > --- a/libavcodec/vp3dsp.h > > +++ b/libavcodec/vp3dsp.h > > @@ -43,8 +43,13

Re: [FFmpeg-devel] [PATCH] [RFC] channel_layout: add support for ambisonics

2019-01-18 Thread Felicia Lim
On Thu, Nov 29, 2018 at 1:55 PM Marton Balint wrote: > > > On Thu, 29 Nov 2018, Rostislav Pehlivanov wrote: > > > This is an RFC to add support for tagging channel layouts as ambisonics > > in a backward-compatible way. > > For now ambisonics up to third order are supported. > > The functions

Re: [FFmpeg-devel] [PATCH 5/5] lavf/tls: enable server verification by default when not on mbedtls

2019-01-18 Thread Rodger Combs
> On Jan 18, 2019, at 05:41, Carl Eugen Hoyos wrote: > > 2019-01-18 9:46 GMT+01:00, Rodger Combs : >> All other TLS wrappers now have a mechanism to load a system trust store >> by default, without setting the cafile option. For Secure Transport and >> Secure Channel, it's the OS. For OpenSSL

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Neil Birkbeck
On Fri, Jan 18, 2019 at 7:48 AM Vittorio Giovara wrote: > On Fri, Jan 18, 2019 at 6:43 AM Carl Eugen Hoyos > wrote: > > > 2019-01-18 4:48 GMT+01:00, Neil Birkbeck : > > > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > > > > wrote: > > > > > >> This allows preservation of color values set from

[FFmpeg-devel] [PATCH] tools/target_dec_fate.list: add entries upto 1214

2019-01-18 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dec_fate.list | 63 ++ 1 file changed, 63 insertions(+) diff --git a/tools/target_dec_fate.list b/tools/target_dec_fate.list index f6b56261bb..b20137bfef 100644 --- a/tools/target_dec_fate.list +++

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix fmp4_init_filename file name with %v problem

2019-01-18 Thread Steven Liu
when set option fmp4_init_filename to init_%v.mp4 before patch: the init file will be init_%v_0.mp4, init_%v_1.mp4 after patch: the init file will be init_0.mp4, init_1.mp4 Reported-By: Gyan Doshi Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 6 +- 1 file changed, 5 insertions(+), 1

[FFmpeg-devel] [PATCH 2/2] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Michael Niedermayer
Fixes: Timeout Fixes: 12192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 Before: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 in 15423 ms After: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264

Re: [FFmpeg-devel] [PATCH] avfilter/extractplanes: add support for 12-bit YUVA formats

2019-01-18 Thread Moritz Barsnick
On Thu, Jan 17, 2019 at 20:38:44 +0100, Carl Eugen Hoyos wrote: > > Fixes alpha extraction for sample at > > > > https://08488297638989341201.googlegroups.com/attach/85d30cd6b8095/Circle%20Ink%20Bleed_10.mov > > This is a textfile afaict. The correct download link seems to be

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2019-01-18 Thread Marton Balint
On Thu, 17 Jan 2019, Michael Niedermayer wrote: On Wed, Jan 16, 2019 at 08:00:22PM +0100, Marton Balint wrote: On Tue, 15 Jan 2019, Michael Niedermayer wrote: On Sun, Dec 30, 2018 at 07:15:49PM +0100, Marton Balint wrote: On Fri, 28 Dec 2018, Michael Niedermayer wrote: On Wed, Dec

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-18 Thread Matthew Fearnley
> On 18 Jan 2019, at 23:00, Michael Niedermayer wrote: > > Fixes: Timeout > Fixes: > 12192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > > Before: > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > in 15423 ms > After: >

[FFmpeg-devel] [PATCH 1/2] avcodec: Add discard_sample_percentage

2019-01-18 Thread Michael Niedermayer
Suggested-by: BBB Signed-off-by: Michael Niedermayer --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 8 libavcodec/options_table.h | 1 + tests/ref/fate/api-mjpeg-codec-param | 2 ++ tests/ref/fate/api-png-codec-param | 2 ++ 5 files

[FFmpeg-devel] [PATCH 3/5] lavf/tls_openssl: on 1.1 or later, verify the server's hostname

2019-01-18 Thread Rodger Combs
--- libavformat/tls_openssl.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index ae3fd6e236..ba233c0229 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -35,6 +35,7 @@

[FFmpeg-devel] [PATCH 5/5] lavf/tls: enable server verification by default when not on mbedtls

2019-01-18 Thread Rodger Combs
All other TLS wrappers now have a mechanism to load a system trust store by default, without setting the cafile option. For Secure Transport and Secure Channel, it's the OS. For OpenSSL and libtls, it's a path set at compile-time. For GNUTLS, it's either a path set at compile-time, or the OS trust

[FFmpeg-devel] [PATCH 1/5] lavf/tls_openssl: disable obsolete locking code on OpenSSL 1.1 and later

2019-01-18 Thread Rodger Combs
These functions are now all no-ops and locking is handled internally. This fixes a small memory leak on init. --- libavformat/tls_openssl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7ae71bdaf3..9dd53c6fc0

[FFmpeg-devel] [PATCH 2/5] lavf/tls_openssl: if no CA path is set, use the system default

2019-01-18 Thread Rodger Combs
This is consistent with the other TLS wrappers --- libavformat/tls_openssl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 9dd53c6fc0..ae3fd6e236 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -253,6

[FFmpeg-devel] [PATCH 4/5] lavf/tls: apply numerichost check to verifyhost

2019-01-18 Thread Rodger Combs
--- libavformat/tls.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/tls.c b/libavformat/tls.c index 10e0792e29..a6dcd3cc96 100644 --- a/libavformat/tls.c +++ b/libavformat/tls.c @@ -80,15 +80,15 @@ int ff_tls_open_underlying(TLSShared *c, URLContext

[FFmpeg-devel] [PATCH] avcodec/libx265: add support for ROI-based encoding

2019-01-18 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavcodec/libx265.c | 74 1 file changed, 74 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 27c90b3..6b1cc74 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -285,6