[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension it, solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Also prints the DNG version of the file

[FFmpeg-devel] [PATCH] avformat/mov: Fix potential integer overflow in entry check in mov_read_trun()

2019-03-17 Thread Michael Niedermayer
No testcase Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a7d444b0ee..ff9a9cbc95 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4778,7 +4778,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1dec_template: Optimize golomb run mode

2019-03-17 Thread Michael Niedermayer
On Fri, Mar 08, 2019 at 05:38:33PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (34sec -> 12sec) > Fixes: > 13398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-5664106709778432 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] pngdec: add ability to check chunk CRC

2019-03-17 Thread Lynne
8 Mar 2019, 14:15 by d...@lynne.ee: > 7 Mar 2019, 21:22 by > mich...@niedermayer.cc > > : > >> On Thu, Mar 07, 2019 at 07:26:32PM +0100, Lynne wrote: >> >>> By default now, if AV_EF_CRCCHECK or AV_EF_IGNORE_ERR are enabled the >>> decoder >>> will skip the chunk

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Carl Eugen Hoyos
Am So., 17. März 2019 um 08:46 Uhr schrieb : > -case TIFF_WHITE_LEVEL: > +case DNG_WHITE_LEVEL: Why is this a good change? > @@ -1389,6 +1405,11 @@ again: > return ret; > } > > +if (s->dng_mode) { > +av_log(avctx, AV_LOG_ERROR, "DNG images are not

Re: [FFmpeg-devel] patch for a new H.264 codec with Matrox m264 card.

2019-03-17 Thread Tomas Härdin
fre 2019-03-15 klockan 18:45 +0100 skrev Nicolas George: > Yufei He (12019-03-15): > > I did not find a better way to make this work. > > It exists: make your client libraries GPL-compatible. I second this /Tomas ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] libavdevice/v4l2: Return EAGAIN when receiving a frame of unexpected size

2019-03-17 Thread Alexander Strasser
I had found that when capturing video for some hours from USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), sometimes when invoking the ioctl DQBUF, the returned buffer is not filled with the size we expect for the raw video frame. Here are two examples for such occurrences:

Re: [FFmpeg-devel] [PATCH v3 3/6] lavc/qsvdec: Replace current parser with MFXVideoDECODE_DecodeHeader()

2019-03-17 Thread Mark Thompson
On 08/03/2019 07:40, Zhong Li wrote: > Using MSDK parser can improve qsv decoder pass rate in some cases (E.g: > sps declares a wrong level_idc, smaller than it should be). > And it is necessary for adding new qsv decoders such as MJPEG and VP9 > since current parser can't provide enough

Re: [FFmpeg-devel] Bug in YUV decoder

2019-03-17 Thread Ben Hutchinson
On Fri, Mar 15, 2019, 11:34 PM Reto Kromer Ben Hutchinson wrote: > > >What is top posting? I'll try to avoid it if I know what it is. > > Then please "google" it. Thanks! > > https://ffmpeg.org/contact.html#MailingLists > https://en.wikipedia.org/wiki/Posting_style#Top-posting > >

Re: [FFmpeg-devel] [PATCH 2/2] lavf/movdec: use a more appropriate error code for bad trun atoms

2019-03-17 Thread Michael Niedermayer
On Sat, Mar 16, 2019 at 05:22:03AM -0500, Rodger Combs wrote: > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 0dfee2e7c4..9ed109962f 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pnm: Optimize reading loop in pnm_get()

2019-03-17 Thread Michael Niedermayer
On Mon, Mar 11, 2019 at 12:42:08AM +0100, Michael Niedermayer wrote: > Fixes: Timeout 13149 (5sec -> 3sec), 13166 (11sec -> 7sec), 13430 (5sec -> > 3sec) > Fixes: > 13149/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5760833622114304 > Fixes: >

Re: [FFmpeg-devel] [PATCH 1/2] lavf/vf_vpp_qsv: add transpose support for QSV VPP

2019-03-17 Thread Mark Thompson
On 15/03/2019 16:34, Linjie Fu wrote: > Add transpose support for qsv_vpp: > - rotation: [0, 3] support clockwise rotation of 0, 90, 180, 270; > - mirror: [0, 1] support horizontal mirroring; > > ffmpeg -hwaccel qsv -v verbose -c:v h264_qsv -i input.h264 > -vf

Re: [FFmpeg-devel] [PATCH v3 5/6] lavc/qsvdec: Add mjpeg decoder support

2019-03-17 Thread Mark Thompson
On 08/03/2019 07:40, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > Changelog | 1 + > configure | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c| 1 + > libavcodec/qsvdec_other.c | 28 +++- > 5 files changed,

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/diracdec: Count truncated parts as errors in decode_component()

2019-03-17 Thread Michael Niedermayer
On Fri, Mar 08, 2019 at 05:38:34PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (29sec -> 4sec) > Fixes: > 13150/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5690185671507968 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/clearvideo: Check remaining data in P frames

2019-03-17 Thread Michael Niedermayer
On Fri, Mar 08, 2019 at 02:20:57AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (19sec -> 419msec) > Fixes: > 13411/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CLEARVIDEO_fuzzer-5733153811988480 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: Return EAGAIN when receiving a frame of unexpected size

2019-03-17 Thread Nicolas George
Alexander Strasser (12019-03-17): > I had found that when capturing video for some hours from > USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), > sometimes when invoking the ioctl DQBUF, the returned buffer is not > filled with the size we expect for the raw video frame.

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Paul B Mahol
On 3/17/19, Nick Renieris wrote: > Στις Κυρ, 17 Μαρ 2019 στις 8:34 μ.μ., ο/η Paul B Mahol > έγραψε: >> Please try with option adding instead(-subimage). It will ignore >> thumbnail and try to decode rest of image. >> Anyhow the return statement is invalid, as it breaks support for files >> that

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: Return EAGAIN when receiving a frame of unexpected size

2019-03-17 Thread Alexander Strasser
On 2019-03-17 18:25 +0100, Nicolas George wrote: > Alexander Strasser (12019-03-17): > > I had found that when capturing video for some hours from > > USB Camera-B4.09.24.1 (Manufacturer: OmniVision Technologies, Inc.), > > sometimes when invoking the ioctl DQBUF, the returned buffer is not > >

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 10:43 π.μ., ο/η Paul B Mahol έγραψε: > Are you sure that this does not break support with previously supported files. > Please remove return statement. By "support" you mean the thumbnail thing? Did you read the StackExchange question? I would consider it more of a bug

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 8:34 μ.μ., ο/η Paul B Mahol έγραψε: > Please try with option adding instead(-subimage). It will ignore > thumbnail and try to decode rest of image. > Anyhow the return statement is invalid, as it breaks support for files > that are already working just fine. Sorry, I

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Κυρ, 17 Μαρ 2019 στις 10:41 μ.μ., ο/η Paul B Mahol έγραψε: > Give link to input you use. All DNGs I've tried. An example is the samples linked in the ticket: https://kenrockwell.com/leica/m9/sample-photos-3.htm Running ffmpeg -i L1004220.DNG out.jpg with the 'return AVERROR_PATCHWELCOME;'

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Paul B Mahol
On 3/17/19, velocit...@gmail.com wrote: > From: Nick Renieris > > Prints "DNG images are not supported" if it finds a TIFF image with > the 'DNGVersion' tag. In DNG images with the .tiff extension it, > solves the issue where the TIFF thumbnail in IFD 0 was incorrectly > parsed (related

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: Return EAGAIN when receiving a frame of unexpected size

2019-03-17 Thread Nicolas George
Alexander Strasser (12019-03-18): > I tested the EAGAIN version and it worked. I also tested returning a ffmpeg.c uses the non-blocking mode. > zero-sized packet, like in the case where V4L flags the data as corrupt, > that worked too. See commit 28f20d2ff487aa589643d8f70eaf614b78839685 > > Do

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension it, solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Adds an option (-dng_thumbnail) for

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread Nick Renieris
Στις Δευ, 18 Μαρ 2019 στις 12:05 π.μ., ο/η Paul B Mahol έγραψε: > Still wrong, You can decode images you linked just fine (albeit with > incorrect colors) with command: > > ffmpeg -subimage 1 -i IMAGE.dng rest of command. Oh ok, I thought you agreed to go with the -thumbnail option I

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-03-17 Thread velocityra
From: Nick Renieris Prints "DNG images are not supported" if it finds a TIFF image with the 'DNGVersion' tag. In DNG images with the .tiff extension, it solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). The user can still decode those with the

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegpicture: Check size of edge_emu_buffer

2019-03-17 Thread Michael Niedermayer
Fixes: OOM Fixes: 13710/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5633152942342144 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpegpicture.c | 7 ++- 1 file

[FFmpeg-devel] [PATCH 2/2] avcodec/indeo2: Check input size against resolution in ir2_decode_plane()

2019-03-17 Thread Michael Niedermayer
Fixes: Timeout (56 sec -> 14 sec) Fixes: 13708/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO2_fuzzer-5656342004498432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/indeo2.c | 2 +-

Re: [FFmpeg-devel] [PATCH v5] avformat/smoothstreamingenc:add bitrate calculate

2019-03-17 Thread Jun Li
On Fri, Mar 15, 2019 at 6:04 PM Jun Li wrote: > Calculate bitrate based on fragment size, only applied when > bitrate is not set, for example rtsp source. > > Signed-off-by: Jun Li > --- > libavformat/smoothstreamingenc.c | 32 +++- > 1 file changed, 27

Re: [FFmpeg-devel] [PATCH v3 3/6] lavc/qsvdec: Replace current parser with MFXVideoDECODE_DecodeHeader()

2019-03-17 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Sunday, March 17, 2019 10:20 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 3/6] lavc/qsvdec: Replace current > parser with MFXVideoDECODE_DecodeHeader() > > On 08/03/2019

Re: [FFmpeg-devel] [PATCH 1/2] lavf/vf_vpp_qsv: add transpose support for QSV VPP

2019-03-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Sunday, March 17, 2019 21:59 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf/vf_vpp_qsv: add transpose > support for QSV VPP > > On