Re: [FFmpeg-devel] [PATCH 1/6] lavc/aacenc_ltp: remove unnecessary condition check.

On Sat, May 11, 2019 at 12:06 AM Jun Zhao wrote: > > From: Jun Zhao > > Condition 'sum==2' is always true, so remove the check logic to > make the code clean. > > Signed-off-by: Jun Zhao > --- > libavcodec/aacenc_ltp.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 5/6] lavc/mlpenc: remove the redundant condition check

On Sat, May 11, 2019 at 12:06 AM Jun Zhao wrote: > > From: Jun Zhao > > remove the redundant condition check for 'frame' > > Signed-off-by: Jun Zhao > --- > libavcodec/mlpenc.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mlpenc.c

Re: [FFmpeg-devel] [PATCH 6/6] lavc/pngenc: check malloc fail before using the pointer

On Sat, May 11, 2019 at 12:06 AM Jun Zhao wrote: > > From: Jun Zhao > > Need to check malloc fail before using the pointer > > Signed-off-by: Jun Zhao > --- > libavcodec/pngenc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/pngenc.c

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

On Mon, May 13, 2019 at 4:06 AM Gyan wrote: > > > > On 10-05-2019 07:25 PM, Gyan wrote: > > At present, if the command args passed to drawtext contain any invalid > > values, ffmpeg may crash or, at best, stop drawing any text. > > Attached patch gets the filter to continue with existing

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am Mo., 13. Mai 2019 um 00:55 Uhr schrieb James Almer : > > On 5/12/2019 7:42 PM, Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : > >> I need *technical* feedback about the API. > > > > I understand that. > > Then, if you can't provide technical feedback, please stop

Re: [FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

On Fri, May 10, 2019 at 7:25 PM Jun Li wrote: > > On Thu, May 9, 2019 at 2:08 AM Jun Li wrote: > >> Fix #5090 >> Fix the timestamp rescale issue, from sidx timebase to >> stream's timebase. >> --- >> libavformat/mov.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCHv2] lavfi: add gblur_opencl filter

On Sun, May 12, 2019 at 10:47 PM Paul B Mahol wrote: > On 5/8/19, Song, Ruiling wrote: > > > > > >> -Original Message- > >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > >> Of Dylan Fernando > >> Sent: Tuesday, May 7, 2019 8:27 AM > >> To:

[FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

--- libavformat/Makefile | 2 +- libavformat/avc.c| 186 + libavformat/avc.h| 15 +++ libavformat/hevc.c | 36 +--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 213 ++- 6 files changed, 372

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: > Marton Balint (12019-05-12): > > Yeah, you are right, what I had in mind was this: > > > > apitch === asetrate,aresample,atempo > > Exactly. And reciprocally, atempo = apitch+asetrate+aresample. > > Furthermore, since it works

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

On 5/12/19, Michael Niedermayer wrote: > On Sun, May 12, 2019 at 11:00:51PM +0200, Nicolas George wrote: >> Marton Balint (12019-05-12): >> > Yeah, you are right, what I had in mind was this: >> > >> > apitch === asetrate,aresample,atempo >> >> Exactly. And reciprocally, atempo =

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On 5/12/2019 7:42 PM, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : >> I need *technical* feedback about the API. > > I understand that. Then, if you can't provide technical feedback, please stop replying to this thread (After you provide the source Hendrik

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add NV24 and NV42 pixel formats

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Sunday, May 12, 2019 18:45 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add NV24 and NV42

Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: enable slice threading

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Friday, May 10, 2019 4:53 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: enable

Re: [FFmpeg-devel] [PATCH 4/6] lavc/libvpxenc: remove redundant condition check

On Sat, May 11, 2019 at 3:14 AM Vignesh Venkatasubramanian wrote: > > From: Jun Zhao > Date: Fri, May 10, 2019 at 9:06 AM > To: > Cc: Jun Zhao > > > From: Jun Zhao > > > > Redundant condition: '!A || B' is equivalent to '!A || (A && B)' but > > more clearly. > > > > Signed-off-by: Jun Zhao >

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Em dom, 12 de mai de 2019 às 18:11, Hendrik Leppkes escreveu: > > On Sun, May 12, 2019 at 11:05 PM Carl Eugen Hoyos wrote: > > > > But seriously: We are of course not allowed to remove copyright > > statements, no matter if we consider them relevant or not. > > > > Please provide a source for

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

On 13-05-2019 06:54 AM, myp...@gmail.com wrote: On Mon, May 13, 2019 at 4:06 AM Gyan wrote: On 10-05-2019 07:25 PM, Gyan wrote: At present, if the command args passed to drawtext contain any invalid values, ffmpeg may crash or, at best, stop drawing any text. Attached patch gets the

Re: [FFmpeg-devel] [PATCH 3/6] lavc/bink: Remove the dead code block

On Sat, May 11, 2019 at 11:04 AM Peter Ross wrote: > > On Sat, May 11, 2019 at 12:05:51AM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > Remove the dead code block > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/bink.c |2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

> On May 12, 2019, at 1:39 PM, Paul B Mahol wrote: > > On 5/12/19, Baptiste Coudurier > wrote: >> Hi Tomas >> >>> On May 12, 2019, at 6:47 AM, Tomas Härdin wrote: >>> >>> fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: +static inline int

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

May 12, 2019, 10:04 PM by ceffm...@gmail.com: > > Yes, and this is the reason why we must not remove the names > of those present (they also hold a copyright, not just those whose > names are missing). > > Please go and discuss the project and the world's attitude and policy towards

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

On May 12, 2019, at 4:14 PM, Reimar Döffinger wrote: > > On Sun, May 12, 2019 at 12:07:42PM -0700, Tim Jones wrote: >> On May 12, 2019, at 11:54 AM, Nicolas George wrote: >>> >>> Tim Jones (12019-05-12): >>> --disable-all-proprietary/--enable-all-proprietary >>> >>> As for this one, on

Re: [FFmpeg-devel] [PATCH V3] lavfi/opencl: add nlmeans_opencl filter

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Ruiling Song > Sent: Tuesday, May 7, 2019 10:45 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Song, Ruiling > Subject: [FFmpeg-devel] [PATCH V3] lavfi/opencl: add nlmeans_opencl filter > >

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : > I need *technical* feedback about the API. I understand that. Please understand that the patch cannot be committed as-is. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

On Sun, May 12, 2019 at 12:07:42PM -0700, Tim Jones wrote: > On May 12, 2019, at 11:54 AM, Nicolas George wrote: > > > > Tim Jones (12019-05-12): > > > >> --disable-all-proprietary/--enable-all-proprietary > > > > As for this one, on the other hand, there will be opposition: we do not > > want

Re: [FFmpeg-devel] [PATCH 2/6] lavc/avpacket: check NULL before using the pointer

On Sat, May 11, 2019 at 8:23 AM Michael Niedermayer wrote: > > On Fri, May 10, 2019 at 10:00:54PM +0200, Carl Eugen Hoyos wrote: > > Am Fr., 10. Mai 2019 um 18:13 Uhr schrieb Jun Zhao : > > > > > > From: Jun Zhao > > > > > > Need to check NULL before using the pointer > > > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] lavf/dashdec: fix the coding logic after open_input fail

> 在 2019年5月11日，15:23，Jun Zhao 写道： > > From: Jun Zhao > > setting return status following goto will never be executed, so > adjust the location in the code. > > Signed-off-by: Jun Zhao > --- > libavformat/dashdec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 1/2] VP4 video decoder

--- i have incorporated all suggestions from the first patch posted jan 2019. if there's nothing further to change, i will apply it a good week or so. cheers, Changelog |1 + doc/general.texi|2 + libavcodec/allcodecs.c |1 + libavcodec/avcodec.h|1 +

[FFmpeg-devel] [PATCH 2/2] avformat/riff: add VP4 fourcc

--- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 0f5cd62547..56387916f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -307,6 +307,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_INDEO5,

Re: [FFmpeg-devel] [PATCH] avcodec/hq_hqa: Check available space before reading slice offsets

On 5/12/19, Michael Niedermayer wrote: > Fixes: Timeout (43sec -> 18sec) > Fixes: > 14556/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQ_HQA_fuzzer-5673543024508928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On 12.05.2019, at 08:12, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > + > +do { > +size = 0; > +if (!get_bits1(gb)) > +break; > +v++; > +do { > +if (!get_bits1(gb)) > +

Re: [FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

On Sat, May 11, 2019 at 11:31:56AM -0700, Philip Langdale wrote: > For the sake of completeness, I'm added NV24/NV42 support to swscale, > but the specific use-case I noted when adding the pixel formats > doesn't require swscale support (because it's OpenGL interop). not sure this adds value to

[FFmpeg-devel] [PATCH] avfilter: add apitch filter

Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. Fixed silly out of phase bug for multichannel audio. --- libavfilter/Makefile | 1 + libavfilter/af_apitch.c | 776

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add NV24 and NV42 pixel formats

Am So., 12. Mai 2019 um 05:38 Uhr schrieb Fu, Linjie : > I'm working on adding support for HEVC 4:2:2/ 4:4:4, 8/10 bit, in vaapi > decoding. > And I'm aslo thinking of add some new pix_fmt for packed FourCC: > 444 8 bit : AYUV > 444 10 bit: Y410 > 422 10 bit: Y210 Do I understand correctly

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross : > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > Also you need real review. He needs to request a review which I believe he did. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On 5/12/19, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > >> Also you need real review. > > He needs to request a review which I believe he did. But full real review is still missing. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/3] swscale: Add test for isSemiPlanarYUV to pixdesc_query

On Sat, May 11, 2019 at 11:31:57AM -0700, Philip Langdale wrote: > Lauri had asked me what the semi planar formats were and that reminded > me that we could add it to pixdesc_query so we know exactly what the > list is. > > Signed-off-by: Philip Langdale > --- > libswscale/tests/pixdesc_query.c

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

Marton Balint (12019-05-12): > Why would you want to do pitch scaling and tempo scaling in a single filter? Because that is the same thing. > Pitch scaling is a combo of asetrate and aresample as far as I understand. You are mistaken: if you do that, you change the pitch and the tempo the same

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

On 5/12/19, Marton Balint wrote: > > > On Sun, 12 May 2019, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> >> This filter can dynamically change both tempo and pitch of audio. >> Also scale range is bigger, from 0.01 to 100. > > Why would you want to do pitch scaling and tempo

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Paul B Mahol (12019-05-12): > You can not merge filters by removing other filters as that will break > user scripts. I know how do avoid that, thank you very much. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> We have both setsar and setdar, > > And that is a mistake. We should have a single "set" filter that can > change all the transparent numeric properties of frames (sar, time base, > timestamp, colorspace, etc.). One of the

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> You can not merge filters by removing other filters as that will break >> user scripts. > > I know how do avoid that, thank you very much. > How would you avoid that? ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

On Sun, 12 May 2019, Nicolas George wrote: Marton Balint (12019-05-12): Why would you want to do pitch scaling and tempo scaling in a single filter? Because that is the same thing. Pitch scaling is a combo of asetrate and aresample as far as I understand. You are mistaken: if you do

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > > Patch updated again. > Made some more cleanups to the transforms, the tables and the main context. > API changed again, now the init function populates the function pointer for > transform. > I decided that having a separate function would

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

Hi Tomas > On May 12, 2019, at 6:47 AM, Tomas Härdin wrote: > > fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: >> +static inline int get_ue_golomb(GetBitContext *gb) { >> +int i, v; >> +for (i = 0; i < 32 && !get_bits1(gb); i++) >> +; >> +for (v = 1; i--;) >> +

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

On 10-05-2019 07:25 PM, Gyan wrote: At present, if the command args passed to drawtext contain any invalid values, ffmpeg may crash or, at best, stop drawing any text. Attached patch gets the filter to continue with existing parameters, if not all of the changes can be parsed or applied. This

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

On 5/12/19, Baptiste Coudurier wrote: > Hi Tomas > >> On May 12, 2019, at 6:47 AM, Tomas Härdin wrote: >> >> fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: >>> +static inline int get_ue_golomb(GetBitContext *gb) { >>> +int i, v; >>> +for (i = 0; i < 32 && !get_bits1(gb);

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On 5/12/19, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : >> >> On 5/12/19, Carl Eugen Hoyos wrote: >> > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : >> >> >> >> Patch updated again. >> >> Made some more cleanups to the transforms, the tables and the

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > > On 5/12/19, Carl Eugen Hoyos wrote: > > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > >> > >> Patch updated again. > >> Made some more cleanups to the transforms, the tables and the main > >> context. > >> API changed again, now

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On 5/12/19, Carl Eugen Hoyos wrote: > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : >> >> Patch updated again. >> Made some more cleanups to the transforms, the tables and the main >> context. >> API changed again, now the init function populates the function pointer >> for transform. >> I

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am So., 12. Mai 2019 um 22:40 Uhr schrieb Paul B Mahol : > > On 5/12/19, Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > >> > >> On 5/12/19, Carl Eugen Hoyos wrote: > >> > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > >> >> > >> >> Patch updated

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

Marton Balint (12019-05-12): > Yeah, you are right, what I had in mind was this: > > apitch === asetrate,aresample,atempo Exactly. And reciprocally, atempo = apitch+asetrate+aresample. Furthermore, since it works with the spectrum, the filter that does the hard work can probably easily output

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On Sun, May 12, 2019 at 10:38 PM Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > > > > On 5/12/19, Carl Eugen Hoyos wrote: > > > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > > >> > > >> Patch updated again. > > >> Made some more cleanups to the

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

Am So., 12. Mai 2019 um 22:59 Uhr schrieb Hendrik Leppkes : > > On Sun, May 12, 2019 at 10:38 PM Carl Eugen Hoyos wrote: > > > > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > > > > > > On 5/12/19, Carl Eugen Hoyos wrote: > > > > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > >

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On Sun, May 12, 2019 at 11:05 PM Carl Eugen Hoyos wrote: > > But seriously: We are of course not allowed to remove copyright > statements, no matter if we consider them relevant or not. > Please provide a source for such claims. - Hendrik ___

[FFmpeg-devel] [PATCH 2/2] avcodec/cinepak: Check available input against encoded buffer size

Fixes: Timeout (12sec -> 2sec) Fixes: 14606/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5738687561728000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cinepak.c | 3 +++

[FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Check for arith decoder errors in dirac_unpack_block_motion_data()

Fixes: Timeout (54sec -> 188ms) Fixes: 14585/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5649933052411904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 5

Re: [FFmpeg-devel] [PATCH 0/4] Add AVDRMFrameDescriptor.format field

On 09/05/2019 20:38, Jonas Karlman wrote: > Hello, > > When a multi-layer AVDRMFrameDescriptor is used to describe a frame the > overall > frame format is missing and applications need to deduce the frame DRM_FORMAT_* > based on sw_format or the layers format. > > This patchset adds a

Re: [FFmpeg-devel] [PATCH 1/4] hwcontext_drm: Add AVDRMFrameDescriptor.format field

On 09/05/2019 20:40, Jonas Karlman wrote: > A AVDRMFrameDescriptor for a NV12 frame may be described in > a single layer descriptor with multiple planes, > > (AVDRMFrameDescriptor) { > .nb_layers = 1, > .layers[0] = { > .format = DRM_FORMAT_NV12, > .nb_planes

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Paul B Mahol (12019-05-11): > It is currently separate filter for ease of testing. Then no problem. But I insist: once it is in shape, for the convenience of the users and ease of maintenance, it should be a single filter. Of course, if you disagree, we can discuss it here. > It can not be

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

On Sun, May 12, 2019 at 05:58:50PM +0100, Mark Thompson wrote: > On 12/05/2019 16:24, Adam Richter wrote: > > This patch separates statements of the form "assert(a && b);" into > > "assert(a);" and "assert(b);", typically involving an assertion > > function like av_assert0. > > > > This patch

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Hi, On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-11): >> It is currently separate filter for ease of testing. > > Then no problem. But I insist: once it is in shape, for the convenience > of the users and ease of maintenance, it should be a single filter. > > Of course, if you

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Paul B Mahol (12019-05-12): > That is hard problem, how would one know what implementation is best for > user scenario. Better developers who know the limits of their filters than users who do not know. > I disagree, current filter have artifacts with small scale factors. And that is what you

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> That is hard problem, how would one know what implementation is best for >> user scenario. > > Better developers who know the limits of their filters than users who do > not know. > >> I disagree, current filter have artifacts

Re: [FFmpeg-devel] [PATCH] avfilter: add asr filter

On 5/11/19, Paul B Mahol wrote: > On 5/5/19, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure| 4 + >> doc/filters.texi | 32 +++ >> libavfilter/Makefile | 1 + >> libavfilter/af_asr.c | 177 +++

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Paul B Mahol (12019-05-12): > Calling atempo filter atempo when it also modifies pitch is bad for users and > at same time not having apitch filter, user would think that they can > not alter pitch. > Sorry if you can not understand my fears. As I have pointed to you (but you made a show of

[FFmpeg-devel] Discussion of all-inclusive full stack builds

Hi Folks, I've long been a fanatic for ffmpeg and now have the bandwidth to dip my toes into the developer pool. My primary experience is in file I/O in C, C++ , and Python, and I force my team to pay close attention to smaller-is-better refactoring. With the enormous number of config

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

Tim Jones (12019-05-12): > Has anyone previously discussed or offered up a simplified set of > config macros for something like: Options to have auto-detection of external libraries enabled have been suggested in the past. > --disable-all-proprietary/--enable-all-proprietary As for this one, on

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

On May 12, 2019, at 11:51 AM, Nicolas George wrote: > > Paul B Mahol (12019-05-12): >> Calling atempo filter atempo when it also modifies pitch is bad for users and >> at same time not having apitch filter, user would think that they can >> not alter pitch. >> Sorry if you can not understand my

Re: [FFmpeg-devel] [PATCH 0/4] Add AVDRMFrameDescriptor.format field

On 2019-05-12 19:28, Mark Thompson wrote: > On 09/05/2019 20:38, Jonas Karlman wrote: >> Hello, >> >> When a multi-layer AVDRMFrameDescriptor is used to describe a frame the >> overall >> frame format is missing and applications need to deduce the frame >> DRM_FORMAT_* >> based on sw_format or

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Tim Jones (12019-05-12): > Coming from the audio world, tempo, and pitch are different things. Tempo and pitch are not the same thing. But changing them is the same thing. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

On Sun, 12 May 2019, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. Why would you want to do pitch scaling and tempo scaling in a single filter? Pitch scaling is a combo

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

On 5/12/19, Nicolas George wrote: > Paul B Mahol (12019-05-12): >> Calling atempo filter atempo when it also modifies pitch is bad for users >> and >> at same time not having apitch filter, user would think that they can >> not alter pitch. >> Sorry if you can not understand my fears. > > As I

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

On May 12, 2019, at 11:54 AM, Nicolas George wrote: > > Tim Jones (12019-05-12): > >> --disable-all-proprietary/--enable-all-proprietary > > As for this one, on the other hand, there will be opposition: we do not > want encourage users to use proprietary software. In fact, there is > currently

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

Paul B Mahol (12019-05-12): > We have both setsar and setdar, And that is a mistake. We should have a single "set" filter that can change all the transparent numeric properties of frames (sar, time base, timestamp, colorspace, etc.). One of the benefits: it can notify users who set inconsistent

[FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

This patch separates statements of the form "assert(a && b);" into "assert(a);" and "assert(b);", typically involving an assertion function like av_assert0. This patch covers all of ffmpeg, except for the libavformat, which I have already submitted separately. I have not tested this patch other

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

On 12/05/2019 16:24, Adam Richter wrote: > This patch separates statements of the form "assert(a && b);" into > "assert(a);" and "assert(b);", typically involving an assertion > function like av_assert0. > > This patch covers all of ffmpeg, except for the libavformat, which I > have already

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

On 12/05/2019 14:47, Tomas Härdin wrote: > fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: >> ... >> +skip_bits(, 2); // reserved_zero_2bits >> +sps->level_idc = get_bits(, 8); >> +sps->id = get_ue_golomb(); >> + >> +if (sps->profile_idc == 100 || sps->profile_idc ==

Re: [FFmpeg-devel] [PATCH] avcodec/hq_hqa: Check available space before reading slice offsets

On Sun, May 12, 2019 at 09:45:59AM +0200, Paul B Mahol wrote: > On 5/12/19, Michael Niedermayer wrote: > > Fixes: Timeout (43sec -> 18sec) > > Fixes: > > 14556/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQ_HQA_fuzzer-5673543024508928 > > > > Found-by: continuous fuzzing process > >

[FFmpeg-devel] [PATCH] libswcale: Fix possible string overflow in test

This is a possible fix for a string overflow in some sscanf calls in libswcale/tests/swscale.c, in the function fileTest(), found by cppcheck. Please see the attachment for more discussion of this. Thanks in advance for considering this patch. Adam From 8b5f994bcd2576588149f228695823b5cf8d3dc8

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: Check offset_for_non_ref_pic and offset_for_top_to_bottom_field

On Sat, May 11, 2019 at 03:35:26PM -0300, James Almer wrote: > On 5/11/2019 2:59 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -2147483648 + -1 cannot be represented in > > type 'int' > > Fixes: > >

[FFmpeg-devel] [PATCH] libavformat: Separate assertions of the form "av_assertN(a && b)" to "av_assertN(a); av_assertN(b)" for more precise diagnostics.

This is the first of what I expect to be several patches to convert assertions of the form "assert(a && b)" to "assert(a); assert(b)". Here are some reasons why I think this would be an improvement. This lengthy argument is not included in the patch attachment. 1. Assertion failures are often

Re: [FFmpeg-devel] [PATCH] avcodec/wmv2dec: Check input bits vs. coded MBs

On Wed, May 01, 2019 at 01:45:21AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (94sec ->8sec) > Fixes: > 14387/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5723546887651328 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCHv2] lavfi: add gblur_opencl filter

On 5/8/19, Song, Ruiling wrote: > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Dylan Fernando >> Sent: Tuesday, May 7, 2019 8:27 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCHv2] lavfi: add gblur_opencl

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On 5/12/2019 3:12 AM, Peter Ross wrote: > --- > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

fre 2019-05-10 klockan 08:50 -0700 skrev Baptiste Coudurier: > +static inline int get_ue_golomb(GetBitContext *gb) { > +int i, v; > +for (i = 0; i < 32 && !get_bits1(gb); i++) > +; > +for (v = 1; i--;) > +v = (v << 1) | get_bits1(gb); Isn't there already a function to

Re: [FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Sun, 12 May 2019 12:54:24 +0200 Michael Niedermayer wrote: > > all these + 1 in the code above look a bit suspect. Can you explain > what they do assuming they are intended Good catch. I should have removed them when I removed the divide by