Re: [FFmpeg-devel] [PATCH] fix typo in dashenc

2019-06-04 Thread Alfred E. Heggestad
On 04/06/2019 14:07, Gyan wrote: On 04-06-2019 04:28 PM, Alfred E. Heggestad wrote: Hi Karthick, thanks for your feedback. here is an updated patch as you suggested. From 7879e39c25ede24693f166eb6a63094757d9fb1e Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date:

Re: [FFmpeg-devel] [PATCH] fix typo in dashenc

2019-06-04 Thread Alfred E. Heggestad
Hi Karthick, thanks for your feedback. here is an updated patch as you suggested. From 7879e39c25ede24693f166eb6a63094757d9fb1e Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Tue, 4 Jun 2019 09:39:59 +0200 Subject: [PATCH] dashenc: fix typo in seg_duration descri

[FFmpeg-devel] [PATCH] fix typo in dashenc

2019-06-04 Thread Alfred E. Heggestad
From 885abee797458936e39b4a252e96836d3d6e3213 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Tue, 4 Jun 2019 09:39:59 +0200 Subject: [PATCH] dashenc: fix typo in seg_duration description --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-18 Thread Alfred E. Heggestad
On 18/06/2019 04:02, Steven Liu wrote: Alfred E. Heggestad 于2019年6月17日周一 下午4:02写道: From 923da82598bddd1ed05750427dbc71e607d296a2 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Mon, 17 Jun 2019 09:59:04 +0200 Subject: [PATCH] dash: change default MP4 extensi

Re: [FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

2019-06-18 Thread Alfred E. Heggestad
On 17/06/2019 10:23, Gyan wrote: On 17-06-2019 01:37 PM, Alfred E. Heggestad wrote: From c69b63a7af5531257753754e64ac33b7ef530e75 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Mon, 17 Jun 2019 10:04:08 +0200 Subject: [PATCH] movenc: calculate track_duration with

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-25 Thread Alfred E. Heggestad
On 25/06/2019 11:43, Jeyapal, Karthick wrote: On 6/24/19 4:23 PM, Alfred E. Heggestad wrote: Hi Karthick, here is the rebased patch as an attachment. please review and apply if it looks okay. Thanks. I have applied it. Thanks for applying it :) /alfred

Re: [FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

2019-06-19 Thread Alfred E. Heggestad
On 19/06/2019 15:36, Derek Buitenhuis wrote: On 19/06/2019 06:43, Gyan wrote: setting track_duration is inconsistent; some times it includes duration and some times not. It may be best to check the commits for these assignments to see if the inconsistency is deliberate. The track duration is

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-20 Thread Alfred E. Heggestad
On 20/06/2019 05:19, Jeyapal, Karthick wrote: On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: On 18/06/2019 04:02, Steven Liu wrote: Alfred E. Heggestad 于2019年6月17日周一 下午4:02写道: From

Re: [FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

2019-06-20 Thread Alfred E. Heggestad
On 19/06/2019 15:36, Derek Buitenhuis wrote: On 19/06/2019 06:43, Gyan wrote: setting track_duration is inconsistent; some times it includes duration and some times not. It may be best to check the commits for these assignments to see if the inconsistency is deliberate. The track duration is

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-19 Thread Alfred E. Heggestad
On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: On 18/06/2019 04:02, Steven Liu wrote: Alfred E. Heggestad 于2019年6月17日周一 下午4:02写道: From 923da82598bddd1ed05750427dbc71e607d296a2 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad"

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-24 Thread Alfred E. Heggestad
On 24/06/2019 11:24, Jeyapal, Karthick wrote: On 6/20/19 3:00 PM, Alfred E. Heggestad wrote: On 20/06/2019 05:19, Jeyapal, Karthick wrote: On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: On 18

[FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-17 Thread Alfred E. Heggestad
From 923da82598bddd1ed05750427dbc71e607d296a2 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Mon, 17 Jun 2019 09:59:04 +0200 Subject: [PATCH] dash: change default MP4 extension to .m4s this was changed in commit 281a21ed50849e3c8c0d03005230e9fd07c24370 --- libavformat/das

[FFmpeg-devel] [PATCH] movenc: calculate track_duration without packet duration

2019-06-17 Thread Alfred E. Heggestad
From c69b63a7af5531257753754e64ac33b7ef530e75 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Mon, 17 Jun 2019 10:04:08 +0200 Subject: [PATCH] movenc: calculate track_duration without packet duration --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] movenc track_duration

2019-07-03 Thread Alfred E. Heggestad
Hi, here is my attempt to fix this bug: https://trac.ffmpeg.org/ticket/7966 I am wondering if track_duration should include the last duration or not. I tried to include duration in the calculation of track_duration here: diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

Re: [FFmpeg-devel] [PATCH] movenc: fix warning if CONFIG_AC3_PARSER not defined

2019-07-04 Thread Alfred E. Heggestad
On 03/07/2019 21:28, Michael Niedermayer wrote: On Tue, Jul 02, 2019 at 02:19:37PM +0200, Alfred E. Heggestad wrote: this patch fixes a compiler warning if CONFIG_AC3_PARSER is not defined. The label 'end' is removed and all the code use the label 'err' instead. What compiler warning

[FFmpeg-devel] [PATCH] movenc: fix warning if CONFIG_AC3_PARSER not defined

2019-07-02 Thread Alfred E. Heggestad
this patch fixes a compiler warning if CONFIG_AC3_PARSER is not defined. The label 'end' is removed and all the code use the label 'err' instead. --- libavformat/movenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH] doc: fix typo in muxers documentation

2019-10-30 Thread Alfred E. Heggestad
Signed-off-by: Alfred E. Heggestad --- doc/muxers.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 4c88b5daec..09ded7d48a 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -2084,7 +2084,7 @@ but supports several other

Re: [FFmpeg-devel] [PATCH] doc: fix typo in muxers documentation

2019-10-30 Thread Alfred E. Heggestad
On 30/10/2019 10:55, Paul B Mahol wrote: Can not be applied, patch is corrupted. sorry about that, patch is attached. /alfred From 417b3a38d25fbc3aca1f8e7d0d65de7efea55777 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Wed, 30 Oct 2019 10:48:44 +0100 Subject: [PATCH

[FFmpeg-devel] [PATCH] sdl2: map AV_PIX_FMT_NONE to SDL_PIXELFORMAT_UNKNOWN

2019-10-30 Thread Alfred E. Heggestad
--- From 6331f77ca00acdaaee0db6b0d2d04fff9f1c70c9 Mon Sep 17 00:00:00 2001 From: "Alfred E. Heggestad" Date: Wed, 30 Oct 2019 12:30:49 +0100 Subject: [PATCH] sdl2: map AV_PIX_FMT_NONE to SDL_PIXELFORMAT_UNKNOWN This does not change the programs behaviour. The purpose of this patch

Re: [FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Alfred E. Heggestad
On 29/10/2019 10:34, Steven Liu wrote: 在 2019年10月29日,17:25,Alfred E. Heggestad 写道: using a gop_size of 10 in the example code is very misleading. in practice this means around 2 keyframes per second. a normal video encoder should not send keyframes so frequent, a better interval is 10

[FFmpeg-devel] [PATCH] examples: set GOP size to 10 seconds

2019-10-29 Thread Alfred E. Heggestad
using a gop_size of 10 in the example code is very misleading. in practice this means around 2 keyframes per second. a normal video encoder should not send keyframes so frequent, a better interval is 10 seconds. Signed-off-by: Alfred E. Heggestad --- doc/examples/encode_video.c | 4 ++-- 1

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
On 05/03/2020 11:40, Moritz Barsnick wrote: On Thu, Mar 05, 2020 at 11:01:19 +0100, Alfred E. Heggestad wrote: -avio_printf(out, "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration / AV_TIME_BASE); +avio_printf(out, "

[FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
use 3 decimals for the following items: - minBufferTime - minimumUpdatePeriod - timeShiftBufferDepth - suggestedPresentationDelay This improves buffering with shaka player Signed-off-by: Alfred E. Heggestad --- libavformat/dashenc.c | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-05 Thread Alfred E. Heggestad
On 05/03/2020 15:37, Carl Eugen Hoyos wrote: Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad : -int64_t update_period = c->last_duration / AV_TIME_BASE; +double update_period = (double)c->last_duration / AV_TIME_BASE; Can't you instead do int64 update_

[FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-30 Thread Alfred E. Heggestad
this fix checks that max_pts > start_pts. the fix has been tested and works. please review and suggest better fixes. Signed-off-by: Alfred E. Heggestad --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c inde

Re: [FFmpeg-devel] [PATCH] dashenc: check pts to prevent division by zero error

2020-01-31 Thread Alfred E. Heggestad
On 31/01/2020 14:17, James Almer wrote: On 1/31/2020 10:08 AM, Jeyapal, Karthick wrote: On 1/30/20 3:28 PM, Alfred E. Heggestad wrote: this usecase will cause a division by zero trap: 1. dashenc has received one frame 2. os->max_pts and os->start_pts have same value 3. delta b