[FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

2016-01-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 92 +++ 1 file changed, 53 insertions(+), 39 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 96f0ccf..788e96a 100644 --- a/libavcodec/ccaption

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

2016-01-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 98 ++- 1 file changed, 45 insertions(+), 53 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 4e478e0..96f0ccf 100644 --- a/libavcodec/ccaption

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: remove unnecessary include

2016-01-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f67caa..4e478e0 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -21,7 +21,6 @@ #i

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-01 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> CC data is fed to in small chunks (usually 60 bytes at a time) and is parsed fully by the eia608 decoder. There is no reason to copy it into a secondary buffer first. --- libavcodec/ccaption_dec.c | 22 +- 1 file changed, 1 insertion(

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

2016-01-05 Thread Aman Gupta
On Tue, Jan 5, 2016 at 6:24 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Tue, Jan 05, 2016 at 09:34:35PM +0100, Clément Bœsch wrote: > > On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > > > From: Aman Gupta <a...@tmm1.net> >

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-05 Thread Aman Gupta
On Tue, Jan 5, 2016 at 12:25 PM, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: > [...] > > This indeed LGTM, but I'm not the maintainer. > > > > OK I finally understood why it's done that way: validate_cc_data_pair() > alters the pkt data, but

[FFmpeg-devel] [PATCH 01/10] libavcodec/ccaption_dec: fix whitespace

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 34a7208..12e8f1d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -159,7

[FFmpeg-devel] [PATCH 10/10] libavcodec/ccaption_dec: extract ass time base into constant

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 56b2b52..6dff761 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 07/10] libavcodec/ass.c: increase hardcoded timestamp for infinite duration

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> before this change, ffmpeg would sometimes generate invalid ASS events when dealing with mpegts streams that had a large start_time: Dialogue: 0,20:57:07.37,9:59:59.99,Default,,0,0,0,,(upbeat music playing) --- libavcodec/ass.c | 2 +- 1 file chan

[FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> new option defaults to true, to preserve existing behavior. by flipping the option to false, subtitle events are emitted as soon as they are received and have an infinite duration. this new mode is useful for realtime decoding of closed captions so th

[FFmpeg-devel] [PATCH 08/10] libavcodec/ccaption_dec.c: fix more whitespace

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 423c576..3de16bf 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption

[FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f17e77..5d4c568 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -399,9

[FFmpeg-devel] [PATCH 05/10] libavcodec/ccaption_dec: combine ROLLUP modes as they are identical

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 5d4c568..424b434 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption

[FFmpeg-devel] [PATCH 02/10] libavcodec/ccaption_dec: fix timestamps on generated subtitles by buffering after EOC/newline commands

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> before: Dialogue: 0,0:00:00.03,0:00:00.67,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER Dialogue: 0,0:00:00.67,0:00:02.30,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER\NTHE NEWS WE MISSED OVER THE Dialogue: 0,0:00:02.30,0:00:03.57,Default,

[FFmpeg-devel] [PATCH 06/10] libavcodec/ccaption_dec: flush screen buffer on seek

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 424b434..423c576 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -196,6 +

[FFmpeg-devel] [PATCH 09/10] libavcodec/ccaption_dec: default to simpler POPON mode

2016-01-05 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> the default value does not really have any effect in normal operation, as the mode command is repeated before every new caption. after seeking, it makes more sense to default to POPON since that is the more common mode. --- libavcodec/ccaption_dec.c | 5 ++

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-06 Thread Aman Gupta
n 6, 2016 at 2:37 AM, wm4 <nfx...@googlemail.com> wrote: > On Tue, 5 Jan 2016 23:41:35 -0800 > Aman Gupta <ffm...@tmm1.net> wrote: > > > From: Aman Gupta <a...@tmm1.net> > > > > new option defaults to true, to preserve existing behavior. by flipp

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-07 Thread Aman Gupta
Thus, it makes sense to reap the screen *after* flipping the active screen, not *before*. The previous behavior was simply wrong, but masked by other bugs also fixed in this patchset. Aman On Tue, Jan 5, 2016 at 11:41 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-08 Thread Aman Gupta
On Fri, Jan 8, 2016 at 2:50 AM, Anshul Maheshwari <anshul.ffm...@gmail.com> wrote: > > > On Thu, Jan 7, 2016 at 6:14 AM, Aman Gupta <a...@tmm1.net> wrote: > >> Probably should have written a longer commit message here. The EOC >> command stands for "end of

[FFmpeg-devel] [PATCH 1/2] lavc/ccaption_dec: flush context on seek

2016-01-09 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index fc6431b..8bef771 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement real_time option

2016-01-09 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EO

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

2016-01-06 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6dff761..706da16 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: in realtime mode, emit new ASS events every 200ms

2016-01-06 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 706da16..737c3f6 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: emit blank ASS events only in realtime mode

2016-01-06 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 737c3f6..8e3008d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 + 1 file changed, 25 insertions(+), 4 del

[FFmpeg-devel] [PATCH v2 5/9] lavc/ccaption_dec: implement tab offset commands

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8c913fe..50625df 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -558,6 +558,11 @@

[FFmpeg-devel] [PATCH v2 3/9] fate: add test for realtime ccaption decoder

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-cc-realtime | 42 ++ 2 files changed, 45 insertions(+) create mode 100644 tests/ref/fate/sub-cc-realtime diff --git a/tests/fate/subtitles.mak b/test

[FFmpeg-devel] [PATCH v2 9/9] fate: update sub-cc tests for subtitle positioning

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4

[FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index ca497e5..a9dfc94 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH v2 4/9] lavc/ccaption_dec: default rollup to row 10

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_m

[FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This is the most commonly used character from the special north-american character set. All the non-standard charsets are "optional" according to the spec, and we currently implement none of them. This commit adds support for "♪" w

[FFmpeg-devel] [PATCH v2 2/9] lavc/ccaption_dec: implement real_time option

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EO

[FFmpeg-devel] [PATCH v2 6/9] lavc/ccaption_dec: clear all unused rows during rollup

2016-01-12 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Sometimes rollup captions can move around the screen. This fixes "ghost" captions from below the current rollup area from continuing to be captured when a rollup moves higher up on the screen. --- libavcodec/ccaption_dec.c | 8 +--- 1

Re: [FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

2016-01-12 Thread Aman Gupta
On Tue, Jan 12, 2016 at 5:42 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > --- > libavcodec/ccaption_dec.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libavcodec/ccaption_dec.c b/libavcod

[FFmpeg-devel] [PATCH 1/3] avformat/mpegts: enhance logging in trace mode

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavformat/mpegts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 4d1bc6d..6acb797 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -446,7 +446,7 @@

[FFmpeg-devel] [PATCH 2/3] avformat/utils: in debug mode, print number of streams found before avformat_find_stream_info()

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavformat/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 25c9a1b..494379a 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3297,8 +3297,8

[FFmpeg-devel] [PATCH] avcodec/utils: ensure conversion from ass to ass_with_timings works with unknown durations

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> the eia_608 decoder with real_time=1 emits subtitles with an unknown duration, which were getting converted into ass incorrectly before this patch. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/uti

[FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> this removes the need to probe to discover mpeg2 and aac streams inside mpegts containers, thus speeding up initial playback. --- libavformat/mpegts.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6

[FFmpeg-devel] [PATCH 1/5] avcodec/ccaption_dec: change write_char() to void as return value is unused

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 3b15149..a6d879e 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 4/5] fate: update sub-cc tests for closed caption positioning

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4

[FFmpeg-devel] [PATCH 3/5] avcodec/ccaption_dec: implement positioning for closed captions

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 ++--- 1 file changed, 26 insertions(+), 3 del

[FFmpeg-devel] [PATCH 2/5] avcodec/ccaption_dec: implement tab offset commands

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index a6d879e..0b4a061 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -713,6 +713,11 @@

[FFmpeg-devel] [PATCH 5/5] avcodec/ccaption_dec: default rollup to row 10

2016-06-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_m

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

2016-06-22 Thread Aman Gupta
This patch should fix the assertion failure you see: https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4 Aman On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty <aha...@gmail.com> wrote: > > > On Jun 16, 2016, at 11:16 AM, Aman Gupta <ffm.

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

2016-06-16 Thread Aman Gupta
The patchset that was merged into libav is now available in ffmpeg as well: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c You can compile ffmpeg from the master branch with --enable-omx --enable-omx-rpi Aman On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty

Re: [FFmpeg-devel] DVB Teletext to HLS Wbvtt Subtitles

2016-01-18 Thread Aman Gupta
ffmpeg has a webvtt encoder and decoder already. You can use this command to convert mpeg2 closed captions into webvtt: ffmpeg -f lavfi -i 'movie=input.mpg[out0+subcc]' -map s out.vtt Aman On Mon, Jan 18, 2016 at 7:25 AM, Sébastien Cramatte wrote: > Hi, > > We are

[FFmpeg-devel] [PATCH 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-02-10 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

[FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement special and extended character sets

2016-02-10 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 151 +- 1 file changed, 148 insertions(+), 3 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 5fb2ec6..c22f939 100644 --- a/libavcodec/ccaption

[FFmpeg-devel] [PATCH v2 2/2] lavc/ccaption_dec: implement special and extended character sets

2016-02-13 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> character sets implemented as defined in https://en.wikipedia.org/wiki/EIA-608#Characters --- libavcodec/ccaption_dec.c | 152 +- 1 file changed, 149 insertions(+), 3 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH v2 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-02-13 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

[FFmpeg-devel] [PATCH v3 2/2] lavc/ccaption_dec: implement special and extended character sets

2016-02-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> character sets implemented as defined in https://en.wikipedia.org/wiki/EIA-608#Characters --- libavcodec/ccaption_dec.c | 152 +- 1 file changed, 149 insertions(+), 3 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-02-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

2016-05-05 Thread Aman Gupta
aha...@gmail.com> wrote: > Curious, > > Do these patches work with ffmpeg running on RPi? > > Thanks, > Amancio > > > On Apr 19, 2016, at 12:00 PM, Aman Gupta <ffm...@tmm1.net> wrote: > > > > On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson <s...@jkqxz.n

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-04-19 Thread Aman Gupta
sample it appears that every command is repeated not twice (as is common in many streams for special character sets and other command, see http://hackipedia.org/ATSC/EIA-608%20samples/EIA-608%20character%20set%20test/README.TXT), but three times. Aman On Mon, Apr 18, 2016 at 1:01 PM, Aman Gupta &l

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

2016-04-18 Thread Aman Gupta
Please send me the sample and I will try to fix the issue. Aman On Mon, Apr 18, 2016 at 1:22 PM Thierry Foucu <tfo...@gmail.com> wrote: > Hi all > > On Sun, Feb 14, 2016 at 6:11 PM, Aman Gupta <ffm...@tmm1.net> wrote: > >> From: Aman Gupta <a...@tmm1.net> &g

Re: [FFmpeg-devel] Change bitrate on-the-fly

2016-08-01 Thread Aman Gupta
I would find your patch useful and am looking forward to reviewing it. Using a socket isn't a bad way to do it IMHO- it's portable and allows easy integration from any language. Another option would be to extend the existing ffmpeg interactive mode to handle your new command. Currently ffmpeg

[FFmpeg-devel] [PATCH] avcodec/utils: only warn when passed invalid lowres value

2016-08-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This makes it easier to use the lowres option when dealing with input files in different codecs. If the codec doesn't support lowres=1 for instance, it will throw a warning and use lowres=0 instead of erroring out completely. --- libavcodec/utils.c | 5 ++

[FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

2017-02-01 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 152 +++ libav

[FFmpeg-devel] [PATCH v2] avfilter/scale: refactor common code for scaling height/width expressions

2017-02-01 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 152 +++ libav

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

2017-02-01 Thread Aman Gupta
On Tue, Jan 31, 2017 at 12:29 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Adds a `-hls_flags +temp_file` which will write segment data to > filename.tmp, and then rename to filename when the segment is complete > and before the file is

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

2017-02-01 Thread Aman Gupta
On Wed, Feb 1, 2017 at 1:23 AM, Steven Liu <lingjiujia...@gmail.com> wrote: > > > 2017-02-01 4:29 GMT+08:00 Aman Gupta <ffm...@tmm1.net>: > >> From: Aman Gupta <a...@tmm1.net> >> >> Adds a `-hls_flags +temp_file` which will write segment data to &

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-01 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to one used in Plex's ffmpeg fork, and allows a transcoding webserver to ensure inco

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

2017-02-02 Thread Aman Gupta
On Thu, Feb 2, 2017 at 9:29 AM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Program terminated with signal SIGSEGV, Segmentation fault. > opts=opts@entry=0x0, flags=flags@entry=0) at libavutil/hwcontext.c:494 > Looks like my editor

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

2017-02-02 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00aff8a4 in vaTerminate () #1 0x00ae50ce in vaapi_device_free (ctx=) at libavutil/hwcontext_vaapi.c:882 #2 0x00ae1f9e in hwdevice_ctx_free (opaque=,

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

2017-02-02 Thread Aman Gupta
On Wed, Feb 1, 2017 at 6:03 AM, Bodecs Bela <bode...@vivanet.hu> wrote: > > > 2017.01.31. 21:29 keltezéssel, Aman Gupta írta: > >> From: Aman Gupta <a...@tmm1.net> >> >> Adds a `-hls_flags +temp_file` which will write segment data to >> filename.t

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

2017-02-03 Thread Aman Gupta
On Fri, Feb 3, 2017 at 12:19 PM, Mark Thompson <s...@jkqxz.net> wrote: > On 03/02/17 05:45, wm4 wrote: > > On Thu, 2 Feb 2017 09:29:13 -0800 > > Aman Gupta <ffm...@tmm1.net> wrote: > > > >> From: Aman Gupta <a...@tmm1.net> > >> > &

[FFmpeg-devel] [PATCH] avfilter/scale: refactor common code for scaling height/width expressions

2017-01-31 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 143 +++ libav

[FFmpeg-devel] aac_latm: SSR is not implemented

2017-01-31 Thread Aman Gupta
I have a mpegts file with a HE-AAC audio track that cannot be decoded by ffmpeg. I have uploaded a sample at the link below, as requested by the decoder. Happy to help with a patch to fix this issue, if someone can point me in the right direction. FWIW, VLC is able to decode the audio without

[FFmpeg-devel] [PATCH] avfilter/scale_vaapi: add support for basic height/width expressions

2017-01-31 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Copied directly from vf_scale.c. Implements the same expression logic, however not all the variables were copied over. This patch was sufficient for my particular use-case `scale_vaapi=-2:min(ih\,720)`, but perhaps it makes sense to add s

[FFmpeg-devel] h264 bitstream corruption in videotoolbox encoder with a53cc=1

2017-02-06 Thread Aman Gupta
Last October, kernrj and I commited a series of patches to add a53cc support to the videotoolbox encoder. In using that feature over the past few months, I've discovered that the generated streams can sometimes contain random/intermittent errors. This only appears to occur on some Macs and not

Re: [FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

2017-02-04 Thread Aman Gupta
On Fri, Feb 3, 2017 at 3:04 PM, Michael Niedermayer <michae...@gmx.at> wrote: > On Wed, Feb 01, 2017 at 04:30:18PM -0800, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > Implements support for height/width expressions in vf_scale_vaapi, > >

[FFmpeg-devel] [PATCH] avfilter/scale: use int64_t for height/width calculation to address overflow

2017-02-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavfilter/scale.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/scale.c b/libavfilter/scale.c index 50cd442..9725f1f 100644 --- a/libavfilter/scale.c +++ b/libavfilter/scale.c @@ -68,7 +68,7

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-04 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to one used in Plex's ffmpeg fork, and allows a transcoding webserver to ensure inco

[FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

2017-02-02 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Program terminated with signal SIGSEGV, Segmentation fault. opts=opts@entry=0x0, flags=flags@entry=0) at libavutil/hwcontext.c:494 --- libavutil/hwcontext_vaapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

2017-01-31 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete and before the file is added to the m3u8 playlist. This patch is similar in spirit to one used in Plex's ffmpeg fork, and

Re: [FFmpeg-devel] [PATCH] avfilter/scale_vaapi: add support for basic height/width expressions

2017-01-31 Thread Aman Gupta
On Tue, Jan 31, 2017 at 12:26 PM, Mark Thompson <s...@jkqxz.net> wrote: > On 31/01/17 19:14, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > Copied directly from vf_scale.c. > > > > Implements the same expression logic, how

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_flags temp_file bug

2017-02-21 Thread Aman Gupta
On Tue, Feb 21, 2017 at 7:13 AM, Steven Liu wrote: > refer to ticket id: #6170 > > rename file from temp to origin name after complete current segment > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 40

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: fix use-after-free of AVFrame buffer when VT decoder fails

2017-02-21 Thread Aman Gupta
On Mon, Feb 13, 2017 at 6:04 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > The videotoolbox hwaccel returns a dummy frame with a 1-byte buffer from > alloc_frame(). In end_frame(), this buffer is replaced with the ac

[FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode API is not invoked until end_frame(), so alloc_frame() returns a dummy frame with a 1-byte buffer. When end_frame() is eventually called, the dummy buffer is replaced with the actual d

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-02-21 Thread Aman Gupta
On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta <ffm...@tmm1.net> wrote: > >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c >> index 41c0964392..a0ae632fed 100644 &g

[FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: fix use-after-free of AVFrame buffer when VT decoder fails

2017-02-13 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> The videotoolbox hwaccel returns a dummy frame with a 1-byte buffer from alloc_frame(). In end_frame(), this buffer is replaced with the actual decoded data from VTDecompressionSessionDecodeFrame(). This is hacky, but works well enough, as long as the VT d

[FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: handle streams with multiple/changing PPS

2017-02-14 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> The videotoolbox hwaccel only receives SLICE and IDR_SLICE NALUs. This works fine most of the time, but some streams fail to decode because changes in PPS are not propagated to the VT decoder. The failures in this case are incredibly annoying, as VTDecod

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: handle streams with multiple/changing PPS

2017-02-14 Thread Aman Gupta
On Tue, Feb 14, 2017 at 5:14 PM Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > The videotoolbox hwaccel only receives SLICE and IDR_SLICE NALUs. This > works fine most of the time, but some streams fail to decode because > changes in PPS a

[FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

2017-02-16 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> This fixes playback of h264 streams with SPS changes. One such sample is available at http://tmm1.s3.amazonaws.com/videotoolbox/spschange.ts. It switches mid-stream from level 4.0 to level 3.2. Previously, playing this sample with the VT hwaccel on iOS

[FFmpeg-devel] [PATCH 2/3] avcodec/videotoolbox: cosmetic change to simplify code with early return

2017-02-16 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/videotoolbox.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 1288aa5..9be7bee 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoo

[FFmpeg-devel] [PATCH 3/3] avcodec/videotoolbox: restart decompression session on bad data errors

2017-02-16 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> On some platforms (observed on macOS Sierra with 12" macbook), the VT decoder will start returning errors when encountering an SPS change in the h264 bitstream. With this patch, the kVTVideoDecoderBadDataErr response from the decode

Re: [FFmpeg-devel] aac_latm: SSR is not implemented

2017-02-16 Thread Aman Gupta
On Wed, Feb 1, 2017 at 9:12 AM Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-02-01 5:06 GMT+01:00 Aman Gupta <ffm...@tmm1.net>: > > I have a mpegts file with a HE-AAC audio track that cannot be decoded by > > ffmpeg. I have uploaded a sample at t

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-08 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- libavcodec/videotoolboxenc.c | 76 ++-- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 4345ca3..859dde9 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

2016-09-08 Thread Aman Gupta
On Thu, Sep 8, 2016 at 2:55 AM, Steven Liu <lingjiujia...@gmail.com> wrote: > 2016-09-08 17:46 GMT+08:00 Michael Niedermayer <mich...@niedermayer.cc>: > > > On Thu, Sep 08, 2016 at 10:47:42AM +0900, Aman Gupta wrote: > > > From: Aman Gupta <a...@tmm1.net>

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-08 Thread Aman Gupta
On Thursday, September 8, 2016, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-08 10:19 GMT+02:00 Aman Gupta <ffm...@tmm1.net <javascript:;>>: > > > +{ "a53cc", "Use A53 Closed Captions (if available)", > OFFSET(a53_c

Re: [FFmpeg-devel] HLS Segmenter and the "hls_time" option

2016-08-30 Thread Aman Gupta
On Fri, Aug 26, 2016 at 2:06 AM, Steven Liu wrote: > 2016-08-26 16:58 GMT+08:00 Ibrahim Tachijian : > > > Thanks this actually does what I expected it to do. > > For me this option will help a lot, and we would really be interested in > > this

[FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

2016-09-07 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- doc/muxers.texi | 4 libavformat/hlsenc.c | 13 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index fd7ee50..e88dbf8 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@

[FFmpeg-devel] [PATCH] lavf/hlsenc: add -hls_start_time to emit EXT-X-START:TIME-OFFSET

2016-09-10 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 5 + 2 files changed, 8 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index ccf8ea1..e179c5a 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -533,6 +533,9 @@ Emit @code{

Re: [FFmpeg-devel] [PATCH 1/2] avformat/segment: give a warning message for remove initial_offset option

2016-09-08 Thread Aman Gupta
I tried to switch from -initial_offset to -output_ts_offset, but it does not work as expected. In Safari, the generated HLS stream stalls out and stops playing after the first segment. Aman On Thu, Sep 8, 2016 at 5:54 PM, Michael Niedermayer wrote: > On Fri, Sep 09,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/segment: give a warning message for remove initial_offset option

2016-09-08 Thread Aman Gupta
11, out10.ts #EXTINF:0.200211, out11.ts #EXTINF:0.200211, out12.ts The TARGETDURATION as well as the duration of the segments themselves is incorrect. Aman On Thu, Sep 8, 2016 at 6:48 PM, Aman Gupta <ffm...@tmm1.net> wrote: > I tried to switch from -initial_offset to -output_ts_offset, but i

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-10 Thread Aman Gupta
On Sunday, September 11, 2016, Richard Kern <ker...@gmail.com> wrote: > > > On Sep 8, 2016, at 4:19 AM, Aman Gupta <ffm...@tmm1.net <javascript:;>> > wrote: > > > > From: Aman Gupta <a...@tmm1.net <javascript:;>

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-08 Thread Aman Gupta
On Thu, Sep 8, 2016 at 9:18 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-08 15:48 GMT+02:00 Aman Gupta <themastermi...@gmail.com>: > > On Thursday, September 8, 2016, Carl Eugen Hoyos <ceffm...@gmail.com> > wrote: > > > >> 2016-09-0

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix the duration error of use output_ts_offset

2016-09-09 Thread Aman Gupta
8:00 Steven Liu <lingjiujia...@gmail.com>: >> >>> >>> >>> 2016-09-09 16:10 GMT+08:00 Steven Liu <lingjiujia...@gmail.com>: >>> >>>> >>>> >>>> 2016-09-09 15:33 GMT+08:00 Steven Liu <lingjiujia...@g

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-09-19 Thread Aman Gupta
On Monday, September 19, 2016, Richard Kern <ker...@gmail.com> wrote: > > On Sep 10, 2016, at 10:33 PM, Aman Gupta <ffm...@tmm1.net > <javascript:_e(%7B%7D,'cvml','ffm...@tmm1.net');>> wrote: > > > > On Sunday, September 11, 2016, Richard Kern <ker...@gma

[FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-19 Thread Aman Gupta
From: Aman Gupta <a...@tmm1.net> ff_videotoolbox_avcc_extradata_create() was never being called if avctx->extradata_size==0, even though the function does not need or use the avctx->extradata. This manifested itself only on h264 streams in specific containers, and only on iOS. I gue

  1   2   3   4   5   6   >