From: Andriy Gelman
---
libavcodec/avpacket.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c
index 8f0603df78..6ae092ed31 100644
--- a/libavcodec/avpacket.c
+++ b/libavcodec/avpacket.c
@@ -44,6 +44,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
pkt
From: Andriy Gelman
This commit replaces packet assignment operator with av_packet_move_ref when
there
is a packet ownership transfer.
---
Aims to address a TODO in libavformat/utils.c about using av_packet_mov_ref
instead of assignment operator.
libavformat/utils.c | 28
From: Andriy Gelman
This commit replaces packet assignment operator with av_packet_move_ref
when there is a packet ownership transfer.
---
Michael, the update patch now has correct behavior for ticket 4221.
libavformat/utils.c | 30 --
1 file changed, 16 insertions
Hello,
I've been working with HEVC + mpegts at low bitrates 10-20kbps.
At these bitrates, mpegts can create a substantial overhead due
to the 188 byte frame size (i.e. a NAL unit of 200 bytes will get
rounded up to 376 bytes).
I've tried to get around this by concatenating multiple NAL units
On Mon, 08. Apr 14:03, Andriy Gelman wrote:
> From: Andriy Gelman
>
> This commit replaces packet assignment operator with av_packet_move_ref
> when there is a packet ownership transfer.
> ---
> Michael, the update patch now has correct behavior for ticket 4221.
>
>
From: Andriy Gelman
During AVPacket assignment, it is currently not clear when the lhs takes
ownership of the packet. This commit replaces assignment with an
explicit av_packet_move_ref call when there is an ownership transfer to
clear the distinction.
---
libavformat/utils.c | 30
From: Andriy Gelman
Fixes Ticket #7895.
Currently, timestamp interpolation is disabled by default in H264 and
HEVC. This creates playback issues when the demuxer does not output a
valid timestamp. This patch allows interpolation when no b-frames have
been observed during decoding, which fixes
Hello,
On Mon, 13. May 12:04, Michael Niedermayer wrote:
> On Sat, May 11, 2019 at 11:20:51PM -0400, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Fixes Ticket #7895.
> >
> > Currently, timestamp interpolation is disabled by default in H264 and
> &
From: Andriy Gelman
This test verifies that missing timestamps from mpegts are interpolated
for a HEVC stream.
---
tests/fate/mpegts.mak | 7 ++
tests/ref/fate/mpegts-probe-interptime | 154 +
2 files changed, 161 insertions(+)
create mode 100644
From: Andriy Gelman
Fixes Ticket #7895.
Currently, timestamp interpolation is disabled by default in H264 and
HEVC. This creates playback issues when the demuxer does not output a
valid timestamp. This patch allows interpolation when no b-frames have
been observed during decoding, which fixes
Hello,
On Tue, 14. May 17:54, Andriy Gelman wrote:
> From: Andriy Gelman
>
> This test verifies that missing timestamps from mpegts are interpolated
> for a HEVC stream.
> ---
> tests/fate/mpegts.mak | 7 ++
> tests/ref/fate/mpegts-p
On Tue, 14. May 22:36, Jun Li wrote:
> Fix #6945
> Current implementaion for autorotate works fine for stream
> level rotataion but no support for frame level operation
> and frame flip. This patch is for adding flip support and
> per frame operations.
> ---
> fftools/cmdutils.c | 9 ++---
>
On Tue, 14. May 22:36, Jun Li wrote:
> Fix #6945
> Current implementaion for autorotate works fine for stream
> level rotataion but no support for frame level operation
> and frame flip. This patch is for adding flip support and
> per frame operations.
> ---
> fftools/cmdutils.c | 9 ++---
>
On Wed, 15. May 11:57, Jun Li wrote:
> On Wed, May 15, 2019 at 11:45 AM Andriy Gelman
> wrote:
>
> > On Tue, 14. May 22:36, Jun Li wrote:
> > > Fix #6945
> > > Current implementaion for autorotate works fine for stream
> > > level rotataion but no s
On Thu, 16. May 00:43, Michael Niedermayer wrote:
> On Tue, May 14, 2019 at 05:54:21PM -0400, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Fixes Ticket #7895.
> >
> > Currently, timestamp interpolation is disabled by default in H264 and
> > HEVC.
Hi Jun,
On Thu, 16. May 00:12, Jun Li wrote:
> Fix #6945
> Current implementaion for autorotate works fine for stream
> level rotataion but no support for frame level operation
> and frame flip. This patch is for adding flip support and
> per frame operations.
> ---
> fftools/cmdutils.c |
On Thu, 16. May 18:28, Jun Li wrote:
> On Thu, May 16, 2019 at 12:54 PM Andriy Gelman
> wrote:
>
> > Hi Jun,
> >
> > On Thu, 16. May 00:12, Jun Li wrote:
> > > Fix #6945
> > > Current implementaion for autorotate works fine for stream
> &g
On Sun, 21. Apr 10:14, Andriy Gelman wrote:
> From: Andriy Gelman
>
> During AVPacket assignment, it is currently not clear when the lhs takes
> ownership of the packet. This commit replaces assignment with an
> explicit av_packet_move_ref call when there is an ownership transfer
Hello,
On Mon, 10. Jun 17:29, Andreas Håkon wrote:
> Hi,
>
> Here is a list of comments on this patch:
> (Note: I use for all the tests the file
> https://samples.ffmpeg.org/HDTV/bshi01.tp)
>
> - By default the current behavior is selected. You can verify that this
> patch doesn’t alter the ori
Michael,
On Thu, 16. May 00:43, Michael Niedermayer wrote:
> On Tue, May 14, 2019 at 05:54:21PM -0400, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Fixes Ticket #7895.
> >
> > Currently, timestamp interpolation is disabled by default in H264 and
> &
Andreas,
On Sun, 09. Jun 13:00, Andreas Rheinhardt wrote:
> Up until now, the bitmasks used to initially find out when one needs
> to take a closer look and search for startcodes were rather primitive:
> If a block (of four or eight bytes, depending on the system) contained a
> zero, it was treat
From: Andriy Gelman
Fixes #7985
This patch checks that the number of audio channels is not zero when
writing the total sample count in adx header.
---
libavformat/rawenc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c
index 993d232b70
On Sun, 14. Jul 00:40, Carl Eugen Hoyos wrote:
>
> > Am 13.07.2019 um 22:50 schrieb Andriy Gelman :
> >
> > From: Andriy Gelman
> >
> > Fixes #7985
>
> Did you check the patch mentioned there?
Sorry, I missed that you sent a patch.
I applied
On Sat, 13. Jul 23:10, Andriy Gelman wrote:
> On Sun, 14. Jul 00:40, Carl Eugen Hoyos wrote:
> >
> > > Am 13.07.2019 um 22:50 schrieb Andriy Gelman :
> > >
> > > From: Andriy Gelman
> > >
> > > Fixes #7985
> >
> > Did you che
From: Andriy Gelman
Fixes #7799
Currently, the mp4toannexb filter always inserts extradata at the start
of each IRAP unit. This can lead to duplication of parameter sets if the
demuxed packet from mdat atom already contains a version of the
parameters.
As in ticket #7799 this can also lead to
Andreas,
On Mon, 22. Jul 12:22, Andreas Håkon wrote:
> Hi,
>
> Based on the discussion of my previous patch
> https://patchwork.ffmpeg.org/patch/13487/
> Here I publish a first part of the patch that only addresses the PCR problem.
Thanks for splitting the patch set.
>
> This supersedes too:
Andreas,
On Sun, 28. Jul 19:07, Andreas Håkon wrote:
> Hi,
>
> This last version fixes the small bug discovered by Michael Niedermayer:
> https://patchwork.ffmpeg.org/patch/14099/
>
> This version is finally clean.
>
> Regards.
> A.H.
>
> ---
> From 08565b81aa2b6d75043e5e984da143480891c3b0 Mo
-f mpegts
zmq:tcp://127.0.0.1:
Multiple clients can then connect with:
$ ./ffplay zmq:tcp://127.0.0.1:
I would be happy to maintain the code.
Thanks,
Andriy
>From 366f705945f9b2c40158730ec18ac9259bca2695 Mon Sep 17 00:00:00 2001
From: Andriy Gelman
Date: Tue, 30 Jul 2019 14:39:32
From: Andriy Gelman
---
libavfilter/f_zmq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c
index 89da5bef06..744c721305 100644
--- a/libavfilter/f_zmq.c
+++ b/libavfilter/f_zmq.c
@@ -139,7 +139,7 @@ static int recv_msg
tests pointed by Michael Niedermayer (Sample_cut.ts) and
> Andriy Gelman (day_flight.mpg).
>
> I hope this time the patch will be accepted.
> Regards.
> A.H.
>
> ---
> From 8381febd0e881cfcd53583b0ccdd7eb2c580e422 Mon Sep 17 00:00:00 2001
> From: Andreas Hakon
> D
From: Andriy Gelman
---
libavformat/mpegtsenc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
index fc0ea225c6..1541a7a073 100644
--- a/libavformat/mpegtsenc.c
+++ b/libavformat/mpegtsenc.c
@@ -846,10 +846,8 @@ static
From: Andriy Gelman
---
libavfilter/f_zmq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c
index 89da5bef06..744c721305 100644
--- a/libavfilter/f_zmq.c
+++ b/libavfilter/f_zmq.c
@@ -139,7 +139,7 @@ static int recv_msg
Andreas,
On Thu, 01. Aug 08:24, Andreas Håkon wrote:
> Hi Andriy,
>
>
> ‐‐‐ Original Message ‐‐‐
> On Thursday, 1 de August de 2019 0:23, Andriy Gelman
> wrote:
>
> > > +for (i = 0; i < ts->nb_services; i++) {
> > > +serv
On Sat, 03. Aug 00:37, Marton Balint wrote:
> The MPEG-TS muxer had a serious bug related to the use of multiple programs:
> in that case, the PCR pid selection was incomplete for all services except
> one.
> This patch solves this problem and selects a stream to become PCR for each
> service, pre
On Sat, 03. Aug 10:19, Marton Balint wrote:
> The MPEG-TS muxer had a serious bug related to the use of multiple programs:
> in that case, the PCR pid selection was incomplete for all services except
> one.
> This patch solves this problem and selects a stream to become PCR for each
> service, pre
Changes in v2:
1. Replaced zmq_poll with zmq_msg_recv.
2. Remove user timeout option as zmq_msg_recv(.., .., ZMQ_DONTWAIT) is a
non-blocking call.
3. Updated docs.
Andriy
>From 53e6e00d30c9fbf5127eea9d377686d37e981c0c Mon Sep 17 00:00:00 2001
From: Andriy Gelman
Date: Tue, 30
On Sun, 04. Aug 14:36, Andriy Gelman wrote:
> Changes in v2:
> 1. Replaced zmq_poll with zmq_msg_recv.
> 2. Remove user timeout option as zmq_msg_recv(.., .., ZMQ_DONTWAIT) is a
> non-blocking call.
> 3. Updated docs.
>
> Andriy
>
> From 53e6e00d30c9fbf51
From: Andriy Gelman
This patch avoids a read past the end of the input buffer in memcpy since the
size
of the received zmq message is recv_buf_size - 1.
---
tools/zmqsend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/zmqsend.c b/tools/zmqsend.c
index 7bd7fe4199
Andreas,
On Sun, 21. Jul 10:47, Andreas Rheinhardt wrote:
> Andriy Gelman:
> > From: Andriy Gelman
> >
> > Fixes #7799
> >
> > Currently, the mp4toannexb filter always inserts extradata at the start
> > of each IRAP unit. This can lead to duplication of p
From: Andriy Gelman
Fixes #7799
Currently, the mp4toannexb filter always inserts the same extradata at
the start of the first IRAP unit. As in ticket #7799, this can lead to
decoding errors if modified parameter sets are signalled in-band.
This commit keeps track of the vps/sps/pps parameter
Andreas,
On Tue, 13. Aug 06:24, Andreas Rheinhardt wrote:
> Andriy Gelman:
> > Andreas,
> >
> > On Sun, 21. Jul 10:47, Andreas Rheinhardt wrote:
> >> Andriy Gelman:
> >>> From: Andriy Gelman
> >>>
> >>> Fixes #7799
> >&g
Minor changes in v3:
1. Removed tab character from as per feedback
2. Removed unused timeout variable from ZMQContext
Andriy
>From 66c11c12fcfa8a7fbb3c8c09d23c017992229a99 Mon Sep 17 00:00:00 2001
From: Andriy Gelman
Date: Tue, 30 Jul 2019 14:39:32 -0400
Subject: [PATCH] libavformat:
On Tue, 20. Aug 01:01, Michael Niedermayer wrote:
> On Sun, Aug 18, 2019 at 10:37:57PM -0400, Andriy Gelman wrote:
> [...]
> > diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> > index 559c3898bc..46f130f4d1 100644
> > --- a/tests/fate/hevc.mak
> > +++ b/tes
Andreas,
On Tue, 20. Aug 07:54, Andreas Rheinhardt wrote:
> Hello,
>
> I have not looked at the *PS and the SEI stuff yet, but here is
> already my review of the general code.
>
> Andriy Gelman:
> > From: Andriy Gelman
> >
> > Fixes #7799
> >
&g
On Mon, 19. Aug 17:28, Andriy Gelman wrote:
> Minor changes in v3:
> 1. Removed tab character from as per feedback
> 2. Removed unused timeout variable from ZMQContext
>
> Andriy
> From 66c11c12fcfa8a7fbb3c8c09d23c017992229a99 Mon Sep 17 00:00:00 2001
> From: Andriy Ge
Andreas,
On Mon, 19. Aug 23:56, Andreas Rheinhardt wrote:
> Up until now, avformat_find_stream_info had a potential for memleaks:
> When everything is fine, it read packets and (depending upon whether
> AVFMT_FLAG_NOBUFFER was set) put them in a packet list or unreferenced
> them when they were no
On Mon, 19. Aug 23:56, Andreas Rheinhardt wrote:
> Up until now, read_frame_internal in avformat/utils.c uses a spare
> packet on the stack that serves no real purpose: At no point in this
> function is there a need for another packet besides the packet destined
> for output:
> 1. If the packet doe
Marton,
Thanks for reviewing this patch.
On Sat, 24. Aug 19:33, Marton Balint wrote:
>
>
> On Fri, 23 Aug 2019, Andriy Gelman wrote:
>
> > On Mon, 19. Aug 17:28, Andriy Gelman wrote:
> > > Minor changes in v3: 1. Removed tab character from as per feedback
>
On Thu, 29. Aug 02:28, Marton Balint wrote:
>
>
> On Wed, 28 Aug 2019, Andriy Gelman wrote:
>
> > > > > +h->is_streamed = 1;
> > > > > +
> > > > > +av_strstart(uri, "zmq:", &uri);
> > > > >
rom ca5aa5149b97152b15457b2f40c753c80e68e3de Mon Sep 17 00:00:00 2001
From: Andriy Gelman
Date: Tue, 30 Jul 2019 14:39:32 -0400
Subject: [PATCH] libavformat: Add ZeroMQ as a protocol option
Currently multiple clients are only supported by using a multicast
destination address. An alternative is to stream t
Fixes #7410.
The value of sub-pixel precision for me/mc can change during an Intra frame. In
multi-threaded decoding this change is not propagated to other frame threads
causing decoding artifacts. This patch initializes the sub-pixel precision
parameter from previous thread, which fixes the iss
On Fri, 28. Feb 00:14, Linjie Fu wrote:
> Signed-off-by: Linjie Fu
> ---
> libavcodec/v4l2_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c
> index 95a2bfa..8110bbb 100644
> --- a/libavcodec/v4l2_context.c
>
From: Andriy Gelman
Supports connecting to a RabbitMQ broker via AMQP version 0-9-1.
Signed-off-by: Andriy Gelman
---
Changes in v2:
- Addressed comments from Marton
- Updated documentation
Compilation notes:
- Requires librabbitmq-dev package (on ubuntu).
- The pkg-config
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
libavformat/libzmq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c
index 8c8b294c921..1b0d8638dbf 100644
--- a/libavformat/libzmq.c
+++ b/libavformat/libzmq.c
@@ -40,7 +40,7
On Sat, 29. Feb 11:21, Paul B Mahol wrote:
> I think this was already rejected?
Thilo had a question on broker performance, which I believe addressed:
http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257483.html
j-b had concerns about how it fits into libavformat:
http://ffmpeg.org/pipermai
On Thu, 27. Feb 15:02, James Almer wrote:
> This commit follows the same logic as 061a0c14bb, but for the encode API: The
> new public encoding API will no longer be a wrapper around the old deprecated
> one, and the internal API used by the encoders now consists of a single
> receive_packet() call
On Mon, 02. Mar 13:38, phunkyfish wrote:
> ---
> compat/w32pthreads.h | 10 ++
> libavformat/udp.c| 8 +++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h
> index 7df33b7da4..64cd40cda4 100644
> --- a/compat/w32pthr
On Mon, 02. Mar 11:41, Anton Khirnov wrote:
> Quoting Marton Balint (2020-02-29 17:09:58)
> >
> >
> > On Sat, 29 Feb 2020, Paul B Mahol wrote:
> >
> > > I think this was already rejected?
> >
> > jb questioned if this belongs to libavformat, and timo asked how well the
> > message brokers hand
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
libavcodec/avcodec.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 5a0fc3405c5..8cda2422efa 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -5037,7
From: Andriy Gelman
Should be squashed with:
http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257735.html
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_m2m.c | 9 -
libavcodec/v4l2_m2m.h | 6 +-
libavcodec/v4l2_m2m_dec.c | 2 +-
libavcodec/v4l2_m2m_enc.c | 17
On Sat, 07. Mar 23:23, James Almer wrote:
> On 3/7/2020 9:23 PM, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Should be squashed with:
> > http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257735.html
> >
> > Signed-off-by: Andriy Gelman
>
On Sat, 07. Mar 23:13, James Almer wrote:
> On 3/7/2020 9:23 PM, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Should be squashed with:
> > http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257735.html
>
> Thank you! Only three remain now :)
>
&
From: Andriy Gelman
struct v4l2_selection contains reserved bytes which should be set to
zero before the ioctl call.
Fixes valgrind error:
Syscall param ioctl(VKI_V4L2_S_SELECTION) points to uninitialised byte(s)
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_m2m_dec.c | 2 +-
1 file
From: Andriy Gelman
Supports connecting to a RabbitMQ broker via AMQP version 0-9-1.
Signed-off-by: Andriy Gelman
---
Changes in v3:
- Fixed a bug when parsing username that contained a url encoded ":"
- Fixed documentation error and improved logging
Changes in v2:
-
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
doc/protocols.texi | 2 +-
libavformat/libzmq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index 27df4759b63..e510019f2d8 100644
--- a/doc/protocols.texi
+++ b/doc
On Sun, 08. Mar 12:25, Marton Balint wrote:
>
> > Subject: [FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1
> > protocol support
> >
> > From: Andriy Gelman
> >
> > Supports connecting to a RabbitMQ broker via AMQP version 0-9-1
On Sun, 08. Mar 16:33, Andriy Gelman wrote:
> From: Andriy Gelman
>
> Supports connecting to a RabbitMQ broker via AMQP version 0-9-1.
>
> Signed-off-by: Andriy Gelman
> ---
>
> Changes in v3:
> - Fixed a bug when parsing username that contained a ur
From: Andriy Gelman
Supports connecting to a RabbitMQ broker via AMQP version 0-9-1.
Signed-off-by: Andriy Gelman
---
Changes in v4:
- Fixed leak from user_decoded/password_decoded when amqp_new_connection()
fails
Changes in v3:
- Fixed a bug when parsing username that
From: Andriy Gelman
v4l2_m2m_{enc,dec} doesn't call its close function when initialization
fails because FF_CODEC_CAP_INIT_CLEANUP is not set. This causes a couple
possible leaks, which are fixed in the commit.
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_m2m_dec.
From: Colin NG
Fixes ticket #8285
Signed-off-by: Andriy Gelman
---
This was sent to the mailing list by Colin NG some time ago, but was never
applied.
libavcodec/v4l2_m2m_enc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c
index
From: Andriy Gelman
Should be squashed with:
http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257735.html
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_m2m.c | 8
libavcodec/v4l2_m2m.h | 3 +++
libavcodec/v4l2_m2m_enc.c | 15 ++-
3 files changed, 25
evertheless led to a compiler warning
> > "‘strncpy’ specified bound depends on the length of the source argument
> > [-Wstringop-overflow=]" in GCC 9.2. strlen() was unnecessary anyway.
> >
> > Reviewed-by: Andriy Gelman
> > Signed-off-by: Andreas Rheinhardt
On Thu, 05. Mar 00:02, Andriy Gelman wrote:
> From: Andriy Gelman
>
> Signed-off-by: Andriy Gelman
> ---
> libavcodec/avcodec.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 5a0f
On Sun, 08. Mar 11:49, Andriy Gelman wrote:
> From: Andriy Gelman
>
> struct v4l2_selection contains reserved bytes which should be set to
> zero before the ioctl call.
>
> Fixes valgrind error:
> Syscall param ioctl(VKI_V4L2_S_SELECTION) points to uninitialised byte(
On Sun, 23. Feb 13:47, Andriy Gelman wrote:
> From: Andriy Gelman
>
> Currently the user gets unhelpful warnings when some default parameters
> are not supported by the device. The verbosity of these log messages has
> been changed to AV_LOG_DEBUG.
>
> Signed-
On Mon, 16. Mar 10:00, Ming Qian wrote:
> v4l2 set the frame rate through frame intervals,
> not set frame rate directly.
> the frame rate and frame intervals are reciprocal.
> so in libavdevice/v4l2.c we can see the following code:
> tpf->numerator = framerate_q.den;
> tpf->denominat
On Mon, 16. Mar 10:02, Ming Qian wrote:
> the draining is set when the output port is finished,
> but it doesn't mean the capture port is finished.
> especially for decoder, there may be a stream buffer to store several
> frames.
> so the decoder still need capture buffer even if the draining is se
On Mon, 16. Mar 10:03, Ming Qian wrote:
> when the last frame of capture is dequeueed,
> driver may send this V4L2_EVENT_EOS event,
> if this event is received, then we can set the capture port done
Please add to your commit message (or something similar depending on what you
tested):
"Without th
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
doc/general.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/general.texi b/doc/general.texi
index 14878f4dcf3..752618a00b4 100644
--- a/doc/general.texi
+++ b/doc/general.texi
@@ -1336,7 +1336,7 @@ performance on
On Thu, 12. Mar 22:40, Andriy Gelman wrote:
> On Sun, 08. Mar 11:49, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > struct v4l2_selection contains reserved bytes which should be set to
> > zero before the ioctl call.
> >
> > Fixes
On Tue, 17. Mar 19:29, Ming Qian wrote:
> v4l2 set the frame rate through frame intervals,
> not set frame rate directly.
> the frame rate and frame intervals are reciprocal.
> so in libavdevice/v4l2.c we can see the following code:
> tpf->numerator = framerate_q.den;
> tpf->denominat
On Tue, 17. Mar 19:39, Ming Qian wrote:
> when the last frame of capture is dequeueed,
> driver may send this V4L2_EVENT_EOS event,
> if this event is received, then we can set the capture port done
s/dequeueed/dequeued
Also I'd change the last line to:
"If this event is received, then the captur
On Sun, 29. Mar 10:53, Andriy Gelman wrote:
> On Tue, 17. Mar 19:29, Ming Qian wrote:
> > v4l2 set the frame rate through frame intervals,
> > not set frame rate directly.
> > the frame rate and frame intervals are reciprocal.
> > so in libavdevice/v4l2.c we can see the
On Wed, 01. Apr 00:38, Michael Niedermayer wrote:
> On Sun, Mar 08, 2020 at 11:49:47AM -0400, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > struct v4l2_selection contains reserved bytes which should be set to
> > zero before the ioctl call.
> >
> >
From: Andriy Gelman
The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format
which breaks the stream when the packets are muxed in avformat. This commit
adds an option to remove the container and thus support the encoder.
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_m2m.h
On Sun, 05. Apr 02:05, Carl Eugen Hoyos wrote:
> Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos
> :
> >
> > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos
> > :
> > >
> > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer :
> > > >
> > > > On 4/3/2020 6:37 PM, Carl Eu
On Sun, 05. Apr 10:34, Carl Eugen Hoyos wrote:
> Am So., 5. Apr. 2020 um 03:30 Uhr schrieb Andriy Gelman
> :
> >
> > On Sun, 05. Apr 02:05, Carl Eugen Hoyos wrote:
> > > Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos
> > > :
> > > >
&
lgtm with a couple of minor comments
On Sun, 05. Apr 10:49, Carl Eugen Hoyos wrote:
> Am Di., 13. Aug. 2019 um 12:45 Uhr schrieb Carl Eugen Hoyos
> :
>
> > Attached patch fixes several compilation warnings when building with
> > chromapring.
>
> I will push this patch if there are no objections.
From: Andriy Gelman
v4l2_m2m uses device memory mapped buffers to store dequeued
frames/packets (reference counted by AVBufferRef). When the
reference count drops to zero, the buffer ownership is returned back to
the device, so that they can re-filled with frames/packets.
There are some cases
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
libavcodec/v4l2_context.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c
index 8110bbb555..31af10d28e 100644
--- a/libavcodec/v4l2_context.c
+++ b/libavcodec
On Wed, 01. Apr 10:38, Ming Qian wrote:
> when the last frame of capture is dequeueed,
> driver may send this V4L2_EVENT_EOS event,
> If this event is received, then the capture buffers have been flushed and
> avcodec_receive_packet()/avcodec_receive_frame() can return AVERROR_EOF.
> Otherwise, the
, and this patch would prevent it (although
it's not needed if an eos event is received).
Perhaps Mark/Aman could also comment?
Thanks,
Andriy
>
> ________
> 发件人: ffmpeg-devel 代表 Andriy Gelman
>
> 发送时间: 2020年3月16日 20:07
> 收件人: FFmpeg development discus
On Mon, 06. Apr 09:37, Andreas Rheinhardt wrote:
> Andriy Gelman:
> > From: Andriy Gelman
> >
> > Signed-off-by: Andriy Gelman
> > ---
> > libavcodec/v4l2_context.c | 6 ++
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> >
On Thu, 09. Apr 02:14, Ming Qian wrote:
> Did you try increasing the -num_capture_buffers option? It may solve your
> problem.
> 1. We can't increase the num_capture_buffers indefinitely.
> 2. There is a ring buffer in driver, so the number of frames who is stored in
> the ring buffer may be a la
On Wed, 08. Apr 20:51, Andriy Gelman wrote:
> On Wed, 01. Apr 10:38, Ming Qian wrote:
> > when the last frame of capture is dequeueed,
> > driver may send this V4L2_EVENT_EOS event,
> > If this event is received, then the capture buffers have been flushed and
>
On Sat, 11. Apr 15:56, Mark Thompson wrote:
> On 04/04/2020 21:26, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format
> > which breaks the stream when the packets are muxed in avformat. This c
On Sat, 11. Apr 18:56, Jan Ekström wrote:
> On Sat, Apr 11, 2020 at 6:43 PM Andriy Gelman wrote:
> >
> > On Sat, 11. Apr 15:56, Mark Thompson wrote:
> > > On 04/04/2020 21:26, Andriy Gelman wrote:
> > > > From: Andriy Gelman
> > > >
> > &
On Mon, 13. Apr 20:02, Jun Zhao wrote:
> From: Jun Zhao
>
> when enable the QSV in FFmpeg, used the cmd "ffmpeg -hwaccels" always
> dump redundancy acceleration methods for QSV like:
>
> Hardware acceleration methods:
> vaapi
> qsv
> drm
> opencl
> qsv
>
> Signed-off-by: Jun Zhao
> ---
> ffto
On Mon, 13. Apr 10:29, Michael Bradshaw wrote:
> On Tue, Mar 31, 2020 at 6:23 AM Derek Buitenhuis
> wrote:
>
> > I agree strongly with Michael's points.
>
>
> I've pushed the patch to master.
seems to break fate
make fate-vsynth1-dnxhd-1080i-colr
TESTvsynth1-dnxhd-1080i-colr
--- ./tests/
On Wed, 08. Apr 20:51, Andriy Gelman wrote:
> On Wed, 01. Apr 10:38, Ming Qian wrote:
> > when the last frame of capture is dequeueed,
> > driver may send this V4L2_EVENT_EOS event,
> > If this event is received, then the capture buffers have been flushed and
>
1 - 100 of 537 matches
Mail list logo
