Hello everyone,
Long time no see !
I'm glad to see ffmpeg still strong.
I'm curently playing with bluetooth audio (A2DP) and I wanted to
use lavc to do the encoding/decoding, so I added some codecs that
I need to ffmpeg.
Here is the result for the SBC codec.
[PATCH 1/3] sbc: implement SBC code
,vc1);
diff --git a/libavcodec/sbc_parser.c b/libavcodec/sbc_parser.c
new file mode 100644
index 00..278ac6f84f
--- /dev/null
+++ b/libavcodec/sbc_parser.c
@@ -0,0 +1,135 @@
+/*
+ * SBC parser
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is
= "truehd",
diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c
new file mode 100644
index 00..1eb99bae03
--- /dev/null
+++ b/libavformat/sbcdec.c
@@ -0,0 +1,76 @@
+/*
+ * RAW SBC demuxer
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
.c
@@ -0,0 +1,854 @@
+/*
+ * Audio Processing Technology codec for Bluetooth (aptX)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ *
Hi again,
Here is the other codec I added for my bluetooth needs: aptX.
This one is based on my reverse engineering and my understanding
of patent EP0398973B1 (long expired).
[PATCH 1/2] aptx: implement the aptX bluetooth codec
[PATCH 2/2] aptx: add raw muxer and demuxer for aptX
--
Aurel
_
a/libavformat/aptxdec.c b/libavformat/aptxdec.c
new file mode 100644
index 00..769b666b4d
--- /dev/null
+++ b/libavformat/aptxdec.c
@@ -0,0 +1,70 @@
+/*
+ * RAW aptX demuxer
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you
On Mon, Nov 06, 2017 at 12:51:55AM +0100, Carl Eugen Hoyos wrote:
> 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs :
>
> > Here is the other codec I added for my bluetooth needs: aptX.
>
> Just curious:
> Could you comment on the quality?
Well, my ears aren't really
On Mon, Nov 06, 2017 at 12:51:19AM +0100, Carl Eugen Hoyos wrote:
> 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs :
>
> > +static int aptx_probe(AVProbeData *p)
> > +{
> > +int len, score = 0;
> > +if (!p || !p->filename)
> > +return 0;
> >
On Mon, Nov 06, 2017 at 12:48:32AM +0100, Carl Eugen Hoyos wrote:
> 2017-11-06 0:35 GMT+01:00 Aurelien Jacobs :
>
> > +static int sbc_probe(AVProbeData *p)
> > +{
> > +int score = 0;
>
> > +int l = strlen(p->filename);
> > +if
On Sun, Nov 05, 2017 at 11:43:37PM +, Rostislav Pehlivanov wrote:
> On 5 November 2017 at 23:35, Aurelien Jacobs wrote:
>
> > ---
> > libavcodec/Makefile | 2 +
> > libavcodec/allcodecs.c | 2 +
> >
On Mon, Nov 06, 2017 at 12:30:02AM +, Rostislav Pehlivanov wrote:
> On 5 November 2017 at 23:39, Aurelien Jacobs wrote:
>
> > The encoder was reverse engineered from binary library and from
> > EP0398973B1 patent (long expired).
> > The decoder was simply
.c
@@ -0,0 +1,826 @@
+/*
+ * Audio Processing Technology codec for Bluetooth (aptX)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ *
--git a/libavformat/aptxdec.c b/libavformat/aptxdec.c
new file mode 100644
index 00..90ce789454
--- /dev/null
+++ b/libavformat/aptxdec.c
@@ -0,0 +1,58 @@
+/*
+ * RAW aptX demuxer
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software
On Wed, Nov 08, 2017 at 10:54:18AM +0100, Paul B Mahol wrote:
> On 11/7/17, Aurelien Jacobs wrote:
> > The encoder was reverse engineered from binary library and from
> > EP0398973B1 patent (long expired).
> > The decoder was simply deduced from the encoder.
> >
On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote:
> On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote:
> [...]
> > +typedef const struct {
> > +const int32_t *quantize_intervals;
> > +const int32_t *invert_quantize_dither_factors
On Wed, Nov 08, 2017 at 05:24:34PM +, Rostislav Pehlivanov wrote:
>
> [...]
>
> Patch doesn't apply
Here is a rebased patch.>From f6d9a7a804bc1c833e7c2e61411ac1b9155cb6ba Mon Sep 17 00:00:00 2001
From: Aurelien Jacobs
Date: Thu, 31 Aug 2017 20:42:15 +0200
Subject: [PATC
On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote:
> On 8 November 2017 at 22:41, Aurelien Jacobs wrote:
>
> > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote:
> > > On Wed, Nov 08, 2017 at 02:06:09PM +0100,
On Thu, Nov 09, 2017 at 03:22:21AM +0100, Michael Niedermayer wrote:
> On Wed, Nov 08, 2017 at 11:41:16PM +0100, Aurelien Jacobs wrote:
> > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote:
> > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aur
On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote:
> On 9 November 2017 at 13:37, Aurelien Jacobs wrote:
>
> > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote:
> > > On 8 November 2017 at 22:41, Aurelien Jacobs wrote:
> > >
&
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote:
> On 11/9/2017 2:46 PM, Clément Bœsch wrote:
> > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote:
> >> Signed-off-by: Rostislav Pehlivanov
> >> ---
> >> doc/developer.texi | 3 +++
> >> 1 file changed, 3 insertions(
On Fri, Nov 10, 2017 at 12:25:12AM +, Rostislav Pehlivanov wrote:
> On 9 November 2017 at 22:48, Aurelien Jacobs wrote:
>
> > On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote:
> > > On 9 November 2017 at 13:37, Aurelien Jacobs wrote:
> > >
&
.c
@@ -0,0 +1,860 @@
+/*
+ * Audio Processing Technology codec for Bluetooth (aptX)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ *
/libavformat/aptxdec.c b/libavformat/aptxdec.c
new file mode 100644
index 00..3b8fae1b55
--- /dev/null
+++ b/libavformat/aptxdec.c
@@ -0,0 +1,78 @@
+/*
+ * RAW aptX demuxer
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you
On Sun, Dec 03, 2017 at 10:57:59AM +, Rostislav Pehlivanov wrote:
> On 5 November 2017 at 23:35, Aurelien Jacobs wrote:
>
> > Hello everyone,
> >
> > Long time no see !
> >
> > I'm glad to see ffmpeg still strong.
> >
> > I'm cu
On Mon, Nov 06, 2017 at 04:22:30AM +0100, Michael Niedermayer wrote:
> Hi
>
> On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> > doc/general.texi
On Mon, Nov 06, 2017 at 04:40:56AM +, Rostislav Pehlivanov wrote:
> On 5 November 2017 at 23:35, Aurelien Jacobs wrote:
>
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> > doc/general.texi | 2 +
On Mon, Nov 06, 2017 at 12:53:38PM -0300, James Almer wrote:
> On 11/5/2017 8:35 PM, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> > doc/general.texi | 2 +
> > libavcodec/
index 00..032f72cf2b
--- /dev/null
+++ b/libavcodec/sbc_parser.c
@@ -0,0 +1,124 @@
+/*
+ * SBC parser
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU
);
REGISTER_DEMUXER (SDP, sdp);
diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c
new file mode 100644
index 00..a04a7c4328
--- /dev/null
+++ b/libavformat/sbcdec.c
@@ -0,0 +1,47 @@
+/*
+ * RAW SBC demuxer
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg
---
doc/general.texi | 2 +-
libavformat/Makefile | 2 ++
libavformat/allformats.c | 4 ++--
libavformat/rawenc.c | 28
4 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/doc/general.texi b/doc/general.texi
index e5669b0e93..560465a4b8 1
ile mode 100644
index 00..99d02cc56a
--- /dev/null
+++ b/libavcodec/sbc.c
@@ -0,0 +1,316 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Co
index 00..16faf5ba9b
--- /dev/null
+++ b/libavcodec/sbcdsp.c
@@ -0,0 +1,390 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C
codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C) 2004-2010 Marcel Holtmann
+ * Copyright (C) 2004-2005 Henryk Ploetz
+ * Copyright (C) 2005-2006 Brad Midgley
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free softwar
iff --git a/libavcodec/x86/sbcdsp_init.c b/libavcodec/x86/sbcdsp_init.c
new file mode 100644
index 00..86effecfdf
--- /dev/null
+++ b/libavcodec/x86/sbcdsp_init.c
@@ -0,0 +1,51 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyrigh
---
Changelog | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Changelog b/Changelog
index ee48876128..8eebcd810c 100644
--- a/Changelog
+++ b/Changelog
@@ -27,6 +27,8 @@ version :
- video setrange filter
- nsp demuxer
- support LibreSSL (via libtls)
+- native SBC and mSBC encoder and deco
---
libavcodec/aptx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c
index d09ce8f838..a35d2861c1 100644
--- a/libavcodec/aptx.c
+++ b/libavcodec/aptx.c
@@ -836,6 +836,7 @@ AVCodec ff_aptx_decoder = {
.decode= aptx_decode_frame,
On Mon, Dec 18, 2017 at 12:19:06AM +0100, Carl Eugen Hoyos wrote:
> 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs :
>
> > +#if CONFIG_SBC_DEMUXER
> > +AVInputFormat ff_sbc_demuxer = {
> > +.name = "sbc",
> > +.long_name = NULL_
On Mon, Dec 18, 2017 at 12:21:00AM +0100, Carl Eugen Hoyos wrote:
> 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs :
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
>
> Very rough numbers are useful in the commit message.
He
On Mon, Dec 18, 2017 at 12:22:27AM +0100, Carl Eugen Hoyos wrote:
> 2017-12-17 22:47 GMT+01:00 Aurelien Jacobs :
> > ---
> > Changelog | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Changelog b/Changelog
> > index ee48876128..8eebcd81
On Mon, Dec 18, 2017 at 12:45:12PM +0100, Michael Niedermayer wrote:
> On Sun, Dec 17, 2017 at 10:47:16PM +0100, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> [...]
> > +static inline void sbc_analyze_4b_
On Mon, Dec 18, 2017 at 01:05:39AM +, Rostislav Pehlivanov wrote:
> On 17 December 2017 at 21:47, Aurelien Jacobs wrote:
>
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> > doc/general.texi | 2 +
> >
---
libavutil/crc.c | 20
libavutil/crc.h | 12
2 files changed, 32 insertions(+)
diff --git a/libavutil/crc.c b/libavutil/crc.c
index 8e44a76ec8..cb26a09a20 100644
--- a/libavutil/crc.c
+++ b/libavutil/crc.c
@@ -413,3 +413,23 @@ uint32_t av_crc(const AVCRC *ctx,
---
libavutil/crc.c | 26 ++
libavutil/crc.h | 1 +
libavutil/tests/crc.c | 7 ---
3 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/libavutil/crc.c b/libavutil/crc.c
index d44550c9c0..8e44a76ec8 100644
--- a/libavutil/crc.c
+++ b/libavutil/c
ode 100644
index 00..61bc27da6e
--- /dev/null
+++ b/libavcodec/sbc.c
@@ -0,0 +1,257 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyr
---
doc/general.texi | 1 +
libavformat/Makefile | 2 ++
libavformat/allformats.c | 2 ++
libavformat/rawdec.c | 24
4 files changed, 29 insertions(+)
diff --git a/doc/general.texi b/doc/general.texi
index ed137f999f..65aee47f2a 100644
--- a/doc/general
index 00..032f72cf2b
--- /dev/null
+++ b/libavcodec/sbc_parser.c
@@ -0,0 +1,124 @@
+/*
+ * SBC parser
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU
---
doc/general.texi | 2 +-
libavformat/Makefile | 2 ++
libavformat/allformats.c | 4 ++--
libavformat/rawenc.c | 28
4 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/doc/general.texi b/doc/general.texi
index e5669b0e93..560465a4b8 1
index 00..e155387f0d
--- /dev/null
+++ b/libavcodec/sbcdsp.c
@@ -0,0 +1,382 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C
* SIMD optimized SBC encoder DSP functions
+;*
+;* Copyright (C) 2017 Aurelien Jacobs
+;* Copyright (C) 2008-2010 Nokia Corporation
+;* Copyright (C) 2004-2010 Marcel Holtmann
+;* Copyright (C) 2004-2005 Henryk Ploetz
+;* Copyright (C) 2005-2006 Brad Midgley
+;*
+;* This file is part of
codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C) 2004-2010 Marcel Holtmann
+ * Copyright (C) 2004-2005 Henryk Ploetz
+ * Copyright (C) 2005-2006 Brad Midgley
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free softwar
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index ee48876128..4a98884a3c 100644
--- a/Changelog
+++ b/Changelog
@@ -27,6 +27,7 @@ version :
- video setrange filter
- nsp demuxer
- support LibreSSL (via libtls)
+- native SBC and mSBC encoder and decode
On Wed, Dec 20, 2017 at 03:47:35PM -0300, James Almer wrote:
> On 12/17/2017 6:47 PM, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> > ---
> > libavcodec/sbcdsp.c | 3 +
> > libavcodec/sbcdsp.h
On Thu, Dec 21, 2017 at 02:12:26AM +0100, Michael Niedermayer wrote:
> On Wed, Dec 20, 2017 at 08:58:05PM +0100, Aurelien Jacobs wrote:
> > ---
> > libavutil/crc.c | 26 ++
> > libavutil/crc.h | 1 +
> > libavutil/tests/crc.c | 7 +
On Wed, Dec 20, 2017 at 10:22:54PM -0300, James Almer wrote:
> On 12/20/2017 4:58 PM, Aurelien Jacobs wrote:
> > +;***
> > +;void ff_sbc_calc_scalefactors(int32_t sb_sample_f[16][2][8],
> > +;
On Thu, Dec 21, 2017 at 11:39:02AM +, Rostislav Pehlivanov wrote:
> On 20 December 2017 at 19:58, Aurelien Jacobs wrote:
>
> > ---
> > libavutil/crc.c | 20
> > libavutil/crc.h | 12
> > 2 files changed, 32 insertions(+)
> &
---
libavutil/crc.c | 26 ++
libavutil/crc.h | 1 +
libavutil/tests/crc.c | 7 ---
tests/ref/fate/crc| 1 +
4 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/libavutil/crc.c b/libavutil/crc.c
index d44550c9c0..8e44a76ec8 100644
--- a/lib
);
diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c
new file mode 100644
index 00..a04a7c4328
--- /dev/null
+++ b/libavformat/sbcdec.c
@@ -0,0 +1,47 @@
+/*
+ * RAW SBC demuxer
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software
ile mode 100644
index 00..af3e9a3fa8
--- /dev/null
+++ b/libavcodec/sbc.c
@@ -0,0 +1,280 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyr
index 00..032f72cf2b
--- /dev/null
+++ b/libavcodec/sbc_parser.c
@@ -0,0 +1,124 @@
+/*
+ * SBC parser
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU
---
doc/general.texi | 2 +-
libavformat/Makefile | 2 ++
libavformat/allformats.c | 4 ++--
libavformat/rawenc.c | 28
4 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/doc/general.texi b/doc/general.texi
index e5669b0e93..560465a4b8 1
index 00..e155387f0d
--- /dev/null
+++ b/libavcodec/sbcdsp.c
@@ -0,0 +1,382 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C
* SIMD optimized SBC encoder DSP functions
+;*
+;* Copyright (C) 2017 Aurelien Jacobs
+;* Copyright (C) 2008-2010 Nokia Corporation
+;* Copyright (C) 2004-2010 Marcel Holtmann
+;* Copyright (C) 2004-2005 Henryk Ploetz
+;* Copyright (C) 2005-2006 Brad Midgley
+;*
+;* This file is part of
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index ee48876128..4a98884a3c 100644
--- a/Changelog
+++ b/Changelog
@@ -27,6 +27,7 @@ version :
- video setrange filter
- nsp demuxer
- support LibreSSL (via libtls)
+- native SBC and mSBC encoder and decode
codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C) 2004-2010 Marcel Holtmann
+ * Copyright (C) 2004-2005 Henryk Ploetz
+ * Copyright (C) 2005-2006 Brad Midgley
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free softwar
On Sat, Dec 23, 2017 at 04:32:26PM -0300, James Almer wrote:
> On 12/23/2017 3:01 PM, Aurelien Jacobs wrote:
> > ---
> > libavutil/crc.c | 26 ++
> > libavutil/crc.h | 1 +
> > libavutil/tests/crc.c | 7 ---
> > tests/re
Updated to match new identifier for CRC (AV_CRC_8_EBU).
>From c168e5e7b288edc2730a4a14614ead5c22d67289 Mon Sep 17 00:00:00 2001
From: Aurelien Jacobs
Date: Sun, 17 Dec 2017 19:53:35 +0100
Subject: [PATCH 2/9] sbc: implement SBC decoder (low-complexity subband codec)
This was originally based
Updated to match new identifier for CRC (AV_CRC_8_EBU).
>From 380c36ec392b066d4b70b0f9fd4957a595294f5a Mon Sep 17 00:00:00 2001
From: Aurelien Jacobs
Date: Sun, 17 Dec 2017 19:59:30 +0100
Subject: [PATCH 5/9] sbc: implement SBC encoder (low-complexity subband codec)
This was originally based
On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote:
> On 12/23/2017 3:01 PM, Aurelien Jacobs wrote:
> > This was originally based on libsbc, and was fully integrated into ffmpeg.
> >
> > Rough speed test:
> > C version:speed= 592x
> > MMX version: sp
On Sat, Dec 23, 2017 at 05:47:04PM -0300, James Almer wrote:
> On 12/23/2017 5:44 PM, Aurelien Jacobs wrote:
> > On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote:
> >> On 12/23/2017 3:01 PM, Aurelien Jacobs wrote:
> >>> This was originally based on libsbc,
On Sat, Dec 23, 2017 at 09:52:11PM +0100, Aurelien Jacobs wrote:
> On Sat, Dec 23, 2017 at 05:47:04PM -0300, James Almer wrote:
> > On 12/23/2017 5:44 PM, Aurelien Jacobs wrote:
> > > On Sat, Dec 23, 2017 at 03:35:28PM -0300, James Almer wrote:
> > >> On 12/23/2017
On Mon, Dec 25, 2017 at 12:43:18PM +, Rostislav Pehlivanov wrote:
> On 23 December 2017 at 18:01, Aurelien Jacobs wrote:
>
> > ---
> > doc/general.texi | 2 +-
> > libavformat/Makefile | 2 ++
> > libavformat/allformats.c | 4 ++--
>
On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote:
> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote:
> > Signed-off-by: Paul B Mahol
> > ---
> > doc/filters.texi | 60 ++
> > libavfilter/Makefile | 1 +
> > libavfilter/af_hrtfm.c | 486
> >
On Wed, Mar 21, 2018 at 10:19:58PM +0530, Gagandeep Singh wrote:
> alpha decompanding curve added to post process the decoded alpha channel
> ---
> libavcodec/cfhd.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
> index fd8
On Fri, Mar 23, 2018 at 10:18:47AM +0100, Paul B Mahol wrote:
> On 3/22/18, Aurelien Jacobs wrote:
> > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote:
> >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote:
> >> > Signed-off-by: Paul B Mahol
>
On Fri, Mar 23, 2018 at 02:32:30PM +0800, Steven Liu wrote:
>
>
> > On 23 Mar 2018, at 13:20, vdi...@akamai.com wrote:
> >
> > From: Vishwanath Dixit
> >
> > ---
> > doc/muxers.texi | 2 +-
> > libavformat/dashenc.c | 10 +-
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
---
libavcodec/aptx.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c
index a35d2861c1..7b9556ce42 100644
--- a/libavcodec/aptx.c
+++ b/libavcodec/aptx.c
@@ -188,7 +188,7 @@ typedef const struct {
const int32_t *quanti
---
libavcodec/aptx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c
index 64a63a7d5b..4173402d03 100644
--- a/libavcodec/aptx.c
+++ b/libavcodec/aptx.c
@@ -466,6 +466,7 @@ static void aptx_quantize_difference(Quantize *quantize,
in
This patchset add support for the aptX HD codec.
This codec is a variation of the aptX codec using less aggressive
quantization and thus producing higher bitrate and higher quality.
The first 3 patches are simple cleanup / preparatory work.
[PATCH 1/5] aptx: simplify by pre-calculating factor_ma
---
Changelog | 2 +-
configure | 2 +
libavcodec/Makefile | 2 +
libavcodec/allcodecs.c | 1 +
libavcodec/aptx.c | 352
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 7 +
7 files changed
---
Changelog| 2 +-
libavformat/Makefile | 2 ++
libavformat/allformats.c | 1 +
libavformat/aptxdec.c| 51
libavformat/rawenc.c | 13
5 files changed, 64 insertions(+), 5 deletions(-)
diff --git a/Chang
---
libavcodec/aptx.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libavcodec/aptx.c b/libavcodec/aptx.c
index 7b9556ce42..64a63a7d5b 100644
--- a/libavcodec/aptx.c
+++ b/libavcodec/aptx.c
@@ -462,10 +462,12 @@ static void aptx_quantize_difference(Quantize *quantize,
On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote:
> On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote:
> > ---
> > Changelog| 2 +-
> > libavformat/Makefile | 2 ++
> > libavformat/allformats.c | 1 +
> &g
On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote:
> On 6 January 2018 at 16:48, Aurelien Jacobs wrote:
>
> > ---
> > Changelog | 2 +-
> > configure | 2 +
> > libavcodec/Makefile | 2 +
>
On Mon, Jan 08, 2018 at 01:27:16PM +0100, Carl Eugen Hoyos wrote:
> 2018-01-08 11:32 GMT+01:00 Hendrik Leppkes :
> > On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov
> > wrote:
> >>
> >> That's okay - for encoding switch the profile depending on both the
> >> avctx->profile setting and the sam
On Mon, Jan 08, 2018 at 12:38:19AM +, Rostislav Pehlivanov wrote:
> On 7 January 2018 at 22:54, Aurelien Jacobs wrote:
>
> > On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote:
> > > On 6 January 2018 at 16:48, Aurelien Jacobs wrote:
> > >
.
And the reported stream is much less explicit:
Stream #0:0: Audio: aptx ([36][0][215][0] / 0xD70024), 48000 Hz, 2 channels,
s32p
vs.
Stream #0:0: Audio: aptx_hd, 48000 Hz, 2 channels, s32p
So for the good of users and maintainers, I suggest to follow the
wmv3/vc1 example, that is to ack
On Sun, Jan 07, 2018 at 04:55:43PM +0100, Aurelien Jacobs wrote:
> On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote:
> > On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote:
> > > ---
> > > Changelog| 2 +-
> >
On Sun, Jan 14, 2018 at 05:19:12PM +, Rostislav Pehlivanov wrote:
> On 14 January 2018 at 13:06, Aurelien Jacobs wrote:
>
> > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote:
> > > On 9 January 2018 at 14:07, Rostislav Pe
On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote:
> 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs :
>
> > Well, here is an updated patch which uses codec tags for the decoder and
> > profile for the encoder.
>
> Sorry but I object to this patch:
> We s
On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote:
> On 20 January 2018 at 17:26, Aurelien Jacobs wrote:
>
> > On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote:
> > > 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs :
> > >
> >
On Mon, Feb 05, 2018 at 12:27:20AM +0100, Michael Niedermayer wrote:
> On Sun, Feb 04, 2018 at 04:07:26PM +0100, Aurelien Jacobs wrote:
> > On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote:
> > > On 20 January 2018 at 17:26, Aurelien Jacobs wrote:
> > &
Jaikrishnan Menon
alsdec.c Thilo Borgmann, Umair Khan
+ aptx.cAurelien Jacobs
ass* Aurelien Jacobs
asv* Michael Niedermayer
atrac3plus
On Fri, Feb 09, 2018 at 10:27:39PM +0100, Aurelien Jacobs wrote:
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ba7a7284eb..b691bd56ec 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -139,6 +1
Hi,
I finnally came back to this SBC codec patchset.
I made the changes to only have one CODEC_ID for both sbc and msbc.
I think I took care of all the remarks from previous review.
Any more comments ?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.o
odec/sbc.c b/libavcodec/sbc.c
new file mode 100644
index 00..f7dba79f4f
--- /dev/null
+++ b/libavcodec/sbc.c
@@ -0,0 +1,271 @@
+/*
+ * Bluetooth low-complexity, subband codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2012-2013 Intel Corporation
+ * Copyright
---
libavutil/crc.c | 26 ++
libavutil/crc.h | 1 +
libavutil/tests/crc.c | 7 ---
tests/ref/fate/crc| 1 +
4 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/libavutil/crc.c b/libavutil/crc.c
index d44550c9c0..c45ea63a62 100644
--- a/lib
codec (SBC)
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ * Copyright (C) 2008-2010 Nokia Corporation
+ * Copyright (C) 2004-2010 Marcel Holtmann
+ * Copyright (C) 2004-2005 Henryk Ploetz
+ * Copyright (C) 2005-2006 Brad Midgley
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free softwar
;
extern AVInputFormat ff_scc_demuxer;
extern AVOutputFormat ff_scc_muxer;
diff --git a/libavformat/sbcdec.c b/libavformat/sbcdec.c
new file mode 100644
index 00..ae74a220dc
--- /dev/null
+++ b/libavformat/sbcdec.c
@@ -0,0 +1,33 @@
+/*
+ * RAW SBC demuxer
+ * Copyright (C) 2017 Aurelien
* SIMD optimized SBC encoder DSP functions
+;*
+;* Copyright (C) 2017 Aurelien Jacobs
+;* Copyright (C) 2008-2010 Nokia Corporation
+;* Copyright (C) 2004-2010 Marcel Holtmann
+;* Copyright (C) 2004-2005 Henryk Ploetz
+;* Copyright (C) 2005-2006 Brad Midgley
+;*
+;* This file is part of
@@ -0,0 +1,124 @@
+/*
+ * SBC parser
+ *
+ * Copyright (C) 2017 Aurelien Jacobs
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation
1 - 100 of 119 matches
Mail list logo