[FFmpeg-devel] [PATCH]Write valid free atom with -moov_size

2014-07-16 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3769. Please review, Carl Eugen diff --git a/libavformat/movenc.c b/libavformat/movenc.c index b3287ca..4b9a4f1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -4398,8 +4398,7 @@ static int mov_write_trailer(AVFormatContext *s) }

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Carl Eugen Hoyos
On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : Hi! Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. Please comment, Carl Eugen diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-17 Thread Carl Eugen Hoyos
On Thursday 17 July 2014 09:41:40 pm Nicolas George wrote: Le nonidi 29 messidor, an CCXXII, Carl Eugen Hoyos a écrit : Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. I would suggest to avoid floating point arithmetic if possible. Possibly something like

[FFmpeg-devel] [PATCH]Parse dri in rtp jpeg

2014-07-18 Thread Carl Eugen Hoyos
Hi! Attached completely untested patch is based on the file attached to ticket #3780. Please review, Carl Eugen diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index 80fe295..ccd80ad 100644 --- a/libavformat/rtpdec_jpeg.c +++ b/libavformat/rtpdec_jpeg.c @@ -106,7 +106,8 @@

Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection

2014-07-21 Thread Carl Eugen Hoyos
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: This patch has a strange side effect. With it gst-libav1.0 (version 1.3.2) gets compiled incorrectly so that when the plugin is loaded by gstreamer it segfaults: ERROR: Caught a segmentation fault while loading plugin file:

Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection

2014-07-21 Thread Carl Eugen Hoyos
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: Program received signal SIGSEGV, Segmentation fault. 0x7601202c in gst_ffmpegdemux_register (plugin=0x62c2c0) at gstavdemux.c:1942 1942 if (!strncmp (in_plugin-long_name, raw , 4) Could you test (a version that

Re: [FFmpeg-devel] [PATCH] mjpegdec: add 0x14121200 pixel format support

2014-07-22 Thread Carl Eugen Hoyos
Przemysław Sobala pszemus at wp-sa.pl writes: Patch adds support for 0x14121200 pixel format to MJPEG decoder. I can deliver a sample image but don't know where upload to? Please provide a sample, either upload to http://www.datafilehost.com/ or read https://ffmpeg.org/bugreports.html

[FFmpeg-devel] [PATCH]Print a warning if the invalid tiff tag type 0 is found in an exif tag

2014-07-22 Thread Carl Eugen Hoyos
Hi! FFmpeg currently requests a sample if an exif tag with tag type 0 is found. Attached patch prints a warning instead, fixes ticket #3792. Please comment, Carl Eugen diff --git a/libavcodec/exif.c b/libavcodec/exif.c index a980da2..fa30f05 100644 --- a/libavcodec/exif.c +++ b/libavcodec/exif.c

Re: [FFmpeg-devel] [PATCH] mjpegdec: add 0x14121200 pixel format support

2014-07-22 Thread Carl Eugen Hoyos
Przemysław Sobala pszemus at wp-sa.pl writes: sample input file: http://www.datafilehost.com/d/8ef264ae Uploaded as http://samples.ffmpeg.org/image-samples/14121200.jpg Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]Fix compilation with nasm

2014-07-22 Thread Carl Eugen Hoyos
Hi! Attached patch fixes compilation with nasm (and passes fate) here, sorry if it is complete nonsense. Please review, Carl Eugen diff --git a/libavcodec/x86/hevc_deblock.asm b/libavcodec/x86/hevc_deblock.asm index 395b20e..01a5250 100644 --- a/libavcodec/x86/hevc_deblock.asm +++

Re: [FFmpeg-devel] [PATCH]Fix compilation with nasm

2014-07-22 Thread Carl Eugen Hoyos
On Wednesday 23 July 2014 12:43:06 am Ronald S. Bultje wrote: Hi, On Tue, Jul 22, 2014 at 5:45 PM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Hi! Attached patch fixes compilation with nasm (and passes fate) here, sorry if it is complete nonsense. You probably want movd m13, betad

Re: [FFmpeg-devel] [PATCH]Fix compilation with nasm

2014-07-23 Thread Carl Eugen Hoyos
Mickaël Raulet mraulet at gmail.com writes: Subject: [PATCH] avcodec/x86/hevc_deblock: Fix compilation with nasm. LGTM ok Patch applied. Thanks everybody, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-24 Thread Carl Eugen Hoyos
On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: Hi! Attached patch fixes ticket #3777 for me, analyzed by Oliver Fromme. What about streaming growing files? It's pretty good to know number of frames of the complete mp3 at start

Re: [FFmpeg-devel] [PATCH]Ignore xing number of frames if filesize is wrong

2014-07-24 Thread Carl Eugen Hoyos
On Thursday 24 July 2014 03:00:02 pm Michael Niedermayer wrote: On Thu, Jul 24, 2014 at 12:50:55PM +0200, Carl Eugen Hoyos wrote: On Saturday 19 July 2014 04:40:47 pm Joakim Plate wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: Hi! Attached patch fixes ticket #3777 for me

[FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-27 Thread Carl Eugen Hoyos
Hi! Some DVD dumps contain subtitles that start after more than 2G, attached patch should allow to specify sufficiently large values for -probesize. Please review, Carl Eugen diff --git a/doc/APIchanges b/doc/APIchanges index c4e7790..e114df4 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-28 Thread Carl Eugen Hoyos
Oliver Fromme oliver at fromme.com writes: That's why I appreciate the patch very much that Carl Eugen has created. Did you test the patch? I think it will not get applied without a test. [...] Maybe I'll try to make a patch that can do this If you consider to invest time in DVD reading,

Re: [FFmpeg-devel] rectification filter

2014-07-28 Thread Carl Eugen Hoyos
Daniel Oberhoff danieloberhoff at gmail.com writes: + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License Your patch is missing a configure hunk that makes sure that the filter is only compiled if --enable-gpl was

Re: [FFmpeg-devel] rectification filter

2014-07-29 Thread Carl Eugen Hoyos
Daniel Oberhoff danieloberhoff at gmail.com writes: OBJS-$(CONFIG_ZOOMPAN_FILTER)+= vf_zoompan.o +OBJS-$(CONFIG_RECTIFICATION_FILTER) += vf_rectification.o REGISTER_FILTER(ZOOMPAN,zoompan,vf); +REGISTER_FILTER(RECTIFICATION, rectification,

Re: [FFmpeg-devel] [RFC]Add int64_t probesize2 to AVFormatContext

2014-07-29 Thread Carl Eugen Hoyos
Oliver Fromme oliver at fromme.com writes: http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/104257/focus=140297 That thread seems to center on DVD playback with ffplay, including menu navigation. My goal is to enable ffmpeg to be able read one title from a DVD and encode it. I

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: refuse to configure input without a decoder.

2014-07-30 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: LGTM Ping. Please add a comment about ticket #3779 to the commit message. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] rectification filter

2014-08-01 Thread Carl Eugen Hoyos
Daniel Oberhoff danieloberhoff at gmail.com writes: all work now, except vuy444p It's yuv444p Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] rectification filter

2014-08-01 Thread Carl Eugen Hoyos
Daniel Oberhoff danieloberhoff at gmail.com writes: And how about that test/data/fate/filter-pixfmts-rectification.rep file? Imo, please send a patch without fate test first, this can still be done. Did you already explain if / how this filter is different from / better than the vignette

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-05 Thread Carl Eugen Hoyos
On Friday 01 August 2014 10:04:17 am Clément Bœsch wrote: On Fri, Aug 01, 2014 at 01:54:57AM +0200, Carl Eugen Hoyos wrote: When transcoding an input file with subtitles to mkv, ffmpeg by default tries to encode the subtitles even if the input contains bitmap subtitles. Attached patch

Re: [FFmpeg-devel] [PATCH]Make loas probe more similar to mp3 probe

2014-08-06 Thread Carl Eugen Hoyos
On Tuesday 05 August 2014 10:28:38 pm Carl Eugen Hoyos wrote: Attached patch copies one line from mp3dec.c into loasdec.c to force probing more data and fixes ticket #3821. An alternative is to remove the offending line from mp3dec.c (it was added in 2006 or earlier). I was unhappy about

Re: [FFmpeg-devel] LFEScaleIndex larger than 127 is not implemented

2014-08-06 Thread Carl Eugen Hoyos
Adrien Montfort adrien.montfort at idol.io writes: I’ve uploaded the file 664461_flac_16_44100_2.wav I have opened ticket #3830, thank you for the sample! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]Do not mux invalid hevc into transport streams

2014-08-07 Thread Carl Eugen Hoyos
Hi! Attached patch checks if the hevc stream contains a startcode when muxed into transport streams. Please review, Carl Eugen diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index c286249..4259318 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1157,6

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: should be ok Please merge from github. but why does dvb teletext not have a TEXT/BITMAP prop ? I believe this would break avcodec_decode_subtitle2() which sets the format depending on the properties. This should be fixed but I don't know the

[FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Carl Eugen Hoyos
Hi! Attached patch should allow to set the teletext decoder properties to (AV_CODEC_PROP_TEXT_SUB | AV_CODEC_PROP_BITMAP_SUB). Please comment, Carl Eugen diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 6071380..3db2a1c 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@

Re: [FFmpeg-devel] [PATCH]Make subtitle properties code in lavc more robust

2014-08-07 Thread Carl Eugen Hoyos
Marton Balint cus at passwd.hu writes: So before applying this patch, I think we should decide what these properties mean exactly... I have no opinion on this, just wanted to show why (imo) libzvbi cannot currently have other properties. Carl Eugen

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-08 Thread Carl Eugen Hoyos
Alessio Treglia alessio at debian.org writes: Many Jessie's multimedia framework and packages have been developed and QA'd with libav. Could you name one framework or package that does not work with FFmpeg (or does not have less bugs with FFmpeg than with avconv libraries)? I have never

[FFmpeg-devel] [PATCH]Remove panscan information in av_frame_copy_props() if resolution changes

2014-08-10 Thread Carl Eugen Hoyos
Hi! Attached is a new variant of [RFC]Remove panscan side data in filters that change the resolution. I don't know how to correctly set the information based on the resolution change, as-is this patch works around ticket #3750 (a regression). Please comment, Carl Eugen diff --git

Re: [FFmpeg-devel] [RFC]Slightly extend the -r input option documentation

2014-08-12 Thread Carl Eugen Hoyos
Timothy Gu timothygu99 at gmail.com writes: +This is not the same as the framerate option used +for some input formats Aside from Lou's comment, you can list some examples for the input formats that have the option. I am slightly against listing examples because that would only add to

Re: [FFmpeg-devel] [PATCH] ffmpeg 0.10.x set correct bit rate in riff wav headers

2014-08-12 Thread Carl Eugen Hoyos
Wilfried Weissmann wweissmann at realnetworks.com writes: The attached patch fixes incorrect bit rate values in riff headers when a conversion is done from 16 bit samples to alaw. From: user user@localhost.localdomain This doesn't look correct, did you use git cherry-pick -x? Carl Eugen

Re: [FFmpeg-devel] [PATCH] ffmpeg 0.10.x set correct bit rate in riff wav headers

2014-08-12 Thread Carl Eugen Hoyos
Wilfried Weissmann wweissmann at realnetworks.com writes: I did cherry-pick from http://git.videolan.org/?p=ffmpeg.git;a=commit;h=7d7b40f4 to my local repo and applied it to the 0.10 branch. I assumed the test/ref/... are for unit tests and included these changes too. Is that what you are

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Carl Eugen Hoyos
Mark Reid mindmark at gmail.com writes: I got the ULs from FMbc version of mxf.c Sounds like this could be added to the commit message. I tested it out on the follow media submitted by users reporting this problem ticket #1554 ticket #3100 ticket #3450 Mentioning these tickets in the

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-14 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: Carl, do you want the fallback to work just when pkg-config is not available I believe this would still leave some use-cases unsolved. or do you actually want a real fallback when it is present but didn't succeed? This is the preferred solution imo.

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-15 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: No it won't work because require_pkg_config dies if it fails, so you can fallback after it. True. Of course we can add another require_pkg_config2() that takes some explicit linking flags in addition to the user ones as a fallback. Sounds useful to me.

[FFmpeg-devel] [PATCH]Fix remote ffprobe fate tests

2014-08-16 Thread Carl Eugen Hoyos
Hi! I cannot really test but I hope attached patch fixes the remaining fate tests that don't work on remote fate targets. Please review and push, Carl EugenFrom 5c2e7283bb1db659246da10d6f1f078123497207 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos ceho...@ag.or.at Date: Sat, 16 Aug 2014 12

Re: [FFmpeg-devel] [PATCH 0/2] Fix ALAC encoder for 24bps

2014-08-17 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: If this is related to ticket #2768, please mention it in the commit message. Sorry, please disregard... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-18 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: An alternative would be to select the profile based on the pixel format. What would be the disadvantage in this case? If a user wants to encode without alpha, he would then need to change the pixel format as well as specify the

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: do not fail when VIDIOC_ENUMSTD returns ENODATA

2014-08-18 Thread Carl Eugen Hoyos
Andre Wolokita andre.wolokita at analog.com writes: -if (ret == AVERROR(EINVAL)) { +if (ret == AVERROR(EINVAL) || ret == AVERROR(ENODATA)) { If I read fate correctly this broke compilation on OpenBSD where ENODATA isn't defined. Carl Eugen

Re: [FFmpeg-devel] [RFC] removing libmpcodecs for reuniting purposes.

2014-08-18 Thread Carl Eugen Hoyos
Ivan Kalvachev ikalvachev at gmail.com writes: softpulldown - turns soft into hard telecine. Do you remember how this filter was used with MEncoder? I have a suspicion that it cannot work with FFmpeg. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-18 Thread Carl Eugen Hoyos
Deti Fliegl deti at fliegl.de writes: +/* free() is needed for a string returned by the DeckLink SDL. */ +#undef free I believe this is not needed anymore but ... +free((void *) tmpDisplayName); ... please move the comment here. Is the cast necessary? +av_log(NULL,

[FFmpeg-devel] [PATCH]Do not ask for mxf samples with unknown field dominance

2014-08-18 Thread Carl Eugen Hoyos
Hi! Attached patch removes a request for samples of which we already have several that all work fine. Please comment, Carl Eugendiff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7a4633f..aabae69 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1603,9 +1603,6 @@

[FFmpeg-devel] [PATCH]Set H264 bitrate

2014-08-18 Thread Carl Eugen Hoyos
Hi! Attached patch from MIKEH / Elemental is apparently meant to implement setting h264 bitrate. It makes no difference for the sample from ticket #3392. I have no idea how to attribute the patch. Please comment, Carl Eugendiff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index

[FFmpeg-devel] [PATCH]Fix maximum wma superframe size

2014-08-18 Thread Carl Eugen Hoyos
Hi! Attached patch from Elemental increases the maximum superframe size, I don't know if this fixes any samples. The original patchfile contains no further attribution. Please comment, Carl Eugendiff --git a/libavcodec/wma.h b/libavcodec/wma.h index c4056ec..37be627 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/isom: add ni24 typo/alias for in24

2014-08-18 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: +{ AV_CODEC_ID_PCM_S24BE, MKTAG('n', 'i', '2', '4') }, BBC typo */ +{ AV_CODEC_ID_PCM_S24LE, MKTAG('n', 'i', '2', '4') }, /* BBC typo */ Doesn't this patch make absolutely sure that the same files that didn't work before this patch (and

Re: [FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

2014-08-19 Thread Carl Eugen Hoyos
James Almer jamrial at gmail.com writes: +static void unpack_yuv(TiffContext *s, AVFrame *p, + const uint8_t *src, int lnum) -static void unpack_yuv(TiffContext *s, AVFrame *p, - const uint8_t *src, int lnum) If you want you could split the moving

Re: [FFmpeg-devel] [PATCH] avformat/isom: add ni24 typo/alias for in24

2014-08-19 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: On Mon, Aug 18, 2014 at 11:39:26PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: +{ AV_CODEC_ID_PCM_S24BE, MKTAG('n', 'i', '2', '4') }, BBC typo */ +{ AV_CODEC_ID_PCM_S24LE, MKTAG('n', 'i', '2', '4

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-08-19 Thread Carl Eugen Hoyos
Deti Fliegl deti at fliegl.de writes: Minor update to propagate field dominance. At least a Changelog entry and a libavdevice version bump are still missing, but consider waiting for a real review. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-20 Thread Carl Eugen Hoyos
Marc-Antoine Arnaud marcantoine.arnaud at arkena.com writes: +if (st-codec-rc_max_rate 0) { +if (INT_MAX - st-codec-rc_max_rate bit_rate) { +bit_rate = 0; +break; +} +bit_rate +=

Re: [FFmpeg-devel] [PATCH 0/5] RGB48/64 with bits_per_raw_sample

2014-08-20 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: Depending on the input and/or filters, you sometime have an input or output pixel format like rgb48le(12 bpc). Unfortunately, most often, the 12 bpc information is ignored or stripped. Could you explain what command line you are

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO henry0312 at gmail.com writes: I added support of ARIB subtitles to mpegts in libavformat. Shouldn't you add ARIB to DESC_types[]? Could you provide samples for both types? (Ideally even for all stream_identifiers but I guess this isn't possible.) Carl Eugen

[FFmpeg-devel] [PATCH]Fail in h264 nal unit decoding if slice header decoding failed

2014-08-21 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3873 here, I don't know if it has any unexpected side-effects. Please review, Carl Eugen diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 389307b..2b299bc 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1585,8 +1585,11 @@ again:

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO henry0312 at gmail.com writes: Shouldn't you add ARIB to DESC_types[]? I don't know which ISO_types or DESC_types I should add to. Do you think DESC_types is better? I probably mixed up stream descriptions and stream identifiers, so ignore this suggestion. But I believe you

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: More complete cleanup in h264_slice_header_init()

2014-08-21 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: Fixes null pointer dereference Fixes Ticket3873 Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Do not show an unreadable error code if mov header parsing fails

2014-08-23 Thread Carl Eugen Hoyos
On Sunday 24 August 2014 12:50:14 am Michael Niedermayer wrote: On Sat, Aug 23, 2014 at 02:02:49PM +0200, Carl Eugen Hoyos wrote: Hi! I don't think showing -1094995529 or similar makes much sense. The calling application can still decide to show the error string (as ffmpeg does

Re: [FFmpeg-devel] [PATCH 0/5] RGB48/64 with bits_per_raw_sample

2014-08-23 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: 2014-08-20 20:26 GMT+02:00 Carl Eugen Hoyos: Christophe Gisquet writes: Depending on the input and/or filters, you sometime have an input or output pixel format like rgb48le(12 bpc). Unfortunately, most often, the 12 bpc

[FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Hi! Attached patch fixes pnm encoding for me if bits_per_raw_sample is set to a value different from the pix_fmt's native value. Please comment, Carl Eugen diff --git a/libavcodec/pnmenc.c b/libavcodec/pnmenc.c index 9198ddb..8f74459 100644 --- a/libavcodec/pnmenc.c +++ b/libavcodec/pnmenc.c @@

Re: [FFmpeg-devel] [PATCH 0/5] RGB48/64 with bits_per_raw_sample

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: The sanest thing to do (and that you are hinting at) is to just drop it. I thought that 2/5 is not correct (but wasn't sure). Patch sent, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: -if( avctx-bits_per_raw_sample ) +if ( avctx-bits_per_raw_sample + av_pix_fmt_desc_get(avctx-pix_fmt)-comp[0].depth_minus1 7) maxdepth = (1 avctx-bits_per_raw_sample) - 1; So

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: Otherwise, this shift would undo scaling performed elsewhere or actually remove bits from the actual value, which would be incorrect. It would undo the shift done in the decoder because we (luckily!!) do not have PIX_FMT_RGB12 and

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: Attached patch fixes pnm encoding for me if bits_per_raw_sample is set to a value different from the pix_fmt's native value. I should have mentioned that this was planned as a [RFC] since I am not completely convinced we want this but current

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: Hi, 2014-08-24 12:48 GMT+02:00 Carl Eugen Hoyos cehoyos at ag.or.at: I think [PATCH 2/5] pnmenc: use bits_per_raw_sample is wrong then Definitely, I still wonder how you tested it. ljpeg 36bits from #2966 and having

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-24 Thread Carl Eugen Hoyos
Christophe Gisquet christophe.gisquet at gmail.com writes: - ffmpeg's and yours (if I'm not mistaken): the signal bitdepth should always match the colorspace one, and bits_per_raw_sample should indicate the original bitdepth I believe that my opinion is mostly irrelevant but that FFmpeg's

Re: [FFmpeg-devel] [PATCH/RFC] avutil/pixelutils: port ppc/altivec sad functions

2014-08-24 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: +OBJS-$(CONFIG_PIXELUTILS) += ppc/pixelutils_init.o + ALTIVEC-OBJS += ppc/float_dsp_altivec.o \ +ALTIVEC-OBJS-$(CONFIG_PIXELUTILS) += ppc/pixelutils_altivec.o \ Something is wrong here, I suspect the \ have to be

Re: [FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain

2014-08-27 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: tests/lena.pnm | 109 - My suggestion would be to only remove it from the release branche(s). If necessary, the tests can be changed so that they copy lena from the fate-suite or from the tests directory to

Re: [FFmpeg-devel] OpenEXR update and question

2014-08-27 Thread Carl Eugen Hoyos
Gonzalo Garramuno ggarra13 at gmail.com writes: I am asking here if my reasoning is correct and what would the best approach be. Please provide a failing sample. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-27 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: Currently no relevant codecs use 12 bits, which is the reason why 9 and 10 bits exist as separate formats while 12 bits does not. Do you believe that x264 code would have to be less efficient than it is now if the 9 and 10 bit

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Carl Eugen Hoyos
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: But I'm fine with moving lena.pnm to the FATE samples, which are downloaded with 'make fate-rsync'. Attached patch removes tests/lena.pnm and adapts the tests, assuming lena.pnm would be added to the top-level of the SAMPLES

Re: [FFmpeg-devel] [RFC] Bug bounties

2014-08-28 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: I was thinking about if we should put an automatic 50 USD bounty on every bug thats open since more than 12 month on trac, and limited to the first 20 claims so its limited to 1000 USD max expenses for us (for now) I believe this is a good

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-28 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: Did you try the patch with pkg-config only detection? And try to add --pkg-config=true to trick the detect function. So, I did try myself Sorry, I was away and still didn't test all new tickets. [~/src/ffmpeg]☭ dash ./configure --disable-everything

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-08-28 Thread Carl Eugen Hoyos
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: But I'm not sure what copying it to tests/data would be good for? So people can still run the limited tests without downloading the whole fate suite. Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] Add SUP (raw BluRay PGS subtitle) muxer

2014-08-29 Thread Carl Eugen Hoyos
Petri Hintukainen phintuka at gmail.com writes: From: Petri Hintukainen phintuka at users.sourceforge.net Fixes ticket #2208 Do I understand correctly that the produced files are compatible with eac3to? Are there other programs that accept these files? Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 2/2] Add missing const all over the place.

2014-08-29 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: There is a risk that one in the code that is not always compiled might break things. We will only find out if you push;-) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-08-29 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: Fix trac ticket #2674. libavfilter/vf_fps.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) probably ok Ping? (I didn't test myself.) Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] added synchronous KLV codec ID and mpegts PAT and PMT descriptors as specified in stanag4609 annex C

2014-08-29 Thread Carl Eugen Hoyos
paolovergori webinostestbed at gmail.com writes: +AV_CODEC_ID_SMPTE_KLV_SYNC = MKBETAG('K','L','V','S'), Please just add this line, do not reindent the other defines, at least not in the same commit. { MKTAG('K','L','V','A'), AVMEDIA_TYPE_DATA, AV_CODEC_ID_SMPTE_KLV }, +{

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Carl Eugen Hoyos
Peter Kasting pkasting at google.com writes: The attached patch fixes instances of MSVC warning C4244 about possible value truncation (e.g. when assigning double to float or int64_t to int). This warning is currently disabled in Chromium's MSVC build and I'm trying to enable it. Why?

[FFmpeg-devel] [PATCH]Clean up if filter initialisation failed

2014-08-29 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a memleak with ffmpeg if the filter initialisation fails, fixes ticket #3858 for me. Please review, Carl Eugen diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c index b6dc42f..7acff28 100644 --- a/ffmpeg_filter.c +++ b/ffmpeg_filter.c @@ -898,8 +898,11 @@ int

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: Second, I believe powf and sinf are less commonly available than pow and sin, so I think this will break compilation on some platforms I fear this is correct. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Clean up if filter initialisation failed

2014-08-31 Thread Carl Eugen Hoyos
Nicolas George george at nsup.org writes: Please mention in the commit short message that it is about the command-line tools and not the library; maybe ffmpeg: clean up if Merged by Michael with that change. Thank you, Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-31 Thread Carl Eugen Hoyos
compn tempn at mi.rr.com writes: will try to dig some more. sup samples are attached to ticket #2208, the original file is in http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket2208/ Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Carl Eugen Hoyos
wm4 nfxjfg at googlemail.com writes: +avio_rb32(s-pb); /* discard DTS (usually 0, and useless) */ Would it be an option to set it dts to AV_NOPTS_VALUE if this value is 0 but use the value otherwise? Or is there no advantage? +full_packet_size = AV_RB16(buf + 10 + 1) + 10 + 3; +

Re: [FFmpeg-devel] [PATCH] build: simplify libwebp check

2014-09-01 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: From: Clément Bœsch clement at stupeflix.com Check is simpler, faster, and explicits the required version. faster? Please remove this if I don't miss anything again... [...] The check is already using pkg-config Sorry about my earlier comment... I

[FFmpeg-devel] [PATCH]Print bits_per_raw_sample for ffprobe -show_streams

2014-09-02 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3919 for me. Please comment, Carl Eugen diff --git a/ffprobe.c b/ffprobe.c index 2d48070..34c7f1e 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2170,6 +2170,7 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id else

Re: [FFmpeg-devel] [PATCH]Print the actual bit depth for audio if it is different from the sample_fmt bit depth

2014-09-03 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: +if (enc-bits_per_raw_sample != av_get_bytes_per_sample(enc-sample_fmt) * 8) Locally changed to bits_per_raw_sample 0 ... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet'sfilter_line()

2014-09-03 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: silly question: how do you compile for x86-32? I tried './configure --arch=x86_32' but it didn't trigger this compile error... iam using: --arch=x86_32 --target-os=linux --extra-cflags=-m32 --extra-ldflags=-m32 --enable-cross-compile

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-04 Thread Carl Eugen Hoyos
Kieran Kunhya kierank at obe.tv writes: In general you should not be probing if there are descriptors because the descriptors are designed to make the codec detection unambiguous. I thought it should be exactly the other way around if the probing returns a sufficiently high score:

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-04 Thread Carl Eugen Hoyos
Kieran Kunhya kierank at obe.tv writes: In general you should not be probing if there are descriptors because the descriptors are designed to make the codec detection unambiguous. I thought it should be exactly the other way around if the probing returns a sufficiently high score:

Re: [FFmpeg-devel] [PATCH] fix vf_idet new files' license header - LGPL

2014-09-05 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: While at it, can you fix your username in git config? skal doesn't have any legal value and can cause problems in the future. I don't know French law but for Austria, this is simply wrong. (Is it on the contrary not allowed here to change the name in the

[FFmpeg-devel] [RFC]Revert the default for ffplay to -noautoexit

2014-09-07 Thread Carl Eugen Hoyos
Hi! I have no strong opinion on this but I wonder if ffplay isn't primarily a test application for which it is very useful not to exit. Please comment, Carl Eugen diff --git a/ffplay.c b/ffplay.c index 06bccce..833b5b1 100644 --- a/ffplay.c +++ b/ffplay.c @@ -311,7 +311,7 @@ static int fast =

Re: [FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-08 Thread Carl Eugen Hoyos
Gaullier Nicolas nicolas.gaullier at arkena.com writes: case 0x3212: descriptor-field_dominance = avio_r8(pb); +descriptor-field_dominance_present = 1; Is it possible to instead initialize descriptor-field_dominance to MXF_TFF? case SeparateFields: +

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-09-08 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: Fix trac ticket #2674. Signed-off-by: Nicolas George george at nsup.org --- libavfilter/vf_fps.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) probably ok Should this get pushed? Carl

Re: [FFmpeg-devel] [PATCH] web/contact: replace MPlayer guidelines link

2014-09-11 Thread Carl Eugen Hoyos
Lou Logan lou at lrcd.com writes: - a href=http://www.mplayerhq.hu/DOCS/tech/patches.txt; MPlayer patch guidelines/a I understand that this is not ideal but ... + a href=git-howto.htmlUsing git to develop FFmpeg/a ... while this contains a lot of useful information it is missing (nearly)

Re: [FFmpeg-devel] Fix bug for POWER8 LE for the test '/libavutil/float_altivec-test'

2014-09-11 Thread Carl Eugen Hoyos
Timothy Gu timothygu99 at gmail.com writes: +t1 = vec_perm(d, edges, vcprm(s0,s1,s2,s3)); +t0 = vec_perm(edges, d, vcprm(s0,s1,s2,s3)); ...you are using the old variable names, which I am pretty sure won't compile. I cannot explain why but it compiles and passes fate

Re: [FFmpeg-devel] [PATCH] web/contact: replace MPlayer guidelines link

2014-09-11 Thread Carl Eugen Hoyos
James Darnley james.darnley at gmail.com writes: Point 2, unified diffs, is covered by out request for patches. Are we doing to allow git diff dumps? While I always send unified diffs, some people (still) send other diffs, and one regular contributor sends diffs in his own format, so this

Re: [FFmpeg-devel] [PATCH] web/contact: replace MPlayer guidelines link

2014-09-11 Thread Carl Eugen Hoyos
Lou Logan lou at lrcd.com writes: Anyway, we also have the quite verbose http://ffmpeg.org/developer.html But you did not replace the MPlayer link by this link but by one that explains git usage which I consider important but different. Carl Eugen

[FFmpeg-devel] [PATCH]Add a closing CRLF to Webm-manifest files

2014-09-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes fate-webm-dash-manifest on aix. I cannot reproduce the problem on other systems and I don't know if the patch is correct. Please comment, Carl Eugen diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 77f6170..849b241 100644 ---

Re: [FFmpeg-devel] [PATCH]Add a closing CRLF to Webm-manifest files

2014-09-11 Thread Carl Eugen Hoyos
Carl Eugen Hoyos cehoyos at ag.or.at writes: Attached patch fixes fate-webm-dash-manifest on aix. This is the failure: $ gmake SAMPLES=fate-suite/ fate-webm-dash-manifest TESTwebm-dash-manifest diff: Missing newline at the end of file tests/data/fate/webm-dash-manifest. --- ./tests/ref

Re: [FFmpeg-devel] Branchpoint tags

2014-09-16 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: Should we add git tags to the revissions where releases are branched off ? Yes please, this would make my life much easier. n2.5-dev sounds ok. Carl Eugen ___ ffmpeg-devel mailing list

  1   2   3   4   5   6   7   8   9   10   >