Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-28 Thread Felix Matouschek
Sorry... tested it again, it does not break the default compilation. The library check in the configure script just fails and the indev is not included when using the broken NDK. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-28 Thread Felix Matouschek
Am 28.11.2017 14:01, schrieb Carl Eugen Hoyos: The patch breaks default compilation for Android? Actually... you are right, it does. It's a bit unfortunate as the header file in the NDK is broken. We can't work around that in ffmpeg, the NDK needs to be fixed. As soon as you include

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-30 Thread Felix Matouschek
Am 30.11.2017 14:48, schrieb Michael Niedermayer: You mean avg_frame_rate and r_frame_rate? The framerate can vary between the values in framerate_range[0] (min) and framerate_range[1] (max). Ideally both values are the same, sometimes min can be lower but for the average the framerate should be

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-30 Thread Felix Matouschek
Am 29.11.2017 04:31, schrieb Michael Niedermayer: if the identifer and the string always match you could do this with a macro avoiding the neede to duplcate each string see AV_STRINGIFY I changed it, is it ok like this? [...] +static int add_video_stream(AVFormatContext *avctx) +{ +

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-30 Thread Felix Matouschek
Sorry, my mail client swallowed the attachment, sent it again. 0001-avdevice-add-android_camera-indev.patch Description: Binary data > Am 30.11.2017 um 10:12 schrieb Felix Matouschek <fe...@matouschek.org>: > > Am 29.11.2017 04:31, schrieb Michael Niedermayer: > &

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-27 Thread Felix Matouschek
Am 22.11.2017 00:20, schrieb Michael Niedermayer: On Tue, Nov 21, 2017 at 08:16:08AM +0100, Felix Matouschek wrote: No more interest? If you hear no more comments for another week, then please ping this with CC to me and ill take a look and apply unless i spot some major issue also you

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-19 Thread Felix Matouschek
Am 19.12.2017 um 21:19 schrieb James Almer : > > Pushed. > > Wouldn't this need to be done for vp8 as well, for that matter? > At least on Android using libvpx 1.6.1 it was not needed for vp8, only for vp9. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-12-19 Thread Felix Matouschek
Hello Michael, could you take a look at the patch? Felix > Am 30.11.2017 um 18:15 schrieb Michael Niedermayer <mich...@niedermayer.cc>: > > On Thu, Nov 30, 2017 at 10:15:48AM +0100, Felix Matouschek wrote: >> Sorry, my mail client swallowed the attachment, sent it again

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-19 Thread Felix Matouschek
Any chance this could get merged? > Am 12.12.2017 um 15:53 schrieb Felix Matouschek <fe...@matouschek.org>: > > Am 12.12.2017 15:37, schrieb James Almer: >> No, this is not correct. If anything has to be added here, it would be >> $libm_extralibs. -lm is not neede

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-10 Thread Felix Matouschek
Hello, here is a new version of the patch with further fixes. Greetings, Felix 0001-avdevice-add-android_camera-indev.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-13 Thread Felix Matouschek
Ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-20 Thread Felix Matouschek
No more interest? Am 02.11.2017 13:42, schrieb Felix Matouschek: Hello, I've written an indev for Android devices to allow capturing their builtin cameras. What needs to be done to merge this? Greetings, Felix ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-03 Thread Felix Matouschek
Hello, Am 02.11.2017 um 14:40 schrieb Nicolas George: When reading the subject of the mail, I first thought it would be about screen capture. Furthermore, there is code for audio, but it is not connected to anything, and it does not seem that the android API connects audio and video together.

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-07 Thread Felix Matouschek
Hello, I tried to address all issues. I did not have time yet to try more image formats, so it is still only YUV420P. Please review. Greetings, FelixFrom a235f56518fc1f11698a5028dfd4b654989993c5 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org> Date: Tue, 24 Oct 2

[FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-02 Thread Felix Matouschek
Hello, I've written an indev for Android devices to allow capturing their builtin cameras. What needs to be done to merge this? Greetings, FelixFrom b21fc8729ef2e1d9867dd7652f2c6173378e4910 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org> Date: Tue, 24 Oct 2017 13

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-07 Thread Felix Matouschek
Am 02.11.2017 16:20, schrieb Daniel Kučera: some devices have cameras which are unlisted - this condition makes them unusable. How does one use unlisted devices? As far as I understood all supported devices are listed. If the Camera2 API does not support the camera it cannot be used.

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-07 Thread Felix Matouschek
> Am 07.11.2017 um 16:17 schrieb Daniel Kučera : > > It's used like here: > https://github.com/danielkucera/ZidoStreamer/blob/master/app/src/main/java/eu/danman/zidostreamer/zidostreamer/StreamService.java#L62 > > If I open standard streaming or camera app, no camera is

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-12-08 Thread Felix Matouschek
).From 80182b2ec0c2fc76584c71a7138c58b4716d5d5f Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org> Date: Fri, 8 Dec 2017 10:43:51 +0100 Subject: [PATCH] avdevice: add android_camera indev To: ffmpeg-devel@ffmpeg.org This commit adds an indev for Android devices on API le

[FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-12 Thread Felix Matouschek
This fixes the detection of the vp9 decoder/encoder. The vp9 decoder/encoder needs libm to successfully link, -lm was missing in the check_lib calls for vp9 in configure.From 0b5bbd7c30f3a76b2e0ab6ceae2bfaebe944b279 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org>

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-12 Thread Felix Matouschek
for your system. This shitty fallback shouldn't be here in the first place, but some people are too stubborn about it. The Android NDK has no pkg-config so it is somehow useful.From b2f30f087aaf7d1284ebe08a09adc478df80ba22 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org>

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2018-02-20 Thread Felix Matouschek
I rebased the patch on the current master, it does apply again. Tested it - still works. Felix Am 19.02.2018 20:39, schrieb Michael Niedermayer: On Mon, Feb 19, 2018 at 08:39:56AM +0100, Felix Matouschek wrote: Hello Michael, do you think the patch could be merged in its current state

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2018-02-18 Thread Felix Matouschek
Hello Michael, do you think the patch could be merged in its current state? It is functional, maybe I can do the cosmetic changes later. I was a bit busy the last weeks. Would be nice if it could get into the 3.5 / 4.0 release. Felix Am 02.01.2018 10:23, schrieb Felix Matouschek: Am

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2018-01-02 Thread Felix Matouschek
> Am 28.12.2017 um 19:20 schrieb Michael Niedermayer : >> >> +av_image_copy_to_buffer(pkt.data, pkt_buffer_size, >> +(const uint8_t * const *) image_plane_data, >> +image_linestrides, ctx->image_format, >> +

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-12-22 Thread Felix Matouschek
Hello Michael, I fixed the things you mentioned. New patch attached. Felix ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-12-22 Thread Felix Matouschek
Am 22.12.2017 20:50, schrieb Lou Logan: I think you forgot to attach the patch. Sorry, flaky mail client... attached it again.From ba2ccca1200a55b0f1c0331ebd6d26324941fb2e Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org> Date: Fri, 22 Dec 2017 20:10:41 +0100 S

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-12-27 Thread Felix Matouschek
Ping > Am 22.12.2017 um 21:36 schrieb Felix Matouschek <fe...@matouschek.org>: > > Am 22.12.2017 20:50, schrieb Lou Logan: >> I think you forgot to attach the patch. > > Sorry, flaky mail client... attached it again. __

[FFmpeg-devel] [PATCH] Fix iterating of input and output devices

2018-03-14 Thread Felix Matouschek
This fixes the iterating of input and output devices In the previous implementation the first input or output device was skipped when device_next was called with prev = NULLFrom f90823e8dccf5751e88b8990f5789d8f67e7c496 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org>

Re: [FFmpeg-devel] [PATCH] Fix iterating of input and output devices

2018-03-14 Thread Felix Matouschek
g list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-develFrom cd8842ecf606d368832066fcda925c705e9e9205 Mon Sep 17 00:00:00 2001 From: Felix Matouschek <fe...@matouschek.org> Date: Wed, 14 Mar 2018 13:14:07 +0100 Subject: [PATCH] Fix iterating of input and output device