Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread James Zern
On Fri, Aug 22, 2014 at 10:53 AM, Deb Mukherjee debar...@google.com wrote: [...] @@ -311,7 +316,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, } else { if (enccfg.rc_end_usage == VPX_CQ) { enccfg.rc_target_bitrate = 100; -} else { +}

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread James Zern
On Tue, Aug 26, 2014 at 10:30 AM, Deb Mukherjee debar...@google.com wrote: Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-03-27 Thread James Zern
On Fri, Mar 27, 2015 at 6:58 PM, Debargha Mukherjee debar...@google.com wrote: [...] +#if CONFIG_LIBVPX_VP9_ENCODER defined(VPX_IMG_FMT_HIGHBITDEPTH) +static int set_pix_fmt(AVCodecContext *avctx, struct vpx_codec_enc_cfg *enccfg, + vpx_codec_flags_t *flags,

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-04-20 Thread James Zern
On Sat, Apr 18, 2015 at 1:06 PM, James Zern jz...@google.com wrote: On Thu, Apr 16, 2015 at 6:19 PM, Debargha Mukherjee debar...@google.com wrote: Resolutions inline... From d84e140ed83bdc3889720e4a6af330198176b839 Mon Sep 17 00:00:00 2001 From: Deb Mukherjee debar...@google.com Date: Wed

Re: [FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
On Wed, Apr 22, 2015 at 8:59 PM, James Zern jz...@google.com wrote: s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 8ece341..8f4a18b 100644 --- a/doc/git

[FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-22 Thread James Zern
this quiets a warning: Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified internal error --- libavcodec/libvpxenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 2104876..159fbdd 100644 ---

[FFmpeg-devel] [PATCH] git-howto.texi: fix a typo

2015-04-22 Thread James Zern
s/Refer to and to sync/Refer to how to sync/ --- doc/git-howto.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 8ece341..8f4a18b 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto.texi @@ -330,7 +330,7 @@ git push Will push

Re: [FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-24 Thread James Zern
On Thu, Apr 23, 2015 at 8:14 AM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Apr 22, 2015 at 08:58:35PM -0700, James Zern wrote: this quiets a warning: Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified internal error --- libavcodec/libvpxenc.c | 5 +++-- 1 file

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-04-18 Thread James Zern
On Thu, Apr 16, 2015 at 6:19 PM, Debargha Mukherjee debar...@google.com wrote: Resolutions inline... From d84e140ed83bdc3889720e4a6af330198176b839 Mon Sep 17 00:00:00 2001 From: Deb Mukherjee debar...@google.com Date: Wed, 25 Mar 2015 17:10:16 -0700 Subject: [PATCH] Support for VP9

Re: [FFmpeg-devel] [PATCH] libvpx: add support for yuv440p and yuv440p10/12 encoding

2015-05-20 Thread James Zern
On Wed, May 20, 2015 at 2:05 PM, James Almer jamr...@gmail.com wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/libvpx.c| 4 libavcodec/libvpxenc.c | 24 +++- 2 files changed, 27 insertions(+), 1 deletion(-) lgtm

Re: [FFmpeg-devel] [PATCH 2/2] libvpxdec: report colorspace

2015-06-24 Thread James Zern
On Tue, Jun 23, 2015 at 4:19 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Tue, Jun 23, 2015 at 6:21 PM, James Zern jz...@google.com wrote: --- libavcodec/libvpxdec.c | 7 +++ 1 file changed, 7 insertions(+) sgtm. applied

Re: [FFmpeg-devel] [PATCH] libvpxenc: support setting colorspace for vp9

2015-06-20 Thread James Zern
On Sat, Jun 20, 2015 at 12:29 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Sat, Jun 20, 2015 at 3:15 PM, James Zern jz...@google.com wrote: On Wed, Jun 17, 2015 at 12:20 PM, James Zern jz...@google.com wrote: the vp9 bitstream supports 8 values: unknown (default), bt601, bt709

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec: report profile for vp9

2015-06-23 Thread James Zern
On Tue, Jun 23, 2015 at 4:18 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hello, On Tue, Jun 23, 2015 at 6:21 PM, James Zern jz...@google.com wrote: --- libavcodec/libvpxdec.c | 20 1 file changed, 20 insertions(+) lgtm. (This is probably a weird/stupid question

[FFmpeg-devel] [PATCH 2/2] libvpxdec: report colorspace

2015-06-23 Thread James Zern
--- libavcodec/libvpxdec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index b31e7b9..0e3ed6f 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -62,6 +62,13 @@ static av_cold int vpx_init(AVCodecContext *avctx, //

[FFmpeg-devel] [PATCH] libvpxenc: support setting colorspace for vp9

2015-06-17 Thread James Zern
the vp9 bitstream supports 8 values: unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved and sRGB. --- doc/encoders.texi | 12 libavcodec/libvpxenc.c | 29 + 2 files changed, 41 insertions(+) diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] libvpxenc: add color-space option for vp9

2015-06-17 Thread James Zern
On Tue, Jun 16, 2015 at 10:58 PM, James Almer jamr...@gmail.com wrote: On 16/06/15 2:43 AM, James Zern wrote: the vp9 bitstream supports 8 values: unknown (default), bt601, bt709, smpte170, smpte240, bt2020, reserved and sRGB. --- doc/encoders.texi | 12 libavcodec

[FFmpeg-devel] [PATCH] doc/muxers.texi: properly insert {}s in example

2015-06-16 Thread James Zern
use '@{' / '@}', fixes compile errors: *** '{' without macro. Before: 1:-'.'} *** '}' without opening '{' before: since: 907ac20 avformat/hlsenc: added HLS encryption Signed-off-by: James Zern jz...@google.com --- doc/muxers.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] libvpxenc: make flags i64 instead of dbl.

2015-08-17 Thread James Zern
On Mon, Aug 17, 2015 at 2:11 PM, Ronald S. Bultje rsbul...@gmail.com wrote: --- libavcodec/libvpxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) lgtm diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 58e8f5d..5f39783 100644 --- a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:50 AM, Michael Niedermayer mich...@niedermayer.cc wrote: On Wed, Jul 29, 2015 at 12:47:08PM +0200, Michael Niedermayer wrote: On Tue, Jul 28, 2015 at 11:12:31PM -0700, James Zern wrote: --- libavcodec/libvpxenc.c | 8 ++-- 1 file changed, 6 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-29 Thread James Zern
On Wed, Jul 29, 2015 at 3:48 AM, Michael Niedermayer mich...@niedermayer.cc wrote: On Tue, Jul 28, 2015 at 11:12:32PM -0700, James Zern wrote: --- libavcodec/libvpxenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) LGTM applied thanks [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH 2/2] libvpxenc: report pict_type/error via side-data

2015-07-29 Thread James Zern
--- libavcodec/libvpxenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 1a1d55f..3db617d 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -690,6 +690,7 @@ static int

[FFmpeg-devel] [PATCH 1/2] libvpxenc: quiet coded_frame deprecation warnings

2015-07-29 Thread James Zern
--- libavcodec/libvpxenc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index fb412b7..1a1d55f 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -717,12 +717,16 @@ FF_ENABLE_DEPRECATION_WARNINGS

Re: [FFmpeg-devel] [PATCH] vp9_parser: fix endless loop w/0-sized frame

2015-10-19 Thread James Zern
On Fri, Oct 16, 2015 at 4:05 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > Hi, > > On Fri, Oct 16, 2015 at 6:46 PM, James Zern <jz...@google.com> wrote: > > > treat this the same as an over-sized superframe packet to break out of > > the pa

[FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

2015-10-19 Thread James Zern
VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed from libvpx and the remaining values were never used here Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxenc.c | 8 1 file changed, 8 deletions(-) diff --git a/libavcodec/libvpxenc.c b/liba

Re: [FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

2015-10-20 Thread James Zern
On Tue, Oct 20, 2015 at 7:02 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Oct 19, 2015 at 10:49:16PM -0700, James Zern wrote: >> VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed >> from libvpx and the remaining values were never used

[FFmpeg-devel] [PATCH] vp9_parser: fix endless loop w/0-sized frame

2015-10-16 Thread James Zern
treat this the same as an over-sized superframe packet to break out of the parser loop and allow the decoder to fail. Signed-off-by: James Zern <jz...@google.com> --- libavcodec/vp9_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9_pars

Re: [FFmpeg-devel] [PATCH] libvpxdec: explicitly signal RGB.

2015-09-03 Thread James Zern
On Thu, Sep 3, 2015 at 6:38 AM, Ronald S. Bultje wrote: > --- > libavcodec/libvpxdec.c | 15 +++ > 1 file changed, 15 insertions(+) > lgtm > diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c > index 52a89ca..eb05f26 100644 > ---

Re: [FFmpeg-devel] [PATCH] vp9: reset segmentation information on context reset.

2015-09-03 Thread James Zern
On Tue, Sep 1, 2015 at 1:44 PM, Ronald S. Bultje wrote: > --- > libavcodec/vp9.c | 1 + > 1 file changed, 1 insertion(+) > lgtm > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 4503ed7..7035512 100644 > --- a/libavcodec/vp9.c > +++ b/libavcodec/vp9.c > @@ -707,6

Re: [FFmpeg-devel] [PATCH] libvpxdec: apply RGB to 444P16 instead of 422P16.

2015-09-11 Thread James Zern
On Fri, Sep 11, 2015 at 10:43 AM, Ronald S. Bultje wrote: > --- > libavcodec/libvpxdec.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > lgtm. sorry I wasn't paying attention with the last patch. > diff --git a/libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-07 Thread James Zern
Hi, On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: >> Would it be a lot easier and correct if I just update the IMAGE_ABI_VERSION >> to 4 in libvpx HEAD and check here in the decoder IMAGE_ABI_VERSION > 3 ? > > Yes, bumping any

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Improve documentation for cpu-used

2016-01-08 Thread James Zern
On Fri, Jan 8, 2016 at 1:58 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5140 here, seems to match: > https://github.com/webmproject/libvpx/commit/a16f07537501ac96531577d5af004ad0b591a705 > > Please comment, Carl Eugen > lgtm. thanks.

[FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

2016-01-11 Thread James Zern
since: cbcc88c libvpx: Support setting color range for vp9. Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index de72be9..b51bfa2 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

2016-01-12 Thread James Zern
On Tue, Jan 12, 2016 at 5:40 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Tue, Jan 12, 2016 at 1:43 AM, James Zern <jz...@google.com> wrote: > >> since: >> cbcc88c libvpx: Support setting color range for vp9. >> >

Re: [FFmpeg-devel] [PATCH] libvpxenc: Allow setting tune parameter

2016-02-02 Thread James Zern
On Tue, Feb 2, 2016 at 6:10 PM, Timothy Gu wrote: > --- > doc/encoders.texi | 6 ++ > libavcodec/libvpxenc.c | 8 > 2 files changed, 14 insertions(+) > lgtm > diff --git a/doc/encoders.texi b/doc/encoders.texi > index c485f90..e9311eb 100644 > ---

Re: [FFmpeg-devel] [PATCH] libvpxenc: quiet unused-variable warning

2016-02-22 Thread James Zern
On Sat, Feb 20, 2016 at 11:39 AM, James Almer <jamr...@gmail.com> wrote: > On 2/20/2016 4:26 PM, James Zern wrote: >> with older versions of libvpx >> since: >> 432be63 lavc/libvpx: Fix support for RGB colorspace. >> >> Signed-off-by: James Zern <jz...@goo

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
Hi, On Thu, Feb 18, 2016 at 3:30 PM, Carl Eugen Hoyos wrote: > Please comment, Carl Eugen > diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c > index a60d186..1e7010b 100644 > --- a/libavcodec/libvpx.c > +++ b/libavcodec/libvpx.c > @@ -46,14 +46,14 @@ static const enum

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
ll this new > code inside some preprocessor checks. I think VPX_IMAGE_ABI_VERSION >= 3 > should do it, but better wait for James Zern for confirmation. That's correct. This would prevent the user from overriding the decision with unspecified/reserved, not sure it matters. _

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:34 PM, Carl Eugen Hoyos wrote: >> Alternatively we could bump the minimum required version and remove most of >> the existing checks. 1.3.0 is pretty old by now and it would let us clean >> these files. > > I would prefer if this could be done

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:02 PM, Hendrik Leppkes wrote: > On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: >> On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: >>> Initial patch by Carl Eugen Hoyos. >>> >>> Fix trac ticket #5249. >> >>

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > On Friday 19 February 2016 07:59:37 am James Zern wrote: > >> The decoder won't change when built on a big-endian platform, so I don't >> think this is correct. > > New patch attached. >

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:00 AM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > James Zern google.com> writes: > >> On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos > > On Friday 19 February 2016 07:59:37 am James Zern wrote: >> > >> >> The

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:43 AM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > Hendrik Leppkes gmail.com> writes: > >> On Fri, Feb 19, 2016 at 8:47 AM, James Zern wrote: >> > On Thu, Feb 18, 2016 at 11:40 PM, Carl Eugen Hoyos wrote: >> >> On Friday 19

Re: [FFmpeg-devel] [PATCH]lavc/libvpx: Fix high-bitrate colour spaces

2016-02-19 Thread James Zern
On Fri, Feb 19, 2016 at 12:17 PM, Carl Eugen Hoyos wrote: > Could you comment on ticket #3271 (is alpha possible in > vp9?) and #4105? I added some notes. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] libvpxenc: quiet unused-variable warning

2016-02-20 Thread James Zern
with older versions of libvpx since: 432be63 lavc/libvpx: Fix support for RGB colorspace. Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 1239103..b1114bc

Re: [FFmpeg-devel] [PATCH 1/2] libwebpenc_animencoder: zero initialize the WebPAnimEncoderOptions struct

2016-03-19 Thread James Zern
On Wed, Mar 16, 2016 at 9:03 PM, James Almer wrote: > This zeroes the WebPAnimEncoderOptions.verbose field, silencing library info > messages > printed to stderr. > > Signed-off-by: James Almer > --- > libavcodec/libwebpenc_animencoder.c | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH 2/2] libwebpenc_animencoder: print library messages in verbose log levels

2016-03-19 Thread James Zern
On Wed, Mar 16, 2016 at 9:03 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libwebpenc_animencoder.c | 2 ++ > 1 file changed, 2 insertions(+) > lgtm. Not really sure if this logging in the lib was really necessary... > diff --git

Re: [FFmpeg-devel] [PATCH 0/3] bump libvpx-vp9 minimum to 1.4.0

2016-07-21 Thread James Zern
On Fri, Jul 15, 2016 at 7:31 PM, James Almer <jamr...@gmail.com> wrote: > On 7/15/2016 10:15 PM, James Zern wrote: >> This compiles against 0.9.0->1.5.0 and tip of tree with checks at each for >> expected encoder/decoder availability and colorspaces. >> Note libvpx

Re: [FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Jul 20, 2016 at 09:05:14PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern <jz...@google.com> >> --- >> libavcodec/libvpx

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-21 Thread James Zern
On Thu, Jul 21, 2016 at 4:22 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Jul 20, 2016 at 09:05:15PM -0700, James Zern wrote: >> + the context struct >> >> Signed-off-by: James Zern <jz...@google.com> >&

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-13 Thread James Zern
On Tue, Jul 12, 2016 at 11:49 AM, Vignesh Venkatasubramanian wrote: >>> > Alright, i have a working patch for the decoder locally (i will push >>> > that to the ML shortly). >>> >>> Here it is: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-July/196403.html >> >>

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-13 Thread James Zern
On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian wrote: > Chrome canary now supports decoding of VP9 streams with alpha > channel [1]. Add support to ffmpeg for creating such files. > > [1] https://codereview.chromium.org/2096813002/ > >

[FFmpeg-devel] [PATCH 2/2] libvpxenc, cosmetics: rename common fns vp8 -> vpx

2016-07-20 Thread James Zern
+ the context struct Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxenc.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c5b1b86..f3cff81

[FFmpeg-devel] [PATCH 1/2] libvpxdec, cosmetics: rename common fns vp8 -> vpx

2016-07-20 Thread James Zern
+ the context struct Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxdec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index f7acc39..5204c99 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 2/3] libvpx: remove pre-1.4.0 checks for vp9

2016-07-18 Thread James Zern
On Fri, Jul 15, 2016 at 7:30 PM, James Almer <jamr...@gmail.com> wrote: > On 7/15/2016 10:15 PM, James Zern wrote: >> Signed-off-by: James Zern <jz...@google.com> >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 del

Re: [FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-18 Thread James Zern
On Sun, Jul 17, 2016 at 3:05 AM, Nicolas George <geo...@nsup.org> wrote: > L'octidi 28 messidor, an CCXXIV, James Zern a écrit : >> this will simplify libvpxenc/dec.c and ensure a more stable vp9 encoder >> is present. >> >> Signed-off-by: James Zern <jz...@

Re: [FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-18 Thread James Zern
On Mon, Jul 18, 2016 at 12:00 PM, James Zern <jz...@google.com> wrote: > On Sun, Jul 17, 2016 at 3:05 AM, Nicolas George <geo...@nsup.org> wrote: >> L'octidi 28 messidor, an CCXXIV, James Zern a écrit : >>> this will simplify libvpxenc/dec.c and ensure a more sta

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-19 Thread James Zern
On Fri, Jul 15, 2016 at 3:29 PM, James Zern <jz...@google.com> wrote: > On Thu, Jul 14, 2016 at 8:16 PM, James Zern <jz...@google.com> wrote: >> On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian >> <vigneshv-at-google@ffmpeg.org> wrote: &g

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-15 Thread James Zern
On Thu, Jul 14, 2016 at 8:16 PM, James Zern <jz...@google.com> wrote: > On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian > <vigneshv-at-google@ffmpeg.org> wrote: >> +ret = vpx_init( >> +avctx, >> +

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-11 Thread James Zern
On Thu, Jul 7, 2016 at 11:43 AM, Vignesh Venkatasubramanian wrote: > VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the > ability to decode such files with alpha channel. > > Signed-off-by: Vignesh Venkatasubramanian > --- >

[FFmpeg-devel] [PATCH 2/3] libvpx: remove pre-1.4.0 checks for vp9

2016-07-15 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index 1eca97a..36f915a 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -40,9

[FFmpeg-devel] [PATCH 3/3] libvpxenc: remove pre-1.4.0 checks for vp9

2016-07-15 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxenc.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c5b1b86..7489c2f 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvp

[FFmpeg-devel] [PATCH 0/3] bump libvpx-vp9 minimum to 1.4.0

2016-07-15 Thread James Zern
This compiles against 0.9.0->1.5.0 and tip of tree with checks at each for expected encoder/decoder availability and colorspaces. Note libvpxdec's ifdefs are within shared code, splitting set_pix_fmt() would be an option. James Zern (3): configure: require libvpx-1.4.0 for vp9 support lib

[FFmpeg-devel] [PATCH 1/3] configure: require libvpx-1.4.0 for vp9 support

2016-07-15 Thread James Zern
this will simplify libvpxenc/dec.c and ensure a more stable vp9 encoder is present. Signed-off-by: James Zern <jz...@google.com> --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0c7b5e9..511ecfe 100755 --- a/configure

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian wrote: > +ret = vpx_init( > +avctx, > +(avctx->codec_id == AV_CODEC_ID_VP8) ? > +_codec_vp8_dx_algo : _codec_vp9_dx_algo,

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Tue, Jul 12, 2016 at 1:47 PM, James Almer wrote: > What's the first libvpx version that supports vp8a and vp9a? > Configure currently checks for 0.9.1 as the oldest supported > version for vp8 decoding, 0.9.7 for vp8 encoding, and 1.3.0 for > both vp9 components. We then use

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Tue, Jul 12, 2016 at 11:48 AM, Vignesh Venkatasubramanian <vigneshv-at-google@ffmpeg.org> wrote: > On Mon, Jul 11, 2016 at 5:55 PM, James Zern > <jzern-at-google@ffmpeg.org> wrote: >> On Thu, Jul 7, 2016 at 11:43 AM, Vignesh Venkatasubramanian >> <

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-06-30 Thread James Zern
On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian wrote: > Chrome canary now supports decoding of VP9 streams with alpha > channel [1]. Add support to ffmpeg for creating such files. > > [1] https://codereview.chromium.org/2096813002/ > >

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread James Zern
On Fri, Jul 1, 2016 at 10:07 AM, Carl Eugen Hoyos wrote: >> Do we have decoder support (for either vp8 or vp9) for these files? > > No, only encoding and muxing. > Seems like a feature request, but no reason to block this one if the vp8 one is here.

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread James Zern
On Fri, Jul 1, 2016 at 9:23 AM, Vignesh Venkatasubramanian <vigneshv-at-google@ffmpeg.org> wrote: > On Thu, Jun 30, 2016 at 10:37 PM, James Zern > <jzern-at-google@ffmpeg.org> wrote: >> On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian >> <vignesh

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Avaoid vp8 transparency encoding with auto-alt-ref

2016-09-16 Thread James Zern
On Fri, Sep 16, 2016 at 4:50 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-17 1:48 GMT+02:00 James Zern: >> On Fri, Sep 16, 2016 at 5:23 AM, Carl Eugen Hoyos wrote: > >>> Attached patch fixes ticket #5815. >> >>> +if (ctx->aut

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Avaoid vp8 transparency encoding with auto-alt-ref

2016-09-16 Thread James Zern
On Fri, Sep 16, 2016 at 5:23 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5815. > > +if (ctx->auto_alt_ref && ctx->is_alpha && avctx->codec_id == > AV_CODEC_ID_VP8) { > +av_log(avctx, AV_LOG_ERROR, "Transparency encoding with auto_alt_ref >

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix DiscardPadding element parsing

2016-11-07 Thread James Zern
On Sat, Nov 5, 2016 at 1:50 PM, James Almer wrote: > If the value is negative then it means padding at the start of the packet > instead of at the end. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add vp8/vp9 mediacodec decoders

2016-10-12 Thread James Zern
On Wed, Oct 12, 2016 at 6:22 AM, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > configure| 4 +++ > libavcodec/Makefile | 2 ++ > libavcodec/allcodecs.c | 4 +++ >

[FFmpeg-devel] [PATCH] ffmpeg_cleanup: fix crash with unrecognized codec

2016-10-14 Thread James Zern
since: 3e5e5bd Merge commit '398f015f077c6a2406deffd9e37ff34b9c7bb3bc' Signed-off-by: James Zern <jz...@google.com> --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 693981f..af8ed76 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -533,7

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 1:22 AM, James Zern <jz...@google.com> wrote: > On Fri, Oct 21, 2016 at 1:14 AM, Kagami Hiiragi <kag...@genshiken.org> wrote: >> On 21/10/16 06:14, James Zern wrote: >>> On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi <kag...@genshiken.o

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 4:55 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Thu, Oct 20, 2016 at 11:14 PM, James Zern <jzern-at-google@ffmpeg.org >> wrote: > >> On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi <kag...@genshiken.org> >

[FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
From: Kagami Hiiragi vp9_cx_iface actually allows values in range [0..2]. This fixes ticket #5894. Signed-off-by: Kagami Hiiragi --- libavcodec/libvpxenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread James Zern
On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi wrote: > vp9_cx_iface actually allows values in range [0..2]. > This fixes ticket #5894. > > Signed-off-by: Kagami Hiiragi > --- > libavcodec/libvpxenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Thu, Oct 20, 2016 at 11:51 AM, Rostislav Pehlivanov wrote: > On 20 October 2016 at 16:31, Kagami Hiiragi wrote: > >> vp9_cx_iface actually allows values in range [0..2]. >> This fixes ticket #5894. >> >> Signed-off-by: Kagami Hiiragi

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 31 +++ > 1 file changed, 31

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:04 PM, James Zern <jz...@google.com> wrote: > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse <alex.conve...@gmail.com> > wrote: >> Report the actual level of the encoded output if a level is >> targeted or the level is passiv

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:08 PM, James Zern <jz...@google.com> wrote: > On Tue, Nov 22, 2016 at 12:04 PM, James Zern <jz...@google.com> wrote: >> On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse <alex.conve...@gmail.com> >> wrote: >>> Report the act

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:32 AM, Alex Converse <alex.conve...@gmail.com> wrote: > On Tue, Nov 22, 2016 at 3:10 PM, James Zern <jz...@google.com> wrote: >> On Tue, Nov 22, 2016 at 12:08 PM, James Zern <jz...@google.com> wrote: >>> On Tue, Nov 22, 2016 at 12

Re: [FFmpeg-devel] [PATCH] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:34 AM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 32 > 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

2016-11-18 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Levels are specified at https://www.webmproject.org/vp9/levels/ > --- > libavcodec/libvpxenc.c | 10 ++ > 1 file changed, 10 insertions(+) > lgtm > diff --git a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
On Fri, Oct 14, 2016 at 11:31 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Fri, Oct 14, 2016 at 08:29:37PM +0200, Michael Niedermayer wrote: >> On Fri, Oct 14, 2016 at 11:09:30AM -0700, James Zern wrote: >> > Ronald, >> > >> > On Fri,

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
Ronald, On Fri, Oct 14, 2016 at 10:01 AM, Ronald S. Bultje wrote: > This is intended to workaround bug "665 Integer Divide Instruction May > Cause Unpredictable Behavior" on some early AMD CPUs, which causes a > div-by-zero in this codepath, such as reported in Mozilla bug

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
t; > On Fri, Oct 14, 2016 at 11:09:30AM -0700, James Zern wrote: >> > > Ronald, >> > > >> > > On Fri, Oct 14, 2016 at 10:01 AM, Ronald S. Bultje <rsbul...@gmail.com> >> wrote: >> > > > This is intended to workaround bug "665

Re: [FFmpeg-devel] [PATCH] libvpxenc: Don't spam level errors for VP8 encodes

2016-12-12 Thread James Zern
On Mon, Dec 12, 2016 at 12:12 PM, Alex Converse wrote: > Fixes "Failed to set VP9E_GET_LEVEL codec control: Codec does not > implement requested capability" log messages on VP8 encodes. > --- > libavcodec/libvpxenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Thu, Apr 20, 2017 at 2:42 PM, James Zern <jzern-at-google@ffmpeg.org> > wrote: > >> On Thu, Apr 13, 2017 at 6:44 PM, James Zern <jz...@google.com> wrote: >> &

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 13, 2017 at 6:44 PM, James Zern <jz...@google.com> wrote: > this was added in 1.6.0 > > Signed-off-by: James Zern <jz...@google.com> > --- > doc/encoders.texi | 2 +- > libavcodec/libvpxenc.c | 3 ++- > 2 files changed, 3 insertions(+), 2 dele

[FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-13 Thread James Zern
this was added in 1.6.0 Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi | 2 +- libavcodec/libvpxenc.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..f8f187664c 100644 --- a/doc/encoder

[FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-13 Thread James Zern
added in: 734d760e2f lavc/libvpxenc: add -row-mt option Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..7f4754d160 100644 --- a/doc/encoders.texi +++

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-13 Thread James Zern
On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian wrote: > Add an option to webm_dash_manifest demuxer to specify a value for > "bandwidth" field in the DASH manifest. The value is then used by > the muxer. Fixes an existing FIXME in the code. > >

Re: [FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-18 Thread James Zern
On Mon, Apr 17, 2017 at 5:06 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Apr 13, 2017 at 06:53:26PM -0700, James Zern wrote: >> added in: >> 734d760e2f lavc/libvpxenc: add -row-mt option >> >> Signed-off-by: James Zern <jz...@google.c

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-17 Thread James Zern
On Thu, Apr 13, 2017 at 6:20 PM, James Zern <jz...@google.com> wrote: > On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian > <vigneshv-at-google@ffmpeg.org> wrote: >> Add an option to webm_dash_manifest demuxer to specify a value for >> "ba

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-03 Thread James Zern
On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi wrote: > [...] > > Updated. I don't think -slices would fit logically because -row-mt is boolean > and -slices is integer. > > --- > libavcodec/libvpxenc.c | 11 +++ > 1 file changed, 11 insertions(+) > Looks all

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-06 Thread James Zern
On Fri, Mar 3, 2017 at 4:52 PM, James Zern <jz...@google.com> wrote: > On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi <kag...@genshiken.org> wrote: >> [...] >> >> Updated. I don't think -slices would fit logically because -row-mt is >> boolean and -slic

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread James Zern
On Thu, Mar 2, 2017 at 11:00 AM, Kagami Hiiragi wrote: > From ae3856c302284d60761c3ad122ff49b7b9b68114 Mon Sep 17 00:00:00 2001 > From: Kagami Hiiragi > Date: Thu, 2 Mar 2017 21:19:09 +0300 > Subject: [PATCH] lavc/libvpxenc: add -row-mt option > > ---

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-28 Thread James Zern
On Thu, Apr 20, 2017 at 3:06 PM, James Zern <jz...@google.com> wrote: > On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: >> Hi, >> >> On Thu, Apr 20, 2017 at 2:42 PM, James Zern <jzern-at-google@ffmpeg.org> >> wrote:

  1   2   >