Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-15 Thread Jeyapal, Karthick
>Shoot, then the original code was incorrect :). > >I will take a final look at your patches next week. > >Regards, >Marton Thanks. And I forgot to mention a thing. Some parts of that code in this patch was started from VLC’s source code. Source link here

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-20 Thread Jeyapal, Karthick
>Then please add the relevant copyright line to the file you changed. >(Probably "Rafaël Carré" but please verify yourself) > >Carl Eugen Thanks for the clarification. I have added the copyright line as you have advised. (Yes, I have verified that that “Rafaël Carré” was the original author of

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-09-13 Thread Jeyapal, Karthick
Thanks for your comments. Please find the patch attached as per your comments. Regards, Karthick 0001-avdevice-decklink_dec-Added-VANC-search-for-all-reso.patch Description: 0001-avdevice-decklink_dec-Added-VANC-search-for-all-reso.patch ___

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-13 Thread Jeyapal, Karthick
Hi Marton, Thanks a lot for your comments. I have modified the patch as per all your comments, except the below one. >> +tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920, >> tgt, cctx->teletext_lines, 0); > >this should be >tgt =

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 Thread Jeyapal, Karthick
Hi Steven, I am restarting this discussion, just to conclude this thread one way or the other. Maybe I am not thinking correctly. Here is detailed thinking, on why I think this patch will not violate HLS spec. >if (target_duration <= en->duration) >target_duration =

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Added configuration to override HTTP User-Agent

2017-09-05 Thread Jeyapal, Karthick
Thanks. Regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 Thread Jeyapal, Karthick
>On 9/6/17, 12:37 PM, "Steven Liu" >> wrote: >segment1.ts duration = 4.88 >ROUND is 5, not 4, is it? >if its duration = 4.04 >ROUND is 4, the real segment1.ts duration is 4.04, > >the safe one is TARGETDURATION = 5, the

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 Thread Jeyapal, Karthick
>On 9/6/17, 3:43 PM, "Steven Liu" ><lingjiujia...@gmail.com<mailto:lingjiujia...@gmail.com>> wrote: > >>2017-09-06 16:46 GMT+08:00 Jeyapal, Karthick >><kjeya...@akamai.com<mailto:kjeya...@akamai.com>>: >>>On 9/6/17, 12:37 PM, &q

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-28 Thread Jeyapal, Karthick
>On 9/29/17, 7:36 AM, "James Almer" wrote: >> >> +static inline uint16_t parity (uint16_t x) >> +{ >> +uint16_t i; >> +for (i = 4 * sizeof (x); i > 0; i /= 2) >> +x ^= x >> i; >> +return x & 1; >> +} > >Can't you use av_parity() instead? Yes, I can.

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-28 Thread Jeyapal, Karthick
>Applied the series, thanks! > >Marton Thanks a lot! Regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-27 Thread Jeyapal, Karthick
>Sorry, still not quite there... Here are some further comments: Thanks for your comments and patience. Please find the updated patch attached, with all the comments taken. Also, I have rebased this patch with the latest ffmpeg, as avcodec version numbers have changed in the meantime. >Also

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-26 Thread Jeyapal, Karthick
>Sorry for the late reply, the last was busy week. Here are some more >comments: Thanks for your comments. Please find the updated patch attached with your comments incorporated. Regards, Karthick 0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch Description:

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/decode: Pass on the Closed Captions Side Data

2017-08-31 Thread Jeyapal, Karthick
>Maybe this should be handled somewhere in generic code? This is hardly >a v210 property at all. Yes, I agree. It is better to handle it in the generic code. Have attached a patch, where the same is handled in decode.c Thanks and regards, Karthick

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Added configuration to override HTTP User-Agent

2017-09-04 Thread Jeyapal, Karthick
>On 9/1/17, 5:36 PM, "Steven Liu" wrote: >> Please find the patch attached. >> >> Regards, >> Karthick >> >> >> >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel at ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Added configuration to override HTTP User-Agent

2017-09-04 Thread Jeyapal, Karthick
>On 9/4/17, 12:41 PM, "Steven Liu" >> wrote: > >Hi Karthick, >set user_agent better than user-agent, because the user-agent is >duplicate with user_agent, and the user-agent will be deprecated in >new version, refer to :

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Added configuration to override HTTP User-Agent

2017-09-04 Thread Jeyapal, Karthick
>On 9/4/17, 1:36 PM, "Steven Liu" >> wrote: >+if (c->user_agent) >+av_dict_set(options, "user-agent", c->user_agent, 0); > >should be >av_dict_set(options, "user_agent", c->user_agent, 0); Oh! OK Got it. Sorry for the confusion.

Re: [FFmpeg-devel] [PATCH v3] avformat/dash: move reused API to common file and header file

2017-09-01 Thread Jeyapal, Karthick
>Pushed. > >Thanks FYI. FATE is failing after this push. It is due to the missing copyright header in dash.c Thanks and Regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/decode: Pass on the Closed Captions Side Data

2017-09-01 Thread Jeyapal, Karthick
>Actually in ff_init_buffer_info is a mapping of packet sidedata to >frame sidedata, if you just add the new CC sidedata type there, the >existing code should already handle it, from what i can tell. > >- Hendrik Thanks for that guidance. It makes perfect sense to handle it in

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-01 Thread Jeyapal, Karthick
>2017-09-01 18:32 GMT+08:00 Steven Liu >>: >Sorry, my mistake. > >the target_duration must large or equal to the en->duration, can not >small than en->duration from HLS version 3. When “round_durations” is enabled “en->duration” also gets

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-01 Thread Jeyapal, Karthick
>The hls_time is set to the segments duration, not target duration, and >the hls_time just a reference value, so the target duration is +1. >anyway, this patch can not catch the point. >The spec clearly says it has to be greater or equal. So rounding it up >is perfectly legal and might even

[FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Added configuration to override HTTP User-Agent

2017-09-01 Thread Jeyapal, Karthick
Please find the patch attached. Regards, Karthick 0001-avformat-hlsenc-Added-configuration-to-override-HTTP.patch Description: 0001-avformat-hlsenc-Added-configuration-to-override-HTTP.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [WARNING! RECEIVED FROM EXTERNAL SENDER] Re: [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-09-05 Thread Jeyapal, Karthick
Overlooked a “signed vs unsigned comparison” compilation warning in the previous patch. Sorry about that. Please use this updated patch(attached) for review. Regards, Karthick 0001-avdevice-decklink_dec-Added-VANC-search-for-all-reso.patch Description:

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-09-05 Thread Jeyapal, Karthick
>On 9/3/17, 4:48 PM, "Marton Balint" > >wrote: >That may well be true, but SMPTE 334M recommands to use lines "from >the second line after the line specified for switching to the last line >preceding active video, inclusive", so I'd skip at least the lines

Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_dec: Added VANC search for all resolutions

2017-09-05 Thread Jeyapal, Karthick
Overlooked a “signed vs unsigned comparison” compilation warning in the previous patch. Sorry about that. Please use this updated patch(attached) for review. Regards, Karthick P.S : I had sent the same reply sometime back, but a new thread got created. Please ignore that. I am using Outlook

Re: [FFmpeg-devel] [PATCH 2/4] avdevice/decklink_dec: Extraction of luma from V210 VANC modularized

2017-09-05 Thread Jeyapal, Karthick
>On 9/3/17, 5:18 PM, "Marton Balint" > >wrote: > >I think we only have vanc numbers until resolution of 1920 width, so that >should be enough. Probably better to add an av_assert which checks if >frame width is less or equal to FF_ARRAY_ELEMS(luma_vanc).

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-05 Thread Jeyapal, Karthick
>On 9/3/17, 8:19 PM, "Marton Balint" > >wrote: >Why don't use you simply use uint16_t here as well? I think we typically >try to avoid unsigned as a type. Done. Changed it to uint16_t. >This VANC parser does not seem right. VANC header can appear multiple

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/tcp: enable TCP_NODELAY by default

2017-11-14 Thread Jeyapal, Karthick
>On 11/14/17, 11:11 PM, "Aman Gupta" <a...@tmm1.net on behalf of >ffm...@tmm1.net> wrote: > >From: Aman Gupta <a...@tmm1.net> > >This can reduce latency and increase throughput, particularly on high >latency networks. > >Signed-off-by: Aman Gupt

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/{http, tls}: enable tcp_nodelay

2017-11-14 Thread Jeyapal, Karthick
>On 11/15/17, 10:32 AM, "Aman Gupta" wrote: > >From: Aman Gupta > >Signed-off-by: Aman Gupta >--- > libavformat/http.c | 1 + > libavformat/tls.c | 1 + > 2 files changed, 2 insertions(+) Again, do want to hardcode tcp_nodelay at http and tls

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Jeyapal, Karthick
Since Vishwanath is on leave today, I have made the changes required and have sent patchset v2. On 11/23/17, 4:11 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : >> From: Vishwanath Dixit >> >> Signed-off-by: Karthick J

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 4:41 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : >> From: Vishwanath Dixit >> +// either provide codec string for both active streams or for none >> +if (vid_st && aud_st && (!strlen(vcodec) ||

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 3:40 PM, "刘歧" <l...@chinaffmpeg.org> wrote: >> 在 2017年11月24日,18:02,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >> >> On 11/22/17, 1:27 PM, "Jeyapal, Karthick" <kjeya...@akamai.com> wrote: >> >>>> On 11/22/1

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added context to av_log calls

2017-11-24 Thread Jeyapal, Karthick
On 11/24/17, 4:36 PM, "Carl Eugen Hoyos" wrote: >2017-11-24 12:03 GMT+01:00 Moritz Barsnick : >> On Fri, Nov 24, 2017 at 15:42:30 +0530, Karthick J wrote: >>> if (av_strncasecmp(master_url, media_url, base_len)) { >>> -av_log(NULL,

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Jeyapal, Karthick
I have rebased the below patch for latest master and have sent a new patch v3. Regards, Karthick On 11/22/17, 2:50 PM, "Karthick J" wrote: --- libavformat/hlsenc.c | 237 +++ libavformat/hlsenc.h | 67 +++ 2

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-23 Thread Jeyapal, Karthick
>On 11/24/17, 9:44 AM, "刘歧" wrote: > > >> 在 2017年11月24日,11:55,Karthick J 写道: >> >> --- >> libavformat/hlsenc.c | 238 >> +++ >> libavformat/hlsenc.h | 68 +++ >> 2 files changed, 194

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-24 Thread Jeyapal, Karthick
On 11/22/17, 1:27 PM, "Jeyapal, Karthick" <kjeya...@akamai.com> wrote: >>On 11/22/17, 9:32 AM, "刘歧" <l...@chinaffmpeg.org> wrote: >> >>This patch is ok, but i see it need an API: ffio_geturlcontext >> >>it in the other patch, i see it

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 8:34 PM, "Carl Eugen Hoyos" <ceffm...@gmail.com> wrote: >2017-11-23 13:56 GMT+01:00 Jeyapal, Karthick <kjeya...@akamai.com>: >> >> On 11/23/17, 5:33 PM, "Carl Eugen Hoyos" <ceffm...@gmail.com> wrote: >> >>&

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: Refactor an inconsistent variable name

2017-11-23 Thread Jeyapal, Karthick
Thanks for pushing this patchset. Regards, Karthick On 11/22/17, 1:43 PM, "刘歧" wrote: > 在 2017年11月22日,16:08,Karthick J 写道: > > --- > libavformat/hlsenc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Allow libavcodec to overwrite profile and level

2017-11-23 Thread Jeyapal, Karthick
On 11/24/17, 5:17 AM, "Carl Eugen Hoyos" wrote: >2017-11-23 22:58 GMT+01:00 Michael Niedermayer : >> On Thu, Nov 23, 2017 at 04:01:06PM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> The (external) encoders may overwrite level and profile because of

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/24/17, 4:31 AM, "Steven Liu" wrote: >Pushed Thanks. > > >Thanks regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Jeyapal, Karthick
Thanks for your comments. I have uploaded new patchset v4 with suggested corrections. Please ignore patchset v3. On 11/24/17, 4:26 PM, "Mark Thompson" wrote: […] >> +s = x264_encoder_headers(x4->enc, , ); >> +avctx->profile = nal->p_payload[5]; > >AVCodecContext.profile

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-24 Thread Jeyapal, Karthick
Oops. Sorry about that. Have sent a new patch v5 that fixes this. Regards, Karthick On 11/25/17, 1:31 AM, "Michael Niedermayer" wrote: On Fri, Nov 24, 2017 at 10:57:45AM +0530, Karthick J wrote: > --- > libavformat/Makefile | 2 +- > libavformat/hlsenc.c |

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-22 Thread Jeyapal, Karthick
>On 11/22/17, 2:18 PM, "Hendrik Leppkes" <h.lepp...@gmail.com> wrote: >>On Wed, Nov 22, 2017 at 9:35 AM, Jeyapal, Karthick <kjeya...@akamai.com> >>wrote: >>>On 11/22/17, 1:47 PM, "刘歧" <l...@chinaffmpeg.org> wrote: […] &g

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-22 Thread Jeyapal, Karthick
>On 11/22/17, 1:47 PM, "刘歧" wrote: > >> 在 2017年11月22日,14:53,Karthick J 写道: >> >> --- >> libavformat/hlsenc.c | 130 +++--- >> libavformat/hlsenc.h | 158 >> +++ >> 2

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-21 Thread Jeyapal, Karthick
>On 11/22/17, 9:32 AM, "刘歧" wrote: > >This patch is ok, but i see it need an API: ffio_geturlcontext > >it in the other patch, i see it have some thing need talk? If that is ok, this >patch should be apply. Thanks for the reply. All concerns raised by Nicolas has been

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Option to generate hls playlist as well

2017-11-22 Thread Jeyapal, Karthick
On 11/22/17, 9:06 PM, "Michael Niedermayer" wrote: >On Wed, Nov 22, 2017 at 02:50:12PM +0530, Karthick J wrote: >> >> +static void get_hls_playlist_name(char *playlist_name, const char >> *base_url, int id) { >> +if (base_url) >> +sprintf(playlist_name,

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:13 PM, "Carl Eugen Hoyos" wrote: > >2017-11-23 6:05 GMT+01:00 Karthick J : > >> +if (hls->flags & HLS_SPLIT_BY_TIME) { >> +// Independent segments cannot be guaranteed when splitting by time >> +hls->flags &=

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-11-23 Thread Jeyapal, Karthick
>From: Aman Gupta >On Wed, Nov 22, 2017 at 7:38 PM wrote: >>From: Vishwanath Dixit >> >>Signed-off-by: Karthick J > >LGTM. > >Have you looked at adding HEVC support? Thanks for the reply. From our side, there are no

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:56 PM, "Carl Eugen Hoyos" wrote: > >2017-11-23 12:21 GMT+01:00 Karthick J : > >> +if (hls->flags & HLS_SPLIT_BY_TIME) { >> +// Independent segments cannot be guaranteed when splitting by time >> +hls->flags &=

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" wrote: >2017-11-23 4:37 GMT+01:00 : > >> +s = x264_encoder_headers(x4->enc, , ); >> +if (avctx->profile == FF_PROFILE_UNKNOWN) >> +avctx->profile = nal->p_payload[5]; >> +if (avctx->level ==

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-23 Thread Jeyapal, Karthick
On 11/23/17, 5:33 PM, "Carl Eugen Hoyos" <ceffm...@gmail.com> wrote: >2017-11-23 12:47 GMT+01:00 Jeyapal, Karthick <kjeya...@akamai.com>: >> On 11/23/17, 4:21 PM, "Carl Eugen Hoyos" <ceffm...@gmail.com> wrote: >> >>>

Re: [FFmpeg-devel] [PATCH v3 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-28 Thread Jeyapal, Karthick
On 11/29/17, 12:04 PM, "刘歧" wrote: >Patchset pushed! Thanks a lot! Regards, Karthick > > >Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-28 Thread Jeyapal, Karthick
On 11/24/17, 3:49 PM, "Jeyapal, Karthick" <kjeya...@akamai.com> wrote: > >On 11/24/17, 3:40 PM, "刘歧" <l...@chinaffmpeg.org> wrote: > >>> 在 2017年11月24日,18:02,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >>> >>> On 11/22/17,

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-28 Thread Jeyapal, Karthick
On 11/29/17, 11:41 AM, "刘歧" <l...@chinaffmpeg.org> wrote: >> 在 2017年11月29日,12:05,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >> >> A gentle reminder. >> 7 days have gone by since the last version of this patchset was submitted. >> And no

Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-29 Thread Jeyapal, Karthick
On 11/25/17, 9:16 AM, "Karthick J" wrote: >--- > libavformat/Makefile | 2 +- > libavformat/hlsenc.c | 115 +++--- > libavformat/hlsplaylist.c | 138 ++ > libavformat/hlsplaylist.h | 51

Re: [FFmpeg-devel] [PATCH v6 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

2017-11-29 Thread Jeyapal, Karthick
On 11/29/17, 5:16 PM, "刘歧" wrote: > >Where can i find the v6 2/2 ? Patch 2/2 didn’t change since v4. So didn’t repost it. You have to use v4 2/2. I am sorry. I was not sure what is the normal practice here. I didn’t repost it, so that the people don’t waste time in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Option to generate hls playlist as well

2017-11-29 Thread Jeyapal, Karthick
Please ignore the below patch and use v2. Sorry for the inconvenience. Regards, Karthick On 11/29/17, 8:47 PM, "Karthick J" wrote: This is to take full advantage of Common Media Application Format. Now server can generate one content and serve both HLS and DASH players.

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat/dashenc: Option to generate hls playlist as well

2017-11-29 Thread Jeyapal, Karthick
On 11/29/17, 7:43 PM, "Steven Liu" wrote: >> +target_duration = lrint((double) target_duration / timescale); >What value will set when the target_duration is 1.023 ? I think we >have talk about the value and the specification describe the standard >process way.

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: Refactored 'get_int_from_double' function to allow reuse

2017-11-29 Thread Jeyapal, Karthick
On 11/30/17, 8:47 AM, "Steven Liu" wrote: [..] >Patchset pushed Thanks. > > >Thanks regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v6 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-12-14 Thread Jeyapal, Karthick
>On 12/14/17, 8:24 PM, "Steven Liu" wrote: > > >> 在 2017年12月14日,下午6:55,vdi...@akamai.com 写道: >> […] >> +libavformat/reverse.c > >this need double check for a better way The better way of doing this is to share ff_reverse function. But such a patch submitted recently was not

Re: [FFmpeg-devel] [PATCH v6 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

2017-12-15 Thread Jeyapal, Karthick
>On 12/15/17, 4:45 AM, "Liu Steven" <l...@chinaffmpeg.org> wrote: > > >> 在 2017年12月15日,上午6:28,Liu Steven <l...@chinaffmpeg.org> 写道: >> >>> >>> 在 2017年12月15日,上午12:29,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >&g

Re: [FFmpeg-devel] [PATCH v2 1/5] avformat/http: ff_http_do_new_request() returns EINVAL if re-used with different hostname

2017-12-13 Thread Jeyapal, Karthick
>On 12/13/17, 6:05 AM, "Aman Gupta" ffm...@tmm1.net> wrote: > >From: Aman Gupta > >This will prevent improper use of ff_http_do_new_request() if the user >tries to send a request for a different host to a previously connected >persistent http/1.1

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-16 Thread Jeyapal, Karthick
>On 11/16/17, 4:43 PM, "Nicolas George" wrote: Thanks for the reply. >I think that would work, thanks. > >But I see that in the other patches you call ffio_geturlcontext() >without checking its return value. That is not good at all, and that >would make Coverity squirm. > >If

Re: [FFmpeg-devel] [PATCH] avformat/tcp: enable TCP_NODELAY by default

2017-11-14 Thread Jeyapal, Karthick
>On 11/14/17, 2:47 AM, "Aman Gupta" wrote: > >>On Mon, Nov 13, 2017 at 12:37 PM, Nicolas George wrote: >> >> Why? >> > >To potentially reduce latency, particularly when using a protocol that >builds on top of tcp like http. Yes. Apart from the latency, overall

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-20 Thread Jeyapal, Karthick
>On 11/20/17, 1:01 PM, "刘歧" wrote: >> 在 2017年11月8日,17:22,Karthick J 写道: >> +{ "http_user_agent", "override User-Agent field in HTTP header", >> OFFSET(user_agent), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, E}, >What about dash_user_agent? The reason

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-20 Thread Jeyapal, Karthick
>On 11/20/17, 12:39 AM, "Marton Balint" wrote: >Thanks, there is one more thing I still don't get: [...] >> +// 1 second timeout >> +for (i = 0; i < 10; i++) { >> +av_usleep(10); >> +// Sometimes VideoInputFrameArrived is called before >>

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-20 Thread Jeyapal, Karthick
>On 11/17/17, 4:31 PM, "Nicolas George" <geo...@nsup.org> wrote: > >Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit : >> I have done the change as suggested. Please find the new patch attached. > >Sorry, but I still have doubts about it. >

Re: [FFmpeg-devel] [PATCH v2 2/3] libavformat/http: Handled multiple_requests option during write

2017-11-20 Thread Jeyapal, Karthick
Please ignore the below patch, and use the updated patch attached. Forgot to reset the end_chunked_post variable in the below patch. Sorry for the inconvenience caused. Regards, Karthick On 11/21/17, 10:24 AM, "Karthick J" wrote: --- libavformat/http.c | 5 + 1 file

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-19 Thread Jeyapal, Karthick
Looks like nobody has any objection for the below patch. Can somebody please push this. Regards, Karthick On 11/8/17, 2:53 PM, "Karthick J" wrote: --- doc/muxers.texi | 2 ++ libavformat/dashenc.c | 22 +++--- 2 files changed, 21 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-20 Thread Jeyapal, Karthick
>On 11/20/17, 1:47 PM, "刘歧" <l...@chinaffmpeg.org> wrote: >> 在 2017年11月20日,15:59,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >> >>> On 11/20/17, 1:01 PM, "刘歧" <l...@chinaffmpeg.org> wrote: >>>> 在 2017年11月8日,17:22,Karthick

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-21 Thread Jeyapal, Karthick
>On 11/22/17, 5:06 AM, "Marton Balint" wrote: > >Ok, applied the series with some minor whitespace/comment fixes. Great! Thanks. > >Thanks, >Marton Regards, Karthick ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-21 Thread Jeyapal, Karthick
>On 11/21/17, 8:24 PM, "Steven Liu" wrote: > […] >> +if (*pb == NULL || !http_base_proto || !hls->http_persistent) { >What about !*pb ? Thanks for your comments. I have modified the patch as per your suggestion and have attached the same. Regards, Karthick

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-16 Thread Jeyapal, Karthick
>On 11/16/17, 1:11 AM, "Marton Balint" wrote: Thanks for the reply. >For the first patch, I think you forgot to call ff_decklink_set_configs in >decklink_enc. ff_decklink_set_configs is not doing anything related to decklink_enc In any case I have added the same and have

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-15 Thread Jeyapal, Karthick
>On 11/15/17, 6:34 PM, "Nicolas George" wrote: >This is rather fragile. Some kind of check that is is actually a real >URLContext would be a very good idea. Thanks for the feedback. I have a relevant condition check so that only a real URLContext is returned. Please find the

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/{http, tls}: enable tcp_nodelay

2017-11-15 Thread Jeyapal, Karthick
>Hmm, I guess if we want this to propagate down we need to add the option to >the tls protocol as well, then pass it down when it instantiates the tcp >protocol. Then add the same option to hls/dash, and again propagate it >down >to tls or tcp. > >This is turning into a much bigger change than

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-15 Thread Jeyapal, Karthick
>>On Tue, Nov 7, 2017 at 2:34 AM Karthick J wrote: >>--- >> libavformat/avio_internal.h | 8 >> libavformat/aviobuf.c       | 8 >> 2 files changed, 16 insertions(+) > >LGTM. This would make my hls demuxer keepalive patch simpler as well. > >I know there were

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-03 Thread Jeyapal, Karthick
>On 11/3/17, 2:18 PM, "Nicolas George" wrote: >I strongly oppose this: we do not want new global state. I also agree. I am open to suggestions, and I would be happy re-implement this feature without new global state. >Also, I am very doubtful about the feature itself. It is

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-06 Thread Jeyapal, Karthick
>On 11/3/17, 9:44 PM, "Aman Gupta" wrote: > >I recently implemented keepalive support in the hls demuxer, and have been >using it with a lot of success. See my patchset: >http://ffmpeg.org/pipermail/ffmpeg-devel/2017-October/217353.html > >Aman Thanks a lot for your excellent

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-06 Thread Jeyapal, Karthick
>On 11/6/17, 6:19 AM, "Marton Balint" <c...@passwd.hu> wrote: > >>On Fri, 27 Oct 2017, Jeyapal, Karthick wrote: > >> Please find the patch attached. >> > >Thanks, below some comments: Thanks a lot for your detailed comments. I have incorporated

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/tcp: Added an option to reuse sockets

2017-11-07 Thread Jeyapal, Karthick
>On 11/7/17, 10:45 AM, "Jeyapal, Karthick" <kjeya...@akamai.com> wrote: > >>On 11/3/17, 9:44 PM, "Aman Gupta" <ffm...@tmm1.net> wrote: >> >>I recently implemented keepalive support in the hls demuxer, and have been >>using it with a

Re: [FFmpeg-devel] [PATCH 0/3] WebM in dashenc

2018-05-04 Thread Jeyapal, Karthick
On 5/3/18 10:11 PM, Jan Ekström wrote: > On Fri, Apr 27, 2018 at 3:51 AM, Jan Ekström wrote: >> Personally I would be for removal of the WebM muxing feature in dashenc >> altogether, since the dashenc feature has never seemingly worked, and >> since there is a whole separate

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashenc: Added option for Segment file format

2018-05-14 Thread Jeyapal, Karthick
On 5/12/18 8:47 PM, Jan Ekström wrote: > On Fri, May 4, 2018 at 9:32 AM, Karthick J wrote: >> From: Karthick Jeyapal >> >> Right now segment file format is chosen to be either mp4 or webm based on >> the codec format. >> This patch makes that choice

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/dashenc: Added option for Segment file format

2018-05-14 Thread Jeyapal, Karthick
On 5/14/18 11:55 AM, Gyan Doshi wrote: > > > On 5/14/2018 11:41 AM, Karthick J wrote: > >> Right now segment file format is chosen to be either mp4 or webm based on >> the codec format. >> This patch makes that choice configurable by the user, instead of being >> decided by the muxer. > > Can

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Add documentation for http method option

2018-05-13 Thread Jeyapal, Karthick
Pushed. On 5/7/18 9:23 AM, Karthick J wrote: > From: Karthick Jeyapal > > --- > doc/muxers.texi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index 2429f8e..ea80296 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dashenc: configuring container format options

2018-05-15 Thread Jeyapal, Karthick
Pushed. On 5/7/18 3:28 PM, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > --- > doc/muxers.texi | 4 > libavformat/dashenc.c | 7 +++ > 2 files changed, 11 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index db81901..e9082a4 100644 >

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/movenc: creating producer reference time (PRFT) box

2018-05-28 Thread Jeyapal, Karthick
Pushed Patchset. Regards, Karthick On 5/7/18 3:27 PM, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > The producer reference time box supplies relative wall-clock times > at which movie fragments, or files containing movie fragments > (such as segments) were produced. > The box is mainly

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/drawtext: present 'hms' formatted 'pts' in 24h format

2018-06-04 Thread Jeyapal, Karthick
Pushed. >On 5/7/18, 6:47 PM, "vdi...@akamai.com" wrote: > >From: Vishwanath Dixit > >HMS is formatted as HH:MM:SS.mmm, but, HH part is not limited to >24 hours. For example, the the drawn text may look like this: >243029:20:30.342. To present the timestamp in more readable and >user friendly

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Added a warning for incorrect segment name extension

2018-05-28 Thread Jeyapal, Karthick
Pushed Patchset. On 5/4/18 12:02 PM, Karthick J wrote: > From: Karthick Jeyapal > > Applicable only to webm output format. > By default all the segment filenames end with .m4s extension. > When someone chooses webm output format, we recommend they also override the >

Re: [FFmpeg-devel] [PATCH 0/3] WebM in dashenc

2018-05-03 Thread Jeyapal, Karthick
On 4/27/18 6:21 AM, Jan Ekström wrote: > Personally I would be for removal of the WebM muxing feature in dashenc > altogether, since the dashenc feature has never seemingly worked, and > since there is a whole separate WebM-specific DASH meta muxer in > webmdashenc. > > But these patches should

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dashenc: Set mp4 as the default format for VP9

2018-04-26 Thread Jeyapal, Karthick
On 4/23/18 11:40 AM, Karthick J wrote: > From: Karthick Jeyapal > > There is a separate muxer(webmdashenc.c) for supporting VP9+webm output in > DASH. > Hence in this muxer we will focus on supporting VP9 in MP4 > Have verified playout support of VP9+MP4 in Chrome and

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dashenc: Set mp4 as the default format for VP9

2018-04-26 Thread Jeyapal, Karthick
On 4/27/18 3:05 AM, Jan Ekström wrote: > On Thu, Apr 26, 2018 at 12:00 PM, Jeyapal, Karthick <kjeya...@akamai.com> > wrote: >> >> >> On 4/23/18 11:40 AM, Karthick J wrote: >>> From: Karthick Jeyapal <kjeya...@akamai.com> >>> >>> T

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/dashenc: Set mp4 as the default format for VP9

2018-04-26 Thread Jeyapal, Karthick
On 4/27/18 4:26 AM, Michael Niedermayer wrote: > On Fri, Apr 27, 2018 at 12:35:42AM +0300, Jan Ekström wrote: >> On Thu, Apr 26, 2018 at 12:00 PM, Jeyapal, Karthick <kjeya...@akamai.com> >> wrote: >>> >>> >>> On 4/23/18 11:40 AM, Kart

[FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-10-27 Thread Jeyapal, Karthick
Please find the patch attached. Regards, Karthick 0001-avdevice-decklink_dec-Autodetect-the-video-input-for.patch Description: 0001-avdevice-decklink_dec-Autodetect-the-video-input-for.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: Signal http end of chunk explicitly during hlsenc_io_close()

2017-12-22 Thread Jeyapal, Karthick
>On 12/22/17, 2:06 PM, "刘歧" wrote: > >> On 22 Dec 2017, at 15:04, Karthick J wrote: >> >> From: Karthick Jeyapal >> >> Currently http end of chunk is called implicitly in hlsenc_io_open(). >> This mean playlists http writes

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: Added a library-internal API for signalling end of chunk

2017-12-22 Thread Jeyapal, Karthick
On 12/22/17, 1:13 PM, "wm4" wrote: > >On Fri, 22 Dec 2017 12:34:41 +0530 >Karthick J wrote: > >> From: Karthick Jeyapal >> >> Right now there is no explicit way to signal end of chunk, when >> http_multiple is set. >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: improve compute target_duration way

2017-12-23 Thread Jeyapal, Karthick
On 12/23/17 8:02 PM, Steven Liu wrote: > > >> 在 2017年12月23日,下午6:38,Jeyapal, Karthick <kjeya...@akamai.com> 写道: >> >> >>> On 12/23/17 4:59 AM, Steven Liu wrote: >>> just use lrint(lrint(duration * 10.0) / 10.0) >>> fix ticket: 6915 >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: improve compute target_duration way

2017-12-23 Thread Jeyapal, Karthick
On 12/23/17 4:59 AM, Steven Liu wrote: > just use lrint(lrint(duration * 10.0) / 10.0) > fix ticket: 6915 > > Suggested-by: beloko > Signed-off-by: Steven Liu > --- > libavformat/dashenc.c | 2 +- > libavformat/hlsenc.c | 2 +- > 2 files changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Dont write stream info for agroup

2018-01-18 Thread Jeyapal, Karthick
On 1/18/18 6:53 PM, Brendan McGrath wrote: > I tried your suggestion and it still didn't work. So I took another look at > the spec and it looks like what was originally there was correct (as seen in > the below example): > https://tools.ietf.org/html/rfc8216#section-8.6 > > In that example -

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Signal http end of chunk(http_shutdown) explicitly

2018-01-25 Thread Jeyapal, Karthick
On 1/2/18 1:49 PM, Karthick J wrote: > From: Karthick Jeyapal > > Currently http end of chunk is signalled implicitly in dashenc_io_open(). > This mean playlists http writes would have to wait upto a segment duration to > signal end of chunk causing delays. > This patch

Re: [FFmpeg-devel] hls BANDWIDTH field in master playlist

2018-02-01 Thread Jeyapal, Karthick
On 2/1/18 3:12 PM, Amit Kale wrote: > Hi All, > > When emitting a master playlist, BANDWIDTH field is computed in > libavformat/hlsenc.c by adding video and audio stream bitrates and then > adding 10% to account for container overhead. However HLS specification > (RFC8216) says that BANDWIDTH

Re: [FFmpeg-devel] [PATCH 2/3] Add a new hls_flag peak_segment_bw

2018-02-18 Thread Jeyapal, Karthick
On 2/12/18 2:24 PM, Amit Kale wrote: > If this flag is set, BANDWIDTH value in a master playlist entry will be set to > the peak segment bandwidth. Thanks for sending the patch. Here are some comments. > --- > doc/muxers.texi | 4 > libavformat/hlsenc.c | 29

  1   2   3   >