Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 03:50 AM, Michael Niedermayer wrote: > On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >>

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-04 Thread John Stebbins
On 10/04/2017 10:13 AM, Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: >> On 10/04/2017 03:50 AM, Michael Niedermayer wrote: >>> On Fri, Sep 29, 2017 at 08:54:08AM -0700, John Stebbins wrote: >>>> When keyfr

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-05 Thread John Stebbins
On 10/04/2017 03:21 PM, Michael Niedermayer wrote: > On Wed, Oct 04, 2017 at 10:58:19AM -0700, John Stebbins wrote: >> On 10/04/2017 10:13 AM, Michael Niedermayer wrote: >>> On Wed, Oct 04, 2017 at 08:18:59AM -0700, John Stebbins wrote: >>>> On 10/04/2017 03:50

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins <jstebb...@jetheaddev.com>: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 02:27 PM, Carl Eugen Hoyos wrote: > 2017-09-25 23:12 GMT+02:00 John Stebbins <stebb...@jetheaddev.com>: >> FYI, such a facility for marking frames to drop would also >> be useful for frame accurate playback of MP4 edit lists. > Do you have samples with edi

[FFmpeg-devel] [PATCH 2/2] mov: fix non-monotonous DTS when fragments overlap in time

2017-10-01 Thread John Stebbins
--- libavformat/mov.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c7422cd9ed..bc3c9cb35b 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4267,6 +4267,7 @@ static int mov_read_trun(MOVContext *c,

[FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-09-29 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors.

[FFmpeg-devel] [PATCH 2/2] mov: fix non-monotonous DTS when fragments overlap in time

2017-09-29 Thread John Stebbins
--- libavformat/mov.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c7422cd9ed..871f10b240 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4267,6 +4267,7 @@ static int mov_read_trun(MOVContext *c,

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-28 Thread John Stebbins
On 09/26/2017 05:12 PM, Michael Niedermayer wrote: Hi On Mon, Sep 25, 2017 at 02:12:26PM -0700, John Stebbins wrote: On 09/25/2017 01:12 PM, Carl Eugen Hoyos wrote: 2017-09-25 19:10 GMT+02:00 John Stebbins <jstebb...@jetheaddev.com>: When keyframe intervals of dash se

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:31 AM, wm4 wrote: > On Mon, 25 Sep 2017 10:10:58 -0700 > John Stebbins <jstebb...@jetheaddev.com> wrote: > >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "t

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
On 09/25/2017 10:12 AM, Carl Eugen Hoyos wrote: > 2017-09-25 19:10 GMT+02:00 John Stebbins <jstebb...@jetheaddev.com>: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. Append new "trun" index >

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-09-25 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. Append new "trun" index entries to the end of the index instead of sorting by timestamp. Sorting by timestamp causes packets to be read out of decode order and results in decode errors.

[FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
When keyframe intervals of dash segments are not perfectly aligned, fragments in the stream can overlap in time. The previous sorting by timestamp causes packets to be read out of decode order and results in decode errors. Insert new "trun" index entries into index_entries in the order that the

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-09 Thread John Stebbins
On 10/06/2017 04:20 PM, Michael Niedermayer wrote: > On Thu, Oct 05, 2017 at 02:38:48PM -0700, John Stebbins wrote: >> On 10/05/2017 09:45 AM, John Stebbins wrote: >>> On 10/04/2017 03:21 PM, Michael Niedermayer wrote: >>>> On Wed, Oct 04, 2017 at 10:58:19AM -0700, Jo

Re: [FFmpeg-devel] [PATCH 1/2] mov: fix decode of fragments that overlap in time

2017-10-05 Thread John Stebbins
On 10/05/2017 09:45 AM, John Stebbins wrote: > On 10/04/2017 03:21 PM, Michael Niedermayer wrote: >> On Wed, Oct 04, 2017 at 10:58:19AM -0700, John Stebbins wrote: >>> On 10/04/2017 10:13 AM, Michael Niedermayer wrote: >>>> On Wed, Oct 04, 2017 at 08:18:59AM -0700, Jo

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-12 Thread John Stebbins
On 10/12/2017 10:22 AM, Michael Niedermayer wrote: > On Wed, Oct 11, 2017 at 10:56:41PM -0700, John Stebbins wrote: >> On 10/11/2017 06:25 PM, Michael Niedermayer wrote: >>> On Tue, Oct 10, 2017 at 06:11:08PM -0700, John Stebbins wrote: >>>> When keyfr

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-22 Thread John Stebbins
On 10/12/2017 10:59 AM, John Stebbins wrote: > When keyframe intervals of dash segments are not perfectly aligned, > fragments in the stream can overlap in time. The previous sorting by > timestamp causes packets to be read out of decode order and results > in decode errors. > >

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-25 Thread John Stebbins
On 11/25/2017 04:03 PM, Carl Eugen Hoyos wrote: > 2017-11-25 21:11 GMT+01:00 John Stebbins <jstebb...@jetheaddev.com>: >> An invalid file may cause huge alloc. Delay expansion of ctts entries >> until the number of samples is known in mov_build_index. > Please mention

[FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-25 Thread John Stebbins
An invalid file may cause huge alloc. Delay expansion of ctts entries until the number of samples is known in mov_build_index. --- libavformat/mov.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

[FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-26 Thread John Stebbins
An invalid file may cause huge alloc. Delay expansion of ctts entries until the number of samples is known in mov_build_index. Found-by: zhao dongzhuo, AD-lab of Venustech --- libavformat/mov.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix huge alloc in mov_read_ctts

2017-11-26 Thread John Stebbins
On 11/25/2017 05:03 PM, James Almer wrote: > On 11/25/2017 10:00 PM, John Stebbins wrote: >> On 11/25/2017 04:03 PM, Carl Eugen Hoyos wrote: >>> 2017-11-25 21:11 GMT+01:00 John Stebbins <jstebb...@jetheaddev.com>: >>>> An invalid file may cause huge all

[FFmpeg-devel] [PATCH] lavf/mov: fix crash in mov_read_sidx

2017-11-24 Thread John Stebbins
Use correct index into streams --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f3e86dfc6d..ddb1e59b85 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4816,7 +4816,7 @@ static int

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-22 Thread John Stebbins
On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: > 2017-08-24 0:39 GMT+02:00 Dale Curtis : > >> -sc->ctts_data[ctts_count].count= count; >> -sc->ctts_data[ctts_count].duration = duration; >> -ctts_count++; >> +/* Expand entries such that

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-11-30 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..c137fe4ae1 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,9 @@ FF_DISABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] lavc/libx265: mark disposable frames

2017-11-30 Thread John Stebbins
Remove redundant sliceType check. It is only needed if using x265 2.4 or below where sliceType BREF is never set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-30 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 312 ++--- 2 files changed, 130 insertions(+), 183 deletions(-) diff --git a/libavformat/isom.h

[FFmpeg-devel] [PATCH 4/6] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-30 Thread John Stebbins
--- libavformat/isom.h | 10 ++ libavformat/mov.c | 92 ++--- libavformat/utils.c | 3 +- 3 files changed, 99 insertions(+), 6 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 65676fb0f5..646b31ccc7 100644 ---

[FFmpeg-devel] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-30 Thread John Stebbins
Rebase to resolve conflicts. These 2 patches should be merged before commit. They are separated to make reviewing easier. Patch 4 alone does not account for edit list fix-ups. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-30 Thread John Stebbins
--- fftools/ffplay.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..152d220cdb 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -198,6 +198,8 @@ typedef struct Decoder { int64_t next_pts;

[FFmpeg-devel] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-30 Thread John Stebbins
Fix parenthesis in conditional ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [mov] Remove concept of ctts entries with count > 1.

2017-11-27 Thread John Stebbins
signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-23 Thread John Stebbins
On 11/23/2017 03:04 AM, Jerome Martinez wrote: > On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >> The matroska spec says blockduration == 0 means the frame is not a >> keyframe. Since all subtitles are "keyframes", 0 blockduration should >> not be written. > As I understand from discussion on

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-23 Thread John Stebbins
On 11/22/2017 05:26 PM, Carl Eugen Hoyos wrote: > 2017-11-23 1:30 GMT+01:00 John Stebbins <stebb...@jetheaddev.com>: >> On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: >>> 2017-08-24 0:39 GMT+02:00 Dale Curtis <dalecur...@chromium.org>: >>> >>>>

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-12-01 Thread John Stebbins
On 12/01/2017 08:25 AM, wm4 wrote: > On Thu, 30 Nov 2017 16:27:01 -0800 > John Stebbins <jstebb...@jetheaddev.com> wrote: > >> --- >> fftools/ffplay.c | 21 - >> 1 file changed, 16 insertions(+), 5 deletions(-) >> >> diff --git a

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: flag discardable packets as such

2017-12-15 Thread John Stebbins
On 12/13/2017 07:14 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > This only has an effect when muxing h265 streams originating from the > libx265 wrapper atm, as no

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: flag discardable packets as such

2017-12-15 Thread John Stebbins
On 12/15/2017 10:00 AM, James Almer wrote: > On 12/15/2017 2:56 PM, John Stebbins wrote: >> On 12/13/2017 07:14 PM, James Almer wrote: >>> Signed-off-by: James Almer <jamr...@gmail.com> >>> --- >>> libavformat/matroskaenc.c | 8 ++-- >>

[FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread John Stebbins
Potentially fixes: https://bugs.chromium.org/p/chromium/issues/detail?id=786269#c1 In theory, the crash can be triggered by an invalid stream that has either tfdt or trun outside of the moof --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c

[FFmpeg-devel] [PATCH] avformat/utils: preserve AV_PKT_FLAG_DISCARD in parse_packet

2017-11-10 Thread John Stebbins
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 2b2411ffe7..93a5a00105 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1457,6 +1457,7 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, int

[FFmpeg-devel] [PATCH] fate/mov: add test for overlapping fragments

2017-11-13 Thread John Stebbins
--- tests/fate/mov.mak | 4 ++ tests/ref/fate/mov-frag-overlap | 105 2 files changed, 109 insertions(+) create mode 100644 tests/ref/fate/mov-frag-overlap diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 01893a0767..1d20892e2f

[FFmpeg-devel] fate/mov overlapping fragments

2017-11-13 Thread John Stebbins
The sample required by the following patch cand be downloaded here: https://john.stebbins.name/owncloud/index.php/s/Tyw7MM6WdRBcljA/download ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
--- fftools/ffplay.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..f1e0522528 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -198,6 +198,8 @@ typedef struct Decoder { int64_t next_pts;

[FFmpeg-devel] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
This update to the patch incorporates Marton's suggestion to eliminate the effects of buffering on the selection of frames to drop. It ties the decision to start dropping disposable frames to the "early" frame drop logic that happens immediately after avcodec_receive_frame. And disposable frames

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-19 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 254 +++-- 2 files changed, 93 insertions(+), 162 deletions(-) diff --git a/libavformat/isom.h

[FFmpeg-devel] mp4 sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
Patch 4 & 5 should be squashed before commit. Patch 4 "works" on it's own, but doesn't account for edit list fix-ups. I seperated them to make reviewing easier. Patch 5 merges ctts_data into the new mov_index_entries struct I created, so it touches quite a lot, but results in a fair amount of

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-11-19 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..8279a99ddd 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,10 @@

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
--- fftools/ffplay.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..97555d5047 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -257,6 +257,7 @@ typedef struct VideoState { struct SwrContext *swr_ctx; int

[FFmpeg-devel] [PATCH 5/6] lavf/mov: fix disposable flags in mov_fix_index

2017-11-19 Thread John Stebbins
Merges ctts_data into mov_index_entries. This allows a considerable amount of code simplification. --- libavformat/isom.h | 1 + libavformat/mov.c | 254 +++-- 2 files changed, 93 insertions(+), 162 deletions(-) diff --git a/libavformat/isom.h

[FFmpeg-devel] [PATCH 4/6] lavf/mov: set AV_PKT_FLAG_DISPOSABLE from sdtp box

2017-11-19 Thread John Stebbins
--- libavformat/isom.h | 10 ++ libavformat/mov.c | 92 ++--- libavformat/utils.c | 3 +- 3 files changed, 99 insertions(+), 6 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 65676fb0f5..646b31ccc7 100644 ---

Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: > 2017-11-19 21:46 GMT+01:00 John Stebbins <jstebb...@jetheaddev.com>: >> The sdtp is required by the AppleTV 4K in order to play 2160p60 video. >> +/** >> + * Flag is used to indicate packets that contain frames t

[FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-19 Thread John Stebbins
The sdtp is required by the AppleTV 4K in order to play 2160p60 video. --- libavcodec/avcodec.h | 6 ++ libavformat/isom.h | 5 + libavformat/movenc.c | 30 ++ libavformat/movenc.h | 2 ++ 4 files changed, 43 insertions(+) diff --git

[FFmpeg-devel] [PATCH 2/6] lavc/libx264: mark disposable frames

2017-11-19 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx264.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91f33..1831f9b30e 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -116,6 +116,7 @@ static int

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
--- fftools/ffplay.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..97555d5047 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -257,6 +257,7 @@ typedef struct VideoState { struct SwrContext *swr_ctx; int

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-19 Thread John Stebbins
On 11/19/2017 01:28 PM, Marton Balint wrote: > On Sun, 19 Nov 2017, John Stebbins wrote: > >> --- >> fftools/ffplay.c | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c >> index 10a917194d..97555d5047

Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-20 Thread John Stebbins
On 11/19/2017 02:29 PM, Carl Eugen Hoyos wrote: > 2017-11-19 23:25 GMT+01:00 John Stebbins <stebb...@jetheaddev.com>: >> On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: >>> 2017-11-19 21:46 GMT+01:00 John Stebbins <jstebb...@jetheaddev.com>: >>>> The s

Re: [FFmpeg-devel] [PATCH]lavf/matroskaenc: Do not write 0 duration for subtitles

2017-11-15 Thread John Stebbins
On 11/14/2017 02:18 PM, Carl Eugen Hoyos wrote: > 2017-11-14 19:02 GMT+01:00 Jerome Martinez : >> On 12/11/2017 03:12, Carl Eugen Hoyos wrote: >>> -put_ebml_uint(pb, MATROSKA_ID_BLOCKDURATION, duration); >>> +if (duration > 0) >>> +

[FFmpeg-devel] [PATCH] lavf/movenc: allow writing avc3 sample entry type

2017-11-15 Thread John Stebbins
The avc3 sample entry type is useful for adaptive streaming. It permits parameter sets to be written inline in the video stream. --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index cc3fc19d9b..01ae467fa1 100644 ---

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-02 Thread John Stebbins
On 12/02/2017 09:25 AM, James Almer wrote: > On 12/2/2017 1:52 PM, John Stebbins wrote: >> On 12/02/2017 01:40 AM, Marton Balint wrote: >>> On Thu, 30 Nov 2017, John Stebbins wrote: >>> >>>> Used by movenc to fill sdtp box >>>> --- >&

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-02 Thread John Stebbins
On 12/02/2017 01:40 AM, Marton Balint wrote: > On Thu, 30 Nov 2017, John Stebbins wrote: > >> Used by movenc to fill sdtp box >> --- >> libavcodec/libx265.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/libx265.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-12-04 Thread John Stebbins
On 12/03/2017 01:12 PM, Marton Balint wrote: > On Thu, 30 Nov 2017, John Stebbins wrote: > >> --- >> fftools/ffplay.c | 21 - >> 1 file changed, 16 insertions(+), 5 deletions(-) >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c &g

[FFmpeg-devel] lavc/libx265: mark disposable frames

2017-12-05 Thread John Stebbins
Add ifdef to support versions of x265 <= 2.4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-05 Thread John Stebbins
Used by movenc to fill sdtp box --- libavcodec/libx265.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 4456e300f2..69bfc4fdaa 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -329,6 +329,13 @@

Re: [FFmpeg-devel] [PATCH 3/6] lavc/libx265: mark disposable frames

2017-12-03 Thread John Stebbins
ail.com>: >>>>> On 12/2/2017 2:40 PM, Carl Eugen Hoyos wrote: >>>>>> 2017-12-02 18:37 GMT+01:00 John Stebbins <stebb...@jetheaddev.com>: >>>>>>> That should be done, or I should add back support for earlier versions. >>>&g

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-18 Thread John Stebbins
On 06/18/2018 07:30 AM, Gyan Doshi wrote: > > On 17-06-2018 10:07 AM, Gyan Doshi wrote: > >>> Just need to make a note to myself to fix HandBrake when we >>> update to a version of ffmpeg with the change. >> I can just use an if-else to check for both, giving priority to 'handler'. > When I wrote

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread John Stebbins
On 06/16/2018 03:49 AM, Gyan Doshi wrote: > Activates functionality added a few years ago. > > Regards, > Gyan > FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it was the only occurrence of usage of this

[FFmpeg-devel] [PATCH] h264_slice: Fix return of incomplete frames from decoder

2018-06-27 Thread John Stebbins
When not using libavformat for demuxing, AVCodecContext.has_b_frames gets set too late causing the recovery frame heuristic in h264_refs to incorrectly flag an early frame as recovered. This patch sets has_b_frames earlier to prevent improperly flagging the frame as recovered. ---

Re: [FFmpeg-devel] [PATCH] mov: fix decode of fragments that overlap in time

2017-10-23 Thread John Stebbins
On 10/23/2017 03:24 AM, Michael Niedermayer wrote: > On Thu, Oct 12, 2017 at 10:59:23AM -0700, John Stebbins wrote: >> When keyframe intervals of dash segments are not perfectly aligned, >> fragments in the stream can overlap in time. The previous sorting by >> timestamp caus

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Fail when codec tag is invalid for format

2018-08-24 Thread John Stebbins
On 08/24/2018 11:15 AM, John Stebbins wrote: > Fixes ticket #6897 > --- > libavformat/movenc.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 8ad7026741..fb001f9195 10064

[FFmpeg-devel] [PATCH] lavf/movenc: Fail when codec tag is invalid for format

2018-08-24 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8ad7026741..4507666863 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1596,23 +1596,21 @@

[FFmpeg-devel] [PATCH] lavf/movenc: Fail when codec tag is invalid for format

2018-08-24 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8ad7026741..fb001f9195 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1596,23 +1596,21 @@

[FFmpeg-devel] [PATCH] lavf/movenc: Fail when codec tag is invalid for format

2018-08-25 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 72a6e12d52..93bb50ce86 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

Re: [FFmpeg-devel] [PATCH 3/4] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
On 08/27/2018 02:03 PM, James Almer wrote: > On 8/27/2018 5:48 PM, John Stebbins wrote: >> On 08/27/2018 01:29 PM, James Almer wrote: >>> On 8/27/2018 4:57 PM, John Stebbins wrote: >>>> Fixes ticket #6897 >>>> --- >>>> libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH 3/4] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
On 08/27/2018 01:29 PM, James Almer wrote: > On 8/27/2018 4:57 PM, John Stebbins wrote: >> Fixes ticket #6897 >> --- >> libavformat/movenc.c | 40 +--- >> 1 file changed, 29 insertions(+), 11 deletions(-) >> >> diff --g

[FFmpeg-devel] [PATCH 3/3] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 46 +--- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8a3b651514..bce7ad0939 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

[FFmpeg-devel] [PATCH 3/3] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 46 +--- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8a3b651514..3ebc7abd8b 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

[FFmpeg-devel] [PATCH 3/4] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
Fixes ticket #6897 --- libavformat/movenc.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8a3b651514..dd6281d210 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@

[FFmpeg-devel] [PATCH] lavf/mov: Fix PCM audio w/ bit depth > 16

2018-08-27 Thread John Stebbins
This type of audio is defined by the QT spec, but can be found in non-QT branded files in the wild. Fixes ticket #7376 --- libavformat/mov.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8915e3b9e0..3d4f6bcb21 100644 ---

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Fail when codec tag is invalid for format

2018-08-27 Thread John Stebbins
On 08/27/2018 10:59 AM, Michael Niedermayer wrote: > On Sat, Aug 25, 2018 at 09:04:44AM -0700, John Stebbins wrote: >> Fixes ticket #6897 >> --- >> libavformat/movenc.c | 40 +--- >> 1 file changed, 29 insertions(+), 11 deletions(-)

[FFmpeg-devel] [PATCH 2/4] lavf/movenc: Add GoPro metadata to permitted mp4 "codecs"

2018-08-27 Thread John Stebbins
--- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 72a6e12d52..8a3b651514 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6778,6 +6778,7 @@ const AVCodecTag codec_mp4_tags[] = { { AV_CODEC_ID_EVRC

[FFmpeg-devel] [PATCH 1/4] lavf/mov: add AVCodecTag entry for GoPro metadata

2018-08-27 Thread John Stebbins
This allows for validation of the track type --- libavformat/isom.c | 5 + libavformat/isom.h | 1 + libavformat/mov.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index ce66d1bcd4..ca9d22e4f7 100644 --- a/libavformat/isom.c +++

[FFmpeg-devel] [PATCH] lavf/mov: factor out setting codec_id

2018-08-31 Thread John Stebbins
Since it is performed in all cases now. --- libavformat/mov.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3d4f6bcb21..4ee67cf500 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2508,22 +2508,19 @@ int

Re: [FFmpeg-devel] [PATCH 3/4] lavf/movenc: Fail when codec tag is invalid for format

2018-09-07 Thread John Stebbins
On 09/06/2018 03:40 PM, James Almer wrote: > On 8/27/2018 6:07 PM, John Stebbins wrote: >> On 08/27/2018 02:03 PM, James Almer wrote: >>> On 8/27/2018 5:48 PM, John Stebbins wrote: >>>> On 08/27/2018 01:29 PM, James Almer wrote: >>>>> On 8/27/2018 4:57

Re: [FFmpeg-devel] [PATCH 3/4] lavf/movenc: Fail when codec tag is invalid for format

2018-09-07 Thread John Stebbins
On 09/07/2018 08:16 AM, James Almer wrote: > On 9/7/2018 12:09 PM, John Stebbins wrote: >> On 09/06/2018 03:40 PM, James Almer wrote: >>> On 8/27/2018 6:07 PM, John Stebbins wrote: >>>> On 08/27/2018 02:03 PM, James Almer wrote: >>>>> On 8/27/2018 5:48

Re: [FFmpeg-devel] [PATCH 1/2] Use QT format for audio sample descriptors depending on stsd version.

2018-09-06 Thread John Stebbins
On 09/06/2018 09:18 AM, Derek Buitenhuis wrote: > On 06/09/2018 17:13, Carl Eugen Hoyos wrote: >> Please mention ticket #7376 (and the Handbrake issue) in the commit >> message. > Wasn't aware there were tickets already, woops. > > Added locally. > > Looks like this also supersedes my earlier

Re: [FFmpeg-devel] [PATCH] lavf/mov: Fix PCM audio w/ bit depth > 16

2018-08-31 Thread John Stebbins
On 08/30/2018 04:43 PM, Michael Niedermayer wrote: > On Mon, Aug 27, 2018 at 12:59:28PM -0700, John Stebbins wrote: >> This type of audio is defined by the QT spec, but can be found in >> non-QT branded files in the wild. >> >> Fixes ticket #7376 >&g

Re: [FFmpeg-devel] [PATCH 1/4] lavf/mov: add AVCodecTag entry for GoPro metadata

2018-08-31 Thread John Stebbins
On 08/30/2018 03:59 PM, Michael Niedermayer wrote: > On Mon, Aug 27, 2018 at 12:57:07PM -0700, John Stebbins wrote: >> This allows for validation of the track type >> --- >> libavformat/isom.c | 5 + >> libavformat/isom.h | 1 + >> libavformat/mov.c | 3 +++

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread John Stebbins
On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: 2019-01-30 19:44 GMT+01:00, no pls : From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 Please wait for a