Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-10-12 Thread Jonathan Campbell
noddfieldcc.vob?dl=0 On 09/15/2016 02:49 PM, Carl Eugen Hoyos wrote: > 2016-09-15 21:52 GMT+02:00 Jonathan Campbell : > >> Do you need me to upload a small 20-second clip of the VOB where >> the garbled captions are visible? > > I believe it

Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-10-13 Thread Jonathan Campbell
AM, Carl Eugen Hoyos wrote: > 2016-10-13 8:29 GMT+02:00 Jonathan Campbell : >> I just realized this has been sitting in my inbox for awhile. >> >> Here's the clip in question. >> >> If you play it in VLC player with "Closed Captions 1" selected, you'll

[FFmpeg-devel] CNG (consistent noise generation) idea

2016-08-30 Thread Jonathan Campbell
"cng" as a boolean set to 0 or 1, off by default. Any suggestions? Jonathan Campbell ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-01 Thread Jonathan Campbell
I finished the consistent noise generation patch for AC-3 decoding. Set AVOption "cons_noisegen" to 1 (true) to enable it. Git repository: https://github.com/joncampbell123/FFmpeg.git commit dbd086586f0ad1591ea2013293bbb6e4dbfd0455 Author: Jonathan Campbell Date: Thu Sep 1 18:

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-01 Thread Jonathan Campbell
On 09/01/2016 07:13 PM, Michael Niedermayer wrote: On Thu, Sep 01, 2016 at 06:59:46PM -0700, Jonathan Campbell wrote: I finished the consistent noise generation patch for AC-3 decoding. Set AVOption "cons_noisegen" to 1 (true) to enable it. Git repository: https://github.com/jonc

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-01 Thread Jonathan Campbell
On 09/01/2016 07:13 PM, Michael Niedermayer wrote: On Thu, Sep 01, 2016 at 06:59:46PM -0700, Jonathan Campbell wrote: I finished the consistent noise generation patch for AC-3 decoding. Set AVOption "cons_noisegen" to 1 (true) to enable it. Git repository: https://github.com/jonc

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
CRC computation isn't fast enough? What should I use then? A sum of byte values? Jonathan Campbell CASTUS On 09/02/2016 04:50 AM, Michael Niedermayer wrote: On Thu, Sep 01, 2016 at 06:59:46PM -0700, Jonathan Campbell wrote: I finished the consistent noise generation patch for AC-3 dec

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
On 09/02/2016 04:50 AM, Michael Niedermayer wrote: On Thu, Sep 01, 2016 at 06:59:46PM -0700, Jonathan Campbell wrote: I finished the consistent noise generation patch for AC-3 decoding. Set AVOption "cons_noisegen" to 1 (true) to enable it. Git repository: https://github.com/jonc

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
On 09/02/2016 01:01 PM, Michael Niedermayer wrote: On Fri, Sep 02, 2016 at 10:19:23AM -0700, Jonathan Campbell wrote: [...] CRC computation isn't fast enough? What should I use then? A sum of byte values? av_lfg_init() calls av_md5_sum() av_md5_sum() is too slow to be called per ac3

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
On 09/02/2016 01:56 PM, Michael Niedermayer wrote: On Fri, Sep 02, 2016 at 01:13:33PM -0700, Jonathan Campbell wrote: On 09/02/2016 01:01 PM, Michael Niedermayer wrote: On Fri, Sep 02, 2016 at 10:19:23AM -0700, Jonathan Campbell wrote: [...] CRC computation isn't fast enough? What sho

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
On 09/02/2016 04:37 PM, Michael Niedermayer wrote: On Fri, Sep 02, 2016 at 04:05:44PM -0700, Jonathan Campbell wrote: On 09/02/2016 01:56 PM, Michael Niedermayer wrote: On Fri, Sep 02, 2016 at 01:13:33PM -0700, Jonathan Campbell wrote: On 09/02/2016 01:01 PM, Michael Niedermayer wrote: On

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-02 Thread Jonathan Campbell
?). I'll format the patch correctly. Jonathan Campbell ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-03 Thread Jonathan Campbell
On 09/02/2016 05:35 PM, Michael Niedermayer wrote: > On Fri, Sep 02, 2016 at 05:31:35PM -0700, Jonathan Campbell wrote: >>> should be in a different patch >>> also needs minor version bump and APIChanges update >>> >>> also please generate patches with git

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-03 Thread Jonathan Campbell
On 09/03/2016 04:09 AM, Carl Eugen Hoyos wrote: > Hi! > > 2016-09-03 12:50 GMT+02:00 Jonathan Campbell : > >> Here you go (as attachments). > > The changes to lfg and the version bump must be one patch. > >> +{ "cons_noisegen", "

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-03 Thread Jonathan Campbell
On 09/03/2016 01:32 PM, Rostislav Pehlivanov wrote: > On 2 September 2016 at 02:59, Jonathan Campbell < > jonat...@impactstudiopro.com> wrote: > >> I finished the consistent noise generation patch for AC-3 decoding. >> >> Set AVOption "cons_noisegen" to

Re: [FFmpeg-devel] CNG (consistent noise generation) patch for AC-3 decoder

2016-09-03 Thread Jonathan Campbell
On 09/03/2016 07:07 AM, James Almer wrote: > On 9/3/2016 7:50 AM, Jonathan Campbell wrote: >> +int av_lfg_init_from_data(AVLFG *c, const uint8_t *data, unsigned int >> length) { >> +unsigned int beg, end, segm; >> +const AVCRC *avcrc; >> +uint32_t c

[FFmpeg-devel] Discussion: How to extend the AVFrame to hold caption data?

2016-09-03 Thread Jonathan Campbell
ension could allow FFMPEG to transcode DVD or HDTV broadcasts while keeping the caption data intact. Similar standards exist to carry caption data packets in H.264 (as SEI packets) and DV video (as DIF packets). Jonathan Campbell ___ ffmpeg-devel

Re: [FFmpeg-devel] Discussion: How to extend the AVFrame to hold caption data?

2016-09-03 Thread Jonathan Campbell
ied, removed > or duplicated (mainly by video filters but also by ffmpeg's video sync > code). > > 2016-09-04 6:14 GMT+03:00 Jonathan Campbell : > >> While I'm finishing up the CNG patch, I'd like to start developing another >> feature that I think FFMPE

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Jonathan Campbell
tchwork to find patches needing review or > pushing. > @end enumerate > > @section Patch review process > I only see one of the 4 patches for AC-3 consistent noise generation (the libavutil version bump) on the patchwork site. Can I assume the other three will make their way into the patch

[FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Jonathan Campbell
n field or even encode extra fields and switch starting fields. Part of the patch is to document comprehensively the format of the DVD caption packet. Jonathan Campbell >From 9213012c7d8ceef2af43fe3c218b1b50728e8f80 Mon Sep 17 00:00:00 2001 From: Jonathan Campbell Date: Mon, 12 Sep 2016 12:3

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-12 Thread Jonathan Campbell
On 09/12/2016 04:56 PM, Michael Niedermayer wrote: > On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: >> These patches fix up the DVD caption handling in mpeg12dec.c to better >> handle odd cases. >> It's based on code I've written elsewhere to

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Jonathan Campbell
On 09/12/2016 07:58 PM, Michael Niedermayer wrote: > On Mon, Sep 12, 2016 at 06:19:43PM -0700, Jonathan Campbell wrote: >> >> >> On 09/12/2016 04:56 PM, Michael Niedermayer wrote: >>> On Mon, Sep 12, 2016 at 03:28:24PM -0700, Jonathan Campbell wrote: >>>

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Jonathan Campbell
On 09/13/2016 12:42 PM, Moritz Barsnick wrote: > On Mon, Sep 12, 2016 at 18:19:43 -0700, Jonathan Campbell wrote: >> Subject: [PATCH 2/7] read caption words field-wise, count properly and limit >> to cc_count. transfer each CC word taking into consideration immediate CC >&

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-14 Thread Jonathan Campbell
or with explanation why not > > thx > > [...] Do you need me to resubmit the patches for the AC-3 consistent noise generation as well? Jonathan Campbell ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-14 Thread Jonathan Campbell
> yes, please resbmit the remaining patch/changes with any comments > from everyone taken care of or with explanation why not > > thx Here you go, squashed into one patch. Sentences ending with a period have been capitalized and printf typecasts removed (Moritz). Jonathan C

[FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Jonathan Campbell
ch to mpeg12enc.c to encode A53 captions from the side data. Jonathan Campbell >From 8d64027573588a62728faebba55d67c00a3d4e3f Mon Sep 17 00:00:00 2001 From: Jonathan Campbell Date: Wed, 14 Sep 2016 10:57:04 -0700 Subject: [PATCH] Read cc words field-wise, limit to cc_count and support extr

Re: [FFmpeg-devel] [PATCH] lavc/mpeg12dec.c: Read cc words field-wise, limit to cc_count and support extra field.

2016-09-15 Thread Jonathan Campbell
On 09/15/2016 12:31 PM, Carl Eugen Hoyos wrote: > 2016-09-15 20:49 GMT+02:00 Jonathan Campbell : > >> This updates the mpeg12dec.c DVD caption decoding to decode >> field-wise and handle caption packets with an extra field. It obeys >> the cc_count field, though still