[FFmpeg-devel] [PATCH] avdevice/xcbgrab: Handle reply and error properly

2019-11-19 Thread Kusanagi Kouichi
Fix a NULL dereference and leaks. Signed-off-by: Kusanagi Kouichi --- libavdevice/xcbgrab.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index b7e689343e..063fecf838 100644 --- a/libavdevice/xcbgrab.c +++ b/libavdevice/xcbgrab.c

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-11-19 Thread Kusanagi Kouichi
headers:0kB muxing overhead: unknown bench: utime=1.231s stime=2.407s rtime=4.349s bench: maxrss=40096kB Signed-off-by: Kusanagi Kouichi --- libavdevice/xcbgrab.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/libavdevice/xcbgrab.c b

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Handle reply and error properly

2019-12-03 Thread Kusanagi Kouichi
On 2019-11-19 22:59:30 +0900, Kusanagi Kouichi wrote: > Fix a NULL dereference and leaks. > > Signed-off-by: Kusanagi Kouichi > --- > libavdevice/xcbgrab.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c > i

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > Use AVBufferPool. > > before: > $ ffmpeg -benchmark -f x11grab -video_size 1920x1200 -r 200 -t 3 -i +0,0 -f > null - > ... > frame= 600 fps=102 q=-0.0 Lsize=N/A time=00:00:03.00 bitrate=N/A speed=0.51x > video:314k

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > > > Use AVBufferPool. > > You don't need a buffer pool for the non-shm case, you should wrap

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-05 Thread Kusanagi Kouichi
On 2019-12-04 22:32:52 +0100, Marton Balint wrote: > > > On Wed, 4 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > > > > > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > > &