e new option.
This should make it evident that the option can also be used for applying
minor timing corrections to the subtitles.
Any feedback is welcome.
Best regards,
Manolis
On Sun, 3 May 2020 at 17:34, Gyan Doshi wrote:
>
>
> On 03-05-2020 08:36 pm, Manolis Stamatogiannakis wrot
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Hello,
I've noticed what appears to be a bug/missing feature in the subtitles
filter: when "-ss" is used for the input, it is not applied to the
subtitles stream. E.g., for the following command line, the video playback
will start on 20:10, but the subtitles will start from 00:00.
ffmpeg -re -ss
Bumping this up after 10 days without a comment.
On Fri, 8 May 2020 at 13:14, Manolis Stamatogiannakis
wrote:
> Allows shifting of subtitle display times to align them with the video.
> This avoids having to rewrite the subtitle file in order to display
> subtitles correctly w
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Good catch. I've fixed the text and resubmitted.
Thanks.
Manolis
On Fri, 8 May 2020 at 12:33, Bodecs Bela wrote:
> see may comment in text
>
> 2020.05.03. 20:08 keltezéssel, Manolis Stamatogiannakis írta:
> > Allows shifting of subtitle display times to align them
Hi David,
Not a full review, but a minor point that popped in mind.
It is common to pad serially numbered files with 0. E.g. if you have <1000
files, the 9th file will be named file009.txt.
Is this case handled by the expansion? Or is it assumed that the text file
numbers are not zero-padded?
les filter with the patch does
not prevent fast-seeking. And you also have the added benefit of adjusting
subtitles delay without having to rewrite them.
Regards,
Manolis
On Mon, 4 May 2020 at 11:38, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-05-03):
> > I've noticed what appears
The section has been expanded to outline how to manage patch revisions.
---
doc/developer.texi | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index b33cab0fc7..dec27cb509 100644
---
, Andriy Gelman wrote:
> On Sun, 05. Jul 20:34, Manolis Stamatogiannakis wrote:
> > On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong
> > wrote:
> >
> > >
> > > You can use `git format-patch -v -n` to get patches like [PATCH
> > > v2 1/20]. See
Adding a new codec/format should be more rare, so it makes sense
to come after the detailed patch submission checklist.
Signed-off-by: Manolis Stamatogiannakis
---
doc/developer.texi | 105 ++---
1 file changed, 52 insertions(+), 53 deletions(-)
diff
- Main text split to two sections.
- Detailed checklist for new codecs or formats demoted to section.
- Detailed checklist for patch submission demoted to section.
Signed-off-by: Manolis Stamatogiannakis
---
doc/developer.texi | 64 +++---
1 file changed
:
> Hi,
>
> Am Donnerstag, 9. Juli 2020, 02:56:28 CEST schrieb Manolis
> Stamatogiannakis:
> > On Tue, 7 Jul 2020 at 16:27, Nicolas George wrote:
> > > > Is tree threading that important? A PR is essentially a single
> thread of
> > > > discussion.
> >
On Tue, 7 Jul 2020 at 13:31, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-07-07):
> > We don't live in a world of innocence. Enabling "less secure"
> applications
> > is trouble waiting to happen.
>
> Please don't believe that "less secure&q
On Tue, 7 Jul 2020 at 12:46, Nicolas George wrote:
>
> * GMail's warnings about "less secure" applications are scare tactics to
> get you to exclusively use their products, because they cannot feed
> you advertisement when you use a real mail client with their IMAP and
> SMTP servers.
>
>
On Tue, 7 Jul 2020 at 14:59, Nicolas George wrote:
>
> Is there a way of interacting with the discussions in GitHub issues
> outside their web interface?
>
> If there is, I never found it. If there is not, then GitHub's issue
> system is just not usable for serious work.
>
Any activity on
On Tue, 7 Jul 2020 at 14:38, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-07-07):
> > I believe I have adequately explained that "less secure" needs to be
> > enabled, not to make your Google account more secure, but to contain
> > the damage from a po
On Tue, 7 Jul 2020 at 16:07, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-07-05):
>
> > +@item If you send your patches with an external email client
> > +(i.e. not @code{git send-email}), make sure to send each patch as a
> separate
> > +email. Do
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
,
Manolis
On Sun, 5 Jul 2020 at 16:06, Steinar H. Gunderson <
steinar+ffm...@gunderson.no> wrote:
> On Sun, Jul 05, 2020 at 03:42:34PM +0200, Manolis Stamatogiannakis wrote:
> > Q2: In a patchset consisting of several commits, is each commit expected
> to
> > be "standalone
Adding a new codec/format should be more rare, so it makes sense
to come after the detailed patch submission checklist.
Signed-off-by: Manolis Stamatogiannakis
---
doc/developer.texi | 105 ++---
1 file changed, 52 insertions(+), 53 deletions(-)
diff
- Documentation for adding a roll-counter.
- Mention the possibility to manualy supersede/withdraw patches on
patchwork.
Signed-off-by: Manolis Stamatogiannakis
---
doc/developer.texi | 41 +
1 file changed, 29 insertions(+), 12 deletions(-)
diff
- Main text split to two sections.
- Detailed checklist for new codecs or formats demoted to section.
- Detailed checklist for patch submission demoted to section.
Signed-off-by: Manolis Stamatogiannakis
---
doc/developer.texi | 64 +++---
1 file changed
On Thu, 9 Jul 2020 at 22:39, Michael Niedermayer
wrote:
>
> > @Michael Niedermayer, since you seem to be the most involved with
> patchwork
> > in the thread, what would be better for this? Keep the wording as a
> > recommendation, or to move it outside the list as purely informational
> text?
>
On Tue, 7 Jul 2020 at 19:14, Michael Niedermayer
wrote:
>
> a lot of patchwork patch maintaince can be automated, ive written a script
> to do that.
> What this does is basically look at local git, fetch all patches from
> patchwork
> (and cache them locally)
> and then find stuff which is
On Tue, 7 Jul 2020 at 16:27, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-07-07):
> > If I reply to the email, my response will appear online in the issue/PR
> > page.
>
> That is good to know. I have never noticed it documented. Does it work
> reliably?
On Tue, 7 Jul 2020 at 16:00, Nicolas George wrote:
> Manolis Stamatogiannakis (12020-07-05):
> > The section has been expanded to outline how to manage patch revisions.
> > ---
> > doc/developer.texi | 37 ++---
> > 1 file changed, 26
Fair point. I've submitted a v2 where the docs reorganization is applied
first.
On Sun, 5 Jul 2020 at 17:30, Gyan Doshi wrote:
>
>
> On 05-07-2020 06:35 pm, Manolis Stamatogiannakis wrote:
> > Some options are common between subtitles/ass filters.
> > Rather than menti
On Sun, 5 Jul 2020 at 19:01, Kieran Kunhya wrote:
>
> For new contributors git send-email is annoying. For people wanting to
> push, the .mbox format is annoying, Gmail doesn't support it any more.
> And you can't get new contributors to start using CLI based email
> clients or run their own
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Some options are common between subtitles/ass filters.
Rather than mentioning for each option whether it is common or not,
the options are now displayed in two separate tables.
Signed-off-by: Manolis Stamatogiannakis
---
doc/filters.texi | 12
1 file changed, 8 insertions(+), 4
Some options are common between subtitles/ass filters.
Rather than mentioning for each option whether it is common or not,
the options are now displayed in two separate tables.
Signed-off-by: Manolis Stamatogiannakis
---
doc/filters.texi | 12
1 file changed, 8 insertions(+), 4
On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong
wrote:
>
> You can use `git format-patch -v -n` to get patches like [PATCH
> v2 1/20]. See git-format-patch documentation for more details.
>
>
That didn't quite work.
I used "git format-patch -s -n -v3 --to ffmpeg-devel@ffmpeg.org
HEAD~2..HEAD" and
Some options are common between subtitles/ass filters.
Rather than mentioning for each option whether it is common or not,
the options are now displayed in two separate tables.
Signed-off-by: Manolis Stamatogiannakis
---
doc/filters.texi | 18 +++---
1 file changed, 11 insertions
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Hello,
I'm trying to submit a patch for adding a "shift" option to subtitles/ass
filters. Initial submission was ok, but resubmitting after addressing some
emails didn't go as expected.
I have the following two questions on the process:
Q1: How do you get the "v2" label when you resubmit a
Previously option implemented only for subtitles filter.
Signed-off-by: Manolis Stamatogiannakis
---
libavfilter/vf_subtitles.c | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c
index
Allows shifting of subtitle display times to align them with the video.
This avoids having to rewrite the subtitle file in order to display
subtitles correctly when input is seeked (-ss).
Also handy for minor subtitle timing corrections without rewriting the
subtitles file.
Signed-off-by: Manolis
Some options are common between subtitles/ass filters.
Rather than mentioning for each option whether it is common or not,
the options are now displayed in two separate tables.
Signed-off-by: Manolis Stamatogiannakis
---
doc/filters.texi | 12
1 file changed, 8 insertions(+), 4
Bumping this once more.
On Thu, 22 Jul 2021 at 16:19, Gyan Doshi wrote:
>
>
> On 2021-07-22 00:08, Manolis Stamatogiannakis wrote:
> > Would it be possible to have a quick review for this patch? It is pretty
> > straightforward.
>
> Will test within a fe
Would it be possible to have a quick review for this patch? It is pretty
straightforward.
Plus, this is its second submission. It already includes the requested
changes from the first time (~1y ago).
Thanks in advance,
Manolis
On Sun, 4 Jul 2021 at 18:13, Manolis Stamatogiannakis
wrote
42 matches
Mail list logo
