[FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
???Source reference??? in those docs but I used the metadata key reel_name because thats what FFmbc calls it. Mark Reid (1): read reel_name metadata from tmcd atom libavformat/mov.c | 20 1 file changed, 20 insertions(+) -- 2.0.0

Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
Thanks for the quick feed back! I attached a small sample file, the media was generated with Davinci Resolve. On Wed, Aug 6, 2014 at 3:00 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Aug 06, 2014 at 01:25:08PM -0700, Mark Reid wrote: --- libavformat/mov.c | 20

Re: [FFmpeg-devel] [PATCH] read reel_name metadata from tmcd atom

2014-08-06 Thread Mark Reid
opps sorry, yes I saw patch the patch comments :) I'll work on another patch with those things fixed! On Wed, Aug 6, 2014 at 3:48 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Aug 06, 2014 at 03:29:04PM -0700, Mark Reid wrote: Thanks for the quick feed back! I attached a small

[FFmpeg-devel] [PATCH v2] read reel_name metadata from tmcd atom

2014-08-07 Thread Mark Reid
--- libavformat/mov.c | 20 1 file changed, 20 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ab85918..afdb9b0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1529,6 +1529,26 @@ static int mov_parse_stsd_data(MOVContext *c, AVIOContext

[FFmpeg-devel] [PATCH v2] read reel_name metadata from tmcd atom

2014-08-07 Thread Mark Reid
Changes since v1: * corrected overflow issues on extradata size checking * added additional size check before malloc * removed strcmp Mark Reid (1): read reel_name metadata from tmcd atom libavformat/mov.c | 20 1 file changed, 20 insertions(+) -- 2.0.0

[FFmpeg-devel] [PATCH] write reel_name metadata to tmcd atom

2014-08-08 Thread Mark Reid
encoder : Lavc55.73.101 mpeg4 timecode: 01:00:00:00 Stream #0:1(eng): Data: none (tmcd / 0x64636D74), 0 kb/s Metadata: handler_name: DataHandler reel_name : ABCD123 timecode: 01:00:00:00 Mark Reid (1): write reel_name

[FFmpeg-devel] [PATCH] write reel_name metadata to tmcd atom

2014-08-08 Thread Mark Reid
--- libavformat/movenc.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 86dbe7f..fe4413c 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1340,6 +1340,16 @@ static int

Re: [FFmpeg-devel] [PATCH] write reel_name metadata to tmcd atom

2014-08-10 Thread Mark Reid
On Fri, Aug 8, 2014 at 6:35 PM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Aug 08, 2014 at 10:37:06AM -0700, Mark Reid wrote: --- libavformat/movenc.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b

[FFmpeg-devel] [PATCH] check that reel_name length doesn't exceed UINT16_MAX

2014-08-10 Thread Mark Reid
--- libavformat/movenc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6a38e89..85fb2e8 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1340,13 +1340,21 @@ static int

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
/ffmpeg-bugs/trac/ticket3100/1sec_mxf_test_Video5270C795.mxf ticket #3450 http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3450/WriteAvidMXFgenerated/5502_0010_v1.mxf I can also supply more sample material if needed. Mark Reid (1): added ULs for demuxing avid media composer mxf files

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
--- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..8ebfdf2 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -28,6 +28,8 @@ const MXFCodecUL ff_mxf_data_definition_uls[] = { { {

[FFmpeg-devel] [PATCH v2] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
UL values copied from FMbc version of mxf.c Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..8ebfdf2 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -28,6

[FFmpeg-devel] [PATCH v2] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
Changes since v1: * add more descriptive commit message Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
On Tue, Aug 12, 2014 at 4:36 PM, Timothy Gu timothyg...@gmail.com wrote: On Aug 12, 2014 10:41 AM, Mark Reid mindm...@gmail.com wrote: I got the ULs from FMbc version of mxf.c Isn't FFmbc GPL? You can't use GPL code in LGPL code unless it is not copyrightable (which ULs probably are, IANAL

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
On Tue, Aug 12, 2014 at 6:44 PM, Timothy Gu timothyg...@gmail.com wrote: On Aug 12, 2014 6:29 PM, Mark Reid mindm...@gmail.com wrote: I didn't realize FFmbc was licensed differently :s. I don't know if it helps, (IANAL either) but the same ULs can be found in libMXF project, as well

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
Changes since v2: *cleaned up commit message *identified keys as legacy ULs Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
sorry I didn't label this patch as version 3 I'll resend this correctly On Tue, Aug 12, 2014 at 8:02 PM, Mark Reid mindm...@gmail.com wrote: UL values from libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
Changes since v2: *cleaned up commit message *identified keys as legacy ULs Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v3] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
UL values from libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..7d30d65 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -28,6 +28,8 @@ const MXFCodecUL

[FFmpeg-devel] [PATCH v4] added ULs for demuxing avid media composer mxf files

2014-08-17 Thread Mark Reid
The AAF SDK refers to these ULs as Legacy. These ULs are the same as the ones found in FFmbc's version of mxf.c and the ones found in libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c

[FFmpeg-devel] [PATCH v4] added ULs for demuxing avid media composer mxf files

2014-08-17 Thread Mark Reid
Changes since v3: *added more details to commit message Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-09-25 Thread Mark Reid
material if required. Mark Reid (1): avformat/mxfdec: read reel_name and source timecode from physical source package libavformat/mxfdec.c | 118 ++- 1 file changed, 97 insertions(+), 21 deletions(-) -- 2.0.0

[FFmpeg-devel] [PATCH] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-09-25 Thread Mark Reid
--- libavformat/mxfdec.c | 118 ++- 1 file changed, 97 insertions(+), 21 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7a4633f..3a1889f 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -188,6 +188,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-09-30 Thread Mark Reid
On Sun, Sep 28, 2014 at 3:16 AM, Michael Niedermayer michae...@gmx.at wrote: On Sun, Sep 28, 2014 at 11:04:34AM +0200, Tomas Härdin wrote: On Thu, 2014-09-25 at 16:13 -0700, Mark Reid wrote: --- libavformat/mxfdec.c | 118 ++- 1 file

[FFmpeg-devel] [PATCH v2] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-10-04 Thread Mark Reid
Changes since v1: * remove unnecessary av_inv_q * fuzz tested (zzuf) the patch on a bunch more mxf files and nothing came up. Mark Reid (1): avformat/mxfdec: read reel_name and source timecode from physical source package libavformat/mxfdec.c | 120

[FFmpeg-devel] [PATCH v2] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-10-04 Thread Mark Reid
--- libavformat/mxfdec.c | 120 ++- 1 file changed, 99 insertions(+), 21 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7a4633f..ef4c4ec 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -188,6 +188,7 @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec: read source timecode from pulldown component

2014-10-24 Thread Mark Reid
to update the fate-lavf-mxf tests. If I added PulldownComponent to the bottom of enum in mxf.h the tests don't fail. AFAIK the InstanceUIDs just need to be unique. Mark Reid (1): libavformat/mxfdec: read source timecode from pulldown component libavformat/mxf.h | 1 + libavformat/mxfdec.c | 31

[FFmpeg-devel] [PATCH] libavformat/mxfdec: read source timecode from pulldown component

2014-10-24 Thread Mark Reid
--- libavformat/mxf.h | 1 + libavformat/mxfdec.c | 31 +-- tests/ref/lavf/mxf | 6 +++--- tests/ref/lavf/mxf_d10 | 2 +- 4 files changed, 34 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index 036c15e..5b95efa 100644

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: read source timecode from pulldown component

2014-10-25 Thread Mark Reid
On Sat, Oct 25, 2014 at 1:42 PM, Tomas Härdin tomas.har...@codemill.se wrote: On Fri, 2014-10-24 at 17:31 -0700, Mark Reid wrote: --- libavformat/mxf.h | 1 + libavformat/mxfdec.c | 31 +-- tests/ref/lavf/mxf | 6 +++--- tests/ref/lavf/mxf_d10

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-18 Thread Mark Reid
--- libavformat/mxfdec.c | 74 +++- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fa0a2f4..8c13c24 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -668,22 +668,6 @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-18 Thread Mark Reid
material_package_name file_package_uid file_package_name reel_uid Mark Reid (1): libavformat/mxfdec.c: export source package uids and names as metadata libavformat/mxfdec.c | 74 +++- 1 file changed, 39 insertions(+), 35 deletions(-) -- 2.0.0

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-21 Thread Mark Reid
On Fri, Nov 21, 2014 at 1:25 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Tue, 2014-11-18 at 16:52 -0800, Mark Reid wrote: --- libavformat/mxfdec.c | 74 +++- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-21 Thread Mark Reid
Changes since v1: * renamed mxf_read_source_package - mxf_read_package --- libavformat/mxfdec.c | 78 +++- 1 file changed, 41 insertions(+), 37 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fa0a2f4..cc740b5 100644 ---

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-25 Thread Mark Reid
(uncompressed single channel image AV_PIX_FMT_GRAY8) Mark Reid (1): libavformat/mxfdec.c: initial support for EssenceGroups libavformat/mxf.c | 1 + libavformat/mxf.h | 1 + libavformat/mxfdec.c | 148 - tests/ref/lavf/mxf

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-25 Thread Mark Reid
--- libavformat/mxf.c | 1 + libavformat/mxf.h | 1 + libavformat/mxfdec.c | 148 - tests/ref/lavf/mxf | 6 +- tests/ref/lavf/mxf_d10 | 2 +- 5 files changed, 127 insertions(+), 31 deletions(-) diff --git a/libavformat/mxf.c

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-29 Thread Mark Reid
On Fri, Nov 28, 2014 at 9:26 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Tue, 2014-11-25 at 15:14 -0800, Mark Reid wrote: --- libavformat/mxf.c | 1 + libavformat/mxf.h | 1 + libavformat/mxfdec.c | 148 - tests

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-30 Thread Mark Reid
Changes since v1: * move EssenceGroup at the end of the enum * removed changes to fate-lavf-mxf tests * tested memory handling with valgrind Mark Reid (1): libavformat/mxfdec.c: initial support for EssenceGroups libavformat/mxf.c| 1 + libavformat/mxf.h| 3 +- libavformat

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-30 Thread Mark Reid
--- libavformat/mxf.c| 1 + libavformat/mxf.h| 3 +- libavformat/mxfdec.c | 148 +-- 3 files changed, 124 insertions(+), 28 deletions(-) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 4dc54d7..14d143e 100644 ---

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c refactor resolving MultiDescriptor and remove essence group hack

2014-12-02 Thread Mark Reid
I think this is a better way to deal with single frame essence data then my previous way. --- libavformat/mxfdec.c | 62 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: support demuxing opatom audio without index

2014-12-21 Thread Mark Reid
--- libavformat/mxfdec.c | 66 +--- 1 file changed, 63 insertions(+), 3 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4715169..92c864f 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -152,6 +152,8 @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: support demuxing opatom audio without index

2014-12-21 Thread Mark Reid
files without indexs. I uploaded a sample mxf encoded to ftp://upload.ffmpeg.org/incoming opatom_missing_index.mxf I can also provide more samples if need. Mark Reid (1): libavformat/mxfdec.c: support demuxing opatom audio without index libavformat/mxfdec.c | 66

Re: [FFmpeg-devel] [PATCH v3] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-14 Thread Mark Reid
On Wed, Jan 14, 2015 at 1:37 AM, tomas.har...@codemill.se wrote: On 2015-01-12 02:18, Mark Reid wrote: changes since v2: *removed log line and changed av_mallocz sizeof --- libavformat/mxfdec.c | 55 ++ ++ 1 file changed, 55 insertions

Re: [FFmpeg-devel] [PATCH v4] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-19 Thread Mark Reid
On Sun, Jan 18, 2015 at 1:11 PM, Michael Niedermayer michae...@gmx.at wrote: On Sun, Jan 18, 2015 at 02:43:21PM +0100, Tomas Härdin wrote: On Wed, 2015-01-14 at 19:26 -0800, Mark Reid wrote: changes since v3: * return if there isn’t exactly one partition * cosmetic and gcc cleanups

[FFmpeg-devel] [PATCH v4] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-14 Thread Mark Reid
changes since v3: * return if there isn’t exactly one partition * cosmetic and gcc cleanups * added comment about EditUnitByteCount --- libavformat/mxfdec.c | 59 1 file changed, 59 insertions(+) diff --git a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: write package name metadata

2015-02-16 Thread Mark Reid
On Mon, Feb 16, 2015 at 4:07 AM, tomas.har...@codemill.se wrote: On 2015-02-13 01:36, Mark Reid wrote: /** + * Convert an UTF-8 string to UTF-16BE and write it. + * @return number of bytes written. + */ +int avio_put_str16be(AVIOContext *s, const char *str); You could maybe split

[FFmpeg-devel] [PATCH] libavformat/mxfenc: write package name metadata

2015-02-12 Thread Mark Reid
, the same way avio_get_str16le was done. The tests need to be updated because avio_put_str16be writes zero terminated strings and the muxer previously wasn't. Mark Reid (1): libavformat/mxfenc: write package name metadata libavformat/avio.h| 6 libavformat/aviobuf.c | 50

[FFmpeg-devel] [PATCH] libavformat/mxfenc: write package name metadata

2015-02-12 Thread Mark Reid
--- libavformat/avio.h| 6 libavformat/aviobuf.c | 50 +--- libavformat/mxfenc.c | 74 --- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 6

[FFmpeg-devel] [PATCH] libavformat/mxfenc.c: added mxf opatom muxer

2015-01-28 Thread Mark Reid
not entirely sure if all the essence container uls are correct as I'm just using the ones from the existing muxer. They might need to be clipwrapped versions or something else but I haven't looked into it yet. Mark Reid (1): libavformat/mxfenc.c: added mxf opatom muxer libavformat/allformats.c | 1

Re: [FFmpeg-devel] [PATCH] tests/fate: added mxf tests for essencegroups and missing index

2015-01-27 Thread Mark Reid
On Mon, Jan 26, 2015 at 5:04 AM, Michael Niedermayer michae...@gmx.at wrote: On Sun, Jan 25, 2015 at 04:38:00PM -0800, Mark Reid wrote: hi, This patch addes 2 mxf tests for formats that I've been working on. Opatom mxf files with missing index segments and ones with essence groups

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: read project_name metadata

2015-01-05 Thread Mark Reid
Hi, MXF files generated by Media Composer or LibMXF can contain a project name property in the Preface. Lots of existing samples have them. http://samples.ffmpeg.org/MXF/issue2160/PW0805A0V01.4C5B5636.EFA330.mxf project_name: DNX145 PW Test

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: read project_name metadata

2015-01-09 Thread Mark Reid
On Tue, Jan 6, 2015 at 10:24 AM, Clément Bœsch u...@pkh.me wrote: On Tue, Jan 06, 2015 at 10:06:13AM -0800, Mark Reid wrote: On Mon, Jan 5, 2015 at 11:26 PM, Clément Bœsch u...@pkh.me wrote: On Mon, Jan 05, 2015 at 04:53:05PM -0800, Mark Reid wrote: Hi, MXF files generated

Re: [FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-09 Thread Mark Reid
On Thu, Jan 8, 2015 at 12:40 PM, Clément Bœsch u...@pkh.me wrote: On Wed, Jan 07, 2015 at 10:31:41AM -0800, Mark Reid wrote: [...] +segment = av_mallocz(sizeof(MXFIndexTableSegment)); sizeof(*segment)? cool, didn't know that worked! +if (!segment) { +av_log(mxf-fc

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: export the full UMID as metadata

2015-01-09 Thread Mark Reid
Changes since v1 * changed umid text formating to conform to SMPTE330 --- libavformat/mxfdec.c | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4715169..d783fb6 100644 ---

[FFmpeg-devel] [PATCH v3] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-11 Thread Mark Reid
changes since v2: *removed log line and changed av_mallocz sizeof --- libavformat/mxfdec.c | 55 1 file changed, 55 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4715169..743a6a0 100644 ---

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: read project_name metadata

2015-01-11 Thread Mark Reid
On Fri, Jan 9, 2015 at 7:47 PM, Michael Niedermayer michae...@gmx.at wrote: On Mon, Jan 05, 2015 at 04:53:05PM -0800, Mark Reid wrote: Hi, MXF files generated by Media Composer or LibMXF can contain a project name property in the Preface. Lots of existing samples have them. http

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export the full UMID as metadata

2015-01-06 Thread Mark Reid
On Tue, Jan 6, 2015 at 12:03 AM, tim nicholson nichot20-at-yahoo@ffmpeg.org wrote: On 05/01/15 20:41, Mark Reid wrote: Hi, This patch exports the full umid of packages as metadata. ffmpeg currently only exports the material number portion of the umid. The new format is ISO

[FFmpeg-devel] [PATCH] test/fate: added mxf_opatom regression tests

2015-02-09 Thread Mark Reid
--- configure | 1 + tests/fate/avformat.mak| 1 + tests/fate/seek.mak| 2 ++ tests/lavf-regression.sh | 4 tests/ref/lavf/mxf_opatom | 3 +++ tests/ref/seek/lavf-mxf_opatom | 53 ++ 6 files

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc.c: added mxf opatom muxer

2015-02-09 Thread Mark Reid
On Sat, Feb 7, 2015 at 7:17 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Jan 28, 2015 at 07:44:21PM -0800, Mark Reid wrote: --- libavformat/allformats.c | 1 + libavformat/mxfenc.c | 139 ++- 2 files changed, 127 insertions

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export the full UMID as metadata

2015-01-05 Thread Mark Reid
them pretty well http://www.digitalpreservationeurope.eu/publications/briefs/UMID_Unique%20Material%20Identifier.pdf umids also have a optional extened 32 bytes, but I've yet to see a file that has them. Mark Reid (1): libavformat/mxfdec.c: export the full UMID as metadata libavformat/mxfdec.c

[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export the full UMID as metadata

2015-01-05 Thread Mark Reid
--- libavformat/mxfdec.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4715169..5ade23a 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -200,6 +200,7 @@ typedef struct

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-07 Thread Mark Reid
Hi, This approach is much simpler then my previous attempt. This version creates a IndexTableSegment and everything else can continue as normal. --- libavformat/mxfdec.c | 56 1 file changed, 56 insertions(+) diff --git

[FFmpeg-devel] [PATCH] libavformat/mxfenc: write user comment metadata

2015-03-14 Thread Mark Reid
--- libavformat/mxfenc.c | 66 +-- tests/ref/lavf/mxf| 6 ++--- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 69 insertions(+), 7 deletions(-) diff --git a/libavformat/mxfenc.c

[FFmpeg-devel] [PATCH] libavformat/mxfenc: write user comment metadata

2015-03-14 Thread Mark Reid
tags added to the primer pack. Mark Reid (1): libavformat/mxfenc: write user comment metadata libavformat/mxfenc.c | 66 +-- tests/ref/lavf/mxf| 6 ++--- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files

Re: [FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-15 Thread Mark Reid
On Sun, Mar 15, 2015 at 1:59 PM, James Almer jamr...@gmail.com wrote: On 13/03/15 10:58 PM, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions(-) From fate

[FFmpeg-devel] [PATCH 0/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-21 Thread Mark Reid
this to work I added a -mxf_audio_tcr option. If not supplied ffmpeg defaults to a timecode rate of 25fps. Mark Reid (2): libavformat/mxfenc: add container duration and package name to primer pack libavformat/mxfenc: add support for muxing mxf opatom audio libavformat/mxfenc.c | 102

[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-21 Thread Mark Reid
--- libavformat/mxfenc.c | 100 ++- 1 file changed, 83 insertions(+), 17 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index ac60357..7483ddc 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -313,6 +313,7 @@

[FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc: add container duration and package name to primer pack

2015-03-21 Thread Mark Reid
--- libavformat/mxfenc.c | 2 ++ tests/ref/lavf/mxf | 6 ++--- tests/ref/lavf/mxf_d10 | 2 +- tests/ref/lavf/mxf_opatom | 4 ++-- tests/ref/seek/lavf-mxf_opatom | 54 +- 5 files changed, 35 insertions(+), 33

[FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-06 Thread Mark Reid
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 96 +--- 2 files changed, 93 insertions(+), 4 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index d9e17c6..71a4084 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@

[FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-06 Thread Mark Reid
: TestSrC comment_example 6: 100Ω comment_example 7: ©2014 I'm currently prefixing all the user comments with comment_ to separate them from other metadata keys. The keys look kinda ugly and can have spaces, if someone has a better suggestion I'd love to here it. Mark Reid (1): libavformat/mxfdec

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index d9e17c6..71a4084 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
changes since v1: * replaced nonportable strlcat with snprintf Mark Reid (1): libavformat/mxfdec: export user comments metadata libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: This fixes a crash, when trying to mux h264 into mxf_opatom. Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 3:57 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) +{ +MXFTaggedValue *tagged_value = arg; +uint8_t key[17

[FFmpeg-devel] [PATCH v3 1/2] libavformat/avio: added avio_put_str16be

2015-03-02 Thread Mark Reid
--- doc/APIchanges| 3 +++ libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 23 +++ libavformat/version.h | 4 ++-- 4 files changed, 30 insertions(+), 6 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5fdfc82..6875aed 100644 ---

[FFmpeg-devel] [PATCH v3 2/2] libavformat/mxfenc: write package name metadata

2015-03-02 Thread Mark Reid
--- libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 82 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

[FFmpeg-devel] [PATCH v3 0/2] libavformat/mxfenc: write package name metadata

2015-03-02 Thread Mark Reid
changes since v2 * simplified put_str16 macro * added entry to doc/APIchanges Mark Reid (2): libavformat/avio: added avio_put_str16be libavformat/mxfenc: write package name metadata doc/APIchanges| 3 ++ libavformat/avio.h| 6 libavformat/aviobuf.c | 23

Re: [FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-02 Thread Mark Reid
On Mon, Mar 2, 2015 at 1:46 AM, Robert Krüger krue...@lesspain.de wrote: On Sun, Mar 1, 2015 at 10:43 PM, Mark Reid mindm...@gmail.com wrote: On Sun, Mar 1, 2015 at 4:06 AM, Robert Krüger krue...@lesspain.de wrote: Currently the product name that ends up in mxf files muxed using

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/avio: added avio_put_str16be

2015-03-02 Thread Mark Reid
On Mon, Mar 2, 2015 at 7:17 AM, Clément Bœsch u...@pkh.me wrote: On Sun, Mar 01, 2015 at 01:30:54PM -0800, Mark Reid wrote: --- libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 50 +++--- libavformat/version.h | 2 +- 3 files

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/avio: added avio_put_str16be

2015-03-03 Thread Mark Reid
On Tue, Mar 3, 2015 at 9:25 AM, Michael Niedermayer michae...@gmx.at wrote: On Mon, Mar 02, 2015 at 08:06:13PM -0800, Mark Reid wrote: --- doc/APIchanges| 3 +++ libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 23 +++ libavformat/version.h | 4

[FFmpeg-devel] [PATCH v4] libavformat/mxfenc: write package name metadata

2015-03-03 Thread Mark Reid
changes since v3: * updated mxf_opatom regression test Mark Reid (1): libavformat/mxfenc: write package name metadata libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf

[FFmpeg-devel] [PATCH v4] libavformat/mxfenc: write package name metadata

2015-03-03 Thread Mark Reid
--- libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 82 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

Re: [FFmpeg-devel] [PATCH v3 2/2] libavformat/mxfenc: write package name metadata

2015-03-04 Thread Mark Reid
On Wed, Mar 4, 2015 at 4:07 AM, tomas.har...@codemill.se wrote: On 2015-03-03 05:06, Mark Reid wrote: +/* + * Returns the calculated length a local tag containing an utf-8 string as utf-16 + */ +static uint64_t mxf_utf16_local_tag_length(const char *utf8_str) +{ +return utf8_str? 4

[FFmpeg-devel] [PATCH v5] libavformat/mxfenc: write package name metadata

2015-03-04 Thread Mark Reid
changes since v4: * added UINT16_MAX check in mxf_utf16_local_tag_length and mxf_write_local_tag_utf16 Mark Reid (1): libavformat/mxfenc: write package name metadata libavformat/mxfenc.c | 97 +-- tests/ref/lavf/mxf| 6 +-- tests/ref

[FFmpeg-devel] [PATCH v5] libavformat/mxfenc: write package name metadata

2015-03-04 Thread Mark Reid
--- libavformat/mxfenc.c | 97 +-- tests/ref/lavf/mxf| 6 +-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 91 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

Re: [FFmpeg-devel] [PATCH v5] libavformat/mxfenc: write package name metadata

2015-03-05 Thread Mark Reid
if (size = UINT16_MAX/2) { that makes way more sense :p, I'll send a new patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v6] libavformat/mxfenc: write package name metadata

2015-03-05 Thread Mark Reid
--- libavformat/mxfenc.c | 97 +-- tests/ref/lavf/mxf| 6 +-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 91 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

[FFmpeg-devel] [PATCH v6] libavformat/mxfenc: write package name metadata

2015-03-05 Thread Mark Reid
changes since v5 * use size = UINT16_MAX/2 instead Mark Reid (1): libavformat/mxfenc: write package name metadata libavformat/mxfenc.c | 97 +-- tests/ref/lavf/mxf| 6 +-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom

Re: [FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-01 Thread Mark Reid
On Sun, Mar 1, 2015 at 4:06 AM, Robert Krüger krue...@lesspain.de wrote: Currently the product name that ends up in mxf files muxed using the new op atom muxer is OP1A muxer which is misleading. Attached patch changes that. ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: write package name metadata

2015-03-01 Thread Mark Reid
--- libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 82 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c

[FFmpeg-devel] [PATCH 0/2] libavformat/mxfenc: write package name metadata

2015-03-01 Thread Mark Reid
changes since v1: * split into 2 patches * added avformat minor version bump * search for file_package_name in stream metadata as well, thats where the demuxer puts the key Mark Reid (2): libavformat/avio: added avio_put_str16be libavformat/mxfenc: write package name metadata libavformat

[FFmpeg-devel] [PATCH 1/2] libavformat/avio: added avio_put_str16be

2015-03-01 Thread Mark Reid
--- libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 50 +++--- libavformat/version.h | 2 +- 3 files changed, 34 insertions(+), 24 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index b9b4017..8fc7e27 100644 ---

[FFmpeg-devel] [PATCH] libavformat/mxfdec: refactor reading strong ref array

2015-03-01 Thread Mark Reid
hi, I was unsure whether this should be a function or a macro, I went with a function. --- libavformat/mxfdec.c | 61 +++- 1 file changed, 22 insertions(+), 39 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-25 Thread Mark Reid
On Mar 24, 2015 7:05 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: --- libavformat/mxfenc.c | 100 ++- 1 file changed, 83 insertions(+), 17 deletions(-) Looks fine as far as I can tell

Re: [FFmpeg-devel] [PATCH v2] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-11 Thread Mark Reid
On Sat, Apr 11, 2015 at 4:58 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Tomas Härdin tomas.hardin at codemill.se writes: +av_log(s, AV_LOG_ERROR, MXF OPAtom only supports 16 or 24 bits le audio\n); This should perhaps be reworded as Only 16- and 24-bit LE is implemented

[FFmpeg-devel] [PATCH v3] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-11 Thread Mark Reid
--- libavformat/mxfenc.c | 102 ++- 1 file changed, 85 insertions(+), 17 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 7b400b3..0b8dfd6 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -313,6 +313,7 @@

[FFmpeg-devel] [PATCH v3] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-11 Thread Mark Reid
changes since v2: * re-worded error message if incorrect audio codec used Mark Reid (1): libavformat/mxfenc: added support mxf opatom audio muxing libavformat/mxfenc.c | 102 ++- 1 file changed, 85 insertions(+), 17 deletions(-) -- 2.2.1

[FFmpeg-devel] [PATCH v2] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-10 Thread Mark Reid
changes since v1: *rename mxf_audio_tcr to mxf_audio_edit_rate Mark Reid (1): libavformat/mxfenc: added support mxf opatom audio muxing libavformat/mxfenc.c | 102 ++- 1 file changed, 85 insertions(+), 17 deletions(-) -- 2.2.1

[FFmpeg-devel] [PATCH v2] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-10 Thread Mark Reid
--- libavformat/mxfenc.c | 102 ++- 1 file changed, 85 insertions(+), 17 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 7b400b3..38772b7 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -313,6 +313,7 @@

[FFmpeg-devel] [PATCH] libavformat/movenc: remove unnecessary null check

2016-05-29 Thread Mark Reid
Fixes CID1361955 --- libavformat/movenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 49cd1bd..3a633a6 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1894,9 +1894,7 @@ static int

Re: [FFmpeg-devel] [PATCH] libavformat/dnxhddec added support for raw 444 and dnxhr formats

2016-02-08 Thread Mark Reid
On Mon, Feb 8, 2016 at 1:25 AM, Christophe Gisquet wrote: > Hi, > > 2016-02-08 8:15 GMT+01:00 Christophe Gisquet : >> At this point, I'd say the encoder would better use that prefix. >> That's what the attached patch does (rebased but

  1   2   >