Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-06 Thread Matthias Troffaes
Many thanks for your feedback, Michael and Nicolas. On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer wrote: > fails on qemu mips Thank you for flagging this failure. I'm currently trying to reproduce the problem. May I ask what toolchain you typically use to compile

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-04-07 Thread Matthias Troffaes
On Thu, Apr 6, 2017 at 5:00 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Apr 06, 2017 at 02:09:46PM +0100, Matthias Troffaes wrote: >> Many thanks for your feedback, Michael and Nicolas. >> >> On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2017-07-21 Thread Matthias Troffaes
... any chance for this patch to get applied? Quick link to original thread: https://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/211866.html Rebased version of patch against latest master attached. Kind regards, Matthias diff --git a/Changelog b/Changelog index 187ae79..4fa0870 100644 ---

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Note that this is a resubmission of https://ffmpeg.org/pipermail/ffmpeg-devel/2017-April/209794.html - in particular the mips test failure reported in https://ffmpeg.org/pipermail/ffmpeg-devel/2017-April/209820.html has been fixed. Kind regards, Matthias On Wed, May 31, 2017 at 1:31 PM, Matthias

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Dear Paul, On Wed, May 31, 2017 at 7:59 PM, Paul B Mahol wrote: > This code does not belong in this filter. > > Make new filter instead. May I kindly ask why you think so? I considered this as well but then decided against it, as this new filter would behave like framestep as

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread Matthias Troffaes
Dear Moritz, On Wed, May 31, 2017 at 2:17 PM, Moritz Barsnick wrote: > On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: >> @@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest >> within each release, >> releases are sorted from

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2017-06-06 Thread Matthias Troffaes
Dear Moritz, On Mon, Jun 5, 2017 at 3:21 PM, Moritz Barsnick wrote: > I can't comment on the rest (and still really like the concept), but > just this: > >> +Allowed values are positive integers between @code{1} and @code{65535}. > > This maximum value is no longer correct.

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-30 Thread Matthias Troffaes
Dear Mark, On Thu, Nov 30, 2017 at 4:53 AM, Mark Reid wrote: > clang give me a warning telling to do this instead > packages[3] = {{0}}; > I assume thats correct as I see thats used throughout the codebase. Ah yes, that's perfect - good catch. Kind regards, Matthias

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Matthias Troffaes
Dear Mark, On Wed, Nov 29, 2017 at 4:11 AM, Mark Reid wrote: > @@ -1445,12 +1463,13 @@ static int > mxf_write_header_metadata_sets(AVFormatContext *s) > AVDictionaryEntry *entry = NULL; > AVStream *st = NULL; > int i; > - > -MXFPackage packages[2] = {}; >

[FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2018-10-24 Thread Matthias Troffaes
Attached a patch which adds a "skipblend" filter, which I've been using for a while. My hope is that an ffmpeg developer here can merge it. The filter is similar to the framestep filter, but additionally blends frames together at each step, for a motion blur effect. The number of frames that are

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2018-11-01 Thread Matthias Troffaes
Dear FFmpeg developers, ... is there a possibility for this patch to get applied? Obviously I'm happy to work further on the code where need be to get this upstreamed. Kind regards, Matthias On Wed, Oct 24, 2018 at 11:14 AM Matthias Troffaes wrote: > > Attached a patch which adds a &quo

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2018-11-01 Thread Matthias Troffaes
Dear Paul, On Thu, Nov 1, 2018 at 10:34 AM Paul B Mahol wrote: > Duplicates funcionality of tmix filter. Many thanks for your reply, and for pointing out the existence of the tmix filter. Please forgive my ignorance about it. I see tmix was only added in April this year, whilst I've been

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2018-11-01 Thread Matthias Troffaes
Dear Paul, On Thu, Nov 1, 2018 at 11:21 AM Matthias Troffaes wrote: > Would you consider accepting a patch that added an integer "cutoff" > option to tmix, for the purpose of setting all weights for frames > beyond "cutoff" to 0? The reason for requesting this is

Re: [FFmpeg-devel] [PATCH] avfilter: add skipblend filter

2018-11-02 Thread Matthias Troffaes
Dear Paul, On Thu, Nov 1, 2018 at 5:26 PM Paul B Mahol wrote: > > I found a way of doing this differently, as I now found that tmix > > doesn't actually step frames, unlike skipblend. For history's sake, > > the way to get skipblend behaviour is to do something like > >

[FFmpeg-devel] [PATCH] libavfilter/af_astats: fix msvc compile error

2019-04-29 Thread Matthias Troffaes
MSVC requires an explicit cast from void * to void when applying the ternary conditional operator to switch between methods that return void. The attached patch fixes the problem. For information, log of failed build:

Re: [FFmpeg-devel] [PATCH] libavfilter/af_astats: fix msvc compile error

2019-04-30 Thread Matthias Troffaes
On Mon, Apr 29, 2019 at 7:32 PM Paul B Mahol wrote: > On 4/29/19, Matthias Troffaes wrote: > > MSVC requires an explicit cast from void * to void when applying the > > ternary conditional operator to switch between methods that return > > void. The attached pa

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: Don't use restrict directly to fix build on MSVC

2019-11-11 Thread Matthias Troffaes
I can confirm this patch fixes the compile problem on MSVC. See: https://ci.appveyor.com/project/mcmtroffaes/ffmpeg-msvc-build/build/job/get5kbjlyw6w1vi5 https://github.com/mcmtroffaes/ffmpeg-msvc-build/commit/d1cc29f4c56937ec75b297bc6feaf0fd8989a549 Kind regards, Matthias On Sun, Nov 10, 2019

Re: [FFmpeg-devel] [PATCH] fix some filter dependencies

2021-05-09 Thread Matthias Troffaes
On Sun, May 9, 2021 at 9:19 AM Anton Khirnov wrote: > Quoting Matthias Troffaes (2021-05-03 10:14:04) > > ... ping. Is there anything else needed? > > Queued, will push shortly. Great, thanks! > But in the future please send git-formatted patches, they require less > work

Re: [FFmpeg-devel] [PATCH 2/2] configure: dnn needs avformat

2021-05-09 Thread Matthias Troffaes
On Thu, May 6, 2021 at 3:54 AM Guo, Yejun wrote: > thanks for the catch, the native backend uses AVIOContext to load model > from file. Will push this patch soon. You're welcome. Thanks for accepting! Kind regards, Matthias ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] configure: enable windres on win32/win64 if available

2021-07-09 Thread Matthias Troffaes
On Fri, Jul 9, 2021 at 9:27 PM James Almer wrote: > Wouldn't it make more sense to add support for rc.exe instead? Yes, that's an excellent point, and I agree that would be better. Additionally, I've just found the patch breaks the build on some libraries (at least postproc), my apologies for

Re: [FFmpeg-devel] [PATCH] fix some filter dependencies

2021-05-03 Thread Matthias Troffaes
... ping. Is there anything else needed? Kind regards, Matthias On Sun, Feb 7, 2021 at 4:30 PM Nicolas George wrote: > Matthias Troffaes (12021-02-07): > > Currently, ffmpeg builds with --disable-avcodec --disable-avformat > > --enable-avfilter result in a broken avfilter libra

Re: [FFmpeg-devel] [PATCH 1/2] configure: fix some filter dependencies

2021-05-04 Thread Matthias Troffaes
On Tue, May 4, 2021 at 1:27 PM Matthias C. M. Troffaes wrote: > Fixes builds with > > --disable-avcodec --disable-avformat --enable-avfilter > > which currently results in a broken avfilter library due to a few > filters that require avcodec or avformat getting mistakenly > compiled. Note that

[FFmpeg-devel] [PATCH] fix some filter dependencies

2021-02-07 Thread Matthias Troffaes
Currently, ffmpeg builds with --disable-avcodec --disable-avformat --enable-avfilter result in a broken avfilter library due to a few filters that require avcodec or avformat are mistakenly compiled in. For example, see: