Paul B Mahol (12024-06-17):
> And once you close all buffersinks the EOF will and must propagate backward
> to all not-closed filters and their in/out pads.
Your analysis here is right, obviously. Closing a source for this bug
makes no sense.
Regards,
--
Nicolas
y, the fftools
should be just user interface around the high-level APIs provided by the
libraries.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vis
n(+), 5 deletions(-)
All three look good to me, but I have not looked that carefully at each
individual change in the second patch.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@f
in the future, but a common API requirement anyway.
>
> Signed-off-by: softworkz
> ---
NAK, redundant.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mail
filter/avfilter.c | 4 ++--
> libavfilter/internal.h | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
LGTM to both.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
gt; 2 files changed, 12 insertions(+)
Even if there is only one, it is still a formats list, and the name of
the function should reflect it; "make_format", singular, is not clear.
ff_make_formats_list_single() maybe?
Regards,
--
Nicolas George
signat
cally only
> use ff_set_common_* functions, which are unaffected by his change.
I do not like the aesthetics of this very much, but it is a useful
change.
I have not looked at each individual filter change, but they are
straightforward.
So ok for my part.
Regards,
--
Nicolas George
sign
ts commands.
>
> This commit fixes this by adding a new AVFilter flag.
I do not like it: it requires redundant changes in all the filters.
It would be more elegant to add avfilter_can_process_commands() that can
check for the process_command callback.
Regards,
--
Nicolas George
signa
and(), directly in the
callback. No flag required.
> And adding a getter for something that is essentially a flag is IMO very
> inelegant.
Maintaining an information manually when it can be derived from a more
authoritative source is worse.
Regards,
--
Nicolas George
signature.asc
De
exit_program(1);
> break;
> }
On top of everything else that has been said about it, this is not the
semantic of AVERROR_EXIT, which is meant for communication within a
library.
--
Nicolas George
signature.asc
Description: PGP signature
__
ged, 11 insertions(+), 2 deletions(-)
No objection for the lavfi part, but please split into two commits. I do
not maintain the fftools part.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpe
ile changed, 1 insertion(+), 1 deletion(-)
Good catch, thanks. Applied.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
James Almer (12021-11-25):
> Have all the concerns people had been addressed? I'm also certain the
> design itself wasn't well received.
Indeed. The whole libavfilter part is nowhere near anything acceptable.
It should not be applied at all.
Regards,
--
w that fares.
We should lock the library versions together so that we do not have to
worry about the internal ABI. This is a problem we force on ourselves
that brings very little benefit, probably benefit nobody actually cares
about.
Regards,
--
Nicolas George
signature.asc
Description: P
people
defending them have refused to discuss.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit lin
/mpegts.c | 3 +--
> libavformat/oggparsevorbis.c | 3 +--
> libavformat/rtsp.c | 3 +--
> libavutil/bprint.c | 6 ++
> 8 files changed, 11 insertions(+), 25 deletions(-)
Ok for the bprint part.
Regards,
--
Nicolas George
signatu
,
just printing in the log is not sustainable, and neither is each filter
inventing it own solution. But that would require an unified efficient
string API.)
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel maili
hole series.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-re
egards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
sentations and permanent storage
representations.
PS: do not Cc me.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubsc
Niklas Haas (12023-10-26):
> From: Niklas Haas
>
> ---
> libavfilter/drawutils.c | 3 ---
> 1 file changed, 3 deletions(-)
Please merge this with patch 1.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@f
read the actual patch.
Niklas: patch 3 is incorrect, please fix it and drop patch 1.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
> if (s->eof)
> -return AVERROR(EINVAL);
> +return AVERROR_EOF;
>
AVERROR_EOF does not have a semantic for writing, only for reading, so
no.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmp
Paul B Mahol (12023-10-27):
> Both patches are required to fix out of memory scenario with this use case:
Then please attach an analysis of the fix in the commit messages. Bugs
that just disappear when you rework the code completely are not fixed.
Regards,
--
Nicolas Geo
Paul B Mahol (12023-10-27):
> As OOM scenarios are bad, will apply this fix soon.
This bug, if it is a bug, has been here for quite some time already, a
few days more will not change anything. I want to analyze this properly,
do not push before please.
Regards,
--
Nicolas Geo
Michael Niedermayer (12023-10-28):
> It was just that jb told me
> "6.1 opportunity is gone.
Unsubstantiated opinion, let us ignore it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
f
Paul B Mahol (12023-10-28):
> I did proper analysis already. Pushed.
Thanks for the precedent, I will gladly do the same to you in the
future.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-de
Jean-Baptiste Kempf (12023-10-29):
> > Unsubstantiated opinion, let us ignore it.
> Again, a personal attack, from you.
YOU are not an OPINION, so, no, this is not a personal attack, this is a
lie.
--
Nicolas George
signature.asc
Description: PGP
Jean-Baptiste Kempf (12023-10-29):
> Because instead of doing the polite and normal thing which would be:
Politeness or not does not make it a personal attack. Moving goalposts
much?
--
Nicolas George
signature.asc
Description: PGP signat
Jean-Baptiste Kempf (12023-10-29):
> Being not polite to someone is a personal attack.
No.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
money in donations and that more of us will have to
keep a day job, but it is the price of freedom.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/
ted for a project on multiple timezones where everybody is
equal but nobody has an obligation. And I think it is very bad that some
body with apparent authority suggests otherwise.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
Jean-Baptiste Kempf (12023-10-29):
> We'll have to agree to disagree.
So you disagree that ffmpeg is not a corporate project where developers
can be forced to have fixed work hours. Interesting.
--
Nicolas George
signature.asc
Description: PGP s
not be.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with s
choose on their own, of
course.
But the project itself should never accept obligations to a corporate
entity. Never.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.o
trings attached are dangerous and should be
refused, whoever they are offered to.
> who you are opposing here, rather than bottom feeders such as myself.
Please refrain from insinuating that I have insulted you like that.
--
Nicolas George
signature.asc
Description: PGP
ot be silently truncated.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Leo Izen (12023-10-30):
> > difference: user data should not be silently truncated.
> There isn't really a bug here, just an extraneous compiler warning.
Truncating user data silently is a bug. The warning is right and needs
proper fix.
Regards,
--
properly reporting the error to the
user is important.
It is just about adding an if and return error.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe
to go on the Internet unsupervised?
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
I wrote it…) I am pretty certain this kind of bug
does not need a source with a single output to be switched to activate.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://f
Paul B Mahol (12023-10-31):
> Huh? I fixed this, and you need to give proof that this does not fixes it.
It is you wou have to prove that your patches fix anything or are in any
way useful.
> Because You can be mistaken and/or evil and simply lie.
Seriously, get a grip.
--
Nicolas
mp4):
[in#0/mov,mp4,m4a,3gp,3g2,mj2 @ 0x557c9a7e72c0] Input stream #0:0 (video):
10513 packets read (83701450 bytes); 10511 frames decoded; 0 decode errors;
[in#0/mov,mp4,m4a,3gp,3g2,mj2 @ 0x557c9a7e72c0] Total: 10513 packets
(83701450 bytes) demuxed
[AVIOContext @ 0x557c9a7e5d40] S
ggered in his specific testcase?
I posted my console output in the last mail.
And even if it did make the bug go away, such an important change is not
acceptable without the proof that it is necessary in the commit message.
Regards,
--
Nicolas George
signature.asc
Desc
uld be detailed and in the commit message.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with s
k.
As it is, the need to switch buffersrc to activate is not established,
and therefore it should not be done.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
Paul B Mahol (12023-11-02):
> I do not understand. What proof you need?
That the patch is correct and necessary.
First, explain how the current triggers the problem. In the commit
message.
--
Nicolas George
___
ffmpeg-devel mailing list
ffm
arse HEAD`, Encode::FB_CROAK));
> -foreach my $email (sort values %assembly) {
> -printf("%s\n", $email);
> +foreach my $name (sort keys %assembly) {
This is also changing the sort order. It might be acceptable but it
might also not be.
> +my $email = $assembly{$name}
ing into this that is not first
analyzing what is going on is a waste of time.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffm
Michael Niedermayer (12023-11-03):
> Signed-off-by: Michael Niedermayer
> ---
> libavfilter/buffersink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patches 1 and 2 look good to me. Good catch.
Regards,
--
Nicolas George
signature.asc
Description: P
h264 @ 0x562874ac4f40] decode_slice_header error
[h264 @ 0x562874ac4f40] no frame!
[…]
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
you are right, that means there is a bug in the framework code. Then
the patch forward is to fix that bug, not needlessly single every simple
filter to activate.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing lis
be found and fixed. This patch just
adds code to work around it, it is not acceptable.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-deve
Paul B Mahol (12023-11-06):
> Gonna apply soon.
No you are not.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
Vittorio Giovara (12023-11-06):
> Nicolas, have you thought of providing a patch to the bug Paul is
> describing?
Why do you not ask Paul if he have thought of giving me time to have a
chance to do so?
--
Nicolas George
signature.asc
Description: PGP sig
;s can go in.
No. I will review this issue when I have the time and Paul will wait.
This is how it works. Invalid patches do not go in just because the
maintainer is busy or sick.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-
rude from you.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.or
ion,
I have already done so, but again you neglected to read it: if there is
a bug, it is in the framework code.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailma
Vittorio Giovara (12023-11-06):
> I'm not misrepresenting anybody's words,
Me: “I never doubted that Paul's patches do make the bug go away in your
test case.”
You: “you insisted it wasn't there”
This is precisely misrepresenting my words.
So stop lying and present
ow anything about lavfi's scheduling so you cannot
help.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visi
avior in this thread was toxic from your
very first post.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
roblem
in the first place, even more so since it was purely trolling.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
judge your own patch.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@f
legate to review this piece?
This is a public mailing-list, have you seen somebody volunteering?
The scheduling in libavfilter is tricky, and I am not aware of anybody
else having manifested interest about the subtle details.
--
Nicolas George
signature.asc
Description: PGP
I have now been able to set up a reasonable test case with limit
memoryuse 600M. Next step is to simplify the test case.
(I cannot understand how you can pretend you analyzed the bug when your
test case contains unrelated filters like hqdn3d or setsar.)
--
Nicolas George
it can be expected that universe will
> froze first before you manage to came to any conclusion about the
> "framework".
Then work on something else. There is no urgency here.
--
Nicolas George
signature.asc
Description: PGP signature
___
have to find a solution, won't we? (I
hope you do not consider removing a feature that people have been using
for years an option.)
I can suggest this: have demuxer code emit virtual subtitles packets to
trigger the sending of the heartbeat frames.
Regards,
--
Nicolas George
signatur
some of the people running this thing is sinking
rapidly.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link abov
w get a mail at
> gmx.at
> i could vote twice.
I am confused: you would get the same token in the second mail, you
would not be able to use it twice.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mail
Paul B Mahol (12023-11-11):
> I waited enough, applied, now for 100% true statement.
Your teacher called, you forgot your pacifier in class yesterday.
I am still expecting you to share the test cases you have so that the
bug can be properly fixed.
--
Nicolas George
signature.
proaches to the person who started the “unacceptable and
unbecoming” behavior. You just shown that you are biassed against me.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
everal members were in fact very
biassed.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
rong” is
the discourse of adults empowering bullies everywhere by punishing the
victims who try to defend themselves.
> Please just stop, you cannot have a bad day on the ml every day, it's bad
> for your mental health.
Oh, so “pacifier” is inappropriate but this is? I hope
se can be simplified by just using single filter, "trim=.." with same
> parameters as in script.
Please show the exact command so that we do not talk at cross-purposes.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffm
roves you
are biassed beyond all credibility.
> I am genuinely concerned for whatever reason is pushing you to use such an
> alienating and toxic language, yes.
Yeah, right. You mocking somebody's mental health was way more
inappropriate than anything that I or Paul ever wrote.
--
it is
necessary.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.or
because that info
does not exist).
But Paul pushed anyway, violating deliberately the project's policy. Out
of courtesy to everybody else I will not revert immediately as I should,
but I will revert with extreme prejudice if I find a simpler fix.
Regards,
--
Nicolas George
signature.as
t I am rather in favor too.
Also, I will say it here instead of sending a separate mail:
I find the strategy of legal intimidation about the GDPR disgusting.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel ma
tween CAN and WOULD. That would be
better than calling somebody's logical arguments “FUD”.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpe
vote for other VideoLAN members (and they are quite of us in the FFmpeg GA).
Hum. This is an angle I had neglected, thanks for bringing it up.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-d
re closely matches
> the subtitles timestamp stored in the file.
I would need to look into it. Does it improve it with your changes or
also with the precedent non-threaded code?
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-deve
ays ago)
thousands of frame queued, eventually failing on OOM.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Nicolas George (12023-11-27):
> Just as I warned you, it breaks the test case I suggested:
>
> ./ffmpeg_g -xerror -i /tmp/dummy_with_sub.mkv -preset ultrafast -lavfi
> '[0:s]setpts=PTS+60/TB[s] ; [0:v][s]overlay' -y /tmp/dummy_with_hardsub.mkv
>
> (/tmp/dummy_with_su
Anton Khirnov (12023-11-23):
> ---
> libavfilter/buffersink.c | 9 +
> 1 file changed, 9 insertions(+)
LGTM, thanks.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman
art and much better than no testing at all.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
Paul B Mahol (12023-11-27):
> Looks unrelated issue I just fixed, and sent patch to ML.
No, it does not change anything, still “queued = 1081”. You could have
tested.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
Paul B Mahol (12023-11-28):
> Gonna apply soon.
24 hours is not enough.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-de
Paul B Mahol (12023-11-28):
> Will wait max 24 hours.
You will wait until I post a review, and if you think I am taking too
much time in… let us say… ten days you can politely ask me where I am.
--
Nicolas George
___
ffmpeg-devel mailing list
ffm
to filtergraph
> that reached EOF by other means, for example EOF is signalled
> by other filter in filtergraph or by buffersink.
>
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/framesync.c | 3 +++
> 1 file changed, 3 insertions(+)
LGTM, good catch.
--
Nicol
Tomas Härdin (12023-11-30):
> Why?
Why not?
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org w
sscanf() can return -1 when it reach the end of the string.
Fix track ticket #10677.
Signed-off-by: Nicolas George
---
libavfilter/af_pan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c
index cfed9f146a..9ab827b396 100644
in parallel.
>
> Changes the results of ffmpeg-fix_sub_duration_heartbeat - tested by
> JEEB to be more correct and deterministic.
> ---
> Fixed the hang. Also updated the public branch.
Still breaking sub2video with time shift, see the test case I already
sent t
Anton Khirnov (12023-12-01):
> See my email from wednesday, it's not actually broken.
I do not have a mail from you from Wednesday. When something succeeds
with the current code and fails with “Error while add the frame to
buffer source(Cannot allocate memory)”, that is broken.
--
last thread).
I do not know what you are talking about, I agreed to no such thing.
The test case I gave you is correct and with the current code it works.
Your changes breaks it, removing an important features for users. Please
include it in your testing routine and only submit again when you have
d that it was
already what you did, but obviously it is not, so let us resolve this
misunderstanding.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit
Paul B Mahol (12023-12-03):
> Will apply soon.
Must you really act like an asshole each time? You will wait for
review.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
ilter.c | 10 ++
> 1 file changed, 10 insertions(+)
You pushed without review, I will revert this without a second thought
if I have the slightest doubt about the validity of this commit.
--
Nicolas George
___
ffmpeg-devel mailing list
ff
tbeat frames only when they are needed,
keeping the current logic in place.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
by threading is the job of the person who
wants to introduce threading. I can offer the help of my expertise about
lavfi and subtitles, of course. But your attitude to just pretend the
problem does not exist is unacceptable.
--
Nicolas George
___
f
than no code at all.
We are not libav, we do not remove code just because the Great Dictator
says so. If you really really want this decoder to have a test, you can
write add it yourself.
Rejected.
--
Nicolas George
signature.asc
Description: P
1 - 100 of 4812 matches
Mail list logo
