[FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

Signed-off-by: Sophia Wang <s...@google.com> --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index f3d701f..c536605 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matrosk

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang <s...@google.com> --- libavformat/matroskadec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index d07a092..8c809ad 100644 --- a/libavformat/matroskadec.c +++ b/libav

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Apologies, I didn't realize that matroska->done was only checked in one place. But Nicolas raises a good point about the subtle change in behavior. I did not intend to change the overall behavior of the code for clients, so I'll modify the patch to restore the matroska->done check. On Tue, Aug 9,

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

splitting into a separate patch? On Sun, Jul 31, 2016 at 10:26 AM, Nicolas George <geo...@nsup.org> wrote: > Le quartidi 14 thermidor, an CCXXIV, Sophia Wang a écrit : > > Since matroska->done is only set to 1 in matroska_resync(), the choice > > of error is made by c

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang <s...@google.com> --- libavformat/matroskadec.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index d07a092..f9693ca 100644 --- a/libavformat/matroskadec.c +++ b/libav

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

ose. On Wed, Aug 10, 2016 at 4:51 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Wed, Aug 10, 2016 at 10:24:08AM -0700, Sophia Wang wrote: > > Signed-off-by: Sophia Wang <s...@google.com> > > --- > > libavformat/matroskadec.c | 15 ++- >

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

I think you're right. Seems like the best solution is to maintain the number of calls to matroska_deliver_packet(); patch modification on the way. On Wed, Aug 31, 2016 at 6:30 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > > On Mon, Aug 15, 2016 at 10:27:47AM -0700, Sophi

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang <s...@google.com> --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..936690d 100644 --- a/libavformat/matroskadec.c +++ b/libav

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang <s...@google.com> --- libavformat/matroskadec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..7ee1c7a 100644 --- a/libavformat/matroskadec.c +++ b/libav

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Fri, Sep 23, 2016 at 1:40 AM, Benoit Fouet <benoit.fo...@free.fr> wrote: > Hi, > > > On 22/09/2016 23:03, Sophia Wang wrote: > >> Signed-off-by: Sophia Wang <s...@google.com> >> --- >> libavformat/matroskadec.c | 13 - >