Re: [FFmpeg-devel] [PATCH v2] added ULs for demuxing avid media composer mxf files

2014-08-14 Thread Tomas Härdin
On Tue, 2014-08-12 at 14:58 -0700, Mark Reid wrote: UL values copied from FMbc version of mxf.c Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..8ebfdf2 100644

Re: [FFmpeg-devel] [PATCH]Do not ask for mxf samples with unknown field dominance

2014-09-10 Thread Tomas Härdin
On Tue, 2014-08-19 at 22:30 +0200, Michael Niedermayer wrote: On Tue, Aug 19, 2014 at 01:30:24AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch removes a request for samples of which we already have several that all work fine. field_dominance can have 256 different values, do we

Re: [FFmpeg-devel] MXF : default fied dominance is TFF

2014-09-10 Thread Tomas Härdin
On Tue, 2014-09-09 at 12:37 +0200, Michael Niedermayer wrote: On Mon, Sep 08, 2014 at 12:17:14PM +, Gaullier Nicolas wrote: I did not found an easy way to set up initialization values to properly handle defaults but I am not a highly skilled developer, and maybe someone will find how

Re: [FFmpeg-devel] [PATCH]Do not ask for mxf samples with unknown field dominance

2014-09-24 Thread Tomas Härdin
On Tue, 2014-09-16 at 09:03 +0100, tim nicholson wrote: On 10/09/14 21:45, Tomas Härdin wrote: On Tue, 2014-08-19 at 22:30 +0200, Michael Niedermayer wrote: On Tue, Aug 19, 2014 at 01:30:24AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch removes a request for samples of which we

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfenc: H.264 Intra support

2014-09-24 Thread Tomas Härdin
On Sat, 2014-09-13 at 12:36 +0200, Michael Niedermayer wrote: From: Baptiste Coudurier baptiste.coudur...@gmail.com Ported by michael from ffmbc to ffmpeg the code is under CONFIG_GPL as ffmbc is GPL Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mxfenc.c | 143

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: read reel_name and source timecode from physical source package

2014-09-28 Thread Tomas Härdin
On Thu, 2014-09-25 at 16:13 -0700, Mark Reid wrote: --- libavformat/mxfdec.c | 118 ++- 1 file changed, 97 insertions(+), 21 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7a4633f..3a1889f 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add jpeg2000 support

2014-10-02 Thread Tomas Härdin
On Tue, 2014-09-30 at 15:37 +0200, Benoit Fouet wrote: Hi, this patch adds support for j2k muxing in MXF. tested with: $ ffmpeg -t 5 -f lavfi -i testsrc -y -c:v libopenjpeg -y out.mxf Played back in ffplay (linux), vlc (windows), Acrok MXF converter (windows). I have no idea against what

Re: [FFmpeg-devel] [PATCH] mxfdec: minor simplification.

2014-10-19 Thread Tomas Härdin
On Sat, 2014-10-18 at 15:26 +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger reimar.doeffin...@gmx.de --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 9306cc6..f916d01 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Tomas Härdin
On Mon, 2014-10-27 at 17:21 +, Thomas Mundt wrote: Hi, I´ve seen that there has been approach last month to implement AVC Intra mxf muxing. I tested the patches, but it didn´t work with any of my samples. Since there also has been discussions about the gpl restriction, I rewrote the

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: refactored resolving timecode component

2014-11-14 Thread Tomas Härdin
On Wed, 2014-11-12 at 12:15 -0800, Mark Reid wrote: --- libavformat/mxfdec.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index b533e2a..87f1e51 100644 --- a/libavformat/mxfdec.c +++

Re: [FFmpeg-devel] [PATCH]Read aspect ratio from mxf

2014-11-21 Thread Tomas Härdin
On Sun, 2014-11-16 at 02:03 +0100, Carl Eugen Hoyos wrote: On Saturday 15 November 2014 11:57:00 pm Michael Niedermayer wrote: On Sat, Nov 15, 2014 at 02:50:38AM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #4107 for me. An alternative would be to force the sar to

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

2014-11-21 Thread Tomas Härdin
On Tue, 2014-11-18 at 16:52 -0800, Mark Reid wrote: --- libavformat/mxfdec.c | 74 +++- 1 file changed, 39 insertions(+), 35 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fa0a2f4..8c13c24 100644 ---

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: initial support for EssenceGroups

2014-11-28 Thread Tomas Härdin
On Tue, 2014-11-25 at 15:14 -0800, Mark Reid wrote: --- libavformat/mxf.c | 1 + libavformat/mxf.h | 1 + libavformat/mxfdec.c | 148 - tests/ref/lavf/mxf | 6 +- tests/ref/lavf/mxf_d10 | 2 +- 5 files changed, 127

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c refactor resolving MultiDescriptor and remove essence group hack

2014-12-04 Thread Tomas Härdin
On Tue, 2014-12-02 at 16:43 -0800, Mark Reid wrote: I think this is a better way to deal with single frame essence data then my previous way. --- libavformat/mxfdec.c | 62 1 file changed, 38 insertions(+), 24 deletions(-) diff

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-12 Thread Tomas Härdin
On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #4173 for me. To be split in two parts. Please comment, Carl Eugen Looks alright. Maybe you want to pass it a MXFMetadataSet** so you can use av_freep() like before? But I suppose it doesn't matter

Re: [FFmpeg-devel] [PATCH]Fix leak reading invalid mxf files

2014-12-14 Thread Tomas Härdin
On Sat, 2014-12-13 at 13:18 +0100, Carl Eugen Hoyos wrote: On Friday 12 December 2014 01:43:19 pm Tomas Härdin wrote: On Wed, 2014-12-10 at 11:30 +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #4173 for me. To be split in two parts. Please comment, Carl Eugen

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec.c: support demuxing opatom audio without index

2014-12-27 Thread Tomas Härdin
On Sun, 2014-12-21 at 17:46 -0800, Mark Reid wrote: hi, Media Composer generates audio OPAtom mxf files that don't have index segments. All the uncompressed pcm audio essence data contained in a single KLV packet. This is my initial attempt to get demuxing working, I'm not too familiar

Re: [FFmpeg-devel] [PATCH v4] libavformat/mxfdec.c: support demuxing opatom audio without index

2015-01-18 Thread Tomas Härdin
On Wed, 2015-01-14 at 19:26 -0800, Mark Reid wrote: changes since v3: * return if there isn’t exactly one partition * cosmetic and gcc cleanups * added comment about EditUnitByteCount --- libavformat/mxfdec.c | 59 1 file changed, 59

Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: write user comment metadata

2015-03-15 Thread Tomas Härdin
On Sat, 2015-03-14 at 17:59 -0700, Mark Reid wrote: --- libavformat/mxfenc.c | 66 +-- tests/ref/lavf/mxf| 6 ++--- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 69 insertions(+), 7

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Tomas Härdin
On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) +{ +MXFTaggedValue *tagged_value = arg; +uint8_t key[17]; + +if (size = 17) +return 0; + +avio_read(pb, key, 17); Really Avid, 17 byte

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-13 Thread Tomas Härdin
On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: This fixes a crash, when trying to mux h264 into mxf_opatom. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-27 Thread Tomas Härdin
On Wed, 2015-03-25 at 15:43 -0700, Mark Reid wrote: On Mar 24, 2015 7:05 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: --- libavformat/mxfenc.c | 100 ++- 1 file changed, 83

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Detect XYZ pixel format for digital cinema files

2015-03-05 Thread Tomas Härdin
On Thu, 2015-03-05 at 00:36 +0200, Vilius Grigaliūnas wrote: While the native jpeg2000 decoder can determine pixel format correctly from the codestream, libopenjpeg wrapper cannot. To make sure that the output is correct when using libopenjpeg to decode digital cinema files, we do detection

Re: [FFmpeg-devel] [PATCH v5] libavformat/mxfenc: write package name metadata

2015-03-05 Thread Tomas Härdin
On Wed, 2015-03-04 at 12:31 -0800, Mark Reid wrote: +/* + * Returns the calculated length a local tag containing an utf-8 string as utf-16 + */ +static int mxf_utf16_local_tag_length(const char *utf8_str) +{ +uint64_t size; + +if (!utf8_str) +return 0; + +size =

Re: [FFmpeg-devel] [PATCH]Set interlaced flag when muxing interlaced dnxhd into mxf

2015-04-19 Thread Tomas Härdin
On Fri, 2015-04-17 at 00:31 +0200, Carl Eugen Hoyos wrote: Hi! Completely untested. Please review, Carl Eugen No idea really. Can't this flag be taken automagically from the codec somehow? /Tomas signature.asc Description: This is a digitally signed message part

Re: [FFmpeg-devel] [PATCH v2] libavformat/mxfenc: added support mxf opatom audio muxing

2015-04-11 Thread Tomas Härdin
On Fri, 2015-04-10 at 20:02 -0700, Mark Reid wrote: @@ -2055,8 +2083,35 @@ static int mxf_write_header(AVFormatContext *s) av_log(s, AV_LOG_ERROR, MXF D-10 only support 16 or 24 bits le audio\n); } sc-index =

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Add color siting element

2015-05-21 Thread Tomas Härdin
On Tue, 2015-05-19 at 15:35 +0100, tim nicholson wrote: On 19/05/15 14:11, Michael Niedermayer wrote: On Tue, May 19, 2015 at 12:07:24PM +0100, tim nicholson wrote: On 19/05/15 01:33, Michael Niedermayer wrote: The default is assumed to be 0xFF, which is what the 2009 spec lists , the

Re: [FFmpeg-devel] [PATCH] mxfdec: set AVFMT_SEEK_TO_PTS demuxer flag

2015-08-10 Thread Tomas Härdin
On Sun, 2015-08-09 at 20:32 +0200, Marton Balint wrote: Since 53f2ef2c4afb1d49a679dea9163cb0e4671f3117 seeking is done using PTS. Signed-off-by: Marton Balint c...@passwd.hu --- libavformat/mxfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] mxfdec: set AVFMT_SEEK_TO_PTS demuxer flag

2015-08-14 Thread Tomas Härdin
On Mon, 2015-08-10 at 10:14 +0200, Tomas Härdin wrote: On Sun, 2015-08-09 at 20:32 +0200, Marton Balint wrote: Since 53f2ef2c4afb1d49a679dea9163cb0e4671f3117 seeking is done using PTS. Signed-off-by: Marton Balint c...@passwd.hu --- libavformat/mxfdec.c | 1 + 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] mxfdec: calculate the index in display order

2015-07-14 Thread Tomas Härdin
On Sat, 2015-07-11 at 18:54 +0200, Marton Balint wrote: This should fix seeking for open GOP files as well. Signed-off-by: Marton Balint c...@passwd.hu --- @@ -1411,8 +1417,7 @@ static int mxf_compute_ptses_fake_index(MXFContext *mxf, MXFIndexTable *index_ta break;

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-21 Thread Tomas Härdin
On Fri, 2015-07-17 at 12:36 +0200, Carl Eugen Hoyos wrote: On Saturday 11 July 2015 04:13:52 pm Tomas Härdin wrote: Just a quick review since I have to bounce: +const MXFCodecUL ff_mxf_codec_tag_uls[] = { Haven't we moved this to mxf.c already? Or rather, don't we have a whole bunch

Re: [FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-24 Thread Tomas Härdin
On Thu, 2015-10-22 at 19:25 +0200, Alexis Ballier wrote: > On Wed, 21 Oct 2015 23:31:29 +0200 > Tomas Härdin <tomas.har...@codemill.se> wrote: > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > klv_decode_ber_length cannot return -1, but can re

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-10-25 Thread Tomas Härdin
On Thu, 2015-10-22 at 19:47 +0200, Alexis Ballier wrote: > On Wed, 21 Oct 2015 23:45:07 +0200 > Tomas Härdin <tomas.har...@codemill.se> wrote: > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > Some files such as those from tickets #2817 & #2776

Re: [FFmpeg-devel] [PATCH 03/11] libavformat/mxfdec.c: Report dark metadata keys only when they match no parser at all, not everytime they fail to match one.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > --- > libavformat/mxfdec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 0ae7ce6..593604e 100644 > --- a/libavformat/mxfdec.c > +++

Re: [FFmpeg-devel] [PATCH 02/11] libavformat/mxfdec.c: cosmetics: Add missing space after '?' in log message.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 94a953b..0ae7ce6 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c >

Re: [FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > klv_decode_ber_length cannot return -1, but can return AVERROR_INVALIDDATA. > Store its return value in a signed integer (instead of unsigned > KLVPacket.length) and forward the error appropriately. > --- > libavformat/mxfdec.c | 6

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > Some files such as those from tickets #2817 & #2776 claim to have constant > edit unit size but, > in fact, have some of them that are smaller. This confuses the demuxer that > tries to infer the > current edit unit from the position in

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc.c: Fix segfault when writing an audio packet when there has not been a video one.

2015-10-21 Thread Tomas Härdin
On Tue, 2015-10-20 at 16:43 +0200, Marton Balint wrote: > On Mon, 19 Oct 2015, Tomas Härdin wrote: > > > On Mon, 2015-10-19 at 11:40 +0200, Alexis Ballier wrote: > >> On Mon, 19 Oct 2015 10:30:00 +0200 > >> Michael Niedermayer <mich...@niedermayer.cc> wrote: &

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-11-06 Thread Tomas Härdin
On Sun, 2015-10-25 at 21:43 +0100, Tomas Härdin wrote: > On Thu, 2015-10-22 at 19:47 +0200, Alexis Ballier wrote: > > On Wed, 21 Oct 2015 23:45:07 +0200 > > Tomas Härdin <tomas.har...@codemill.se> wrote: > > > > > On Wed, 2015-10-21 at 18:00 +0200, Alex

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc.c: Fix segfault when writing an audio packet when there has not been a video one.

2015-10-19 Thread Tomas Härdin
On Mon, 2015-10-19 at 11:40 +0200, Alexis Ballier wrote: > On Mon, 19 Oct 2015 10:30:00 +0200 > Michael Niedermayer wrote: > > > On Fri, Oct 16, 2015 at 10:42:32AM +0200, Alexis Ballier wrote: > > > This happens when writing the trailer of a file containing audio > > >

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-13 Thread Tomas Härdin
On Mon, 2015-10-05 at 14:25 +0200, Tobias Rapp wrote: > On 05.10.2015 09:10, tim nicholson wrote: > > On 04/10/15 13:07, Tomas Härdin wrote: > >> On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: > >>> [...] > >> > >> For me the most importan

Re: [FFmpeg-devel] [PATCH]lavf/mxf: Map codec_tag for Avid files if everything else fails

2015-07-11 Thread Tomas Härdin
On Fri, 2015-07-10 at 20:11 +0200, Carl Eugen Hoyos wrote: Hi! Attached patch allows decoding of the sample provided on ffmpeg-user: http://ffmpeg.org/pipermail/ffmpeg-user/2015-July/027472.html Better suggestions welcome, Carl Eugen Just a quick review since I have to bounce: +const

Re: [FFmpeg-devel] [PATCH]Support more mxf files with codec_ul

2015-09-02 Thread Tomas Härdin
On Tue, 2015-09-01 at 23:53 +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes decoding the sample from ticket #4820 for me. > > Please comment, Carl Eugen > -static const MXFCodecUL mxf_codec_uls[] = { > -{ { >

Re: [FFmpeg-devel] [PATCH] mxfdec: set AVFMT_SEEK_TO_PTS demuxer flag

2015-08-25 Thread Tomas Härdin
On Tue, 2015-08-25 at 07:58 +0100, tim nicholson wrote: On 14/08/15 13:27, Tomas Härdin wrote: On Mon, 2015-08-10 at 10:14 +0200, Tomas Härdin wrote: On Sun, 2015-08-09 at 20:32 +0200, Marton Balint wrote: Since 53f2ef2c4afb1d49a679dea9163cb0e4671f3117 seeking is done using PTS

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-04 Thread Tomas Härdin
On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: > On 19.09.2015 22:49, Tomas Härdin wrote: > > On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: > >> Hi, > >> > >> attached patch fixes ticket #4759 but I guess it is a bit too hasty to > >&g

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-09-19 Thread Tomas Härdin
On Wed, 2015-09-16 at 14:33 +0200, Tobias Rapp wrote: > Hi, > > attached patch fixes ticket #4759 but I guess it is a bit too hasty to > always abort transcoding if a single frame cannot be written. I guess it > would be better to check for some "exit_on_error" like flag set but > couldn't

Re: [FFmpeg-devel] [PATCH] lavf/mxfdec: fix seeking before the first keyframe

2015-12-07 Thread Tomas Härdin
On Sat, 2015-11-28 at 02:56 +0100, Marton Balint wrote: > Regression since 53f2ef2c4afb1d49a679dea9163cb0e4671f3117. > Fixes ticket #5017. > > Signed-off-by: Marton Balint > --- > libavformat/mxfdec.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] Several, actually, regarding the QuickTime palette issue in Matroska

2015-12-16 Thread Tomas Härdin
On Wed, 2015-12-16 at 20:30 +0100, Mats Peterson wrote: > On 12/16/2015 08:27 PM, Mats Peterson wrote: > > On 12/16/2015 08:26 PM, Kieran Kunhya wrote: > >>> I have said before that I'm not going to dwell into the complexities > >>> of Git, > >>> since it feels about as wasteful as programming a

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Fix integer overflow in length computation

2015-12-14 Thread Tomas Härdin
On Wed, 2015-12-09 at 18:13 +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes: CID1341577 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfenc.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Set width to actual coded_width for AVCI50

2015-11-24 Thread Tomas Härdin
On Tue, 2015-11-24 at 12:02 +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5029. > > Please comment, Carl Eugen Looks simple enough, but (ab)using MXFCodecUL like that has a slight stink to it. Can we perhaps rename the struct to something that signals its more general

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Set width to actual coded_width for AVCI50

2015-11-27 Thread Tomas Härdin
On Thu, 2015-11-26 at 00:48 +0100, Carl Eugen Hoyos wrote: > On Wednesday 25 November 2015 12:57:07 am Tomas Härdin wrote: > > On Tue, 2015-11-24 at 12:02 +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #5029. > > > &

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: check if source_package is NULL

2016-06-12 Thread Tomas Härdin
On Tue, 2016-05-31 at 23:02 +0200, Marton Balint wrote: > Fixes ticket #5554. > > Signed-off-by: Marton Balint > --- >  libavformat/mxfdec.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index

Re: [FFmpeg-devel] [PATCHv2] Revert "do not write f2 if not interlaced"

2016-02-01 Thread Tomas Härdin
On Fri, 2016-01-29 at 17:45 +0100, Sebastian Dröge wrote: > From: Sebastian Dröge > > This reverts commit 8ed82d8174a666f80ab8834e3617cbe91ae740a9. > > SMPTE S377-1-2009c defines in F.4.1 that the Video Line Map should > always be an array with two 32 bit integers as

Re: [FFmpeg-devel] [PATCH 09/12] avformat/mxfenc: use ff_parse_creation_time_metadata

2016-02-16 Thread Tomas Härdin
On Sat, 2016-02-06 at 20:13 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- >  libavformat/mxfenc.c | 5 + >  1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 6da8b10..cd13f89 100644 > ---

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Fix canopus essence element size

2016-03-13 Thread Tomas Härdin
On Thu, 2016-03-10 at 15:08 +0100, Carl Eugen Hoyos wrote: > Hi! > > While debugging ticket #5312, I realized that I included the  > track number in the Canopus essence element. OK /Tomas signature.asc Description: This is a digitally signed message part

Re: [FFmpeg-devel] [RFC]lavf/mxfdec: Assume first track if track number is unknown

2016-03-13 Thread Tomas Härdin
On Thu, 2016-03-10 at 15:06 +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5312 here. > The OP claims that the file plays fine with Mainconcept softare,  > afaict the track number of the video track in the mxf header  > (0x15010800) does not match the track number of the

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Support canopus codecs

2016-03-09 Thread Tomas Härdin
On Wed, 2016-03-09 at 15:21 +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5316 here. > I unfortunately have no idea what the hunk in mxf_read_header()  > does, decoding works fine without it. Strange. Why was mxf_canopus_essence_element_key added then? Pushing without it

Re: [FFmpeg-devel] [PATCH 5/6] libavformat/mxf: add dnxhr codec ul

2016-08-07 Thread Tomas Härdin
On Mon, 2016-07-04 at 18:07 -0700, Mark Reid wrote: > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 0affca9..8f2f10a 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -1098,6 +1098,10 @@ static int mxf_match_uid(const UID key, const UID uid, > int len) >  

[FFmpeg-devel] New MXF maintainer wanted

2016-08-20 Thread Tomas Härdin
Hi Long story short: I no longer work with MXF (or broadcast in general), and my free time is currently being consumed by other projects. Therefore I feel it'd be better if someone took over the role as MXF maintainer. I took a few shots at the recent MXF tickets on trac, but I've forgotten too

[FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-02 Thread Tomas Härdin
TER_ENCDEC (LIBGSM,libgsm); REGISTER_ENCDEC (LIBGSM_MS, libgsm_ms); diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c594993766..488eb8b1f5 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -622,6 +622,7 @@ enum AVCodecID { AV_CODEC_ID_PAF_AUDIO,

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 01:07 +0200, Carl Eugen Hoyos wrote: > 2017-08-03 0:40 GMT+02:00 Tomas Härdin <tjop...@acc.umu.se>: > > > > > Decoding a .c2 file is straightforward however, thanks to the > > header: > > > >   ffmpeg -i report2074.c2 out.wav >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Tomas Härdin
On Thu, 2017-08-03 at 13:00 +0200, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXV, Tomas Härdin a écrit : > > With both the raw demuxer and the encoder you need to specify the > > desired mode, like this: > The encoder could default to one the two. Default on-th

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check decomp_size

2017-08-16 Thread Tomas Härdin
On 2017-08-16 05:04, Michael Niedermayer wrote: Fixes: OOM Fixes: 2710/clusterfuzz-testcase-minimized-4750001420894208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-16 Thread Tomas Härdin
On 2017-08-15 21:15, Moritz Barsnick wrote: On Tue, Aug 08, 2017 at 23:49:45 +0200, Tomas Härdin wrote: Feel free to comment Don't forget to mention #1959 in the commit message. Huh, I didn't know there was a ticket for it. That audiobook guy popped up on [Freetel-codec2] too, and thus

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check decomp_size

2017-08-16 Thread Tomas Härdin
On 2017-08-16 14:35, Michael Niedermayer wrote: On Wed, Aug 16, 2017 at 09:48:43AM +0200, Tomas Härdin wrote: On 2017-08-16 05:04, Michael Niedermayer wrote: Fixes: OOM Fixes: 2710/clusterfuzz-testcase-minimized-4750001420894208 Found-by: continuous fuzzing process https://github.com/google

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check decomp_size

2017-08-17 Thread Tomas Härdin
On 2017-08-16 16:03, Michael Niedermayer wrote: Fixes: OOM Fixes: 2710/clusterfuzz-testcase-minimized-4750001420894208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-04 Thread Tomas Härdin
On Thu, 2017-08-03 at 22:24 +0200, Reimar Döffinger wrote: > On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > > > > > +//statically assert the size of avpriv_codec2_header > > +//putting it here because all codec2 things depend on > >

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-08 Thread Tomas Härdin
On Fri, 2017-08-04 at 19:20 +0200, Tomas Härdin wrote: > TODO: > > * have -mode be an integer and use the CONST system Nicolas mentioned > * option for demuxing multiple frames at a time > * sort the extradata aliasing thing > * address API issues in libcodec2, possibly

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vorbisenc: Apply dynamic frame lengths

2017-08-23 Thread Tomas Härdin
On 2017-08-22 03:23, Tyler Jones wrote: +static int create_residues(vorbis_enc_context *venc) +{ +int res, ret; +vorbis_enc_residue *rc; + +venc->nresidues = 2; +venc->residues = av_malloc(sizeof(vorbis_enc_residue) * venc->nresidues); av_malloc_array()? Applies to most

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-18 Thread Tomas Härdin
On 2017-08-18 08:14, Vitaly Buka wrote: Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 4 +++- libavformat/mov.c | 2 +-

[FFmpeg-devel] License consent (cinepakenc.c)

2017-05-16 Thread Tomas Härdin
Hi I got a question from Diego via IRC about what license cinepakenc.c actually has, since the first commit message just has a message by"Rl" saying that I said it was OK but with no appropriately signed message from me. So I'm posting this just to clarify things: I consent to the original

Re: [FFmpeg-devel] License consent (cinepakenc.c)

2017-05-16 Thread Tomas Härdin
On Tue, 2017-05-16 at 15:42 -0300, James Almer wrote: > On 5/16/2017 3:13 PM, Tomas Härdin wrote: > > > > Hi > > > > I got a question from Diego via IRC about what license cinepakenc.c > > actually has, since the first commit message just has a message > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix aspect ratio when writing 16:9 DV frames

2017-09-14 Thread Tomas Härdin
On 2017-09-14 15:44, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 7289e0b..da4d7b4 100644 --- a/libavformat/mxfenc.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: use the common packet pts setter function for opatom files

2017-09-14 Thread Tomas Härdin
On 2017-09-13 21:31, Marton Balint wrote: On Fri, 8 Sep 2017, Michael Niedermayer wrote: On Thu, Sep 07, 2017 at 05:11:40PM +0200, Marton Balint wrote: Fixes ticket #6631. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 12 +++- 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfenc: Replace more literal magic numbers by enum values.

2017-09-10 Thread Tomas Härdin
On Sun, 2017-09-10 at 22:10 +0200, Michael Niedermayer wrote: >  enum { >  INDEX_MPEG2 = 0, >  INDEX_AES3, > @@ -159,6 +139,26 @@ enum { >  INDEX_H264, >  }; >   > +static const struct { > +enum AVCodecID id; > +int index; > +} mxf_essence_mappings[] = { > +{

Re: [FFmpeg-devel] [PATCH] add Weston Capture demuxer, parser and decoder

2017-09-10 Thread Tomas Härdin
On Sun, 2017-09-10 at 21:03 +0200, Paul B Mahol wrote: > +static av_cold int wcap_decode_init(AVCodecContext *avctx) > +{ > +WCAPContext *s = avctx->priv_data; > +uint32_t format; > + > +if (avctx->extradata && avctx->extradata_size >= 4) { > +format =

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfenc: write reel_name if metadata key is present

2017-11-28 Thread Tomas Härdin
On 2017-11-28 05:35, Mark Reid wrote: On Mon, Nov 27, 2017 at 2:40 AM, Tomas Härdin <tjop...@acc.umu.se> wrote: On Sun, 2017-11-26 at 21:42 -0800, Mark Reid wrote: @@ -1396,13 +1410,17 @@ static int mxf_write_package(AVFormatContext *s, MXFPackage *package) } // write mu

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mxfenc: pass MXFPackage around instead of type

2017-11-28 Thread Tomas Härdin
On Tue, 2017-11-28 at 21:09 +0100, Michael Niedermayer wrote: > On Mon, Nov 27, 2017 at 11:00:51AM +0100, Tomas Härdin wrote: > > On Sun, 2017-11-26 at 21:42 -0800, Mark Reid wrote: > > > --- > > >

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-11-29 Thread Tomas Härdin
On 2017-11-29 05:11, Mark Reid wrote: @@ -980,7 +980,7 @@ static void mxf_write_structural_component(AVFormatContext *s, AVStream *st, MXF // write uid mxf_write_local_tag(pb, 16, 0x3C0A); -mxf_write_uuid(pb, package->type == MaterialPackage ? SourceClip: SourceClip +

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-11-29 Thread Tomas Härdin
On 2017-11-29 05:11, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 42 +++--- 2 files changed, 36 insertions(+), 7 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index 2d5b44943b..ffcc429a8b 100644 ---

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-11-30 Thread Tomas Härdin
On Wed, 2017-11-29 at 20:18 -0800, Mark Reid wrote: > On Wed, Nov 29, 2017 at 1:36 AM, Tomas Härdin <tjop...@acc.umu.se> > wrote: > > > On 2017-11-29 05:11, Mark Reid wrote: > > > > > @@ -980,7 +980,7 @@ static void > > > mxf_write_structural_componen

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfenc: write reel_name if metadata key is present

2017-11-27 Thread Tomas Härdin
On Sun, 2017-11-26 at 21:42 -0800, Mark Reid wrote: > @@ -1396,13 +1410,17 @@ static int mxf_write_package(AVFormatContext > *s, MXFPackage *package) > } > > // write multiple descriptor reference > -if (package->type == SourcePackage) { > +if (package->instance == 1) { Would

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mxfenc: pass MXFPackage around instead of type

2017-11-27 Thread Tomas Härdin
On Sun, 2017-11-26 at 21:42 -0800, Mark Reid wrote: > --- > libavformat/mxfenc.c | 99 +- > -- > 1 file changed, 55 insertions(+), 44 deletions(-) > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c > index 035e65ed43..ed6ecbf541 100644 >

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mxfenc: use track count to generate component instance uuid

2017-11-27 Thread Tomas Härdin
On Sun, 2017-11-26 at 21:42 -0800, Mark Reid wrote: > --- > libavformat/mxf.h | 1 - > libavformat/mxfenc.c| 45 + > > tests/ref/fate/copy-trac4914| 2 +- > tests/ref/fate/time_base| 2 +- > tests/ref/lavf/mxf

Re: [FFmpeg-devel] [RFC] [Vote] Drop Windows XP support

2017-12-14 Thread Tomas Härdin
On 2017-12-14 14:26, wm4 wrote: I propose that FFmpeg sets the minimum supported Windows version to Windows Vista (or maybe Windows 7). This would remove Windows XP support. The reason is that Windows XP does not provide certain convenient APIs, in particular locking primitives that map well to

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Tomas Härdin
On Thu, 2017-12-07 at 22:40 +0100, Michael Niedermayer wrote: > On Thu, Dec 07, 2017 at 04:41:09PM +0100, Tomas Härdin wrote: > > On 2017-12-05 05:46, Mark Reid wrote: > > > @@ -1398,16 +1397,26 @@ static void > > > mxf_write_package(AVFormatCont

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-12-07 Thread Tomas Härdin
On Thu, 2017-12-07 at 14:45 -0800, Mark Reid wrote: > On Dec 7, 2017 7:45 AM, "Tomas Härdin" <tjop...@acc.umu.se> wrote: > > On 2017-12-05 05:46, Mark Reid wrote: > > > --- > > libavformat/mxf.h| 1 + > > libavformat/mxfenc.c | 42 +

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: use track count to generate component instance uuid

2017-12-07 Thread Tomas Härdin
On 2017-12-05 05:46, Mark Reid wrote: @@ -1398,16 +1397,26 @@ static void mxf_write_package(AVFormatContext *s, MXFPackage *package) mxf_write_uuid(pb, SubDescriptor, 0); } +/* + * for every 1 track in a package there is 1 sequence and 1 component. + * all 3

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mxfenc: write reel_name if metadata key is present

2017-12-07 Thread Tomas Härdin
On 2017-12-05 05:46, Mark Reid wrote: --- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 42 +++--- 2 files changed, 36 insertions(+), 7 deletions(-) @@ -1476,6 +1495,15 @@ static int mxf_write_header_metadata_sets(AVFormatContext *s) }

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-07 Thread Tomas Härdin
sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt: > 2018-05-06 13:32 GMT+02:00 Tomas Härdin <tjop...@acc.umu.se>: > > > fre 2018-05-04 klockan 01:52 +0200 skrev Thomas Mundt: > > > Hi, > > > > > > this is a better version of the patch. > >

Re: [FFmpeg-devel] Add IRC nicknames to MAINTAINERS?

2018-05-14 Thread Tomas Härdin
ons 2018-04-25 klockan 11:42 +0200 skrev Paul B Mahol: > On 4/25/18, Tomas Haerdin wrote: > > ons 2018-04-25 klockan 09:55 +0100 skrev Josh de Kock: > > > On 2018/04/25 9:35, Paul B Mahol wrote: > > > > On 4/25/18, Tomas Haerdin wrote: > > > > > [...] > >

Re: [FFmpeg-devel] [PATCH 03/13] avformat/mxfenc: Add Product Version, Toolkit version and Platform

2018-05-08 Thread Tomas Härdin
mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer >  static void mxf_write_identification(AVFormatContext *s) >  { >  MXFContext *mxf = s->priv_data; > @@ -790,7 +809,7 @@ static void

Re: [FFmpeg-devel] [PATCH 01/13] avformat/mxfenc: Correct KAG alignment of preface

2018-05-08 Thread Tomas Härdin
mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- >  libavformat/mxfenc.c|  1 + >  tests/ref/fate/copy-trac4914|  4 ++-- >  tests/ref/fate/mxf-reel_name|  2 +- >  tests/ref/fate/time_base|  

Re: [FFmpeg-devel] github

2018-04-27 Thread Tomas Härdin
fre 2018-04-27 klockan 00:50 +0200 skrev wm4: > On Thu, 26 Apr 2018 14:41:55 +0200 > Daniel Oberhoff wrote: > > > > On 26. Apr 2018, at 14:40, wm4 wrote: > > > > > > On Thu, 26 Apr 2018 14:12:14 +0200 > > > Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-10 Thread Tomas Härdin
tis 2018-05-08 klockan 18:32 +0200 skrev Thomas Mundt: > 2018-05-07 10:40 GMT+02:00 Tomas Härdin <tjop...@acc.umu.se>: > > > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt: > > > 2018-05-06 13:32 GMT+02:00 Tomas Härdin <tjop...@acc.umu.se>: > > >

Re: [FFmpeg-devel] [PATCH 06/13] avformat/mxfenc: Add Sample width/height/x offset/y offset, Display x offset and F2 offset

2018-05-10 Thread Tomas Härdin
tis 2018-05-08 klockan 18:26 +0200 skrev Michael Niedermayer: > On Tue, May 08, 2018 at 12:40:49PM +0200, Tomas Härdin wrote: > > mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > > > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > >

Re: [FFmpeg-devel] [PATCH v3] avformat/mxfenc: add h264 profiles

2018-05-10 Thread Tomas Härdin
tor 2018-05-10 klockan 22:44 +0200 skrev Tomas Härdin: > tis 2018-05-08 klockan 18:32 +0200 skrev Thomas Mundt: > > 2018-05-07 10:40 GMT+02:00 Tomas Härdin <tjop...@acc.umu.se>: > > > > > sön 2018-05-06 klockan 21:31 +0200 skrev Thomas Mundt: > > > > 201

Re: [FFmpeg-devel] [PATCH 05/13] avformat/mxfenc: Fix stored width

2018-05-08 Thread Tomas Härdin
mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > This fixes the width to have computations matching the height > > > Signed-off-by: Michael Niedermayer > --- >  libavformat/mxfenc.c  |   3 +- >  

Re: [FFmpeg-devel] [PATCH 11/13] avformat/mxfenc: Write Audio Ref Level for D10

2018-05-08 Thread Tomas Härdin
mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer >  // Generic Sound Essence Descriptor >  { 0x3D02, > {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x04,0x04,0x02,0x03,0x01,0x04,0x00,0x00,0x00}}, > /* Locked/Unlocked */

Re: [FFmpeg-devel] [PATCH 07/13] avformat/mxfenc: Add vertical subsampling support

2018-05-08 Thread Tomas Härdin
mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > @@ -1149,6 +1151,8 @@ static void mxf_write_cdci_common(AVFormatContext *s, > AVStream *st, const UID ke >  desc_size += 5; >  if (sc->interlaced) >   

  1   2   3   4   5   >