Re: [FFmpeg-devel] [PATCH] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-28 Thread Carl Eugen Hoyos
2017-11-28 1:46 GMT+01:00 Colin NG : > +char tmp_str[MAX_URL_SIZE]; > +char tmp_str_2[MAX_URL_SIZE]; Assuming this is not speed-critical code, please also allocate these two with av_malloc(), FFmpeg can be compiled for systems with tiny stack. Carl Eugen

Re: [FFmpeg-devel] [PATCH] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-27 Thread Steven Liu
2017-11-28 8:46 GMT+08:00 Colin NG : > --- > libavformat/dashdec.c | 95 > --- > 1 file changed, 82 insertions(+), 13 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 3798649..5d5970e 100644

[FFmpeg-devel] [PATCH] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-27 Thread Colin NG
--- libavformat/dashdec.c | 95 --- 1 file changed, 82 insertions(+), 13 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 3798649..5d5970e 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -148,6 +148,11

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-22 Thread Steven Liu
2017-11-23 9:16 GMT+08:00 Colin NG : > Clean up coding style. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > diff --git a/libavformat/dashdec.c

[FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-22 Thread Colin NG
Clean up coding style. diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 3798649..7e7ae52 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -148,6 +148,11 @@ static uint64_t get_current_time_in_sec(void) return av_gettime() / 100; } +static char

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-19 Thread Moritz Barsnick
On Sat, Nov 18, 2017 at 00:16:33 +, Colin NG wrote: > Cleaned the code up. Please do read the ffmpeg style guide. > +static char * ishttp(char *url) { Asterisk attaches to the right hand side. > -ret = s->io_open(s, pb, url, AVIO_FLAG_READ, ); > +av_freep(pb); > +ret =

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-17 Thread Colin NG
Cleaned the code up. From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Carl Eugen Hoyos <ceffm...@gmail.com> Sent: November 17, 2017 5:24 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] Fix for

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-17 Thread Carl Eugen Hoyos
2017-11-17 1:55 GMT+01:00 Colin NG : > Excluded the fix for byte range issue and update some coding style issues. > +if (pb) av_freep(pb); The if() should be unnecessary. Please avoid adding empty lines in unrelated parts of the file and while there, try to fix "if

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-16 Thread Colin NG
; Sent: November 15, 2017 10:54 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault) 2017-11-15 3:54 GMT+01:00 Colin NG <colin...@hotmail.com>: > - Add a function to handle the base URL Processing describ

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-15 Thread Colin NG
mber 15, 2017 10:54 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault) 2017-11-15 3:54 GMT+01:00 Colin NG <colin...@hotmail.com>: > - Add a function to handle the base URL Processing described in section 5.6

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-15 Thread Carl Eugen Hoyos
2017-11-15 3:54 GMT+01:00 Colin NG : > - Add a function to handle the base URL Processing described in section 5.6.5 > of IEC_23009-1. > > - Fix for downloading dash content with byte range info As said: If these are two separate issues, please send two patches. Use

[FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-14 Thread Colin NG
- Add a function to handle the base URL Processing described in section 5.6.5 of IEC_23009-1. - Fix for downloading dash content with byte range info diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 0e3afd2..0be8a49 100644 --- a/libavformat/dashdec.c +++

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-12 Thread Moritz Barsnick
On Thu, Nov 09, 2017 at 00:19:33 +, Colin NG wrote: Before the next attempt, please do have a look at the docs about ffmpeg's programming style, especially bracket placement. > +static int isLocal(char *url) { > + > +if (av_strstart(url, "http://;, NULL) || av_strstart(url, "https://;,

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-09 Thread Carl Eugen Hoyos
2017-11-09 1:19 GMT+01:00 Colin NG : > - Add a function to handle the base URL Processing described in section 5.6.5 > of IEC_23009-1. > > - Fix for downloading content with byte range selection This sounds as if the patch should be split in two. Thank you, Carl Eugen

[FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-09 Thread Colin NG
- Add a function to handle the base URL Processing described in section 5.6.5 of IEC_23009-1. - Fix for downloading content with byte range selection diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index f63f1ff..19ef6f8 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c