Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-11 Thread Timo Rothenpieler
I applied the patch to the current ffmpeg master and made some style adjustments, you can take a look on my github fork: https://github.com/BtbN/FFmpeg/commit/3b5964c521343b883f92079765148fd630a9370c I also attached the patch for reference. Any comments? From

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-11 Thread Clément Bœsch
On Fri, Sep 11, 2015 at 11:45:59AM +0200, Timo Rothenpieler wrote: > I applied the patch to the current ffmpeg master and made some style > adjustments, you can take a look on my github fork: > > https://github.com/BtbN/FFmpeg/commit/3b5964c521343b883f92079765148fd630a9370c > > I also attached

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-11 Thread Agatha Hu
在 2015/9/11 17:45, Timo Rothenpieler 写道: * PGP Signed by an unknown key I applied the patch to the current ffmpeg master and made some style adjustments, you can take a look on my github fork: https://github.com/BtbN/FFmpeg/commit/3b5964c521343b883f92079765148fd630a9370c I also attached the

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-11 Thread Timo Rothenpieler
I just sent 3 patches following your suggestion (merge initialQP section) and fix the !ctx->twopass < 1 typo. The first patch is fixing cuCtxCreate. I guess this patch and mine are almost the same excpet mine omits most of the log output. Agatha Hu Yes, they seem to be about the same. The

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-11 Thread Timo Rothenpieler
-av_log(avctx, AV_LOG_FATAL, "Failed loading %s from CUDA library\n", s); \ +av_log(avctx, AV_LOG_FATAL, "[nvenc]: Failed loading %s from CUDA library\n", s); \ This kind of changes are unwanted. The codec name should already be raised in the logging (through avctx). It also

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-10 Thread Timo Rothenpieler
--- libavcodec/nvenc.c | 59 +- 1 file changed, 54 insertions(+), 5 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 5490652..7c683ea 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -610,8 +610,17 @@ static

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-10 Thread Agatha Hu
在 2015/9/10 17:48, Timo Rothenpieler 写道: @@ -770,7 +780,7 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) avctx->qmin = -1; avctx->qmax = -1; } else if (ctx->cbr) { -if (!ctx->twopass) { +if (!ctx->twopass < 1) { This doesn't seem right

Re: [FFmpeg-devel] [PATCH] Optimize nvenc parameters, add 3 more presets: fast, medium, slow

2015-09-10 Thread Agatha Hu
在 2015/9/10 17:48, Timo Rothenpieler 写道: * PGP Signed by an unknown key --- libavcodec/nvenc.c | 59 +- 1 file changed, 54 insertions(+), 5 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 5490652..7c683ea 100644