Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-17 Thread Michael Niedermayer
On Thu, Nov 16, 2017 at 06:27:38PM -0500, Dave Rice wrote: > > > On Nov 16, 2017, at 6:08 PM, Carl Eugen Hoyos wrote: > > > > 2017-11-16 17:54 GMT+01:00 Dave Rice : > > > >> +if (track->mode == MODE_MOV && track->par->codec_id == > >> AV_CODEC_ID_V410) > >> +avio_wb16(pb, 0x18); >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-16 Thread Dave Rice
> On Nov 16, 2017, at 6:08 PM, Carl Eugen Hoyos wrote: > > 2017-11-16 17:54 GMT+01:00 Dave Rice : > >> +if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V410) >> +avio_wb16(pb, 0x18); >> +else if (track->mode == MODE_MOV && track->par->codec_id == >> AV_CODEC_

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-16 Thread Carl Eugen Hoyos
2017-11-16 17:54 GMT+01:00 Dave Rice : > +if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V410) > +avio_wb16(pb, 0x18); > +else if (track->mode == MODE_MOV && track->par->codec_id == > AV_CODEC_ID_V210) > +avio_wb16(pb, 0x18); It appears you can merge t

[FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

2017-11-16 Thread Dave Rice
This corrects a few values in the Image Description for v210 and v410 in mov. Apple defines what the depth value for these uncompressed formats should be in https://developer.apple.com/library/content/technotes/tn2162/_index.html