Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-10 Thread Michael Niedermayer
On Tue, Nov 10, 2015 at 01:01:44PM +, tim nicholson wrote: > On 10/11/15 12:28, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Also support disabling them as they seem to cause problems to some > > Users. They are also not allowed in IRT D-10 thus

[FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-10 Thread Michael Niedermayer
From: Michael Niedermayer Also support disabling them as they seem to cause problems to some Users. They are also not allowed in IRT D-10 thus the default for mxf_d10 is not to write them This also decreases the filesize when no user comment are stored Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-10 Thread tim nicholson
On 10/11/15 12:28, Michael Niedermayer wrote: > From: Michael Niedermayer > > Also support disabling them as they seem to cause problems to some > Users. They are also not allowed in IRT D-10 thus the default for > mxf_d10 is not to write them > > This also decreases the

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-10 Thread Michael Niedermayer
On Mon, Nov 09, 2015 at 07:38:17PM +0100, Marton Balint wrote: > > On Mon, 9 Nov 2015, Michael Niedermayer wrote: > > >From: Michael Niedermayer > > > >Also support disabling them as they seem to cause problems to some > >Users. > > > >Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-10 Thread Michael Niedermayer
On Tue, Nov 10, 2015 at 07:37:28AM +, tim nicholson wrote: > On 09/11/15 17:56, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Also support disabling them as they seem to cause problems to some > > Users. > > > > [..] > > -for (i = 0; i <

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-09 Thread Marton Balint
On Mon, 9 Nov 2015, Michael Niedermayer wrote: From: Michael Niedermayer Also support disabling them as they seem to cause problems to some Users. Signed-off-by: Michael Niedermayer --- doc/muxers.texi | 13

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Only store user comment related tags when needed

2015-11-09 Thread tim nicholson
On 09/11/15 17:56, Michael Niedermayer wrote: > From: Michael Niedermayer > > Also support disabling them as they seem to cause problems to some > Users. > > [..] > -for (i = 0; i < local_tag_number; i++) { > +for (i = 0; i < FF_ARRAY_ELEMS(mxf_local_tag_batch);