Re: [FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-18 Thread Michael Niedermayer 
On Tue, Oct 18, 2016 at 01:53:58PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded:
> > This code is not correct for git master
> > 
> > Signed-off-by: Michael Niedermayer 
> > ---
> >  doc/examples/demuxing_decoding.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/doc/examples/demuxing_decoding.c 
> > b/doc/examples/demuxing_decoding.c
> > index 49fb6af..b1a216a 100644
> > --- a/doc/examples/demuxing_decoding.c
> > +++ b/doc/examples/demuxing_decoding.c
> > @@ -93,10 +93,9 @@ static int decode_packet(int *got_frame, int cached)
> >  return -1;
> >  }
> >  
> > -printf("video_frame%s n:%d coded_n:%d pts:%s\n",
> > +printf("video_frame%s n:%d coded_n:%d\n",
> > cached ? "(cached)" : "",
> > -   video_frame_count++, frame->coded_picture_number,
> > -   av_ts2timestr(frame->pts, _dec_ctx->time_base));
> > +   video_frame_count++, frame->coded_picture_number);
> >  
> >  /* copy decoded frame to destination buffer:
> >   * this is required since rawvideo expects non aligned data */
> 
> Considering it was never so useful (it was mostly set to NOPTS), LGTM.

applied

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-18 Thread Stefano Sabatini 
On date Tuesday 2016-10-18 04:58:52 +0200, Michael Niedermayer encoded:
> This code is not correct for git master
> 
> Signed-off-by: Michael Niedermayer 
> ---
>  doc/examples/demuxing_decoding.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/examples/demuxing_decoding.c 
> b/doc/examples/demuxing_decoding.c
> index 49fb6af..b1a216a 100644
> --- a/doc/examples/demuxing_decoding.c
> +++ b/doc/examples/demuxing_decoding.c
> @@ -93,10 +93,9 @@ static int decode_packet(int *got_frame, int cached)
>  return -1;
>  }
>  
> -printf("video_frame%s n:%d coded_n:%d pts:%s\n",
> +printf("video_frame%s n:%d coded_n:%d\n",
> cached ? "(cached)" : "",
> -   video_frame_count++, frame->coded_picture_number,
> -   av_ts2timestr(frame->pts, _dec_ctx->time_base));
> +   video_frame_count++, frame->coded_picture_number);
>  
>  /* copy decoded frame to destination buffer:
>   * this is required since rawvideo expects non aligned data */

Considering it was never so useful (it was mostly set to NOPTS), LGTM.
-- 
FFmpeg = Free and Frightening Magical Prodigious Exxagerate Guide
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-17 Thread Michael Niedermayer 
This code is not correct for git master

Signed-off-by: Michael Niedermayer 
---
 doc/examples/demuxing_decoding.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c
index 49fb6af..b1a216a 100644
--- a/doc/examples/demuxing_decoding.c
+++ b/doc/examples/demuxing_decoding.c
@@ -93,10 +93,9 @@ static int decode_packet(int *got_frame, int cached)
 return -1;
 }
 
-printf("video_frame%s n:%d coded_n:%d pts:%s\n",
+printf("video_frame%s n:%d coded_n:%d\n",
cached ? "(cached)" : "",
-   video_frame_count++, frame->coded_picture_number,
-   av_ts2timestr(frame->pts, _dec_ctx->time_base));
+   video_frame_count++, frame->coded_picture_number);
 
 /* copy decoded frame to destination buffer:
  * this is required since rawvideo expects non aligned data */
-- 
2.10.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel