Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
I have trouble with mailman email system . My company email client can reply email . but looks mailman can not read out text content . and it will add a warning picture automatically . And third part email client such as outlook , though it works with text content without warning pitcture. but It can not reply to specific mail loop .. I'm trying make all works . But if you can give some suggestion for mailman client . it's much better ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
Hello Mr. Moritz I update docs . and here is the latest patch . Ps: when I test doc file , muxers.texi It show some warning by root@saber:/ffmpeg# makeinfo --html --no-split -o muext.html doc/muxers.texi doc/muxers.texi:1948: @ref reference to nonexistent node `concat' doc/muxers.texi:2357: @ref reference to nonexistent node `Format stream specifiers look the doc have some issue before add my patch, please info related guys update it . B.R Huang Siyuan 0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
Hello Mr. Moritz I update docs . and here is the latest patch . Ps: when I test doc file , muxers.texi It show some warning by root@saber:/ffmpeg# makeinfo --html --no-split -o muext.html doc/muxers.texi doc/muxers.texi:1948: @ref reference to nonexistent node `concat' doc/muxers.texi:2357: @ref reference to nonexistent node `Format stream specifiers look the doc have some issue before add my patch, please info related guys update it . B.R Huang Siyuan 0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
On Thu, Jun 04, 2020 at 10:35:32 +0800, Siyuan Huang wrote: > Hello Mr. Moritz Please use your mailer's reply function to reply to e-mail messages to the list, so that the email threading in maintained. > I have try finding recently doc update for dashenc.c , but I found no > related commit . > > For example in f63407a9863a0168cddfafebb6b8a4ba85716bbe commit , it add some > options , but no doc update in that commit . Yes, documentation was missed in that commit, but added later, in e7c04eaf50b4b50f2528ab2c69b76777a1862535. > Can you show which document should I update ? doc/muxers.texi: https://github.com/FFmpeg/FFmpeg/blob/master/doc/muxers.texi#L202 > I Only find following doc webpage , but there is nothing about options, just > for function , enum etc. > > http://ffmpeg.org/doxygen/trunk/dashenc_8c.html No, I meant user documentation, not doxygen (which documents source and API). Regards, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
Hello Mr. Moritz I have try finding recently doc update for dashenc.c , but I found no related commit . For example in f63407a9863a0168cddfafebb6b8a4ba85716bbe commit , it add some options , but no doc update in that commit . Can you show which document should I update ? I Only find following doc webpage , but there is nothing about options, just for function , enum etc. http://ffmpeg.org/doxygen/trunk/dashenc_8c.html Huang Siyuan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
Hello Mr. Michael Update by your opinions 0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
On Mon, Jun 01, 2020 at 18:21:40 +0800, Siyuan Huang wrote:
> { "max_playback_rate", "Set desired maximum playback rate",
> OFFSET(max_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
> },
> +{"update_period", "Set the mpd update interval", OFFSET(update_period),
> AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, E},
> { NULL },
Documentation also needs to be updated when adding or changing options.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
On Mon, Jun 01, 2020 at 06:21:40PM +0800, Siyuan Huang wrote:
> Hello Mr.James
>
>
>
> For this , in dash if . there are tcs whose segment type is SegmentTemplate
> ,and minimumUpdatePeriod is not 50 .
>
> (eg: https://livesim.dashif.org/livesim/mup_30/testpic_2s/Manifest.mpd)
>
> Cause there is no rules in dash spec says , in template cases , the live
> miniupdateperiod should be 500s,
>
> So I modify my patch that , keep the 500 as the default minimumUpdatePeriod
> value , but add option to set this value for template cases
>
>
>
> B.R
>
> Huang Siyuan
>
> dashenc.c |4
> 1 file changed, 4 insertions(+)
> dd5fe480cc5f00a97ae191281638dc5c5643d1b9
> 0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch
> From fe662fef246c465f72b4e82c44cbe6fd62e73a4e Mon Sep 17 00:00:00 2001
> From: SiyuanHuang
> Date: Mon, 1 Jun 2020 18:19:07 +0800
> Subject: [PATCH] libavformat/dashenc.c:add support to change mpd update
> interval
>
> according iso 23009-1 , in live cases , mpd refresh period should be
> changeable
>
> Signed-off-by: SiyuanHuang
> ---
> libavformat/dashenc.c | 4
> 1 file changed, 4 insertions(+)
> mode change 100644 => 100755 libavformat/dashenc.c
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
> old mode 100644
> new mode 100755
this looks unintended
> index 3f6c39f003..4143b94883
> --- a/libavformat/dashenc.c
> +++ b/libavformat/dashenc.c
> @@ -196,6 +196,7 @@ typedef struct DASHContext {
> int target_latency_refid;
> AVRational min_playback_rate;
> AVRational max_playback_rate;
> +int64_t update_period;
> } DASHContext;
>
> static struct codec_string {
> @@ -1178,6 +1179,8 @@ static int write_manifest(AVFormatContext *s, int final)
> char now_str[100];
> if (c->use_template && !c->use_timeline)
> update_period = 500;
> +if (c->update_period)
> +update_period = c->update_period;
> avio_printf(out, "\tminimumUpdatePeriod=\"PT%"PRId64"S\"\n",
> update_period);
> if (!c->ldash)
> avio_printf(out,
> "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration /
> AV_TIME_BASE);
> @@ -2372,6 +2375,7 @@ static const AVOption options[] = {
> { "target_latency", "Set desired target latency for Low-latency dash",
> OFFSET(target_latency), AV_OPT_TYPE_DURATION, { .i64 = 0 }, 0, INT_MAX, E },
> { "min_playback_rate", "Set desired minimum playback rate",
> OFFSET(min_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
> },
> { "max_playback_rate", "Set desired maximum playback rate",
> OFFSET(max_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
> },
> +{"update_period", "Set the mpd update interval", OFFSET(update_period),
> AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, E},
shouldnt this be AV_OPT_TYPE_INT64 ?
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Nations do behave wisely once they have exhausted all other alternatives.
-- Abba Eban
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
Hello Mr.James For this , in dash if . there are tcs whose segment type is SegmentTemplate ,and minimumUpdatePeriod is not 50 . (eg: https://livesim.dashif.org/livesim/mup_30/testpic_2s/Manifest.mpd) Cause there is no rules in dash spec says , in template cases , the live miniupdateperiod should be 500s, So I modify my patch that , keep the 500 as the default minimumUpdatePeriod value , but add option to set this value for template cases B.R Huang Siyuan 0001-libavformat-dashenc.c-add-support-to-change-mpd-upda.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
On 5/29/2020 4:18 AM, Siyuan Huang wrote:
> according iso 23009-1 , in live cases , mpd refresh period should be
> changeable
>
> and default 500 seconds is too long , in normal live cases , it should be
> 2~5 seconds
It's set to 500 when timeline isn't used (for example, template only),
in which case there's no need to get a new mpd so often as it rarely, if
at all, ever changes.
When timeline is enabled, it's already set to update much more often.
Also, your email client mangled this patch and can't be applied.
>
>
>
> Signed-off-by: SiyuanHuang
>
> ---
>
> libavformat/dashenc.c | 6 +-
>
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> mode change 100644 => 100755 libavformat/dashenc.c
>
>
>
> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>
> old mode 100644
>
> new mode 100755
>
> index 0cf0df50ef..6f8de5762b
>
> --- a/libavformat/dashenc.c
>
> +++ b/libavformat/dashenc.c
>
> @@ -196,6 +196,7 @@ typedef struct DASHContext {
>
> int target_latency_refid;
>
> AVRational min_playback_rate;
>
> AVRational max_playback_rate;
>
> +int64_t update_period;
>
> } DASHContext;
>
> static struct codec_string {
>
> @@ -1177,7 +1178,9 @@ static int write_manifest(AVFormatContext *s, int
> final)
>
> int64_t update_period = c->last_duration / AV_TIME_BASE;
>
> char now_str[100];
>
> if (c->use_template && !c->use_timeline)
>
> -update_period = 500;
>
> +update_period = 5;
>
> +if (c->update_period)
>
> +update_period = c->update_period;
>
> avio_printf(out, "\tminimumUpdatePeriod=\"PT%"PRId64"S\"\n",
> update_period);
>
> if (!c->ldash)
>
> avio_printf(out,
> "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration /
> AV_TIME_BASE);
>
> @@ -2368,6 +2371,7 @@ static const AVOption options[] = {
>
> { "dvb_dash", "DVB-DASH profile", 0, AV_OPT_TYPE_CONST, {.i64 =
> MPD_PROFILE_DVB }, 0, UINT_MAX, E, "mpd_profile"},
>
> { "http_opts", "HTTP protocol options", OFFSET(http_opts),
> AV_OPT_TYPE_DICT, { .str = NULL }, 0, 0, E },
>
> { "target_latency", "Set desired target latency for Low-latency dash",
> OFFSET(target_latency), AV_OPT_TYPE_DURATION, { .i64 = 0 }, 0, INT_MAX, E },
>
> +{ "update_period", "Set the mpd update interval",
> OFFSET(update_period),AV_OPT_TYPE_INT,{ .i64 = 0},0 ,INT_MAX,E},
>
> { "min_playback_rate", "Set desired minimum playback rate",
> OFFSET(min_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
> },
>
> { "max_playback_rate", "Set desired maximum playback rate",
> OFFSET(max_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
> },
>
> { NULL },
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change mpd update interval
according iso 23009-1 , in live cases , mpd refresh period should be
changeable
and default 500 seconds is too long , in normal live cases , it should be
2~5 seconds
Signed-off-by: SiyuanHuang
---
libavformat/dashenc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
mode change 100644 => 100755 libavformat/dashenc.c
diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
old mode 100644
new mode 100755
index 0cf0df50ef..6f8de5762b
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -196,6 +196,7 @@ typedef struct DASHContext {
int target_latency_refid;
AVRational min_playback_rate;
AVRational max_playback_rate;
+int64_t update_period;
} DASHContext;
static struct codec_string {
@@ -1177,7 +1178,9 @@ static int write_manifest(AVFormatContext *s, int
final)
int64_t update_period = c->last_duration / AV_TIME_BASE;
char now_str[100];
if (c->use_template && !c->use_timeline)
-update_period = 500;
+update_period = 5;
+if (c->update_period)
+update_period = c->update_period;
avio_printf(out, "\tminimumUpdatePeriod=\"PT%"PRId64"S\"\n",
update_period);
if (!c->ldash)
avio_printf(out,
"\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration /
AV_TIME_BASE);
@@ -2368,6 +2371,7 @@ static const AVOption options[] = {
{ "dvb_dash", "DVB-DASH profile", 0, AV_OPT_TYPE_CONST, {.i64 =
MPD_PROFILE_DVB }, 0, UINT_MAX, E, "mpd_profile"},
{ "http_opts", "HTTP protocol options", OFFSET(http_opts),
AV_OPT_TYPE_DICT, { .str = NULL }, 0, 0, E },
{ "target_latency", "Set desired target latency for Low-latency dash",
OFFSET(target_latency), AV_OPT_TYPE_DURATION, { .i64 = 0 }, 0, INT_MAX, E },
+{ "update_period", "Set the mpd update interval",
OFFSET(update_period),AV_OPT_TYPE_INT,{ .i64 = 0},0 ,INT_MAX,E},
{ "min_playback_rate", "Set desired minimum playback rate",
OFFSET(min_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
},
{ "max_playback_rate", "Set desired maximum playback rate",
OFFSET(max_playback_rate), AV_OPT_TYPE_RATIONAL, { .dbl = 1.0 }, 0.5, 1.5, E
},
{ NULL },
--
2.17.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
