Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

2017-11-26 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 08:19:45PM +, Derek Buitenhuis wrote: > On 11/22/2017 8:09 PM, Michael Niedermayer wrote: > > not much, no > > its a non static function tough > > i can remove the check completely if thats preferred ? > > I guess leave it since it's non-static. > > LGTM. ok, will

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

2017-11-22 Thread Derek Buitenhuis
On 11/22/2017 8:09 PM, Michael Niedermayer wrote: > not much, no > its a non static function tough > i can remove the check completely if thats preferred ? I guess leave it since it's non-static. LGTM. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

2017-11-22 Thread Michael Niedermayer
On Wed, Nov 22, 2017 at 02:09:46PM +, Derek Buitenhuis wrote: > On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > If it's a duplicate

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

2017-11-22 Thread Derek Buitenhuis
On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If it's a duplicate check, is there even a gain from using an assert? - Derek

[FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

2017-11-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9e876efc8c..6940dfc7d5 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2437,8 +2437,7 @@