Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-16 Thread James Almer
On 10/16/2016 2:01 PM, Nicolas George wrote: > Le quintidi 25 vendémiaire, an CCXXV, James Almer a écrit : >>> Nothing probably, just me not giving it much thought after i couldn't find >>> any sample using cm, in or dar instead of pixels, and assuming the >>> calculations were tailored

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-16 Thread Nicolas George
Le quintidi 25 vendémiaire, an CCXXV, James Almer a écrit : > > Nothing probably, just me not giving it much thought after i couldn't find > > any sample using cm, in or dar instead of pixels, and assuming the > > calculations were tailored specifically for sizes in pixels. > > I manually created

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-16 Thread James Almer
On 10/16/2016 10:28 AM, James Almer wrote: > On 10/16/2016 5:58 AM, Nicolas George wrote: >> > Le quartidi 24 vendémiaire, an CCXXV, James Almer a écrit : >>> >> A missing DisplayUnit element or one with the default value of 0 means >>> >> DisplayWidth and DisplayHeight should be interpreted as

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-16 Thread James Almer
On 10/16/2016 5:58 AM, Nicolas George wrote: > Le quartidi 24 vendémiaire, an CCXXV, James Almer a écrit : >> A missing DisplayUnit element or one with the default value of 0 means >> DisplayWidth and DisplayHeight should be interpreted as pixels. >> >> The current code setting

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-16 Thread Nicolas George
Le quartidi 24 vendémiaire, an CCXXV, James Almer a écrit : > A missing DisplayUnit element or one with the default value of 0 means > DisplayWidth and DisplayHeight should be interpreted as pixels. > > The current code setting st->sample_aspect_ratio is wrong when DisplayUnit > is anything else.

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-15 Thread James Almer
On 10/15/2016 8:07 PM, Carl Eugen Hoyos wrote: > 2016-10-16 0:09 GMT+02:00 James Almer : > >> +if (track->video.display_unit == >> MATROSKA_VIDEO_DISPLAYUNIT_PIXELS) > > If you don't mind please add braces here. Added brackets, which i assume is what you meant.

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-15 Thread Carl Eugen Hoyos
2016-10-16 0:09 GMT+02:00 James Almer : > +if (track->video.display_unit == > MATROSKA_VIDEO_DISPLAYUNIT_PIXELS) If you don't mind please add braces here. Both patches make sense afaict. Thank you, Carl Eugen ___

[FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: set aspect ratio only when DisplayWidth and DisplayHeight are in pixels

2016-10-15 Thread James Almer
A missing DisplayUnit element or one with the default value of 0 means DisplayWidth and DisplayHeight should be interpreted as pixels. The current code setting st->sample_aspect_ratio is wrong when DisplayUnit is anything else. Signed-off-by: James Almer ---