Re: [FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static and rename it
On Fri, Jan 6, 2017 at 11:11 AM, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 09:52:48AM +1100, Hendrik Leppkes wrote: >> On Fri, Jan 6, 2017 at 9:15 AM, Michael Niedermayer >> wrote: >> > On Wed, Jan 04, 2017 at 02:36:41PM +0100, Steve Lhomme wrote: >> >> --- >> >> libavcodec/dxva2.c | 8 >> >> libavcodec/dxva2_internal.h | 2 -- >> >> 2 files changed, 4 insertions(+), 6 deletions(-) >> > >> > applied >> > >> > PS: it seems this was posted over a month ago with no reviewes or >> > comments, is some co-maintainer needed for this ? >> > >> > thx >> > >> >> This set was being reviewed on the libav mailing list, it makes no >> sense to review it twice. > > It makes sense to approve or reject patches. Otherwise noone knows > and also patchwork has the status wrong then. > > Furthermore without approval, patches wont neccessarily get applied > and without rejection patches may get applied that someone would have > arguments against. > > So i think the maintainer should reply to patches here with either > a review, an approval or a rejection or something along these lines. > And in that light, was my question about a co-maintainer ... While review is still on-going, there is no such status to apply. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static and rename it
On Fri, Jan 06, 2017 at 09:52:48AM +1100, Hendrik Leppkes wrote: > On Fri, Jan 6, 2017 at 9:15 AM, Michael Niedermayer > wrote: > > On Wed, Jan 04, 2017 at 02:36:41PM +0100, Steve Lhomme wrote: > >> --- > >> libavcodec/dxva2.c | 8 > >> libavcodec/dxva2_internal.h | 2 -- > >> 2 files changed, 4 insertions(+), 6 deletions(-) > > > > applied > > > > PS: it seems this was posted over a month ago with no reviewes or > > comments, is some co-maintainer needed for this ? > > > > thx > > > > This set was being reviewed on the libav mailing list, it makes no > sense to review it twice. It makes sense to approve or reject patches. Otherwise noone knows and also patchwork has the status wrong then. Furthermore without approval, patches wont neccessarily get applied and without rejection patches may get applied that someone would have arguments against. So i think the maintainer should reply to patches here with either a review, an approval or a rejection or something along these lines. And in that light, was my question about a co-maintainer ... [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static and rename it
On Fri, Jan 6, 2017 at 9:15 AM, Michael Niedermayer wrote: > On Wed, Jan 04, 2017 at 02:36:41PM +0100, Steve Lhomme wrote: >> --- >> libavcodec/dxva2.c | 8 >> libavcodec/dxva2_internal.h | 2 -- >> 2 files changed, 4 insertions(+), 6 deletions(-) > > applied > > PS: it seems this was posted over a month ago with no reviewes or > comments, is some co-maintainer needed for this ? > > thx > This set was being reviewed on the libav mailing list, it makes no sense to review it twice. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static and rename it
On Wed, Jan 04, 2017 at 02:36:41PM +0100, Steve Lhomme wrote: > --- > libavcodec/dxva2.c | 8 > libavcodec/dxva2_internal.h | 2 -- > 2 files changed, 4 insertions(+), 6 deletions(-) applied PS: it seems this was posted over a month ago with no reviewes or comments, is some co-maintainer needed for this ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control. Democracy: All politicians are under surveillance, all their steps and actions recorded, for the citizens to enforce control. signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static and rename it
---
libavcodec/dxva2.c | 8
libavcodec/dxva2_internal.h | 2 --
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c
index 04a9c11..2ac3f3e 100644
--- a/libavcodec/dxva2.c
+++ b/libavcodec/dxva2.c
@@ -29,7 +29,7 @@
#include "avcodec.h"
#include "dxva2_internal.h"
-void *ff_dxva2_get_surface(const AVFrame *frame)
+static void *get_surface(const AVFrame *frame)
{
return frame->data[3];
}
@@ -38,7 +38,7 @@ unsigned ff_dxva2_get_surface_index(const AVCodecContext
*avctx,
const AVDXVAContext *ctx,
const AVFrame *frame)
{
-void *surface = ff_dxva2_get_surface(frame);
+void *surface = get_surface(frame);
unsigned i;
for (i = 0; i < DXVA_CONTEXT_COUNT(avctx, ctx); i++) {
@@ -159,14 +159,14 @@ int ff_dxva2_common_end_frame(AVCodecContext *avctx,
AVFrame *frame,
if (D3D11VA_CONTEXT(ctx)->context_mutex != INVALID_HANDLE_VALUE)
WaitForSingleObjectEx(D3D11VA_CONTEXT(ctx)->context_mutex,
INFINITE, FALSE);
hr =
ID3D11VideoContext_DecoderBeginFrame(D3D11VA_CONTEXT(ctx)->video_context,
D3D11VA_CONTEXT(ctx)->decoder,
-
ff_dxva2_get_surface(frame),
+ get_surface(frame),
0, NULL);
}
#endif
#if CONFIG_DXVA2
if (avctx->pix_fmt == AV_PIX_FMT_DXVA2_VLD)
hr = IDirectXVideoDecoder_BeginFrame(DXVA2_CONTEXT(ctx)->decoder,
- ff_dxva2_get_surface(frame),
+ get_surface(frame),
NULL);
#endif
if (hr != E_PENDING || ++runs > 50)
diff --git a/libavcodec/dxva2_internal.h b/libavcodec/dxva2_internal.h
index 24adb99..c962810 100644
--- a/libavcodec/dxva2_internal.h
+++ b/libavcodec/dxva2_internal.h
@@ -96,8 +96,6 @@ typedef union {
#define DXVA_CONTEXT_CFG_RESIDACCEL(avctx, ctx)
(ctx->d3d11va.cfg->ConfigResidDiffAccelerator)
#endif
-void *ff_dxva2_get_surface(const AVFrame *frame);
-
unsigned ff_dxva2_get_surface_index(const AVCodecContext *avctx,
const AVDXVAContext *,
const AVFrame *frame);
--
2.10.2
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH 1/4] dxva2: make ff_dxva2_get_surface() static
From: Steve Lhomme
---
libavcodec/dxva2.c | 2 +-
libavcodec/dxva2_internal.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c
index 04a9c11..a64b1b5 100644
--- a/libavcodec/dxva2.c
+++ b/libavcodec/dxva2.c
@@ -29,7 +29,7 @@
#include "avcodec.h"
#include "dxva2_internal.h"
-void *ff_dxva2_get_surface(const AVFrame *frame)
+static void *ff_dxva2_get_surface(const AVFrame *frame)
{
return frame->data[3];
}
diff --git a/libavcodec/dxva2_internal.h b/libavcodec/dxva2_internal.h
index 24adb99..c962810 100644
--- a/libavcodec/dxva2_internal.h
+++ b/libavcodec/dxva2_internal.h
@@ -96,8 +96,6 @@ typedef union {
#define DXVA_CONTEXT_CFG_RESIDACCEL(avctx, ctx)
(ctx->d3d11va.cfg->ConfigResidDiffAccelerator)
#endif
-void *ff_dxva2_get_surface(const AVFrame *frame);
-
unsigned ff_dxva2_get_surface_index(const AVCodecContext *avctx,
const AVDXVAContext *,
const AVFrame *frame);
--
2.10.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
