Re: [FFmpeg-devel] [PATCH 2/3] lavfi: Move new field to the end of AVFilterLink

[Michael Niedermayer]

On Wed, Jun 29, 2016 at 11:58:02AM +0200, Timo Rothenpieler wrote:
> Even though this is not part of the public API, some external
> applications access fields after it, thus breaking after updating from
> ffmpeg 3.0 or earlier.
> Since it is not public, it can be freely moved to the end to avoid
> that problem in the future.
> ---
>  libavfilter/avfilter.h | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)

LGTM

please also backport to release/3.1

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/3] lavfi: Move new field to the end of AVFilterLink

[Timo Rothenpieler]

Even though this is not part of the public API, some external
applications access fields after it, thus breaking after updating from
ffmpeg 3.0 or earlier.
Since it is not public, it can be freely moved to the end to avoid
that problem in the future.
---
 libavfilter/avfilter.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
index 79227a7..8a7f791 100644
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
@@ -474,12 +474,6 @@ struct AVFilterLink {
 AVRational frame_rate;
 
 /**
- * For hwaccel pixel formats, this should be a reference to the
- * AVHWFramesContext describing the frames.
- */
-AVBufferRef *hw_frames_ctx;
-
-/**
  * Buffer partially filled with samples to achieve a fixed/minimum size.
  */
 AVFrame *partial_buf;
@@ -550,6 +544,12 @@ struct AVFilterLink {
  * cleared when a frame is filtered.
  */
 int frame_wanted_out;
+
+/**
+ * For hwaccel pixel formats, this should be a reference to the
+ * AVHWFramesContext describing the frames.
+ */
+AVBufferRef *hw_frames_ctx;
 };
 
 /**
-- 
2.9.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel