Re: [FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

2019-05-12 Thread Philip Langdale
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Sun, 12 May 2019 12:54:24 +0200 Michael Niedermayer wrote: > > all these + 1 in the code above look a bit suspect. Can you explain > what they do assuming they are intended Good catch. I should have removed them when I removed the divide by

Re: [FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

2019-05-12 Thread Michael Niedermayer
On Sat, May 11, 2019 at 11:31:56AM -0700, Philip Langdale wrote: > For the sake of completeness, I'm added NV24/NV42 support to swscale, > but the specific use-case I noted when adding the pixel formats > doesn't require swscale support (because it's OpenGL interop). not sure this adds value to

[FFmpeg-devel] [PATCH 2/3] swscale: Add support for NV24 and NV42

2019-05-11 Thread Philip Langdale
For the sake of completeness, I'm added NV24/NV42 support to swscale, but the specific use-case I noted when adding the pixel formats doesn't require swscale support (because it's OpenGL interop). The implementation is pretty straight-forward. Most of the existing NV12 codepaths work regardless