Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1_block: Fix invalid left shift in vc1_decode_p_mb()

2019-10-03 Thread Michael Niedermayer 
On Thu, Oct 03, 2019 at 08:56:54AM +0200, Paul B Mahol wrote:
> lgtm

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1_block: Fix invalid left shift in vc1_decode_p_mb()

2019-10-03 Thread Paul B Mahol 
lgtm

On 10/2/19, Michael Niedermayer  wrote:
> Fixes: left shift of negative value -6
> Fixes:
> 17810/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5638541240958976
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/vc1_block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c
> index fe7dbf8b1d..f1c9f41f30 100644
> --- a/libavcodec/vc1_block.c
> +++ b/libavcodec/vc1_block.c
> @@ -1481,7 +1481,7 @@ static int vc1_decode_p_mb(VC1Context *v)
>
> v->vc1dsp.vc1_inv_trans_8x8(v->block[v->cur_blk_idx][block_map[i]]);
>  if (v->rangeredfrm)
>  for (j = 0; j < 64; j++)
> -v->block[v->cur_blk_idx][block_map[i]][j] <<=
> 1;
> +v->block[v->cur_blk_idx][block_map[i]][j] *= 2;
>  block_cbp   |= 0xF << (i << 2);
>  block_intra |= 1 << i;
>  } else if (is_coded[i]) {
> --
> 2.23.0
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/5] avcodec/vc1_block: Fix invalid left shift in vc1_decode_p_mb()

2019-10-02 Thread Michael Niedermayer 
Fixes: left shift of negative value -6
Fixes: 
17810/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5638541240958976

Found-by: continuous fuzzing process 
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer 
---
 libavcodec/vc1_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c
index fe7dbf8b1d..f1c9f41f30 100644
--- a/libavcodec/vc1_block.c
+++ b/libavcodec/vc1_block.c
@@ -1481,7 +1481,7 @@ static int vc1_decode_p_mb(VC1Context *v)
 
v->vc1dsp.vc1_inv_trans_8x8(v->block[v->cur_blk_idx][block_map[i]]);
 if (v->rangeredfrm)
 for (j = 0; j < 64; j++)
-v->block[v->cur_blk_idx][block_map[i]][j] <<= 1;
+v->block[v->cur_blk_idx][block_map[i]][j] *= 2;
 block_cbp   |= 0xF << (i << 2);
 block_intra |= 1 << i;
 } else if (is_coded[i]) {
-- 
2.23.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".