Re: [FFmpeg-devel] [PATCH 4/4] lavf/movdec: request probing for an ambiguous codec tag

[Jan Ekstrom]

On Thu, Oct 19, 2017 at 10:39 AM, Rodger Combs  wrote:
> ---
>  libavformat/isom.c | 2 ++
>  1 file changed, 2 insertions(+)

This change makes sense due to the ambiguousness of the container mapping. LGTM.

Jan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 4/4] lavf/movdec: request probing for an ambiguous codec tag

[Rodger Combs]

---
 libavformat/isom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/isom.c b/libavformat/isom.c
index 77983c5eaa..8b3f88ce74 100644
--- a/libavformat/isom.c
+++ b/libavformat/isom.c
@@ -519,6 +519,8 @@ FF_ENABLE_DEPRECATION_WARNINGS
 codec_id= ff_codec_get_id(ff_mp4_obj_type, object_type_id);
 if (codec_id)
 st->codecpar->codec_id = codec_id;
+if (object_type_id == 0x6B) // This can be either MP3 or MP2; let 
probe_codec decide
+st->request_probe = 5;
 av_log(fc, AV_LOG_TRACE, "esds object type id 0x%02x\n", object_type_id);
 len = ff_mp4_read_descr(fc, pb, );
 if (tag == MP4DecSpecificDescrTag) {
-- 
2.14.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel