Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-12-14 Thread Dixit, Vishwanath
>On 11/24/17, 9:06 PM, "Jeyapal, Karthick" wrote: > >Thanks for your comments. I have uploaded new patchset v4 with suggested >corrections. >Please ignore patchset v3. > >On 11/24/17, 4:26 PM, "Mark Thompson" wrote: >[…] >>> +s = x264_encoder_headers(x4->enc, &nal, &nnal); >>> +avctx->

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Jeyapal, Karthick
Thanks for your comments. I have uploaded new patchset v4 with suggested corrections. Please ignore patchset v3. On 11/24/17, 4:26 PM, "Mark Thompson" wrote: […] >> +s = x264_encoder_headers(x4->enc, &nal, &nnal); >> +avctx->profile = nal->p_payload[5]; > >AVCodecContext.profile should i

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Carl Eugen Hoyos
2017-11-24 11:55 GMT+01:00 Mark Thompson : > On 24/11/17 09:37, Karthick J wrote: >> -s = x264_encoder_headers(x4->enc, &nal, &nnal); >> +if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) { >> avctx->extradata = p = av_mallocz(s + AV_INPUT_BUFFER_PADDING_SIZE); >> if (!

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Mark Thompson
On 24/11/17 09:37, Karthick J wrote: > From: Vishwanath Dixit > > --- > libavcodec/libx264.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 9c67c91..6b93aa8 100644 > --- a/libavcodec/libx264.c > +++ b/lib

[FFmpeg-devel] [PATCH v2 2/3] avcodec/libx264:setting profile and level in avcodec context

2017-11-24 Thread Karthick J
From: Vishwanath Dixit --- libavcodec/libx264.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91..6b93aa8 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -454,6 +454,9 @@ static av_cold int