Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-13 Thread Anton Khirnov
Quoting Marton Balint (2020-01-10 18:42:03) > > > On Fri, 10 Jan 2020, Anton Khirnov wrote: > > > Quoting Marton Balint (2019-12-30 23:23:40) > >> Also add helper functions to allocate and free such a struct, and make it > >> usable by providing a new av_eval_expr2 function for which you can

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-11 Thread Marton Balint
On Sat, 11 Jan 2020, Michael Niedermayer wrote: On Fri, Jan 10, 2020 at 12:49:08AM +0100, Marton Balint wrote: On Thu, 9 Jan 2020, Michael Niedermayer wrote: On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: On Wed, 1 Jan 2020, Michael Niedermayer wrote: On Mon, Dec 30,

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-11 Thread Michael Niedermayer
On Fri, Jan 10, 2020 at 12:49:08AM +0100, Marton Balint wrote: > > > On Thu, 9 Jan 2020, Michael Niedermayer wrote: > > >On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: > >> > >> > >>On Wed, 1 Jan 2020, Michael Niedermayer wrote: > >> > >>>On Mon, Dec 30, 2019 at 11:23:40PM

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-10 Thread Marton Balint
On Fri, 10 Jan 2020, Anton Khirnov wrote: Quoting Marton Balint (2019-12-30 23:23:40) Also add helper functions to allocate and free such a struct, and make it usable by providing a new av_eval_expr2 function for which you can specify a custom AVExprState. Why not just parse the expression

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-10 Thread Anton Khirnov
Quoting Marton Balint (2019-12-30 23:23:40) > Also add helper functions to allocate and free such a struct, and make it > usable by providing a new av_eval_expr2 function for which you can specify a > custom AVExprState. Why not just parse the expression multiple times? Performance? Beyond that,

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-09 Thread Marton Balint
On Thu, 9 Jan 2020, Michael Niedermayer wrote: On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: On Wed, 1 Jan 2020, Michael Niedermayer wrote: On Mon, Dec 30, 2019 at 11:23:40PM +0100, Marton Balint wrote: Also add helper functions to allocate and free such a struct, and

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-09 Thread Michael Niedermayer
On Wed, Jan 01, 2020 at 05:40:33PM +0100, Marton Balint wrote: > > > On Wed, 1 Jan 2020, Michael Niedermayer wrote: > > >On Mon, Dec 30, 2019 at 11:23:40PM +0100, Marton Balint wrote: > >>Also add helper functions to allocate and free such a struct, and make it > >>usable by providing a new

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-08 Thread Marton Balint
On Wed, 1 Jan 2020, Marton Balint wrote: On Wed, 1 Jan 2020, Michael Niedermayer wrote: On Mon, Dec 30, 2019 at 11:23:40PM +0100, Marton Balint wrote: Also add helper functions to allocate and free such a struct, and make it usable by providing a new av_eval_expr2 function for which you

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-01 Thread Marton Balint
On Wed, 1 Jan 2020, Michael Niedermayer wrote: On Mon, Dec 30, 2019 at 11:23:40PM +0100, Marton Balint wrote: Also add helper functions to allocate and free such a struct, and make it usable by providing a new av_eval_expr2 function for which you can specify a custom AVExprState.

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2020-01-01 Thread Michael Niedermayer
On Mon, Dec 30, 2019 at 11:23:40PM +0100, Marton Balint wrote: > Also add helper functions to allocate and free such a struct, and make it > usable by providing a new av_eval_expr2 function for which you can specify a > custom AVExprState. > > Signed-off-by: Marton Balint > --- > doc/APIchanges

[FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

2019-12-30 Thread Marton Balint
Also add helper functions to allocate and free such a struct, and make it usable by providing a new av_eval_expr2 function for which you can specify a custom AVExprState. Signed-off-by: Marton Balint --- doc/APIchanges | 4 libavutil/eval.c| 36