Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-12-02 Thread Michael Niedermayer
On Fri, Dec 01, 2017 at 11:16:37AM -0800, Dale Curtis wrote: > On Thu, Nov 30, 2017 at 5:49 PM, Michael Niedermayer > wrote: > > > I dont see anything really wrong with the file > > > > For kicks, I tried running it through oggz-validate, but it doesn't know > how to handle ogm. Which TIL, is di

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-12-01 Thread Dale Curtis
On Thu, Nov 30, 2017 at 5:49 PM, Michael Niedermayer wrote: > I dont see anything really wrong with the file > For kicks, I tried running it through oggz-validate, but it doesn't know how to handle ogm. Which TIL, is distinct from ogv. > > it seems what happens is that theres a data packet in

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-30 Thread Michael Niedermayer
On Thu, Nov 30, 2017 at 12:19:10PM -0800, Dale Curtis wrote: > On Wed, Nov 29, 2017 at 5:58 PM, Michael Niedermayer > wrote: > > > > > AV_EF_EXPLODE appears to be a possibility, yes > > in general demuxers should try to extract as much as possible from a > > file and not give up if some broken pa

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-30 Thread Dale Curtis
On Wed, Nov 29, 2017 at 5:58 PM, Michael Niedermayer wrote: > > AV_EF_EXPLODE appears to be a possibility, yes > in general demuxers should try to extract as much as possible from a > file and not give up if some broken packet is found > I don't think this is a good idea; some of these errors se

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-29 Thread Michael Niedermayer
On Wed, Nov 29, 2017 at 11:57:17AM -0800, Dale Curtis wrote: > On Tue, Nov 28, 2017 at 4:32 PM, Michael Niedermayer > wrote: > > > > > > This breaks converting of this: > > ./ffmpeg -i bgc.sub.dub.ogm -vf subtitles=bgc.sub.dub.ogm -an file.avi > > > > https://samples.ffmpeg.org/ogg/bgc.sub.dub.og

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-29 Thread Dale Curtis
On Tue, Nov 28, 2017 at 4:32 PM, Michael Niedermayer wrote: > > > This breaks converting of this: > ./ffmpeg -i bgc.sub.dub.ogm -vf subtitles=bgc.sub.dub.ogm -an file.avi > > https://samples.ffmpeg.org/ogg/bgc.sub.dub.ogm > > That's due to the vorbis parser returning AVERROR_INVALIDDATA here, wit

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Michael Niedermayer
On Tue, Nov 28, 2017 at 02:17:21PM -0800, Dale Curtis wrote: > Fixes bad parens in the above patch. > > - dale > > On Tue, Nov 28, 2017 at 2:03 PM, Dale Curtis > wrote: > > > Actually packet() was broken too, updated the patch to fix this case too. > > > > - dale > > > > On Tue, Nov 28, 2017 at

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Fixes bad parens in the above patch. - dale On Tue, Nov 28, 2017 at 2:03 PM, Dale Curtis wrote: > Actually packet() was broken too, updated the patch to fix this case too. > > - dale > > On Tue, Nov 28, 2017 at 1:41 PM, Dale Curtis > wrote: > >> Fixes ticket #6804. All of the ogg header parser

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Actually packet() was broken too, updated the patch to fix this case too. - dale On Tue, Nov 28, 2017 at 1:41 PM, Dale Curtis wrote: > Fixes ticket #6804. All of the ogg header parsers may return > standard AVERROR codes; these return values should not be > treated as success. > > Signed-off-by

[FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Fixes ticket #6804. All of the ogg header parsers may return standard AVERROR codes; these return values should not be treated as success. Signed-off-by: Dale Curtis From 34d68a511a2d933b111964f84cfd2d0a289dec97 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Tue, 28 Nov 2017 13:40:20 -0800 Sub