Re: [FFmpeg-devel] avcodec/samidec: check av_strdup() return value

2017-11-27 Thread Moritz Barsnick 
On Mon, Nov 27, 2017 at 08:53:22 +0800, Pan Bian wrote:
> + if (!dupsrc)
> + return AVERROR(ENOMEM);
> +

Tabs are not allowed, please check your indentation. You can use
tools/patcheck to find these kinds of issues.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] avcodec/samidec: check av_strdup() return value

2017-11-26 Thread Pan Bian 
From: Pan Bian 

In function sami_paragraph_to_ass(), the return value of av_strdup() is
not checked. To avoid potential NULL dereference, the return value
should be checked against NULL.

Signed-off-by: Pan Bian 
---
 libavcodec/samidec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c
index 2620424..35fcc41 100644
--- a/libavcodec/samidec.c
+++ b/libavcodec/samidec.c
@@ -48,6 +48,9 @@ static int sami_paragraph_to_ass(AVCodecContext *avctx, const 
char *src)
 AVBPrint *dst_content = &sami->encoded_content;
 AVBPrint *dst_source = &sami->encoded_source;
 
+   if (!dupsrc)
+   return AVERROR(ENOMEM);
+
 av_bprint_clear(&sami->encoded_content);
 av_bprint_clear(&sami->content);
 av_bprint_clear(&sami->encoded_source);
-- 
1.9.1


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel