Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

[Clément Bœsch]

On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote:
> ffmpeg | branch: master | Ganesh Ajjanagadde  | Tue 
> Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | 
> committer: Ganesh Ajjanagadde
> 
> avcodec/dct32_template: use M_SQRT1_2 instead of actual literal
> 
> Fixed point value remains unchanged.
> 
> Signed-off-by: Ganesh Ajjanagadde 
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ccf3c694032bd84c7672979fa89f437980d717ba
> ---
> 
>  libavcodec/dct32_template.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/dct32_template.c b/libavcodec/dct32_template.c
> index fb53d53..c70396e 100644
> --- a/libavcodec/dct32_template.c
> +++ b/libavcodec/dct32_template.c
> @@ -73,7 +73,7 @@
>  #define COS3_0 FIXHR(0.54119610014619698439/2)
>  #define COS3_1 FIXHR(1.30656296487637652785/4)
>  
> -#define COS4_0 FIXHR(0.70710678118654752439/2)
> +#define COS4_0 FIXHR(M_SQRT1_2/2)

I think you meant M_SQRT1_2

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

[Clément Bœsch]

On Sun, Nov 22, 2015 at 10:38:35PM +0100, Clément Bœsch wrote:
> On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote:
> > ffmpeg | branch: master | Ganesh Ajjanagadde  | Tue 
> > Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | 
> > committer: Ganesh Ajjanagadde
> > 
> > avcodec/dct32_template: use M_SQRT1_2 instead of actual literal
> > 
> > Fixed point value remains unchanged.
> > 
> > Signed-off-by: Ganesh Ajjanagadde 
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ccf3c694032bd84c7672979fa89f437980d717ba
> > ---
> > 
> >  libavcodec/dct32_template.c |2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/dct32_template.c b/libavcodec/dct32_template.c
> > index fb53d53..c70396e 100644
> > --- a/libavcodec/dct32_template.c
> > +++ b/libavcodec/dct32_template.c
> > @@ -73,7 +73,7 @@
> >  #define COS3_0 FIXHR(0.54119610014619698439/2)
> >  #define COS3_1 FIXHR(1.30656296487637652785/4)
> >  
> > -#define COS4_0 FIXHR(0.70710678118654752439/2)
> > +#define COS4_0 FIXHR(M_SQRT1_2/2)
> 
> I think you meant M_SQRT1_2
> 

Sorry, I'm tired

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

[Ganesh Ajjanagadde]

On Sun, Nov 22, 2015 at 4:38 PM, Clément Bœsch  wrote:
> On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote:
>> ffmpeg | branch: master | Ganesh Ajjanagadde  | Tue 
>> Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] | 
>> committer: Ganesh Ajjanagadde
>>
>> avcodec/dct32_template: use M_SQRT1_2 instead of actual literal
>>
>> Fixed point value remains unchanged.
>>
>> Signed-off-by: Ganesh Ajjanagadde 
>>
>> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ccf3c694032bd84c7672979fa89f437980d717ba
>> ---
>>
>>  libavcodec/dct32_template.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/dct32_template.c b/libavcodec/dct32_template.c
>> index fb53d53..c70396e 100644
>> --- a/libavcodec/dct32_template.c
>> +++ b/libavcodec/dct32_template.c
>> @@ -73,7 +73,7 @@
>>  #define COS3_0 FIXHR(0.54119610014619698439/2)
>>  #define COS3_1 FIXHR(1.30656296487637652785/4)
>>
>> -#define COS4_0 FIXHR(0.70710678118654752439/2)
>> +#define COS4_0 FIXHR(M_SQRT1_2/2)
>
> I think you meant M_SQRT1_2

fixed typo and pushed, thanks.

>
> --
> Clément B.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dct32_template: use M_SQRT1_2 instead of actual literal

[Ganesh Ajjanagadde]

On Sun, Nov 22, 2015 at 4:39 PM, Clément Bœsch  wrote:
> On Sun, Nov 22, 2015 at 10:38:35PM +0100, Clément Bœsch wrote:
>> On Sun, Nov 22, 2015 at 10:24:49PM +0100, Ganesh Ajjanagadde wrote:
>> > ffmpeg | branch: master | Ganesh Ajjanagadde  | 
>> > Tue Nov 10 22:26:25 2015 -0500| [ccf3c694032bd84c7672979fa89f437980d717ba] 
>> > | committer: Ganesh Ajjanagadde
>> >
>> > avcodec/dct32_template: use M_SQRT1_2 instead of actual literal
>> >
>> > Fixed point value remains unchanged.
>> >
>> > Signed-off-by: Ganesh Ajjanagadde 
>> >
>> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ccf3c694032bd84c7672979fa89f437980d717ba
>> > ---
>> >
>> >  libavcodec/dct32_template.c |2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/libavcodec/dct32_template.c b/libavcodec/dct32_template.c
>> > index fb53d53..c70396e 100644
>> > --- a/libavcodec/dct32_template.c
>> > +++ b/libavcodec/dct32_template.c
>> > @@ -73,7 +73,7 @@
>> >  #define COS3_0 FIXHR(0.54119610014619698439/2)
>> >  #define COS3_1 FIXHR(1.30656296487637652785/4)
>> >
>> > -#define COS4_0 FIXHR(0.70710678118654752439/2)
>> > +#define COS4_0 FIXHR(M_SQRT1_2/2)
>>
>> I think you meant M_SQRT1_2
>>
>
> Sorry, I'm tired

too rash on my end as well, reverted. Sorry all for the confusion.

>
> --
> Clément B.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel