Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mscc: fix several bugs

2018-08-28 Thread Carl Eugen Hoyos 


> Am 28.08.2018 um 12:05 schrieb Paul B Mahol :
> 
>> On 8/28/18, Carl Eugen Hoyos  wrote:
>> 2018-08-28 12:00 GMT+02:00, Paul B Mahol :
 On 8/28/18, Carl Eugen Hoyos  wrote:
 2018-08-26 18:05 GMT+02:00, Paul B Mahol :
 
> switch (avctx->bits_per_coded_sample) {
> -case  8: avctx->pix_fmt = AV_PIX_FMT_GRAY8;  break;
> +case  8: avctx->pix_fmt = AV_PIX_FMT_PAL8;   break;
 
 Do you have a sample that looks correct with this particular change?
 Can you share it?
>>> 
>>> No, but PAL8 samples looks same as in VirtualDub2.
>> 
>> But GRAY8 looks really nice and there is no palette in extradata
>> for the two files I can test.
> 
> There is palette, as side data.

Did you look at the actual data?
It doesn’t look like a palette to me...

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mscc: fix several bugs

2018-08-28 Thread Paul B Mahol 
On 8/28/18, Carl Eugen Hoyos  wrote:
> 2018-08-28 12:00 GMT+02:00, Paul B Mahol :
>> On 8/28/18, Carl Eugen Hoyos  wrote:
>>> 2018-08-26 18:05 GMT+02:00, Paul B Mahol :
>>>
  switch (avctx->bits_per_coded_sample) {
 -case  8: avctx->pix_fmt = AV_PIX_FMT_GRAY8;  break;
 +case  8: avctx->pix_fmt = AV_PIX_FMT_PAL8;   break;
>>>
>>> Do you have a sample that looks correct with this particular change?
>>> Can you share it?
>>
>> No, but PAL8 samples looks same as in VirtualDub2.
>
> But GRAY8 looks really nice and there is no palette in extradata
> for the two files I can test.

There is palette, as side data.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mscc: fix several bugs

2018-08-28 Thread Carl Eugen Hoyos 
2018-08-28 12:00 GMT+02:00, Paul B Mahol :
> On 8/28/18, Carl Eugen Hoyos  wrote:
>> 2018-08-26 18:05 GMT+02:00, Paul B Mahol :
>>
>>>  switch (avctx->bits_per_coded_sample) {
>>> -case  8: avctx->pix_fmt = AV_PIX_FMT_GRAY8;  break;
>>> +case  8: avctx->pix_fmt = AV_PIX_FMT_PAL8;   break;
>>
>> Do you have a sample that looks correct with this particular change?
>> Can you share it?
>
> No, but PAL8 samples looks same as in VirtualDub2.

But GRAY8 looks really nice and there is no palette in extradata
for the two files I can test.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mscc: fix several bugs

2018-08-28 Thread Paul B Mahol 
On 8/28/18, Carl Eugen Hoyos  wrote:
> 2018-08-26 18:05 GMT+02:00, Paul B Mahol :
>
>>  switch (avctx->bits_per_coded_sample) {
>> -case  8: avctx->pix_fmt = AV_PIX_FMT_GRAY8;  break;
>> +case  8: avctx->pix_fmt = AV_PIX_FMT_PAL8;   break;
>
> Do you have a sample that looks correct with this particular change?
> Can you share it?

No, but PAL8 samples looks same as in VirtualDub2.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mscc: fix several bugs

2018-08-27 Thread Carl Eugen Hoyos 
2018-08-26 18:05 GMT+02:00, Paul B Mahol :

>  switch (avctx->bits_per_coded_sample) {
> -case  8: avctx->pix_fmt = AV_PIX_FMT_GRAY8;  break;
> +case  8: avctx->pix_fmt = AV_PIX_FMT_PAL8;   break;

Do you have a sample that looks correct with this particular change?
Can you share it?

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel