Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[wm4]

On Tue, 2 Jan 2018 03:55:18 +0100
Michael Niedermayer  wrote:

> On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> > ffmpeg | branch: master | wm4  | Thu Dec 21 20:23:14 
> > 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4
> > 
> > w32pthreads: always use Vista+ API, drop XP support
> > 
> > This removes the XP compatibility code, and switches entirely to SWR
> > locks, which are available starting at Windows Vista.
> > 
> > This removes CRITICAL_SECTION use, which allows us to add
> > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> > 
> > Windows XP is hereby not a supported build target anymore. It was
> > decided in a project vote that this is OK.
> >   
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> > >   
> > ---
> > 
> >  Changelog  |   2 +
> >  compat/w32pthreads.h   | 266 
> > ++---
> >  configure  |  13 ++-
> >  libavcodec/pthread_frame.c |   4 -
> >  libavcodec/pthread_slice.c |   4 -
> >  libavfilter/pthread.c  |   4 -
> >  libavutil/slicethread.c|   4 -
> >  7 files changed, 19 insertions(+), 278 deletions(-)  
> 
> This breaks mingw32 / wine support on ubuntu 14.04
> the code simply crashes at runtime
> 
> [...]

wine usually doesn't implement the full win32 API, so it's a given that
some programs fail.

InitializeConditionVariable in particular can not fail according to MSDN.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Michael Niedermayer]

On Tue, Jan 02, 2018 at 02:14:15PM +0100, Hendrik Leppkes wrote:
> On Tue, Jan 2, 2018 at 2:05 PM, Michael Niedermayer
>  wrote:
> > On Tue, Jan 02, 2018 at 10:36:44AM +0100, Hendrik Leppkes wrote:
> >> On Tue, Jan 2, 2018 at 4:28 AM, Michael Niedermayer
> >>  wrote:
> >> > On Tue, Jan 02, 2018 at 03:58:14AM +0100, Michael Niedermayer wrote:
> >> >> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
> >> >> > On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> >> >> > > ffmpeg | branch: master | wm4  | Thu Dec 21 
> >> >> > > 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | 
> >> >> > > committer: wm4
> >> >> > >
> >> >> > > w32pthreads: always use Vista+ API, drop XP support
> >> >> > >
> >> >> > > This removes the XP compatibility code, and switches entirely to SWR
> >> >> > > locks, which are available starting at Windows Vista.
> >> >> > >
> >> >> > > This removes CRITICAL_SECTION use, which allows us to add
> >> >> > > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> >> >> > >
> >> >> > > Windows XP is hereby not a supported build target anymore. It was
> >> >> > > decided in a project vote that this is OK.
> >> >> > >
> >> >> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> >> >> > > ---
> >> >> > >
> >> >> > >  Changelog  |   2 +
> >> >> > >  compat/w32pthreads.h   | 266 
> >> >> > > ++---
> >> >> > >  configure  |  13 ++-
> >> >> > >  libavcodec/pthread_frame.c |   4 -
> >> >> > >  libavcodec/pthread_slice.c |   4 -
> >> >> > >  libavfilter/pthread.c  |   4 -
> >> >> > >  libavutil/slicethread.c|   4 -
> >> >> > >  7 files changed, 19 insertions(+), 278 deletions(-)
> >> >> >
> >> >> > This breaks mingw32 / wine support on ubuntu 14.04
> >> >> > the code simply crashes at runtime
> >> >>
> >> >> Heres what wine provides as debug info:
> >> >>
> >> >> Unhandled exception: unimplemented function 
> >> >> KERNEL32.dll.InitializeConditionVariable called in 32-bit code 
> >> >> (0x7bc4e590).
> >> >
> >> > and thats mingw64:
> >> > Unhandled exception: unimplemented function 
> >> > KERNEL32.dll.InitializeConditionVariable called in 64-bit code 
> >> > (0x2ae6eb445e38).
> >> > Register dump:
> >> >  rip:2ae6eb445e38 rsp:0032e150 rbp:00099840 
> >> > eflags:0206 (   - --  I   - -P- )
> >> >  rax:2ae6eb445df0 rbx:0032e170 rcx:0032e170 
> >> > rdx:000140c31e80
> >> >  rsi:00014199182c rdi:000141992788  r8:000f  
> >> > r9: r10:2ae6eb6dfd6f
> >> >  r11:2ae6eb1ae510 r12: r13:000b4580 
> >> > r14:7b8883b0 r15:0033
> >> > Stack dump:
> >> > 0x0032e150:  0032e170 7b888429
> >> > 0x0032e160:  416e6f6974706972 4474654770616300
> >> > 0x0032e170:  00018100 
> >> > 0x0032e180:  2ae6eb445e38 0002
> >> > 0x0032e190:  000141992788 00014199182c
> >> > 0x0032e1a0:   
> >> > 0x0032e1b0:   
> >> > 0x0032e1c0:   
> >> > 0x0032e1d0:   
> >> > 0x0032e1e0:   
> >> > 0x0032e1f0:   
> >> > 0x0032e200:  000b44c0 000b44c0
> >> > Backtrace:
> >> > =>0 0x2ae6eb445e38 in ntdll (+0x35e38) (0x00099840)
> >> >   1 0x000140c31e80 in ffmpeg (+0xc31e7f) (0x00099840)
> >> >   2 0x00014003e6dd in ffmpeg (+0x3e6dc) (0x00099840)
> >> >   3 0x0001400364ba in ffmpeg (+0x364b9) (0x00099840)
> >> >   4 0x00014002f8b3 in ffmpeg (+0x2f8b2) (0x00099840)
> >> >   5 0x000140030355 in ffmpeg (+0x30354) (0x0032e4b0)
> >> >   6 0x00014000d478 in ffmpeg (+0xd477) (0x0001)
> >> >
> >>
> >> Yeah the compilation environment doesn't matter if Wine doesn't
> >> implement the function, so both mingw32 and mingw64 behave the same.
> >> I don't think (old) Wine is something we should worry too much about,
> >> considering you can just use native Linux builds, I doubt any real
> >> usage occurs for FFmpeg through Wine.
> >
> > Almost all windows testing i did over the years is through mingw + wine.
> > If that doesnt work anymore, then i cannot (easily) test windows anymore.
> >
> > Someone else should in this case do that testing in the future.
> > That means in practice, testing as many patches as possible and HEAD
> > bisecting found issues and reporting them to the developers whos commits
> > where the first to show an issue.
> >
> 
> Upgrading Wine is not an option? The wine project itself provides
> Ubuntu packages for 

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Hendrik Leppkes]

On Tue, Jan 2, 2018 at 2:05 PM, Michael Niedermayer
 wrote:
> On Tue, Jan 02, 2018 at 10:36:44AM +0100, Hendrik Leppkes wrote:
>> On Tue, Jan 2, 2018 at 4:28 AM, Michael Niedermayer
>>  wrote:
>> > On Tue, Jan 02, 2018 at 03:58:14AM +0100, Michael Niedermayer wrote:
>> >> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
>> >> > On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
>> >> > > ffmpeg | branch: master | wm4  | Thu Dec 21 
>> >> > > 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | 
>> >> > > committer: wm4
>> >> > >
>> >> > > w32pthreads: always use Vista+ API, drop XP support
>> >> > >
>> >> > > This removes the XP compatibility code, and switches entirely to SWR
>> >> > > locks, which are available starting at Windows Vista.
>> >> > >
>> >> > > This removes CRITICAL_SECTION use, which allows us to add
>> >> > > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
>> >> > >
>> >> > > Windows XP is hereby not a supported build target anymore. It was
>> >> > > decided in a project vote that this is OK.
>> >> > >
>> >> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
>> >> > > ---
>> >> > >
>> >> > >  Changelog  |   2 +
>> >> > >  compat/w32pthreads.h   | 266 
>> >> > > ++---
>> >> > >  configure  |  13 ++-
>> >> > >  libavcodec/pthread_frame.c |   4 -
>> >> > >  libavcodec/pthread_slice.c |   4 -
>> >> > >  libavfilter/pthread.c  |   4 -
>> >> > >  libavutil/slicethread.c|   4 -
>> >> > >  7 files changed, 19 insertions(+), 278 deletions(-)
>> >> >
>> >> > This breaks mingw32 / wine support on ubuntu 14.04
>> >> > the code simply crashes at runtime
>> >>
>> >> Heres what wine provides as debug info:
>> >>
>> >> Unhandled exception: unimplemented function 
>> >> KERNEL32.dll.InitializeConditionVariable called in 32-bit code 
>> >> (0x7bc4e590).
>> >
>> > and thats mingw64:
>> > Unhandled exception: unimplemented function 
>> > KERNEL32.dll.InitializeConditionVariable called in 64-bit code 
>> > (0x2ae6eb445e38).
>> > Register dump:
>> >  rip:2ae6eb445e38 rsp:0032e150 rbp:00099840 
>> > eflags:0206 (   - --  I   - -P- )
>> >  rax:2ae6eb445df0 rbx:0032e170 rcx:0032e170 
>> > rdx:000140c31e80
>> >  rsi:00014199182c rdi:000141992788  r8:000f  
>> > r9: r10:2ae6eb6dfd6f
>> >  r11:2ae6eb1ae510 r12: r13:000b4580 
>> > r14:7b8883b0 r15:0033
>> > Stack dump:
>> > 0x0032e150:  0032e170 7b888429
>> > 0x0032e160:  416e6f6974706972 4474654770616300
>> > 0x0032e170:  00018100 
>> > 0x0032e180:  2ae6eb445e38 0002
>> > 0x0032e190:  000141992788 00014199182c
>> > 0x0032e1a0:   
>> > 0x0032e1b0:   
>> > 0x0032e1c0:   
>> > 0x0032e1d0:   
>> > 0x0032e1e0:   
>> > 0x0032e1f0:   
>> > 0x0032e200:  000b44c0 000b44c0
>> > Backtrace:
>> > =>0 0x2ae6eb445e38 in ntdll (+0x35e38) (0x00099840)
>> >   1 0x000140c31e80 in ffmpeg (+0xc31e7f) (0x00099840)
>> >   2 0x00014003e6dd in ffmpeg (+0x3e6dc) (0x00099840)
>> >   3 0x0001400364ba in ffmpeg (+0x364b9) (0x00099840)
>> >   4 0x00014002f8b3 in ffmpeg (+0x2f8b2) (0x00099840)
>> >   5 0x000140030355 in ffmpeg (+0x30354) (0x0032e4b0)
>> >   6 0x00014000d478 in ffmpeg (+0xd477) (0x0001)
>> >
>>
>> Yeah the compilation environment doesn't matter if Wine doesn't
>> implement the function, so both mingw32 and mingw64 behave the same.
>> I don't think (old) Wine is something we should worry too much about,
>> considering you can just use native Linux builds, I doubt any real
>> usage occurs for FFmpeg through Wine.
>
> Almost all windows testing i did over the years is through mingw + wine.
> If that doesnt work anymore, then i cannot (easily) test windows anymore.
>
> Someone else should in this case do that testing in the future.
> That means in practice, testing as many patches as possible and HEAD
> bisecting found issues and reporting them to the developers whos commits
> where the first to show an issue.
>

Upgrading Wine is not an option? The wine project itself provides
Ubuntu packages for 14.04 as well, and even their "stable" version is
2.0, much newer then the 1.6 that ships with 14.04 by default.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Michael Niedermayer]

On Tue, Jan 02, 2018 at 10:36:44AM +0100, Hendrik Leppkes wrote:
> On Tue, Jan 2, 2018 at 4:28 AM, Michael Niedermayer
>  wrote:
> > On Tue, Jan 02, 2018 at 03:58:14AM +0100, Michael Niedermayer wrote:
> >> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
> >> > On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> >> > > ffmpeg | branch: master | wm4  | Thu Dec 21 
> >> > > 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | 
> >> > > committer: wm4
> >> > >
> >> > > w32pthreads: always use Vista+ API, drop XP support
> >> > >
> >> > > This removes the XP compatibility code, and switches entirely to SWR
> >> > > locks, which are available starting at Windows Vista.
> >> > >
> >> > > This removes CRITICAL_SECTION use, which allows us to add
> >> > > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> >> > >
> >> > > Windows XP is hereby not a supported build target anymore. It was
> >> > > decided in a project vote that this is OK.
> >> > >
> >> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> >> > > ---
> >> > >
> >> > >  Changelog  |   2 +
> >> > >  compat/w32pthreads.h   | 266 
> >> > > ++---
> >> > >  configure  |  13 ++-
> >> > >  libavcodec/pthread_frame.c |   4 -
> >> > >  libavcodec/pthread_slice.c |   4 -
> >> > >  libavfilter/pthread.c  |   4 -
> >> > >  libavutil/slicethread.c|   4 -
> >> > >  7 files changed, 19 insertions(+), 278 deletions(-)
> >> >
> >> > This breaks mingw32 / wine support on ubuntu 14.04
> >> > the code simply crashes at runtime
> >>
> >> Heres what wine provides as debug info:
> >>
> >> Unhandled exception: unimplemented function 
> >> KERNEL32.dll.InitializeConditionVariable called in 32-bit code 
> >> (0x7bc4e590).
> >
> > and thats mingw64:
> > Unhandled exception: unimplemented function 
> > KERNEL32.dll.InitializeConditionVariable called in 64-bit code 
> > (0x2ae6eb445e38).
> > Register dump:
> >  rip:2ae6eb445e38 rsp:0032e150 rbp:00099840 
> > eflags:0206 (   - --  I   - -P- )
> >  rax:2ae6eb445df0 rbx:0032e170 rcx:0032e170 
> > rdx:000140c31e80
> >  rsi:00014199182c rdi:000141992788  r8:000f  
> > r9: r10:2ae6eb6dfd6f
> >  r11:2ae6eb1ae510 r12: r13:000b4580 
> > r14:7b8883b0 r15:0033
> > Stack dump:
> > 0x0032e150:  0032e170 7b888429
> > 0x0032e160:  416e6f6974706972 4474654770616300
> > 0x0032e170:  00018100 
> > 0x0032e180:  2ae6eb445e38 0002
> > 0x0032e190:  000141992788 00014199182c
> > 0x0032e1a0:   
> > 0x0032e1b0:   
> > 0x0032e1c0:   
> > 0x0032e1d0:   
> > 0x0032e1e0:   
> > 0x0032e1f0:   
> > 0x0032e200:  000b44c0 000b44c0
> > Backtrace:
> > =>0 0x2ae6eb445e38 in ntdll (+0x35e38) (0x00099840)
> >   1 0x000140c31e80 in ffmpeg (+0xc31e7f) (0x00099840)
> >   2 0x00014003e6dd in ffmpeg (+0x3e6dc) (0x00099840)
> >   3 0x0001400364ba in ffmpeg (+0x364b9) (0x00099840)
> >   4 0x00014002f8b3 in ffmpeg (+0x2f8b2) (0x00099840)
> >   5 0x000140030355 in ffmpeg (+0x30354) (0x0032e4b0)
> >   6 0x00014000d478 in ffmpeg (+0xd477) (0x0001)
> >
> 
> Yeah the compilation environment doesn't matter if Wine doesn't
> implement the function, so both mingw32 and mingw64 behave the same.
> I don't think (old) Wine is something we should worry too much about,
> considering you can just use native Linux builds, I doubt any real
> usage occurs for FFmpeg through Wine.

Almost all windows testing i did over the years is through mingw + wine.
If that doesnt work anymore, then i cannot (easily) test windows anymore.

Someone else should in this case do that testing in the future.
That means in practice, testing as many patches as possible and HEAD
bisecting found issues and reporting them to the developers whos commits
where the first to show an issue.

Thanks

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Hendrik Leppkes]

On Tue, Jan 2, 2018 at 10:47 AM, Nicolas George  wrote:
> Hendrik Leppkes (2018-01-02):
>> I don't think (old) Wine is something we should worry too much about,
>> considering you can just use native Linux builds, I doubt any real
>> usage occurs for FFmpeg through Wine.
>
> What about proprietary applications that use FFmpeg (either by calling
> the executable or with dynamic linking according to the terms of the
> LGPL (let's believe it exists))?
>

Then they can probably upgrade Wine? 14.04 comes with Wine 1.6 from
2013, its quite old.
In fact, InitializeConditionVariable was implemented in Wine 1.7.11,
so not even too far in the future from 1.6

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Nicolas George]

Hendrik Leppkes (2018-01-02):
> I don't think (old) Wine is something we should worry too much about,
> considering you can just use native Linux builds, I doubt any real
> usage occurs for FFmpeg through Wine.

What about proprietary applications that use FFmpeg (either by calling
the executable or with dynamic linking according to the terms of the
LGPL (let's believe it exists))?

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Hendrik Leppkes]

On Tue, Jan 2, 2018 at 4:28 AM, Michael Niedermayer
 wrote:
> On Tue, Jan 02, 2018 at 03:58:14AM +0100, Michael Niedermayer wrote:
>> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
>> > On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
>> > > ffmpeg | branch: master | wm4  | Thu Dec 21 
>> > > 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | 
>> > > committer: wm4
>> > >
>> > > w32pthreads: always use Vista+ API, drop XP support
>> > >
>> > > This removes the XP compatibility code, and switches entirely to SWR
>> > > locks, which are available starting at Windows Vista.
>> > >
>> > > This removes CRITICAL_SECTION use, which allows us to add
>> > > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
>> > >
>> > > Windows XP is hereby not a supported build target anymore. It was
>> > > decided in a project vote that this is OK.
>> > >
>> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
>> > > ---
>> > >
>> > >  Changelog  |   2 +
>> > >  compat/w32pthreads.h   | 266 
>> > > ++---
>> > >  configure  |  13 ++-
>> > >  libavcodec/pthread_frame.c |   4 -
>> > >  libavcodec/pthread_slice.c |   4 -
>> > >  libavfilter/pthread.c  |   4 -
>> > >  libavutil/slicethread.c|   4 -
>> > >  7 files changed, 19 insertions(+), 278 deletions(-)
>> >
>> > This breaks mingw32 / wine support on ubuntu 14.04
>> > the code simply crashes at runtime
>>
>> Heres what wine provides as debug info:
>>
>> Unhandled exception: unimplemented function 
>> KERNEL32.dll.InitializeConditionVariable called in 32-bit code (0x7bc4e590).
>
> and thats mingw64:
> Unhandled exception: unimplemented function 
> KERNEL32.dll.InitializeConditionVariable called in 64-bit code 
> (0x2ae6eb445e38).
> Register dump:
>  rip:2ae6eb445e38 rsp:0032e150 rbp:00099840 
> eflags:0206 (   - --  I   - -P- )
>  rax:2ae6eb445df0 rbx:0032e170 rcx:0032e170 
> rdx:000140c31e80
>  rsi:00014199182c rdi:000141992788  r8:000f  
> r9: r10:2ae6eb6dfd6f
>  r11:2ae6eb1ae510 r12: r13:000b4580 
> r14:7b8883b0 r15:0033
> Stack dump:
> 0x0032e150:  0032e170 7b888429
> 0x0032e160:  416e6f6974706972 4474654770616300
> 0x0032e170:  00018100 
> 0x0032e180:  2ae6eb445e38 0002
> 0x0032e190:  000141992788 00014199182c
> 0x0032e1a0:   
> 0x0032e1b0:   
> 0x0032e1c0:   
> 0x0032e1d0:   
> 0x0032e1e0:   
> 0x0032e1f0:   
> 0x0032e200:  000b44c0 000b44c0
> Backtrace:
> =>0 0x2ae6eb445e38 in ntdll (+0x35e38) (0x00099840)
>   1 0x000140c31e80 in ffmpeg (+0xc31e7f) (0x00099840)
>   2 0x00014003e6dd in ffmpeg (+0x3e6dc) (0x00099840)
>   3 0x0001400364ba in ffmpeg (+0x364b9) (0x00099840)
>   4 0x00014002f8b3 in ffmpeg (+0x2f8b2) (0x00099840)
>   5 0x000140030355 in ffmpeg (+0x30354) (0x0032e4b0)
>   6 0x00014000d478 in ffmpeg (+0xd477) (0x0001)
>

Yeah the compilation environment doesn't matter if Wine doesn't
implement the function, so both mingw32 and mingw64 behave the same.
I don't think (old) Wine is something we should worry too much about,
considering you can just use native Linux builds, I doubt any real
usage occurs for FFmpeg through Wine.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Michael Niedermayer]

On Tue, Jan 02, 2018 at 03:58:14AM +0100, Michael Niedermayer wrote:
> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
> > On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> > > ffmpeg | branch: master | wm4  | Thu Dec 21 
> > > 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | 
> > > committer: wm4
> > > 
> > > w32pthreads: always use Vista+ API, drop XP support
> > > 
> > > This removes the XP compatibility code, and switches entirely to SWR
> > > locks, which are available starting at Windows Vista.
> > > 
> > > This removes CRITICAL_SECTION use, which allows us to add
> > > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> > > 
> > > Windows XP is hereby not a supported build target anymore. It was
> > > decided in a project vote that this is OK.
> > > 
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> > > ---
> > > 
> > >  Changelog  |   2 +
> > >  compat/w32pthreads.h   | 266 
> > > ++---
> > >  configure  |  13 ++-
> > >  libavcodec/pthread_frame.c |   4 -
> > >  libavcodec/pthread_slice.c |   4 -
> > >  libavfilter/pthread.c  |   4 -
> > >  libavutil/slicethread.c|   4 -
> > >  7 files changed, 19 insertions(+), 278 deletions(-)
> > 
> > This breaks mingw32 / wine support on ubuntu 14.04
> > the code simply crashes at runtime
> 
> Heres what wine provides as debug info:
> 
> Unhandled exception: unimplemented function 
> KERNEL32.dll.InitializeConditionVariable called in 32-bit code (0x7bc4e590).

and thats mingw64:
Unhandled exception: unimplemented function 
KERNEL32.dll.InitializeConditionVariable called in 64-bit code 
(0x2ae6eb445e38).
Register dump:
 rip:2ae6eb445e38 rsp:0032e150 rbp:00099840 eflags:0206 
(   - --  I   - -P- )
 rax:2ae6eb445df0 rbx:0032e170 rcx:0032e170 
rdx:000140c31e80
 rsi:00014199182c rdi:000141992788  r8:000f  
r9: r10:2ae6eb6dfd6f
 r11:2ae6eb1ae510 r12: r13:000b4580 
r14:7b8883b0 r15:0033
Stack dump:
0x0032e150:  0032e170 7b888429
0x0032e160:  416e6f6974706972 4474654770616300
0x0032e170:  00018100 
0x0032e180:  2ae6eb445e38 0002
0x0032e190:  000141992788 00014199182c
0x0032e1a0:   
0x0032e1b0:   
0x0032e1c0:   
0x0032e1d0:   
0x0032e1e0:   
0x0032e1f0:   
0x0032e200:  000b44c0 000b44c0
Backtrace:
=>0 0x2ae6eb445e38 in ntdll (+0x35e38) (0x00099840)
  1 0x000140c31e80 in ffmpeg (+0xc31e7f) (0x00099840)
  2 0x00014003e6dd in ffmpeg (+0x3e6dc) (0x00099840)
  3 0x0001400364ba in ffmpeg (+0x364b9) (0x00099840)
  4 0x00014002f8b3 in ffmpeg (+0x2f8b2) (0x00099840)
  5 0x000140030355 in ffmpeg (+0x30354) (0x0032e4b0)
  6 0x00014000d478 in ffmpeg (+0xd477) (0x0001)

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[James Almer]

On 1/1/2018 11:58 PM, Michael Niedermayer wrote:
> On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
>> On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
>>> ffmpeg | branch: master | wm4  | Thu Dec 21 20:23:14 
>>> 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4
>>>
>>> w32pthreads: always use Vista+ API, drop XP support
>>>
>>> This removes the XP compatibility code, and switches entirely to SWR
>>> locks, which are available starting at Windows Vista.
>>>
>>> This removes CRITICAL_SECTION use, which allows us to add
>>> PTHREAD_MUTEX_INITIALIZER, which will be useful later.
>>>
>>> Windows XP is hereby not a supported build target anymore. It was
>>> decided in a project vote that this is OK.
>>>
 http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
>>> ---
>>>
>>>  Changelog  |   2 +
>>>  compat/w32pthreads.h   | 266 
>>> ++---
>>>  configure  |  13 ++-
>>>  libavcodec/pthread_frame.c |   4 -
>>>  libavcodec/pthread_slice.c |   4 -
>>>  libavfilter/pthread.c  |   4 -
>>>  libavutil/slicethread.c|   4 -
>>>  7 files changed, 19 insertions(+), 278 deletions(-)
>>
>> This breaks mingw32 / wine support on ubuntu 14.04
>> the code simply crashes at runtime
> 
> Heres what wine provides as debug info:
> 
> Unhandled exception: unimplemented function 
> KERNEL32.dll.InitializeConditionVariable called in 32-bit code (0x7bc4e590).

Guess this means Wine doesn't support Vista+ API? At least not the one
in Ubuntu 14.04.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Michael Niedermayer]

On Tue, Jan 02, 2018 at 03:55:18AM +0100, Michael Niedermayer wrote:
> On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> > ffmpeg | branch: master | wm4  | Thu Dec 21 20:23:14 
> > 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4
> > 
> > w32pthreads: always use Vista+ API, drop XP support
> > 
> > This removes the XP compatibility code, and switches entirely to SWR
> > locks, which are available starting at Windows Vista.
> > 
> > This removes CRITICAL_SECTION use, which allows us to add
> > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> > 
> > Windows XP is hereby not a supported build target anymore. It was
> > decided in a project vote that this is OK.
> > 
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> > ---
> > 
> >  Changelog  |   2 +
> >  compat/w32pthreads.h   | 266 
> > ++---
> >  configure  |  13 ++-
> >  libavcodec/pthread_frame.c |   4 -
> >  libavcodec/pthread_slice.c |   4 -
> >  libavfilter/pthread.c  |   4 -
> >  libavutil/slicethread.c|   4 -
> >  7 files changed, 19 insertions(+), 278 deletions(-)
> 
> This breaks mingw32 / wine support on ubuntu 14.04
> the code simply crashes at runtime

Heres what wine provides as debug info:

Unhandled exception: unimplemented function 
KERNEL32.dll.InitializeConditionVariable called in 32-bit code (0x7bc4e590).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:7bc4e590 ESP:06f1e598 EBP:06f1e5fc EFLAGS:0206(   - --  I   - -P- )
 EAX:01c9be44 EBX:7bcbf000 ECX: EDX:7bcda388
 ESI:06f1e5a4 EDI:0019b2c0
Stack dump:
0x06f1e598:  06f1e5d8 f75abfbc  8100
0x06f1e5a8:  0001  7bc4e590 0002
0x06f1e5b8:  01c9cd04 01c9be44 0019b340 
0x06f1e5c8:  f75abf7b 7b8b5000 004422b0 0019b2c0
0x06f1e5d8:  06f1e608 7b8788ff  7ba5a648
0x06f1e5e8:  7b893f6b 7b8878ac 0019b2d8 0019b240
Backtrace:
=>0 0x7bc4e590 call_dll_entry_point+0x480() in ntdll (0x06f1e5fc)
  1 0x0023000f (0x06f1e658)
  2 0x00442393 in ffmpeg_g (+0x42392) (0x0019b200)
  3 0x0043a148 in ffmpeg_g (+0x3a147) (0x0019b200)
  4 0x004334d0 in ffmpeg_g (+0x334cf) (0x0019b200)
  5 0x00433ed6 in ffmpeg_g (+0x33ed5) (0x0019b080)
  6 0x0040e644 in ffmpeg_g (+0xe643) (0x00191300)
  7 0x00420e15 in ffmpeg_g (+0x20e14) (0x0001)
  8 0x0042121c in ffmpeg_g (+0x2121b) (0x0400)
  9 0x0042490b in ffmpeg_g (+0x2490a) (0x)
  10 0x00426fc7 in ffmpeg_g (+0x26fc6) (0x)
  11 0x0104d5bb in ffmpeg_g (+0xc4d5ba) (0x06f1fd98)
  12 0x004013e0 in ffmpeg_g (+0x13df) (0x06f1fe60)
  13 0x7b85e5cc call_process_entry+0xb() in kernel32 (0x06f1fe78)
  14 0x7b85f653 in kernel32 (+0x4f652) (0x06f1feb8)
  15 0x7bc799b0 call_thread_func_wrapper+0xb() in ntdll (0x06f1fed8)
  16 0x7bc7c93d call_thread_func+0x7c() in ntdll (0x06f1ffa8)
  17 0x7bc7998e RtlRaiseException+0x21() in ntdll (0x06f1ffc8)
  18 0x7bc4e8fe call_dll_entry_point+0x7ed() in ntdll (0x06f1ffe8)
  19 0xf75b050d wine_call_on_stack+0x1c() in libwine.so.1 (0x)
  20 0xf75b05cb wine_switch_to_stack+0x2a() in libwine.so.1 (0xff8dbd58)
  21 0x7bc541e2 LdrInitializeThunk+0x3a1() in ntdll (0xff8dbdb8)
  22 0x7b865bdd __wine_kernel_init+0xa0c() in kernel32 (0xff8dced8)
  23 0x7bc547a3 __wine_process_init+0x192() in ntdll (0xff8dcf68)
  24 0xf75adc70 wine_init+0x30f() in libwine.so.1 (0xff8dcfc8)
  25 0x7bf00fdc main+0xfb() in  (0xff8dd418)
  26 0xf73adaf3 __libc_start_main+0xf2() in libc.so.6 (0x)

  [...]


-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[Michael Niedermayer]

On Tue, Dec 26, 2017 at 01:50:08AM +, wm4 wrote:
> ffmpeg | branch: master | wm4  | Thu Dec 21 20:23:14 
> 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4
> 
> w32pthreads: always use Vista+ API, drop XP support
> 
> This removes the XP compatibility code, and switches entirely to SWR
> locks, which are available starting at Windows Vista.
> 
> This removes CRITICAL_SECTION use, which allows us to add
> PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> 
> Windows XP is hereby not a supported build target anymore. It was
> decided in a project vote that this is OK.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56
> ---
> 
>  Changelog  |   2 +
>  compat/w32pthreads.h   | 266 
> ++---
>  configure  |  13 ++-
>  libavcodec/pthread_frame.c |   4 -
>  libavcodec/pthread_slice.c |   4 -
>  libavfilter/pthread.c  |   4 -
>  libavutil/slicethread.c|   4 -
>  7 files changed, 19 insertions(+), 278 deletions(-)

This breaks mingw32 / wine support on ubuntu 14.04
the code simply crashes at runtime

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel