Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> -Original Message-
> From: James Almer [mailto:jamr...@gmail.com]
> Sent: January 28, 2018 6:32 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Mironov, Mikhail 
> Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
> AMD GPUs based on AMF SDK
> 
> On 11/29/2017 12:13 PM, Mironov, Mikhail wrote:
> >>
> >>> +{ AV_PIX_FMT_D3D11,  AMF_SURFACE_NV12 },
> >>
> >> Wut, really? It's not a typo? It looks tricky.
> >>
> >> I assume AMF has D3D11 input, but then it'd still need to exclude P010.
> >> I don't think this is ever done, and sending a P010 frame probably
> >> crashes the thing?
> >>
> >>> +};
> >
> > There is a checking at initialization time of sw_format that will fail for 
> > P010.
> >
> > Thanks,
> > Mikhail
> 
> Could you take a look at https://trac.ffmpeg.org/ticket/6990? h264_amf has
> issues encoding d3d11 frames.

I reproduced the issue. Looks like a broken sync on texture between encoder and 
decoder. 
I submitted an internal ticket to the driver team. Will push for ASAP fix.
Thanks, 
Mikhail

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[James Almer]

On 11/29/2017 12:13 PM, Mironov, Mikhail wrote:
>>
>>> +{ AV_PIX_FMT_D3D11,  AMF_SURFACE_NV12 },
>>
>> Wut, really? It's not a typo? It looks tricky.
>>
>> I assume AMF has D3D11 input, but then it'd still need to exclude P010.
>> I don't think this is ever done, and sending a P010 frame probably
>> crashes the thing?
>>
>>> +};
> 
> There is a checking at initialization time of sw_format that will fail for 
> P010.
> 
> Thanks,
> Mikhail

Could you take a look at https://trac.ffmpeg.org/ticket/6990? h264_amf
has issues encoding d3d11 frames.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[wm4]

On Wed, 29 Nov 2017 15:13:01 +
"Mironov, Mikhail"  wrote:

> >   
> > > +{ AV_PIX_FMT_D3D11,  AMF_SURFACE_NV12 },  
> > 
> > Wut, really? It's not a typo? It looks tricky.
> > 
> > I assume AMF has D3D11 input, but then it'd still need to exclude P010.
> > I don't think this is ever done, and sending a P010 frame probably
> > crashes the thing?
> >   
> > > +};  
> 
> There is a checking at initialization time of sw_format that will fail for 
> P010.

Oops, missed that. Great then.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> 
> > +{ AV_PIX_FMT_D3D11,  AMF_SURFACE_NV12 },
> 
> Wut, really? It's not a typo? It looks tricky.
> 
> I assume AMF has D3D11 input, but then it'd still need to exclude P010.
> I don't think this is ever done, and sending a P010 frame probably
> crashes the thing?
> 
> > +};

There is a checking at initialization time of sw_format that will fail for P010.

Thanks,
Mikhail
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[wm4]

On Tue, 28 Nov 2017 00:43:25 +
Mark Thompson  wrote:

> ...
> 
> Ok; done, plus some trivial testing to make sure it works.  If you're happy 
> with this and noone else says anything then I'll push it tomorrow.
> 
> Relatedly: your name on patches does not match your full name - I've 
> preserved the patch one here, but was that intended?
> 
> Thanks,
> 
> - Mark
> 
> 
>  Changelog|   1 +
>  configure|  10 +
>  libavcodec/Makefile  |   4 +
>  libavcodec/allcodecs.c   |   2 +
>  libavcodec/amfenc.c  | 604 
> +++
>  libavcodec/amfenc.h  | 148 
>  libavcodec/amfenc_h264.c | 395 +++
>  libavcodec/amfenc_hevc.c | 326 +
>  8 files changed, 1490 insertions(+)
>  create mode 100644 libavcodec/amfenc.c
>  create mode 100644 libavcodec/amfenc.h
>  create mode 100644 libavcodec/amfenc_h264.c
>  create mode 100644 libavcodec/amfenc_hevc.c
> 
> diff --git a/Changelog b/Changelog
> index afead72f14..7a913bf7a7 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -21,6 +21,7 @@ version :
>  - video mix filter
>  - video normalize filter
>  - audio lv2 wrapper filter
> +- AMD AMF H.264 and HEVC encoders
>  
>  
>  version 3.4:
> diff --git a/configure b/configure
> index 6748ef8bc9..3036b69cab 100755
> --- a/configure
> +++ b/configure
> @@ -304,6 +304,7 @@ External library support:
>--disable-zlib   disable zlib [autodetect]
>  
>The following libraries provide various hardware acceleration features:
> +  --disable-amfdisable AMF video encoding code [autodetect]
>--disable-audiotoolbox   disable Apple AudioToolbox code [autodetect]
>--disable-cuda   disable dynamically linked Nvidia CUDA code 
> [autodetect]
>--enable-cuda-sdkenable CUDA features that require the CUDA SDK 
> [no]
> @@ -1639,6 +1640,7 @@ EXTERNAL_LIBRARY_LIST="
>  "
>  
>  HWACCEL_AUTODETECT_LIBRARY_LIST="
> +amf
>  audiotoolbox
>  crystalhd
>  cuda
> @@ -2782,12 +2784,14 @@ scale_npp_filter_deps="cuda libnpp"
>  scale_cuda_filter_deps="cuda_sdk"
>  thumbnail_cuda_filter_deps="cuda_sdk"
>  
> +amf_deps_any="libdl LoadLibrary"
>  nvenc_deps="cuda"
>  nvenc_deps_any="libdl LoadLibrary"
>  nvenc_encoder_deps="nvenc"
>  
>  h263_v4l2m2m_decoder_deps="v4l2_m2m h263_v4l2_m2m"
>  h263_v4l2m2m_encoder_deps="v4l2_m2m h263_v4l2_m2m"
> +h264_amf_encoder_deps="amf"
>  h264_crystalhd_decoder_select="crystalhd h264_mp4toannexb_bsf h264_parser"
>  h264_cuvid_decoder_deps="cuvid"
>  h264_cuvid_decoder_select="h264_mp4toannexb_bsf"
> @@ -2804,6 +2808,7 @@ 
> h264_vaapi_encoder_deps="VAEncPictureParameterBufferH264"
>  h264_vaapi_encoder_select="cbs_h264 vaapi_encode"
>  h264_v4l2m2m_decoder_deps="v4l2_m2m h264_v4l2_m2m"
>  h264_v4l2m2m_encoder_deps="v4l2_m2m h264_v4l2_m2m"
> +hevc_amf_encoder_deps="amf"
>  hevc_cuvid_decoder_deps="cuvid"
>  hevc_cuvid_decoder_select="hevc_mp4toannexb_bsf"
>  hevc_mediacodec_decoder_deps="mediacodec"
> @@ -6194,6 +6199,11 @@ void f(void) { struct { const GUID guid; } s[] = { { 
> NV_ENC_PRESET_HQ_GUID } };
>  int main(void) { return 0; }
>  EOF
>  
> +enabled amf &&
> +check_cpp_condition "AMF/core/Version.h" \
> +"(AMF_VERSION_MAJOR << 48 | AMF_VERSION_MINOR << 32 | 
> AMF_VERSION_RELEASE << 16 | AMF_VERSION_BUILD_NUM) >= 0x0001000400040001" ||
> +disable amf
> +
>  # Funny iconv installations are not unusual, so check it after all flags 
> have been set
>  if enabled libc_iconv; then
>  check_func_headers iconv.h iconv
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index a6203d424b..ab7893f560 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -55,6 +55,7 @@ OBJS = ac3_parser.o 
> \
>  OBJS-$(CONFIG_AANDCTTABLES)+= aandcttab.o
>  OBJS-$(CONFIG_AC3DSP)  += ac3dsp.o ac3.o ac3tab.o
>  OBJS-$(CONFIG_ADTS_HEADER) += adts_header.o mpeg4audio.o
> +OBJS-$(CONFIG_AMF) += amfenc.o
>  OBJS-$(CONFIG_AUDIO_FRAME_QUEUE)   += audio_frame_queue.o
>  OBJS-$(CONFIG_AUDIODSP)+= audiodsp.o
>  OBJS-$(CONFIG_BLOCKDSP)+= blockdsp.o
> @@ -337,6 +338,7 @@ OBJS-$(CONFIG_H264_DECODER)+= h264dec.o 
> h264_cabac.o h264_cavlc.o \
>h264_mb.o h264_picture.o \
>h264_refs.o h264_sei.o \
>h264_slice.o h264data.o
> +OBJS-$(CONFIG_H264_AMF_ENCODER)+= amfenc_h264.o
>  OBJS-$(CONFIG_H264_CUVID_DECODER)  += cuviddec.o
>  OBJS-$(CONFIG_H264_MEDIACODEC_DECODER) += mediacodecdec.o
>  OBJS-$(CONFIG_H264_MMAL_DECODER)   += mmaldec.o
> @@ -356,6 +358,7 @@ OBJS-$(CONFIG_HAP_ENCODER) += hapenc.o hap.o
>  OBJS-$(CONFIG_HEVC_DECODER)+= hevcdec.o hevc_mvs.o \
>   

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mark Thompson]

On 28/11/17 02:23, Mironov, Mikhail wrote:
> 
> 
>> Ok; done, plus some trivial testing to make sure it works.  If you're happy 
>> with this and noone else says anything then I'll push it tomorrow.
> 
> OK.
> 
>> Relatedly: your name on patches does not match your full name - I've 
>> preserved the patch one here, but was that intended?
> 
> No, it was how I configured global  git user name on dev machine for several 
> other projects and did not change it for ffmpeg.
> If you can put the full one: Mikhail Mironov. I will adjust in the future.

Changed, and pushed.

Thank you!

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> Ok; done, plus some trivial testing to make sure it works.  If you're happy 
> with this and noone else says anything then I'll push it tomorrow.

OK.

> Relatedly: your name on patches does not match your full name - I've 
> preserved the patch one here, but was that intended?

No, it was how I configured global  git user name on dev machine for several 
other projects and did not change it for ffmpeg.
If you can put the full one: Mikhail Mironov. I will adjust in the future.
Thanks,
Mikhail

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Mark Thompson
> Sent: November 27, 2017 6:39 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
> AMD GPUs based on AMF SDK
> 
> On 27/11/17 23:34, Mironov, Mikhail wrote:
> >> -Original Message-
> >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> Behalf
> >> Of Mark Thompson
> >> Sent: November 27, 2017 6:25 PM
> >> To: ffmpeg-devel@ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding
> >> for AMD GPUs based on AMF SDK
> >>
> >> On 27/11/17 22:35, Mironov, Mikhail wrote:
> > -Original Message-
> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> > Behalf Of Mark Thompson
> > Sent: November 27, 2017 3:11 PM
> > To: FFmpeg development discussions and patches  > de...@ffmpeg.org>
> > Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding
> for
>  AMD
> > GPUs based on AMF SDK
> >
> > From: mmironov 
> >
> > Requires AMF headers for at least version 1.4.2 (older versions do
> > not support building with C).
> > ---
> > Uses upstream headers from  > LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't
> > find an official install method so I've assumed that the AMF
> > headers are under an AMF/ prefix (they have rather generic names,
> > so they need something).  Just copying the two directories from
> > the source path to /usr/local/include/AMF or similar is sufficient.
> >
> > I've also assumed that the features which don't yet exist upstream
> > (H.264 CONSTRAINED profiles) will appear in a future version 1.5.0.
> > There might be more version checking needed, but I'm not sure
> > (newer version / older header should work because of the version
> > initialisation, while older version / newer header fails at that 
> > maybe?).
> >
> > The OS checks are removed, it builds fine on Linux if you have the
> >> headers.
> >
> 
>  The public headers from github do not have several fixes that were
>  done in the customized header.
>  I could cherry-pick and push them but I did not test this for a
>  while assuming that the custom header is used.
> 
> >>>
> >>> Pushed.
> >>
> >> Thank you!
> >>
> >> Is there an official way to detect a finer version there?  (The
> >> version number is still 1.4.4.)  If not, we can just look for one of
> >> the just-added enum constants for the configure test.
> >
> > There is AMFQueryVersion() exposed as "C" export. See Factory.h It
> > will return driver version of runtime but at this point the API is forward 
> > and
> backward compatible.
> > The changes I pushed do not change API, just fixed C  compatibility issues.
> > So at this point there is no need to check version against header.
> > In the future if backward compatibility is broken AMFInit() will check
> header version and will return error.
> 
> We need to check the compatibility of the header at configure-time, though -
> configure needs to determine whether the header is usable or not.
> 
> If the user has, for example, the original 1.4.4 headers then the configure
> test looking for the AMFFactory will pass, but the compile will not succeed.

OK, I pushed version change to 1.4.4.1 in Version.h  You can check against it 
and 
when we push full update it will be 1.4.5.x or higher. 

> 
> - Mark
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mark Thompson]

On 27/11/17 23:34, Mironov, Mikhail wrote:
>> -Original Message-
>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
>> Of Mark Thompson
>> Sent: November 27, 2017 6:25 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
>> AMD GPUs based on AMF SDK
>>
>> On 27/11/17 22:35, Mironov, Mikhail wrote:
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> Behalf Of Mark Thompson
> Sent: November 27, 2017 3:11 PM
> To: FFmpeg development discussions and patches  de...@ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
 AMD
> GPUs based on AMF SDK
>
> From: mmironov 
>
> Requires AMF headers for at least version 1.4.2 (older versions do
> not support building with C).
> ---
> Uses upstream headers from  LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't
> find an official install method so I've assumed that the AMF headers
> are under an AMF/ prefix (they have rather generic names, so they
> need something).  Just copying the two directories from the source
> path to /usr/local/include/AMF or similar is sufficient.
>
> I've also assumed that the features which don't yet exist upstream
> (H.264 CONSTRAINED profiles) will appear in a future version 1.5.0.
> There might be more version checking needed, but I'm not sure (newer
> version / older header should work because of the version
> initialisation, while older version / newer header fails at that maybe?).
>
> The OS checks are removed, it builds fine on Linux if you have the
>> headers.
>

 The public headers from github do not have several fixes that were
 done in the customized header.
 I could cherry-pick and push them but I did not test this for a while
 assuming that the custom header is used.

>>>
>>> Pushed.
>>
>> Thank you!
>>
>> Is there an official way to detect a finer version there?  (The version 
>> number
>> is still 1.4.4.)  If not, we can just look for one of the just-added enum
>> constants for the configure test.
> 
> There is AMFQueryVersion() exposed as "C" export. See Factory.h
> It will return driver version of runtime but at this point the API is forward 
> and backward compatible.
> The changes I pushed do not change API, just fixed C  compatibility issues.
> So at this point there is no need to check version against header.
> In the future if backward compatibility is broken AMFInit() will check header 
> version and will return error.

We need to check the compatibility of the header at configure-time, though - 
configure needs to determine whether the header is usable or not.

If the user has, for example, the original 1.4.4 headers then the configure 
test looking for the AMFFactory will pass, but the compile will not succeed.

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Mark Thompson
> Sent: November 27, 2017 6:25 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
> AMD GPUs based on AMF SDK
> 
> On 27/11/17 22:35, Mironov, Mikhail wrote:
> >>> -Original Message-
> >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> >>> Behalf Of Mark Thompson
> >>> Sent: November 27, 2017 3:11 PM
> >>> To: FFmpeg development discussions and patches  >>> de...@ffmpeg.org>
> >>> Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
> >> AMD
> >>> GPUs based on AMF SDK
> >>>
> >>> From: mmironov 
> >>>
> >>> Requires AMF headers for at least version 1.4.2 (older versions do
> >>> not support building with C).
> >>> ---
> >>> Uses upstream headers from  >>> LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't
> >>> find an official install method so I've assumed that the AMF headers
> >>> are under an AMF/ prefix (they have rather generic names, so they
> >>> need something).  Just copying the two directories from the source
> >>> path to /usr/local/include/AMF or similar is sufficient.
> >>>
> >>> I've also assumed that the features which don't yet exist upstream
> >>> (H.264 CONSTRAINED profiles) will appear in a future version 1.5.0.
> >>> There might be more version checking needed, but I'm not sure (newer
> >>> version / older header should work because of the version
> >>> initialisation, while older version / newer header fails at that maybe?).
> >>>
> >>> The OS checks are removed, it builds fine on Linux if you have the
> headers.
> >>>
> >>
> >> The public headers from github do not have several fixes that were
> >> done in the customized header.
> >> I could cherry-pick and push them but I did not test this for a while
> >> assuming that the custom header is used.
> >>
> >
> > Pushed.
> 
> Thank you!
> 
> Is there an official way to detect a finer version there?  (The version number
> is still 1.4.4.)  If not, we can just look for one of the just-added enum
> constants for the configure test.

There is AMFQueryVersion() exposed as "C" export. See Factory.h
It will return driver version of runtime but at this point the API is forward 
and backward compatible.
The changes I pushed do not change API, just fixed C  compatibility issues.
So at this point there is no need to check version against header.
In the future if backward compatibility is broken AMFInit() will check header 
version and will return error.

Thanks,
Mikhail
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mark Thompson]

On 27/11/17 22:35, Mironov, Mikhail wrote:
>>> -Original Message-
>>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
>>> Of Mark Thompson
>>> Sent: November 27, 2017 3:11 PM
>>> To: FFmpeg development discussions and patches >> de...@ffmpeg.org>
>>> Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
>> AMD
>>> GPUs based on AMF SDK
>>>
>>> From: mmironov 
>>>
>>> Requires AMF headers for at least version 1.4.2 (older versions do not
>>> support building with C).
>>> ---
>>> Uses upstream headers from >> LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't find
>>> an official install method so I've assumed that the AMF headers are
>>> under an AMF/ prefix (they have rather generic names, so they need
>>> something).  Just copying the two directories from the source path to
>>> /usr/local/include/AMF or similar is sufficient.
>>>
>>> I've also assumed that the features which don't yet exist upstream
>>> (H.264 CONSTRAINED profiles) will appear in a future version 1.5.0.
>>> There might be more version checking needed, but I'm not sure (newer
>>> version / older header should work because of the version
>>> initialisation, while older version / newer header fails at that maybe?).
>>>
>>> The OS checks are removed, it builds fine on Linux if you have the headers.
>>>
>>
>> The public headers from github do not have several fixes that were done in
>> the customized header.
>> I could cherry-pick and push them but I did not test this for a while 
>> assuming
>> that the custom header is used.
>>
> 
> Pushed.

Thank you!

Is there an official way to detect a finer version there?  (The version number 
is still 1.4.4.)  If not, we can just look for one of the just-added enum 
constants for the configure test.

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> > -Original Message-
> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> > Of Mark Thompson
> > Sent: November 27, 2017 3:11 PM
> > To: FFmpeg development discussions and patches  > de...@ffmpeg.org>
> > Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for
> AMD
> > GPUs based on AMF SDK
> >
> > From: mmironov 
> >
> > Requires AMF headers for at least version 1.4.2 (older versions do not
> > support building with C).
> > ---
> > Uses upstream headers from  > LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't find
> > an official install method so I've assumed that the AMF headers are
> > under an AMF/ prefix (they have rather generic names, so they need
> > something).  Just copying the two directories from the source path to
> > /usr/local/include/AMF or similar is sufficient.
> >
> > I've also assumed that the features which don't yet exist upstream
> > (H.264 CONSTRAINED profiles) will appear in a future version 1.5.0.
> > There might be more version checking needed, but I'm not sure (newer
> > version / older header should work because of the version
> > initialisation, while older version / newer header fails at that maybe?).
> >
> > The OS checks are removed, it builds fine on Linux if you have the headers.
> >
> 
> The public headers from github do not have several fixes that were done in
> the customized header.
> I could cherry-pick and push them but I did not test this for a while assuming
> that the custom header is used.
> 

Pushed.
Thanks,
 Mikhail
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Mark Thompson
> Sent: November 27, 2017 3:11 PM
> To: FFmpeg development discussions and patches  de...@ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD
> GPUs based on AMF SDK
> 
> From: mmironov 
> 
> Requires AMF headers for at least version 1.4.2 (older versions do not
> support building with C).
> ---
> Uses upstream headers from  LibrariesAndSDKs/AMF/tree/master/amf/public/include>.  I couldn't find an
> official install method so I've assumed that the AMF headers are under an
> AMF/ prefix (they have rather generic names, so they need something).  Just
> copying the two directories from the source path to /usr/local/include/AMF
> or similar is sufficient.
> 
> I've also assumed that the features which don't yet exist upstream (H.264
> CONSTRAINED profiles) will appear in a future version 1.5.0.  There might be
> more version checking needed, but I'm not sure (newer version / older
> header should work because of the version initialisation, while older version
> / newer header fails at that maybe?).
> 
> The OS checks are removed, it builds fine on Linux if you have the headers.
> 

The public headers from github do not have several fixes that were done in the 
customized header. 
I could cherry-pick and push them but I did not test this for a while assuming 
that the custom header is used.

Thanks,
Mikhail
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel