Re: [FFmpeg-devel] [PATCH] aacenc: Free any extradata before re-allocating.

On Tue, Feb 6, 2018 at 5:40 PM, Josh Allmann wrote: > If the encoder has its avctx fields set by > avcodec_parameters_to_context, then the extradata is deep-copied. But it shouldn't have. Thats not a common pattern. What source codec parameters would you use for an

Re: [FFmpeg-devel] [PATCH] aacenc: Free any extradata before re-allocating.

On Tue, 6 Feb 2018 08:40:20 -0800 Josh Allmann wrote: > On 6 February 2018 at 03:16, Rostislav Pehlivanov > wrote: > > > On 6 February 2018 at 06:56, Josh Allmann > > wrote: > > > > > Fixes a leak that occurs if

Re: [FFmpeg-devel] [PATCH] aacenc: Free any extradata before re-allocating.

On 6 February 2018 at 03:16, Rostislav Pehlivanov wrote: > On 6 February 2018 at 06:56, Josh Allmann > wrote: > > > Fixes a leak that occurs if avctx->extradata contains any data > > prior to opening the codec, eg left over from an initialization >

Re: [FFmpeg-devel] [PATCH] aacenc: Free any extradata before re-allocating.

On 6 February 2018 at 06:56, Josh Allmann wrote: > Fixes a leak that occurs if avctx->extradata contains any data > prior to opening the codec, eg left over from an initialization > call to avcodec_parameters_from_context. > --- > libavcodec/aacenc.c | 4 > 1 file