Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-06 Thread Lou Logan
On Tue, Dec 5, 2017, at 10:23 PM, Lou Logan wrote: > As it is late here I plan to test and commit this tomorrow unless > someone else does first. Pushed. Thanks for the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Lou Logan
On Tue, Dec 5, 2017, at 09:36 PM, Gyan Doshi wrote: > Both done. Thanks, and LGTM. As it is late here I plan to test and commit this tomorrow unless someone else does first. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Gyan Doshi
On 12/6/2017 4:08 AM, Lou Logan wrote: Nit: change "set :" to "set:". Would it be possible to list the profiles with x265_profile_names similar to what is done for libx264? Both done. From 607ed6fd623cee0e2d49a70d9446b8360c799498 Mon Sep 17 00:00:00 2001 From: Gyan Doshi

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Lou Logan
On Tue, Dec 5, 2017, at 03:28 PM, Bang He wrote: > can it list profiles and levels? I don't know (also, too lazy to look into it). That's why I asked. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Bang He
can it list profiles and levels? On Wed, Dec 6, 2017 at 6:38 AM, Lou Logan wrote: > On Tue, 5 Dec 2017 19:46:09 +0530 > Gyan Doshi wrote: > > > From 13ad80871978fe7e5837863e0e2f7b7d6b356155 Mon Sep 17 00:00:00 2001 > > From: Gyan Doshi

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Lou Logan
On Tue, 5 Dec 2017 19:46:09 +0530 Gyan Doshi wrote: > From 13ad80871978fe7e5837863e0e2f7b7d6b356155 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Tue, 5 Dec 2017 13:17:53 +0530 > Subject: [PATCH] avcodec/libx265 - Add named option to set profile >

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Gyan Doshi
On 12/5/2017 7:37 PM, Derek Buitenhuis wrote: Patch OK with log line dropped. Revised patch v2 attached. Thanks, Gyan From 13ad80871978fe7e5837863e0e2f7b7d6b356155 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 5 Dec 2017 13:17:53 +0530 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Derek Buitenhuis
On 12/5/2017 2:05 PM, Gyan Doshi wrote: > > On 12/5/2017 7:21 PM, Derek Buitenhuis wrote: > >> This is inconsistent with the way libx264.c does it. It calls the profile >> function before the param parsing. > > From http://x265.readthedocs.io/en/default/cli.html#profile-level-tier > > "API

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Gyan Doshi
On 12/5/2017 7:21 PM, Derek Buitenhuis wrote: This is inconsistent with the way libx264.c does it. It calls the profile function before the param parsing. From http://x265.readthedocs.io/en/default/cli.html#profile-level-tier "API users must call x265_param_apply_profile() after configuring

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Derek Buitenhuis
On 12/5/2017 9:22 AM, Gyan Doshi wrote: > Revised patch attached. [...] > From bbb8013e7404360139a13b58a377a29d3ca69552 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Tue, 5 Dec 2017 13:17:53 +0530 > Subject: [PATCH] avcodec/libx265 - Add named option to set profile >

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Bang He
i approve On Tue, Dec 5, 2017 at 5:22 PM, Gyan Doshi wrote: > > On 12/5/2017 2:33 PM, Hendrik Leppkes wrote: > >> >> Please just name the option "profile" to stay consistent with all the >> other encoders. >> > > Revised patch attached. > >

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Gyan Doshi
On 12/5/2017 2:33 PM, Hendrik Leppkes wrote: Please just name the option "profile" to stay consistent with all the other encoders. Revised patch attached. From bbb8013e7404360139a13b58a377a29d3ca69552 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 5 Dec 2017

Re: [FFmpeg-devel] [PATCH] avcodec/libx265.c - Add named option to set profile

2017-12-05 Thread Hendrik Leppkes
On Tue, Dec 5, 2017 at 9:12 AM, Gyan Doshi wrote: > Attached patch allows users to set x265 encoding profile. > Addresses ticket #6894. > Please just name the option "profile" to stay consistent with all the other encoders. - Hendrik