Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-10 Thread Michael Niedermayer 
On Fri, Feb 09, 2018 at 01:56:39PM +0100, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552
> Fixes: special case for theora (untested due to lack of sample)
> 
> Found-by: continuous fuzzing process 
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/vp3.c | 3 +++
>  1 file changed, 3 insertions(+)

applied

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-09 Thread Michael Niedermayer 
On Fri, Feb 09, 2018 at 04:41:44AM +0100, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552
> 
> Found-by: continuous fuzzing process 
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/vp3.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index cf9c57f5fa..120c20f349 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -978,6 +978,9 @@ static int unpack_vlcs(Vp3DecodeContext *s, GetBitContext 
> *gb,
>  if (eob_run_get_bits[token])
>  eob_run += get_bits(gb, eob_run_get_bits[token]);
>  
> +if (!eob_run)
> +return AVERROR_INVALIDDATA;
> +
>  // record only the number of blocks ended in this plane,
>  // any spill will be recorded in the next plane.
>  if (eob_run > num_coeffs - coeff_i) {

this is incorrect for theora, (its correct for vp3) i will post a better patch

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-09 Thread Paul B Mahol 
On 2/9/18, Michael Niedermayer  wrote:
> Fixes: out of array access
> Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/vp3.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index cf9c57f5fa..120c20f349 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -978,6 +978,9 @@ static int unpack_vlcs(Vp3DecodeContext *s,
> GetBitContext *gb,
>  if (eob_run_get_bits[token])
>  eob_run += get_bits(gb, eob_run_get_bits[token]);
>
> +if (!eob_run)
> +return AVERROR_INVALIDDATA;
> +
>  // record only the number of blocks ended in this plane,
>  // any spill will be recorded in the next plane.
>  if (eob_run > num_coeffs - coeff_i) {
> --
> 2.16.1
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

probably ok
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel