Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
On Thu, Jun 14, 2018, at 1:39 PM, Lou Logan wrote: > Makes v4l2 outdev name consistent with the v4l2 indev. > > Signed-off-by: Lou Logan > --- > libavdevice/v4l2enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
2018-06-17 19:10 GMT+02:00, Lou Logan : > On Sun, Jun 17, 2018, at 8:25 AM, Carl Eugen Hoyos wrote: >> >> Wouldn't it make more sense to remove the extremely >> long name at the next bump if consistency is needed >> here? > > I don't think it matters too much to also have the alias video4linux2, or at > least I can't think of any good reasons to remove it. > > One reason for this trivial patch was so the v4l2 in/out-devs can be listed > on one line in "ffmpeg -devices" or "ffmpeg -formats" like (all?) the > others. One user reported that he was unaware of the outdev because he only > saw the indev listed (possibly looking only for video4linux2). Thank you for the explanation. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
On Sun, Jun 17, 2018, at 8:25 AM, Carl Eugen Hoyos wrote: > > Wouldn't it make more sense to remove the extremely > long name at the next bump if consistency is needed > here? I don't think it matters too much to also have the alias video4linux2, or at least I can't think of any good reasons to remove it. One reason for this trivial patch was so the v4l2 in/out-devs can be listed on one line in "ffmpeg -devices" or "ffmpeg -formats" like (all?) the others. One user reported that he was unaware of the outdev because he only saw the indev listed (possibly looking only for video4linux2). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
2018-06-14 23:39 GMT+02:00, Lou Logan :
> AVOutputFormat ff_v4l2_muxer = {
> -.name = "v4l2",
> +.name = "video4linux2,v4l2",
Wouldn't it make more sense to remove the extremely
long name at the next bump if consistency is needed
here?
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
On Fri, Jun 15, 2018 at 5:56 AM Lou Logan wrote: > > On Thu, Jun 14, 2018, at 1:39 PM, Lou Logan wrote: > > Makes v4l2 indev name consistent with the v4l2 indev. > > Should say: > Makes v4l2 outdev name consistent with the v4l2 indev. > > I changed this locally before sending, but forgot to re-make the updated > patch. LGTM if fix the commit message. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias
On Thu, Jun 14, 2018, at 1:39 PM, Lou Logan wrote: > Makes v4l2 indev name consistent with the v4l2 indev. Should say: Makes v4l2 outdev name consistent with the v4l2 indev. I changed this locally before sending, but forgot to re-make the updated patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
